- 16 Dec, 2015 3 commits
-
-
mtrofin authored
...except for 2 places (map::insert and map::find returns) [turbofan] move down parallel moves BUG= Review URL: https://codereview.chromium.org/1531453003 Cr-Commit-Position: refs/heads/master@{#32875}
-
mtrofin authored
The regression the bug tracks (see the bug link) appears to be due to identical gap moves in the predecessors of a block not being moved to the common successor. This CR fixes one reason that is happening. BUG=chromium:549262 LOG=n Review URL: https://codereview.chromium.org/1523393003 Cr-Commit-Position: refs/heads/master@{#32874}
-
v8-autoroll authored
Rolling v8/third_party/icu to 8d342a405be5ae8aacb1e16f0bc31c3a4fbf26a2 Rolling v8/tools/clang to 6261565695263bd878edd055e81ecc5e989711d6 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1529973004 Cr-Commit-Position: refs/heads/master@{#32873}
-
- 15 Dec, 2015 24 commits
-
-
jkummerow authored
The proxy may be on its own target's or handler's prototype chain, leading to infinite recursion either when looking up the trap, or when calling through to the target. We can't eagerly prevent this from happening (e.g. at "foo.__proto__ = bar" calling time) because the presence of traps can change at any time. BUG=v8:1543,chromium:569882 LOG=n Review URL: https://codereview.chromium.org/1526953002 Cr-Commit-Position: refs/heads/master@{#32872}
-
ishell authored
BUG=chromium:514080,chromium:527994,v8:4325 LOG=N Review URL: https://codereview.chromium.org/1522413002 Cr-Commit-Position: refs/heads/master@{#32871}
-
mstarzinger authored
TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1526983002 Cr-Commit-Position: refs/heads/master@{#32870}
-
baptiste.afsa authored
Original CL: https://codereview.chromium.org/1375253002/ Implement machine instruction scheduling after instruction selection. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1526913003 Cr-Commit-Position: refs/heads/master@{#32869}
-
yangguo authored
credits to gcov. Review URL: https://codereview.chromium.org/1528843002 Cr-Commit-Position: refs/heads/master@{#32868}
-
mstarzinger authored
This fixes a path in the compilation pipeline that side-stepped the interpreter when a function literal was eagerly compiled. This caused the interpreter to miss some test coverage. R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1528853002 Cr-Commit-Position: refs/heads/master@{#32867}
-
zhengxing.li authored
X87: [TurboFan] Change the implementation of Float32's NaN comparision's return value in kX87Float32Min and kX87Float32Max. The CL 32796(https://codereview.chromium.org/1512023002) adds many Float32 comparision test data which including the NaN comparision. As there's no Specification for the return value of NaN comparision, Current x87 will check the Float comparision instruction's first operand, if it's NaN, return the second operand. Otherwise, return itself. But this conflicts with the Gcc compiler's implementation and cause the RunFloat32MinP and RunFloat32MaxP tests failed. For (a < b) comparision, The Gcc compiler will treat the NaN comparision's result same as a GT b and return b. The minss sse instruction in IA32 has the similar behavior. So this CL will make the implementation of NaN comparision's return value in kX87Float32Min and kX87Float32Max same as Gcc and IA32. BUG= Review URL: https://codereview.chromium.org/1522333002 Cr-Commit-Position: refs/heads/master@{#32866}
-
yangguo authored
The third argument optionally specifies the frame from which to step. This feature is not used and not well tested. R=jkummerow@chromium.org BUG=chromium:569835 LOG=N Review URL: https://codereview.chromium.org/1525993002 Cr-Commit-Position: refs/heads/master@{#32865}
-
mstarzinger authored
This fixes runtime calls emitted by the RawMachineAssembler to use the correct CEntryStub depending on the return count of runtime functions. Note that this only affects WIN64 and PPC, where the ABI is different. R=mythria@chromium.org Review URL: https://codereview.chromium.org/1528643004 Cr-Commit-Position: refs/heads/master@{#32864}
-
yangguo authored
Revert of [debugger] re-enable step in frame test. (patchset #1 id:1 of https://codereview.chromium.org/1518403004/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/4780/steps/Mjsunit/logs/debug-step-4-in-frame Original issue's description: > [debugger] re-enable step in frame test. > > Issue has long been fixed. > > R=jkummerow@chromium.org > BUG=v8:2921 > LOG=N > > Committed: https://crrev.com/f27105b17a23a64faeae33b939555840e388136e > Cr-Commit-Position: refs/heads/master@{#32862} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2921 Review URL: https://codereview.chromium.org/1522333003 Cr-Commit-Position: refs/heads/master@{#32863}
-
yangguo authored
Issue has long been fixed. R=jkummerow@chromium.org BUG=v8:2921 LOG=N Review URL: https://codereview.chromium.org/1518403004 Cr-Commit-Position: refs/heads/master@{#32862}
-
develar authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1477233002 Cr-Commit-Position: refs/heads/master@{#32861}
-
yangguo authored
Revert of [WIP][turbofan] Instruction scheduler for Turbofan. (patchset #7 id:120001 of https://codereview.chromium.org/1375253002/ ) Reason for revert: Does not compile https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/6870/steps/compile/logs/stdio Original issue's description: > [turbofan] Instruction scheduler for Turbofan. > > Implement machine instruction scheduling after instruction selection. > > Currently only works for arm64. > > R=danno@chromium.org, bmeurer@chromium.org, titzer@chromium.org > > Committed: https://crrev.com/e11bba3acd5188f0e12686b6fcf3e0ab22989216 > Cr-Commit-Position: refs/heads/master@{#32858} TBR=jarin@chromium.org,bmeurer@chromium.org,baptiste.afsa@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526913002 Cr-Commit-Position: refs/heads/master@{#32860}
-
yangguo authored
credits to gcov. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1529763002 Cr-Commit-Position: refs/heads/master@{#32859}
-
baptiste.afsa authored
Implement machine instruction scheduling after instruction selection. Currently only works for arm64. R=danno@chromium.org, bmeurer@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1375253002 Cr-Commit-Position: refs/heads/master@{#32858}
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 Cr-Commit-Position: refs/heads/master@{#32841} Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32857}
-
yangguo authored
We used to flood the handler when preparing for stepping, even if we may not throw. Instead, we now flood the handler only when we actually throw. This also solves an issue with step-next when we throw and leave the function unexpectedly. In combination with microtasks, this could cause a crash. R=mstarzinger@chromium.org BUG=chromium:568477 LOG=N Review URL: https://codereview.chromium.org/1527593002 Cr-Commit-Position: refs/heads/master@{#32856}
-
machenbach authored
Revert of [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. (patchset #1 id:1 of https://codereview.chromium.org/1527863003/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3491 Original issue's description: > [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. > > The TypeOfStub didn't test the undetectable bit properly if the instance > was also callable, and therefore returned "object" for document.all > (which is both undetectable and callable). > > R=yangguo@chromium.org > BUG=chromium:567998 > LOG=n > > Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc > Cr-Commit-Position: refs/heads/master@{#32852} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:567998 Review URL: https://codereview.chromium.org/1525703003 Cr-Commit-Position: refs/heads/master@{#32855}
-
zhengxing.li authored
port 56673804 (r32803) original commit message: BUG= Review URL: https://codereview.chromium.org/1524063002 Cr-Commit-Position: refs/heads/master@{#32854}
-
zhengxing.li authored
X87: [proxy] fixing for-in for proxies, fixing harmony/proxy.js tests, improving error messages and some drive-by fixes. port df2a9297 (r32801) original commit message: BUG= Review URL: https://codereview.chromium.org/1523993003 Cr-Commit-Position: refs/heads/master@{#32853}
-
bmeurer authored
The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). R=yangguo@chromium.org BUG=chromium:567998 LOG=n Review URL: https://codereview.chromium.org/1527863003 Cr-Commit-Position: refs/heads/master@{#32852}
-
Benedikt Meurer authored
R=machenbach@chromium.org TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1522343002 . Cr-Commit-Position: refs/heads/master@{#32851}
-
Adam Klein authored
Turning it off broke both the trace viewer and using the devtools to connect to an earlier version of Chrome running on another device. BUG=chromium:552100, chromium:569417, chromium:569647 TBR=rossberg@chromium.org LOG=y Review URL: https://codereview.chromium.org/1521993004 . Cr-Commit-Position: refs/heads/master@{#32850}
-
v8-autoroll authored
Rolling v8/build/gyp to b85ad3e578da830377dbc1843aa4fbc5af17a192 Rolling v8/tools/clang to f8fd8b699f6c474577b455e55b22df23ceaa2da8 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1527613005 Cr-Commit-Position: refs/heads/master@{#32849}
-
- 14 Dec, 2015 13 commits
-
-
mstarzinger authored
This unifies the decision whether to use Ignition or FullCodeGenerator to generate baseline code into a single place. This allows for small function literals that are compiled eagerly to go through Ignition. R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1525663002 Cr-Commit-Position: refs/heads/master@{#32848}
-
mstarzinger authored
This removes the ability to generate stub code via the full-fledged compiler pipeline that parses and analyzes JavaScript source code. Generation of stub code has been moved to a lower-level entry point. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1520373002 Cr-Commit-Position: refs/heads/master@{#32847}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1526663002 Cr-Commit-Position: refs/heads/master@{#32846}
-
machenbach authored
Revert of [debugger] debug-evaluate should not not modify local values. (patchset #2 id:20001 of https://codereview.chromium.org/1513183003/ ) Reason for revert: [Sheriff] Layout test changes. Original issue's description: > [debugger] debug-evaluate should not not modify local values. > > Debug evaluate no longer writes back changes to the replicated > context chain to the original after execution. Changes to the > global object or script contexts still stick. Calling functions > that bind to the original context chain also have their expected > side effects. > > As far as I can tell, DevTools is not interested in modifying > local variable values. Modifying global variable values still > works as expected. However, I have not yet removed the old > implementation, but merely keep it behind a flag. > > R=mstarzinger@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 > Cr-Commit-Position: refs/heads/master@{#32841} TBR=mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526553003 Cr-Commit-Position: refs/heads/master@{#32845}
-
jkummerow authored
- proxies-with-unscopables needed updating of trap names - proxies-symbols doesn't make sense any more: it tested symbol fitering/ blacklisting, but Proxies interact with Symbols just fine according to the current spec. BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1529473002 Cr-Commit-Position: refs/heads/master@{#32844}
-
neis authored
This CL tries to correctly support the following: - stringifying a proxy, - stringifying with a proxy as replacer (callable or arraylike), - stringifying with a replacer that returns a proxy, - parsing with a callable proxy as reviver, - parsing with a reviver that inserts proxies into the object, - and whatever else you can imagine. This also fixes some bugs observable without proxies. BUG=v8:3139,v8:1543 LOG=n Review URL: https://codereview.chromium.org/1515133002 Cr-Commit-Position: refs/heads/master@{#32843}
-
ahaas authored
The test Run_Wasm_StoreMem_offset_oob contained an I64STORE instruction, which is not yet implemented on 32 bit platforms. I turned off those parts of the test on 32 bit platforms which contain I64 instructions. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1526573002 Cr-Commit-Position: refs/heads/master@{#32842}
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32841}
-
machenbach authored
BUG=chromium:568949 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1520163003 Cr-Commit-Position: refs/heads/master@{#32840}
-
bradnelson authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1526623002 Cr-Commit-Position: refs/heads/master@{#32839}
-
sigurds authored
Move replacements out of virtual object. Replacements are global to the graph and are not dependent on the virtual state (after they are discovered). R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1527533002 Cr-Commit-Position: refs/heads/master@{#32838}
-
mstarzinger authored
This uses the same pipeline entry function for all three assemblers currently supported by TurboFan. The Pipeline::GenerateCodeForCodeStub is by now generic enough to accommodate all uses. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1521363003 Cr-Commit-Position: refs/heads/master@{#32837}
-
neis authored
This CL makes proxy-related error messages more accurate and verbose. (Exception: those used in deprecated functions in v8natives.js.) Some of the old error messages were simply wrong. On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and JSProxy::DefineOwnProperty. R=cbruni@chromium.org, jkummerow@chromium.org BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1527583002 Cr-Commit-Position: refs/heads/master@{#32836}
-