- 03 Mar, 2021 12 commits
-
-
Nico Hartmann authored
Bug: v8:11298 Change-Id: I99d36812aabd99fd92a20f743705aee193914381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2731530Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73158}
-
Camillo Bruni authored
- Add private NewStructInternal - Dehandlify JSObject initializers Bug: v8:11263 Change-Id: I62d77ef32747c2042de707ba10fad20327af0930 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2729342Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73157}
-
Camillo Bruni authored
Bug: v8:11165 Change-Id: Id1c7abec73d5dd4824c0d84c9789a8b4ea4911ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726513Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73156}
-
Santiago Aboy Solanes authored
Also add the qualifier `compiler::` to places where it should have been used in the first place. Bug: v9:6949 Change-Id: Ib5ca6829cd9d72b1e3047afc92363910c902bbbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2731529Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73155}
-
Omer Katz authored
LargePage::PayloadSize inclues the heap object header. Keeping PayloadSize as is to keep it aligned with NormalPage::PayloadSize and introducing LargePage::ObjectSize as the counterpart for HeapObjectHeader::ObjectSize that will exclude the header. Bug: chromium:1056170 Change-Id: I8a5f50841fd9dbd6c9a4a4035d9040021944cacc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2731533Reviewed-by:
-
Frank Emrich authored
This CL is part of a series that adds the C++ implementation of SwissNameDictionary, a deterministic property backing store based on Swiss Tables. This CL contains: 1. Copy and equality functions used for testing 2. Runtime functions corresponding to most dictionary operations, which are used temporarily while the CSA/Torque implementation is work in progress 3. Some minor changes to SwissNameDictionary needed for testing (adding template instantiations, V8_EXPORT_PRIVATE, ...) Bug: v8:11388 Change-Id: Iea5f4650b0a443edf563565138ea86fcb45af13a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2722094 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73153}
-
Clemens Backes authored
This is a wasm-only test, hence move it to the wasm directory and skip it in no-wasm builds. R=ahaas@chromium.org Bug: v8:11238 Change-Id: I57c9abbb98c3415f4d759372d479e1f61464217f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2731536Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73152}
-
Seth Brenith authored
This is a partial reland of https://crrev.com/c/2601880 . In preparation for ScopeInfo not being a FixedArrayBase, this change privatizes the FixedArray-style functions that provide access to ScopeInfo fields by index, and moves them from scope-info-inl.h to scope-info.cc. Those functions are still used pretty heavily during initialization (ScopeInfo::Create, etc.), but at least we can avoid presenting them to the rest of the world. This change also introduces a new length() function in ScopeInfo which hides the one inherited from FixedArrayBase and computes the ScopeInfo's length based on its flags, so that there are no remaining readers of the 'length' field. Change-Id: I609754010723b679e5cf00f386020faaab84c17a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718275 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73151}
-
Dan Elphick authored
Fixes gn check error due to include of test/common/wasm/wasm-macro-gen.h. Also changes common_test_headers dep from v8_for_testing to v8_internal_headers, since otherwise on windows the wasm_api_tests binary ends up depending on wee8 and libv8_for_testing which define many of the same symbols. Bug: v8:7330 Change-Id: Ib03b860668146f21456729a3d2c5e0d75d8c17d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2729335 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73150}
-
Santiago Aboy Solanes authored
Also access the DescriptorArray through GetFieldType concurrently if the FLAG_turbo_direct_heap_access is on. Bug: v8:7790 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_no_cm_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Change-Id: I2506fe44a3be9f3474934300d52849f278899e70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720299Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73149}
-
Alex Kodat authored
These simplify production of extra information in stack traces or dereferencing source maps in processing stack traces. While these can be managed externally, this can be very complicated in environments where scripts come from many different sources, possibly not even under embedder control. Since V8 already has easy access to this information, it's nice to share it with embedders. Bug: v8:11509 Change-Id: Ic5a1685adf4cdf456bdf7191ce815f728cf491e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2724571Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73148}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a1f3c3d..122de42 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/aa09fa7..b60d41f Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/201ff85..8869f42 Rolling v8/third_party/aemu-linux-x64: gUyZgCT7R0DTHyu0Lq1Q7yrbbA9cage7ltjq_oN3mXkC..xxaIXDIq8jINlzwdt2TTV0PFwnzlgMri76ohrXyvF-wC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cae643a..6da8f82 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6ac4a15..bf0766c Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/1e315c5..07f4869 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ea420884e582976db279ec8995c642f0f5786b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2730858Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73147}
-
- 02 Mar, 2021 28 commits
-
-
Junliang Yan authored
Change-Id: I5a7e9df277941a4fe88747720bed3c930fd6b4db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726544Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73146}
-
Sara Tang authored
Design doc: https://docs.google.com/document/d/1xkXj94iExFgLWc_OszTNyNGi523ARaKMWPZTeomhI4U This is the second (and hopefully final!) change list needed to integrate ETW into V8. In particular, we added stack-walking functionality for JIT-ted functions! Some notes on instrumentation: - The gist of getting stack-walking in ETW is we need to emit events with specific event IDs. These events get stitched into a pseudo-PDB that is recognizable by ETW. - Unfortunately, we cannot rely on the TraceLogging API from the first CL, as it does not support specifying event IDs. Instead, Bill Ticehurst wrote an API that peels back the TraceLogging API just enough so that we can specify event IDs. This API is the entirety of etw-metdata.h - We attach a CodeEventHandler that logs a stack-walking event whenever code movement is triggered. Bug: v8:11043 Change-Id: I1bf57c985b7375f045089027855b1c03878abb78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616221Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73145}
-
Ng Zhi An authored
Operand 1 is not always a register (when AVX is supported). Bug: chromium:1182571,v8:11215 Change-Id: I75740b4900c4d8b4a10478780d93c995836faeb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2724393Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73144}
-
Milad Fa authored
Change-Id: I051a82a4a041aa81c150ce559b2b3cbee7718425 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727271Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73143}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: Ib8df4e10aa3a459cc24ca8d89db1f39b53cc5966 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727269 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73142}
-
Ng Zhi An authored
Wasm SIMD does not have an opcode to multiply a vector by a scalar. In these cases, Wasm code uses mul(x, shuffle(y, imms)), where the shuffle is a dup of a single lane in y. Pattern match on this to emit a fmul (element). We can do similar pattern match on f64x2 too, that will come in a future patch. Bug: v8:11257 Change-Id: I61e8c46b56719a1179c8a6032dbf8a4cc03b40a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719083 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I27fc7c63ba673ec575d22438feb17f30c73074f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727586Reviewed-by:
-
Santiago Aboy Solanes authored
Remove sloppy-ness from the CODE_ASSEMBLER_UNARY_OP macros and the remaining methods. Bug: v8:6949 Change-Id: I48e2800c6bac558ae4005fa09551a4551c1dbb25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2725530 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#73139}
-
Clemens Backes authored
This removes all wasm includes from src/debug and src/inspector if webassembly is disabled (v8_enable_webassembly=false). It also removes the definition of {WasmValueObject} and {v8::debug::WasmScript}. This will allow to later fully exclude the src/wasm directory from compilation (once other components are fixed). R=bmeurer@chromium.org, machenbach@chromium.org Bug: v8:11238 Change-Id: I41a1d83d01fbb6c015cdfd6cc063bad90052505d Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726506Reviewed-by:Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73138}
-
Camillo Bruni authored
After deprecation and removal of the old misleading API we re-add v8::String::IsExternal which returns true for both, external one-byte and external two-byte strings. Bug: v8:10641 Change-Id: I4c66d4df891f7180c7a727a45c1fbd254a7f5c02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726512Reviewed-by:
-
Santiago Aboy Solanes authored
Tnodifying the last cases of StoreElement, brings the total Node* occurrences in code-stub-assembler to 0! Bug: v8:6949 Change-Id: I27f61447a2a57969b5d24fe24ee5b2265aa20f8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727504 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Tail calls are connected to the end of the graph, so technically they also constitute loop exits. Additional Changes: - In DoReturnCall, change the argument {Node* index_node} into {Value index_or_caller_value}. - Rename StackValueVector -> ValueVector. - Add a test that reveals the bug. Bug: chromium:1183622, v8:11298 Change-Id: I58f7877f2d03e94f6a281e566829897c3000b890 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727503Reviewed-by: -
Leszek Swirski authored
Add a Utf16CharacterStream for windows-1252, which uses a table to covert from windows-1252 to the appropriate uc16 character. This fixes issues where windows-1252 encoded source was treated like latin-1. This introduces a new encoding type in the API, so embedders will have to opt-in to using this new stream. Fixed: v8:9315 Change-Id: I2e847c2d4f1727281f6be24b4743d77bb232a62d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2729338 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Dan Elphick authored
Moves the handling of base/trace_event/common/trace_event_common.h from v8_base_without_compiler to v8_internal_headers to fix a build break caused by: https://chromium-review.googlesource.com/c/v8/v8/+/2712569 Change-Id: Ie3c161874e18cdfaf30286ff0fa299a4c4e2c1a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2729340Reviewed-by:
-
Milad Fa authored
Also renamed VECTOR_BIN_OP to VECTOR_ARITHMETIC_OP for clarity. Change-Id: Icbe1cf9ac95f2c0b1cec364f50123a9fcb846f48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727644Reviewed-by:
-
Nico Hartmann authored
This reverts commit 6e234e9d. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/4795/overview Original change's description: > [wasm][liftoff][eh] Implement catch_all > > Inline a catch handler after each potentially throwing call. The handler > just merges values into the actual catch environment and then jumps to > the catch body. > > This automatically adds support for unwind, which also uses the > "CatchAll" interface method. > > Many tests can be written either with "catch" or with "catch_all". > Duplicate them to get coverage for both. > > R=clemensb@chromium.org > > Bug: v8:11453 > Change-Id: I789ad44b8d1e496f026157d5c37a12004a8b37e3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726497 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73129} Bug: v8:11453 Change-Id: Ica7fa708962d9ae4b9fbf7473963d187062227ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727266 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73131}
-
Toon Verwaest authored
The interpreter always adjusts the current interrupt budget down by the current bytecode size as well. This aligns the optimization heuristics. Bug: v8:11420 Change-Id: I0cc78d004779b393a3d8fb46e44bdd7465fcf4ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726496 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73130}
-
Thibaud Michaud authored
Inline a catch handler after each potentially throwing call. The handler just merges values into the actual catch environment and then jumps to the catch body. This automatically adds support for unwind, which also uses the "CatchAll" interface method. Many tests can be written either with "catch" or with "catch_all". Duplicate them to get coverage for both. R=clemensb@chromium.org Bug: v8:11453 Change-Id: I789ad44b8d1e496f026157d5c37a12004a8b37e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726497Reviewed-by:
-
Camillo Bruni authored
- Fix diff coloring when a baseline is selected - Cleanup UI and use dark-mode by default - Reuse CSS from the system-analyzer - Support loading mutliple files by default everywhere - Use hideable panels from system-analyzer Change-Id: Iafe271d2f86fbbd10a940b3ac99874dd51f45442 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721763 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73128}
-
Camillo Bruni authored
Clang cannot optimise across handle derefs and produces quite inefficient code when setting multiple properties in a row. We are already dealing with a lot of raw pointers in factory, thus adding further DisallowGarbageCollection and will not significantly increase the risk of stale pointers. Bug: v8:11263 Change-Id: I2b62f79ecde95faa84a182c09d89c03423900d98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2581963 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Using templates seems like the best way to go. We are duplicating code but seems like a fair trade-off. Bug: v8:6949 Change-Id: I22b3d5e2e74bfc2bf46f95656782aae4944d72de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727816Reviewed-by:
-
Dan Elphick authored
Dependency is needed as wasm-interpreter.cc uses base/overflowing-math.h and base/safe_conversions.h. Bug: v8:7330 Change-Id: I4515babf18723a34c89e63621f8aaa49252d3461 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727408 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Dan Elphick authored
Adds test/common/flag-utils.h and test/common/wasm/flag-utils.h to wasm_test_common to reduce the number of gn check errors by 4. Bug: v8:7330 Change-Id: I94e11130c4b96972604cabbaa019617cb1f8f67a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727404 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Liu Yu authored
Add register t3 to ALLOCATABLE_GENERAL_REGISTERS, and change kSpeculationPoisonRegister from a7 to t3. Change-Id: I199c1b837d5fdd0b47f0865ac3146e47e4ddb68f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726050 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73123}
-
Dan Elphick authored
Adds cppgc_headers to v8_internal_headers and fuzzer_support to lib_wasm_fuzzer_common in BUILD.gn as well as v8_libbase and v8_libplatform to cctest_headers in test/cctest/BUILD.gn. Bug: v8:7730 Change-Id: I9759bb0993be779ddfc26668b9e08503ea53bd69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727501 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949 Change-Id: Ie8620ec5f3025cdf4f419c80db221d57698fd508 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726514Reviewed-by:
-
Dan Elphick authored
To fix 6 gn check errors, this adds a cppgc_headers dep to v8_headers. To resolve the resulting cycle, it also changes v8_libplatform to depend on v8_config_headers since it only needs v8config.h. Bug: v8:7330 Change-Id: I1e21271c84f2a80c248c584e8e107da99eaad5a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727500 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Be explicit about source positions for `Return`s in the BytecodeGenerator, and only do self-healing explicitly in the `ReturnStatement` translation, where an end position of `kNoSourcePosition` is turned into the return position of the function literal. This allows us to reason more easily about which `Return`s actually receive a meaningful source position, and in particular it allows us to construct the internal `Return`s for `yield` and `yield*` with no source position attached to them. Previously they'd get the source position for the implicit (final) return attached to it, which confused the debugger and led to breakpoints being set in the completely wrong spot. Considering the simplified example ``` function* foo(){ var a = 1; } ``` this would previously generate the following bytecode ``` 0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 } 4 : Mov <closure>, r2 7 : Mov <this>, r3 13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3 14 : Star0 13 E> 15 : SuspendGenerator r0, r0-r1, [0] 20 : ResumeGenerator r0, r0-r1 24 : Star2 25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0 29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 } 33 : Ldar r2 13 E> 35 : Throw 36 : Ldar r2 30 S> 38 : Return <=========================== internal Return 27 S> 39 : LdaSmi [1] 41 : Star1 42 : LdaUndefined 30 S> 43 : Return ``` where everything between offset 4 and 42 corresponds to the implicit yield at the beginning of every generator function, in particular the code between 20 and 42 corresponds to that initial yields resumption logic. Notice how the internal Return at offset 38 gets assigned the source position of the function literal (the same as the implicit return at the end). This confuses the debugger quite a bit when trying to set a breakpoint on the closing brace, since it's going in bytecode order and will thus discover the `Return` at offset 38 first (matching the source position 30 it's currently looking for) and setting the breakpoint there. This `Return` bytecode however is only executed when the generator is resumed via `GeneratorPrototype.return()`, and it'll not hit when the developer uses the generator normally, which is not the desired behavior and extremely confusing (especially since stepping on the other hand works as expected). With this patch, we no longer slap a source position (and in particular not the function literal's return position) onto these internal `Return`s as you can see from the generated bytecode below: ``` 0 : SwitchOnGeneratorState r0, [0], [1] { 0: @20 } 4 : Mov <closure>, r2 7 : Mov <this>, r3 13 E> 10 : InvokeIntrinsic [_CreateJSGeneratorObject], r2-r3 14 : Star0 13 E> 15 : SuspendGenerator r0, r0-r1, [0] 20 : ResumeGenerator r0, r0-r1 24 : Star2 25 : InvokeIntrinsic [_GeneratorGetResumeMode], r0-r0 29 : SwitchOnSmiNoFeedback [1], [2], [0] { 0: @39, 1: @36 } 33 : Ldar r2 13 E> 35 : Throw 36 : Ldar r2 38 : Return 27 S> 39 : LdaSmi [1] 41 : Star1 42 : LdaUndefined 30 S> 43 : Return ``` This also allows us to remove the break position finding hack that was kept in BreakIterator::BreakIndexFromPosition() for generators and modules. Fixed: chromium:901819 Change-Id: If19a6b26e2622d49b6b5e54bf7a162747543f970 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727820Reviewed-by:
-
