- 26 Apr, 2018 24 commits
-
-
Ben Smith authored
The new spec has two arguments, the first is the global descriptor, and the second is the initial value: new WebAssembly.Global({type: i32}, 42); If the initial value argument is omitted, the value is set to 0. Bug: v8:7625 Change-Id: I679d4b7c49c69ec7ffcdfeb8ae506fa7ab9bba95 Reviewed-on: https://chromium-review.googlesource.com/1028847Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#52822}
-
Kim-Anh Tran authored
Top-tier code needs to be explicitly logged after compilation. Change-Id: Ic3c54ff4b7bddd44516a611398b7373fe0acc8d4 Reviewed-on: https://chromium-review.googlesource.com/1030391Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@google.com> Cr-Commit-Position: refs/heads/master@{#52821}
-
Ben L. Titzer authored
This CL simplifies and extends the implementation of Managed<T> and now uses a std::shared_ptr<T> underneath in order to offer cross-isolate management of C++ allocated memory. R=mstarzinger@chromium.org CC=ulan@chromium.org Bug: v8:7424 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id43a26f565677e8c9cdfd73810568d4f2b1871fe Reviewed-on: https://chromium-review.googlesource.com/1028190Reviewed-by:
-
jgruber authored
This is a reland of f5d30851 Original change's description: > [builtins] Introduce further constant & external reference indirections > > This introduces further indirections for embedded constants and > external references for builtins generated by the macro-assembler. > The used mechanisms (LookupConstant and LookupExternalReference) are > identical to what we already use in CSA. > > Almost all builtins are now isolate-independent in both release and > debug modes. snapshot_blob.bin is roughly 670K smaller in embedded > builds vs. non-embedded builds, while libv8.so is roughly 280K larger. > > Bug: v8:6666 > Change-Id: I7a6c2193ef5a763e6cf7543dd51597d6fff6c110 > Reviewed-on: https://chromium-review.googlesource.com/1006581 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52810} TBR=mstarzinger@chromium.org Bug: v8:6666 Change-Id: I73dfe207f2c5f79a9a06c165c75f5619e88a5a17 Reviewed-on: https://chromium-review.googlesource.com/1030550Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52819}
-
Alexey Kozyatinskiy authored
This is a reland of 436faae0 Original change's description: > [inspector] added timeout for Debugger.evaluateOnCallFrame method > > R=dgozman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 > Reviewed-on: https://chromium-review.googlesource.com/1023035 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52798} Bug: none Change-Id: I91219382b5dc45b54dd8e5c64d9f0d11c849b9c8 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1030510 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52818}
-
Yang Guo authored
R=jgruber@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I62955f95812a2c6ac04599c437971863a73af66d Reviewed-on: https://chromium-review.googlesource.com/1014103Reviewed-by:
-
sreten.kovacevic authored
Implement emit_jump when target is in register. Bug: v8:6600 Change-Id: Idd8fc739ac9997cad53feffdfcee5ae25d9ad6ee Reviewed-on: https://chromium-review.googlesource.com/1030453Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52816}
-
Vincent Belliard authored
When a liftoff function bails out after generating some constant pool, this avoids to trigger a check in the Assembler destructor. Bug: v8:6600 Change-Id: I79c595605bc0add1f3f5617ac7feedf162081d8a Reviewed-on: https://chromium-review.googlesource.com/1026647Reviewed-by:
-
Ivica Bogosavljevic authored
In liftoff, call to PrepareCallCFunction was using at as scratch register. This is a very bad idea, since at is later used in underlying macro assembler TEST=cctest/test-run-wasm-64/RunWasmLiftoff_Regression_6858 Change-Id: Ifbc43678731d2833d2faa2f20fe79ea9e3089002 Reviewed-on: https://chromium-review.googlesource.com/1030430Reviewed-by:
Sreten Kovacevic <sreten.kovacevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52814}
-
jgruber authored
This reverts commit f5d30851. Breakages: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/20370 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/21174 TBR=yangguo@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Change-Id: Ic4d28fccf647aadcac0a60430b7fb66d22ce4577 Reviewed-on: https://chromium-review.googlesource.com/1030431Reviewed-by:
-
Jakob Gruber authored
This reverts commit 2f0a78ab. Reason for revert: Test fixed by https://chromium-review.googlesource.com/1030211. Original change's description: > [test] Disable pause-on-oom in no_snap > > > TBR=machenbach@chromium.org > > Bug: v8:7631 > No-Tree-Checks: true > No-Try: true > Change-Id: Iace8fae7fcbdd1766394ee30d0c1e54f3a29e2b9 > Reviewed-on: https://chromium-review.googlesource.com/1027852 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52780} TBR=machenbach@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7631 Change-Id: I42bd9d251eb82b2e49e45756118d7dde8f99536d Reviewed-on: https://chromium-review.googlesource.com/1030390Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52812}
-
jgruber authored
Intl builtins must stay behind V8_INTL_SUPPORT. This fixes: ci.chromium.org/buildbot/client.v8.ports/V8%20Mips%20-%20builder/16733 TBR=yangguo@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Change-Id: I001df26585e376c6e242ece88612e10417529037 Reviewed-on: https://chromium-review.googlesource.com/1030272Reviewed-by:
-
jgruber authored
This introduces further indirections for embedded constants and external references for builtins generated by the macro-assembler. The used mechanisms (LookupConstant and LookupExternalReference) are identical to what we already use in CSA. Almost all builtins are now isolate-independent in both release and debug modes. snapshot_blob.bin is roughly 670K smaller in embedded builds vs. non-embedded builds, while libv8.so is roughly 280K larger. Bug: v8:6666 Change-Id: I7a6c2193ef5a763e6cf7543dd51597d6fff6c110 Reviewed-on: https://chromium-review.googlesource.com/1006581 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
jgruber authored
This should fix the recent frequent pause-on-oom failures. The callback attempted to create a handle without a HandleScope. Bug: v8:7631 Change-Id: Id15ba287896d62d3205585d14204f0c92a8823f8 Reviewed-on: https://chromium-review.googlesource.com/1030211Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52809}
-
Peter Marshall authored
When running this test locally, the OptimizeFunctionOnNextCall call fails, because the line above has no semicolon, and automatic insertion doesn't help, probably because of the % sign. The test still runs, but the first call after level1() fails, meaning the inlining does not happen. Change-Id: Icd2d08e676ea3cade63d4e12277748a447e410fc Reviewed-on: https://chromium-review.googlesource.com/1030210Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#52808}
-
Stephan Herhut authored
This adds support for the I32AtomicCompareExchange operations in the interpreter. Also, the interpreter will now fail if it encounters an unknown opcode from the atomic prefix. Bug: chromium:826069 Change-Id: Iec1742271f4fdd83fcaa09ca72c24d1cf8c58835 Reviewed-on: https://chromium-review.googlesource.com/1029867Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#52807}
-
sreten.kovacevic authored
Implement float to i32/u32 conversion on mips. Also, fix order of arguments in some macro-assembler instructions used for these conversions. Bug: v8:6600 Change-Id: I94c91f8ac7796ac66fb3cf0129a2a27c1a6ec336 Reviewed-on: https://chromium-review.googlesource.com/1028232 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/358d25a..403c903 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/8febfea..ab7b6a7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f718fb1..dc970d3 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/b640d87..4bd8c46 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/aff99f5..e4194dc Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5395a74..abe5e4f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I8b2b34357451a7c1f71327e7cf633dc73aea5f72 Reviewed-on: https://chromium-review.googlesource.com/1029740 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52805}
-
Camillo Bruni authored
- display enum cache - display capacity Change-Id: I79eed54af36b1fbb5435d96b650c0823be380e20 Reviewed-on: https://chromium-review.googlesource.com/1027874 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#52804}
-
Clemens Hammacher authored
This adds support for f32.min and f32.max, implemented on ia32, x64, mips and mips64. R=ahaas@chromium.org Bug: v8:6600 Change-Id: If73abf3cf46011ba84158ed2ec02d074adcf4ba2 Reviewed-on: https://chromium-review.googlesource.com/1027841 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80b7a3c..358d25a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I31cde2d9d9ffbfd4954038d36fc8bfd2f726151d Reviewed-on: https://chromium-review.googlesource.com/1012970Reviewed-by:
-
Stephan Herhut authored
For wasm memory buffers, we normally require the memory to be allocated via WebAssembly.Memory, which will set a is_wasm_memory flag and register the memory with the wasm allocation tracker. This CL weakens that requirement in a DCHECK to allow for running experimental threaded applications even though the is_wasm_memory flag is not currently propagated via postMessage. Bug: chromium:836800 Change-Id: I4613b8651423307ce4cd466c0df28fc43244ec4f Reviewed-on: https://chromium-review.googlesource.com/1027813 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52801}
-
Michael Achenbach authored
This reverts commit 436faae0. Reason for revert: Introduces flakes: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/24482 https://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/13557 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/25210 Original change's description: > [inspector] added timeout for Debugger.evaluateOnCallFrame method > > R=dgozman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 > Reviewed-on: https://chromium-review.googlesource.com/1023035 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52798} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I63ee0d19642856a7c0c2128bfa4c4620974d1919 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1029910Reviewed-by:
-
Sigurd Schneider authored
This CL also removes the JSBuiltinReducer, which is no longer needed. Bug: v8:7340, v8:7250 Change-Id: I28896f6ce0d352047ea1cb7ea6de490818840faf Reviewed-on: https://chromium-review.googlesource.com/1027853 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52799}
-
- 25 Apr, 2018 16 commits
-
-
Alexey Kozyatinskiy authored
R=dgozman@chromium.org,yangguo@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 Reviewed-on: https://chromium-review.googlesource.com/1023035 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#52798}
-
Jungshik Shin authored
Rolling ICU to include the following CLs will make the two tests below pass unexpectedly. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1026797 intl402/language-tags-canonicalized.js intl402/Intl/preferred-variants.js Mark them as skipped for now. Will remove from the status file when the following v8 CL is submitted after ICU is rolled. https://chromium-review.googlesource.com/c/v8/v8/+/1023379 Bug: v8:7669, v8:5693 Test: The above tests Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iae2ab0076b3dfcf45b8940c0d294cb3371463654 Reviewed-on: https://chromium-review.googlesource.com/1028655Reviewed-by:
-
Jungshik Shin authored
https://github.com/tc39/ecma402/pull/194 requires that TimeClip be called before formatting in Intl.DateTimeFormat. Bug: v8:7471 Test: test262/intl402/DateTimeFormat/prototype/format/time-clip* Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iad80376ae7598aab3e4df84a6cbbcd8691e16e09 Reviewed-on: https://chromium-review.googlesource.com/1027442Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52796}
-
Aleksey Kozyatinskiy authored
This reverts commit dcdabdc8. Reason for revert: broke tsan. Original change's description: > [elements] Improve Array.prototype.splice speed > > By using memmove for SMI elements we get a roughly 3x speedup over the slower > iterative copying with write barriers. > > Bug: chromium:835558 > Change-Id: I73da07a1648a3495ff78212ffa1ed949d205a7d2 > Reviewed-on: https://chromium-review.googlesource.com/1028236 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52792} TBR=cbruni@chromium.org,ishell@chromium.org Change-Id: I77c46fe3d47d651de3c39df9fbf5f30c340188e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:835558 Reviewed-on: https://chromium-review.googlesource.com/1028337Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52795}
-
Ben Smith authored
The WasmInstanceObject stores two new arrays: - imported_mutable_globals_buffers_: a FixedArray of all the imported globals' array buffers. - imported_mutable_globals: a calloc'd array of Addresses pointing to the mutable global in its array buffer. When accessing the global, the generated code looks up the address in imported_mutable_globals to find where to load/store. Bug: v8:7625 Change-Id: I60844c21a788fce28f346455f10f2283d1c152e9 Reviewed-on: https://chromium-review.googlesource.com/1020602 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
When only_terminate_in_safe_scope flag is passed as CreateParams for v8::Isolate, V8 does not trigger intrruption for termination if there is no explicit SafeForTerminationeScope. Scope enables termination only in direct v8 calls, any recursive calls require explicit SafeForTerminationScope. R=yangguo@chromium.org Bug: chromium:820640 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iac17e30a4b47aa84e70e9218ca0adca9d07f726e Reviewed-on: https://chromium-review.googlesource.com/1025390Reviewed-by:
-
Camillo Bruni authored
By using memmove for SMI elements we get a roughly 3x speedup over the slower iterative copying with write barriers. Bug: chromium:835558 Change-Id: I73da07a1648a3495ff78212ffa1ed949d205a7d2 Reviewed-on: https://chromium-review.googlesource.com/1028236Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#52792}
-
Camillo Bruni authored
This is is a preparatory CL to detach the JSFunction from the Context. We mainly rewrite the DebugScopeInterator to no longer rely on the a JSFunction to be around. Additionally the empty_function needs to have a proper ScopeInfo now. Drive-by-fix: Improve ScopeInfo debug printing Bug: v8:7066 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2f2fa0e78914a12e076384e0e1234c2322ad1ee8 Reviewed-on: https://chromium-review.googlesource.com/918721 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#52791}
-
Camillo Bruni authored
- 30% speedup by adding HeapObject shortcut for Heap::InNewSpace Bug: chromium:835558 Change-Id: I48b5ec43a5ecdd7d82827c955ab418fdeff449d8 Reviewed-on: https://chromium-review.googlesource.com/1027471 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52790}
-
Ben Smith authored
The mutable-globals proposal spec allows importing as Numbers or WebAssembly.Global values, but always exports as WebAssembly.Global. Since the value is always boxed, we can also import/export i64 values. This CL also includes support for export of mutable globals. Since the underlying ArrayBuffer that stores the global's value is shared between the module and the WebAssembly.Global object, all that needs to be done is remove the validation check. Bug: v8:7625 Change-Id: I24d763e3bc193d229a7cc33b2f2690a473c6f2bc Reviewed-on: https://chromium-review.googlesource.com/1018406 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Andrew Grieve authored
And tweak --depot-tools to go first on PATH Change-Id: Iee53d84fd028ac0c2de6f872184cbce51e84c54f Reviewed-on: https://chromium-review.googlesource.com/1028210Reviewed-by:
-
Kim-Anh Tran authored
Statistics need to be updated after top-tier code is added to the native module. Change-Id: Ie3a76caf233a2c3929b40fd0371c3069724b5289 Reviewed-on: https://chromium-review.googlesource.com/1027854Reviewed-by:
-
Camillo Bruni authored
Iterate over all descriptors instead of bailing out early and missing enumerable properties later. Bug: chromium:836145 Change-Id: I104f7ea89480383b6b4b9204942a166bdf8e0597 Reviewed-on: https://chromium-review.googlesource.com/1027832Reviewed-by:
-
Clemens Hammacher authored
This adds support for i64.div_s, i64.div_u, i64.rem_s, and i64.rem_u. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I37e564684b278c8d2f664a859851c67f4bd83190 Reviewed-on: https://chromium-review.googlesource.com/1027612Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: v8:6600 Change-Id: Iaa46324dfcf3b20f42d6a7448fca9ef2bbf241e9 Reviewed-on: https://chromium-review.googlesource.com/1027851 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Predrag Rudic authored
Change-Id: Ide0b3cab6c1cdb6cbb1b189852b309e08c1c504f Reviewed-on: https://chromium-review.googlesource.com/1028010Reviewed-by:
-
