- 11 Nov, 2016 15 commits
-
-
ahaas authored
According to the spec data segments are allowed even if the memory size is zero. However, if one of the data segments has a length greater than 0, then module instantiation should fail. I also changed the exception type in LoadDataSegments to TypeError, because that's the exception type for all exceptions which can happen during instantiation. R=titzer@chromium.org, rossberg@chromium.org TEST=cctest/test-run-wasm-module/EmptyMemoryEmptyDataSegment, cctest/test-run-wasm-module/EmptyMemoryNonEmptyDataSegment Review-Url: https://codereview.chromium.org/2483053005 Cr-Commit-Position: refs/heads/master@{#40922}
-
jkummerow authored
A SmiUntag() was missing when loading the old backing store's length. BUG=chromium:664469 Review-Url: https://codereview.chromium.org/2492783004 Cr-Commit-Position: refs/heads/master@{#40921}
-
leszeks authored
BUG=v8:5512 Review-Url: https://codereview.chromium.org/2491773006 Cr-Commit-Position: refs/heads/master@{#40920}
-
bmeurer authored
Revert of [compiler] Fix flipped boolean checks in marked tier-up (patchset #7 id:120001 of https://codereview.chromium.org/2478323002/ ) Reason for revert: Breaks deopt fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/14872/steps/Deopt%20Fuzz%20on%20Ubuntu-12.04/logs/stdio Original issue's description: > [compiler] Fix flipped boolean checks in marked tier-up > > Fixes incorrect checks for handle validity when checking the compiled > code, as well as incorrect uses of tst in arm and ppc flag checking > code. Also adds a test that the tier-up works correctly. TBR=rmcilroy@chromium.org,leszeks@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2492523007 Cr-Commit-Position: refs/heads/master@{#40919}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2493183002 Cr-Commit-Position: refs/heads/master@{#40918}
-
jgruber authored
This CL adds support for: * conditional breaks in setBreakpoint, * locals in frame.local{Count,Name,Value}, * evaluation on a frame in frame.evaluate, * and more detailed scope information in scopeObject. Uses of several functions that are not covered by the inspector protocol and are only used in tests have been removed. Local handling has been modified to also include arguments as locals. Inspector differs in this regard from our FrameDetails in that arguments are always shown as locals. Argument-related functions were removed. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2491543002 Cr-Commit-Position: refs/heads/master@{#40917}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2493173002 Cr-Commit-Position: refs/heads/master@{#40916}
-
leszeks authored
Fixes incorrect checks for handle validity when checking the compiled code, as well as incorrect uses of tst in arm and ppc flag checking code. Also adds a test that the tier-up works correctly. Review-Url: https://codereview.chromium.org/2478323002 Cr-Commit-Position: refs/heads/master@{#40915}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2492793005 Cr-Commit-Position: refs/heads/master@{#40914}
-
titzer authored
This CL moves all heap-allocated WASM data structures, both ones that are bonafide JSObjects and ones that are FixedArrays only, into a consistent place with consistent layout. Note that not all accessors are complete, and I haven't fully spread the new static typing goodness to all places in the code. R=ahaas@chromium.org,rossberg@chromium.org CC=gdeepti@chromium.org,mtrofin@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2490663002 Cr-Commit-Position: refs/heads/master@{#40913}
-
jkummerow authored
And decouple hydrogen-instructions.h from code-stubs.h. This avoids all of Crankshaft being recompiled when code-stub-assembler.h changes. Review-Url: https://codereview.chromium.org/2498563002 Cr-Commit-Position: refs/heads/master@{#40912}
-
mstarzinger authored
This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2432413004 Cr-Commit-Position: refs/heads/master@{#40911}
-
mythria authored
Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280 Review-Url: https://codereview.chromium.org/2487573005 Cr-Commit-Position: refs/heads/master@{#40910}
-
bmeurer authored
Utilize the string length protector to deoptimize if the resulting string length for string addition overflows. This way we generate less code here and avoid holding on to the lazy frame state, and thus potentially reduce the number live ranges. BUG=v8:5267,v8:5404 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2491943004 Cr-Commit-Position: refs/heads/master@{#40909}
-
bmeurer authored
The contract for TurboFan is that we use NumberConstants for any kind of number value until the representation selection picks concrete representations, i.e. Int32Constant or Float64Constant. We will soon be able to also guard this contract with DCHECKs. BUG=v8:5267 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2499573002 Cr-Commit-Position: refs/heads/master@{#40908}
-
- 10 Nov, 2016 25 commits
-
-
jyan authored
use StoreDouble and LoadDouble function to avoid overflowing offset used in std and ld R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2492913002 Cr-Commit-Position: refs/heads/master@{#40907}
-
yangguo authored
Revert of Compiling an array literal should be context-independent. (patchset #5 id:80001 of https://codereview.chromium.org/2479123002/ ) Reason for revert: speculative revert to fix https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9646/steps/Mjsunit%20%28flakes%29/logs/debug-scopes Original issue's description: > Compiling an array literal should be context-independent. > > We are removing use of the debugger context. When the debugger triggers > compilation, we may not have a context from which to create a JSArray. > > R=ishell@chromium.org TBR=ishell@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2481363009 Cr-Commit-Position: refs/heads/master@{#40906}
-
mlippautz authored
Record feedback for moved pages. Aligns the behavior of the copying and moving evacuator. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2494723002 Cr-Commit-Position: refs/heads/master@{#40905}
-
rmcilroy authored
BUG=chromium:664146 Review-Url: https://codereview.chromium.org/2495543002 Cr-Commit-Position: refs/heads/master@{#40904}
-
gsathya authored
- A new runtime function (%create_resolving_functions) is installed to call the CreateResolvingFunctions builtin from JS. - Three new builtins are created - resolve and reject functions and a third function that creates a new JSFunctions from these resolve/reject builtins. - The promise reject function is installed on the context temporarily as internal_promise_reject. This should go away once we remove PromiseSet. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2459283004 Cr-Commit-Position: refs/heads/master@{#40903}
-
ishell authored
BUG=chromium:663750, chromium:664123 Review-Url: https://codereview.chromium.org/2495563002 Cr-Commit-Position: refs/heads/master@{#40902}
-
ahaas authored
According to the spec, import wrappers are only generated for JavaScript functions, not for WebAssembly function. If an imported WebAssembly function does not have the expected type, then a type error is thrown. R=titzer@chromium.org, rossberg@chromium.org TEST=mjsunit/wasm/test-import-export-wrapper Review-Url: https://codereview.chromium.org/2486943005 Cr-Commit-Position: refs/heads/master@{#40901}
-
jarin authored
BUG=chromium:664087 Review-Url: https://codereview.chromium.org/2491333002 Cr-Commit-Position: refs/heads/master@{#40900}
-
bjaideep authored
Port 832439ab Original commit message: FullCodeGen does not include CallICs in the total ic count. Fix it by making calls to CallIC to go through CallIC function, which keeps track of the total number of ICs. R=mythria@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2492803002 Cr-Commit-Position: refs/heads/master@{#40899}
-
bjaideep authored
Port 93c65952 Original commit message: This changes {FrameState} nodes modeling "after" states to use bytecode offsets pointing to the deoptimizing bytecode. This is in sync with the normal execution, as the bytecode offset is advanced after operations complete in regular bytecode handlers. The change is necessary to ensure lazy deoptimized frames contain an accurate bytecode offset while they are on the stack. Such frames can be inspected by various stack walks. The continuation builtin will advance the bytecode offset upon return. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2486393005 Cr-Commit-Position: refs/heads/master@{#40898}
-
mstarzinger authored
R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-662367 BUG=chromium:662367 Review-Url: https://codereview.chromium.org/2486923004 Cr-Commit-Position: refs/heads/master@{#40897}
-
jkummerow authored
BUG=v8:5269,v8:5561 Review-Url: https://codereview.chromium.org/2444353002 Cr-Commit-Position: refs/heads/master@{#40896}
-
jkummerow authored
to actually trap allocation mementos. Review-Url: https://codereview.chromium.org/2487943005 Cr-Commit-Position: refs/heads/master@{#40895}
-
bmeurer authored
BUG=chromium:664084 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2494703002 Cr-Commit-Position: refs/heads/master@{#40894}
-
jkummerow authored
This is mostly a performance experiment. If it provides no speedup, it can be reverted to keep IC miss events in timeline plots. Otherwise, the RuntimeCallStats system is the replacement tool for investigating performance issues related to IC misses. This effectively reverts 1f8adc15 / r21736. Review-Url: https://codereview.chromium.org/2480343002 Cr-Commit-Position: refs/heads/master@{#40893}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2493553002 Cr-Commit-Position: refs/heads/master@{#40892}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2487673004 Cr-Commit-Position: refs/heads/master@{#40891}
-
ishell authored
BUG=v8:5561 Review-Url: https://codereview.chromium.org/2489293002 Cr-Commit-Position: refs/heads/master@{#40890}
-
mythria authored
FullCodeGen does not include CallICs in the total ic count. Fix it by making calls to CallIC to go through CallIC function, which keeps track of the total number of ICs. BUG= Review-Url: https://codereview.chromium.org/2451703002 Cr-Commit-Position: refs/heads/master@{#40889}
-
mythria authored
Ignition does not collect information about lhs and rhs types. It collects information about the combined type of lhs, rhs and result types. Since ignition combines the feedback, sometimes we may collect less precise information than FCG. This impacts performance of some benchmarks like audio-beat-detection. This cl tries to mitigate this affect by passing only full-codegen feedback when the combined FCG feedback is same as the feedback collected by ignition. BUG= Review-Url: https://codereview.chromium.org/2488983002 Cr-Commit-Position: refs/heads/master@{#40888}
-
mstarzinger authored
This changes {FrameState} nodes modeling "after" states to use bytecode offsets pointing to the deoptimizing bytecode. This is in sync with the normal execution, as the bytecode offset is advanced after operations complete in regular bytecode handlers. The change is necessary to ensure lazy deoptimized frames contain an accurate bytecode offset while they are on the stack. Such frames can be inspected by various stack walks. The continuation builtin will advance the bytecode offset upon return. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-660379 BUG=chromium:660379 Review-Url: https://codereview.chromium.org/2487173002 Cr-Commit-Position: refs/heads/master@{#40887}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2492553003 Cr-Commit-Position: refs/heads/master@{#40886}
-
jgruber authored
TurboFan can create ConsStrings with empty first parts (for history on this decision, see da27e0c8). Add a fast-path for such cases in String::SlowFlatten. BUG= Review-Url: https://codereview.chromium.org/2489273002 Cr-Commit-Position: refs/heads/master@{#40885}
-
yangguo authored
We are removing use of the debugger context. When the debugger triggers compilation, we may not have a context from which to create a JSArray. R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2479123002 Cr-Commit-Position: refs/heads/master@{#40884}
-
rmcilroy authored
We seem to get some small wins from avoiding the Ldr bytecodes, probably due to reduced icache pressure since there are less bytecode handlers. Replace the Ldr bytecodes with Star lookahead inlined into the Lda versions. Also fixes IsAccumulatorLoadWithoutEffects to include LdaContextSlot and LdaCurrentContextSlot BUG=v8:4280 Review-Url: https://codereview.chromium.org/2489513005 Cr-Commit-Position: refs/heads/master@{#40883}
-