- 01 Oct, 2018 14 commits
-
-
Clemens Hammacher authored
This removes duplication in the platform-dependent assemblers by introducing {AssemblerBase::ShouldRecordRelocInfo}. On arm64, we also remove a bool and replace it by an early exit. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I08c623a19167a358c3188dc9008f045120da82b1 Reviewed-on: https://chromium-review.googlesource.com/1251085Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56319}
-
Michael Starzinger authored
R=titzer@chromium.org Change-Id: Id2766ee8d69ebd1a747374f1be71788c77a41d70 Reviewed-on: https://chromium-review.googlesource.com/1254128Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#56318}
-
Peter Marshall authored
This change saves 55 KiB binary size. Bug: v8:8238 Change-Id: I01ba8ea7de2884f178577ba007496b35d8578acc Reviewed-on: https://chromium-review.googlesource.com/1254122Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56317}
-
Peter Marshall authored
This reduces the usage of macros and shrinks the binary size (by 4 KiB). Bug: v8:8238 Change-Id: Ic689f8ce7dabe481125fcdb74a265155431317b6 Reviewed-on: https://chromium-review.googlesource.com/1253605Reviewed-by:
-
Hai Dang authored
The protector is useful for follow-up optimizations on string iterator. Tests are also added. Change-Id: I416037c742628c4d4d3b878d0df727a9ae7162f7 Reviewed-on: https://chromium-review.googlesource.com/1251122Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Hai Dang <dhai@google.com> Cr-Commit-Position: refs/heads/master@{#56315}
-
Florian Sattler authored
Delay the creation of FunctionNameVariables until we validated the FormalParameters. This is needed so we don't declare them in cases where we later get an error, have to reset, and reparse. Bug: chromium:890553, v8:7926 Change-Id: I742e6f7f71158e3903843bd583dc7943468c18f6 Reviewed-on: https://chromium-review.googlesource.com/1254061Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#56314}
-
Michael Starzinger authored
R=titzer@chromium.org Change-Id: I543f7d65d04b54951be126ca1e30bb7e81f026a8 Reviewed-on: https://chromium-review.googlesource.com/1253606Reviewed-by:
-
Tobias Tebbi authored
This removes the burden from Torque not to emit unnecessary phis. This is factored out from the Torque IR CL (https://crrev.com/c/1245766). Change-Id: I302714250e9ea6367f37613c09caa522d56c151c Reviewed-on: https://chromium-review.googlesource.com/1254121Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56312}
-
Michael Lippautz authored
Instead of writing the forwarding pointer of this object and treating it like an object that would survive on scavenge just write the actual string pointer to the outer slot. As a consequence, the ThingString will not look like a live object and is handled properly when pruning the external string table. Bug: v8:8249 Test: test/cctest/heap/test-external-string-tracker.cc Change-Id: I975900213e2e4b598f298c8f78b6c6047c9e6da4 Reviewed-on: https://chromium-review.googlesource.com/1252885Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#56311}
-
Mathias Bynens authored
It was shipped in Chrome 67. Bug: v8:6791, v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I94d8f0aa18570452403a35dea270b18f155c970a Reviewed-on: https://chromium-review.googlesource.com/1253604Reviewed-by:
-
Maya Lekova authored
This change adds an infrastructure to "snapshot" data that is being serialized only once. This data lives in its own per-isolate zone, wrapped in a new CompilerData class. This change reduces the "serialize standard objects" on TypeScript benchmark from ~69ms to ~30ms (more than 50% improvement). Bug: v8:7790 Change-Id: I6ce4f6fb993334969662fdd993d681945a9f3727 Reviewed-on: https://chromium-review.googlesource.com/1238920 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Georg Neis authored
Once the broker retired, only allow retrieval of a reference's handle. That's all we need for now. Bug: v8:7790 Change-Id: Ib75887ed4a68e19ad7fad4c6046e340502542850 Reviewed-on: https://chromium-review.googlesource.com/1251086Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Currently, we call the MapRef::AsElementsKind method on an initial map multiple times (from JSCreateLowering::ReduceJSCreateArray). However, this does not does not play well with the heap copier/broker, which only expectes AsElementsKind to be called on initial maps. This CL makes sure we only call AsElementsKind once (on the initial map). Bug: chromium:890620 Change-Id: If44421d3900abb7629ea8f789a005b8d8ebaf881 Reviewed-on: https://chromium-review.googlesource.com/1253105Reviewed-by:
-
Toon Verwaest authored
Shortcuts allow identifiable primary expressions to bypass all productions starting from assignment expression. We can identify them by looking at the token after the single token of which the primary expression consists. This CL adds support for 'identifier' followed by '=' as a primary LHS. Change-Id: I2f1939a39e03384598359a3a39e1d6cef9967e21 Reviewed-on: https://chromium-review.googlesource.com/1252805Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56306}
-
- 30 Sep, 2018 4 commits
-
-
Michael Achenbach authored
This reverts commit c285380c. Reason for revert: Lots of dcheck failures on GPU bots, e.g.: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Win%20V8%20FYI%20Release%20(NVIDIA)/1997 https://ci.chromium.org/p/v8/builders/luci.v8.ci/Linux%20V8%20FYI%20Release%20(NVIDIA)/2770 Original change's description: > Create a fast path to get migration target when updating map > > During map updating, store the pointer to new map in the > raw_transitions slot of the old map that is deprecated from map > transition tree. Thus, we can get the migration target directly > instead of TryReplayPropertyTransitions when updating map. > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM > Chromebook and ~9% on big-core Ubuntu. > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db > Reviewed-on: https://chromium-review.googlesource.com/1233433 > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56303} TBR=ishell@chromium.org,shiyu.zhang@intel.com Change-Id: I9b268d662cfa3a7fec577468eafe6570389252bc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1253104Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56305}
-
Benedikt Meurer authored
The representation changer was lacking support for directly converting Word64 values to Bit representation. Bug: chromium:890243, v8:4153, v8:7881, v8:8171, v8:8178 Change-Id: I5fa31716c7b2b10ad00dc31d5035a1ada152661c Reviewed-on: https://chromium-review.googlesource.com/1251551Reviewed-by:
-
Shiyu Zhang authored
During map updating, store the pointer to new map in the raw_transitions slot of the old map that is deprecated from map transition tree. Thus, we can get the migration target directly instead of TryReplayPropertyTransitions when updating map. This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM Chromebook and ~9% on big-core Ubuntu. Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db Reviewed-on: https://chromium-review.googlesource.com/1233433 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56303}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e76ff65..79a709e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d525ef3..98289bc Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/003e878..7792d28 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I831486cac2077b74f5a4cd89243908dce2cceee4 Reviewed-on: https://chromium-review.googlesource.com/1253186Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56302}
-
- 29 Sep, 2018 4 commits
-
-
Benedikt Meurer authored
Change the way that the (internal) await closures store the link to the generator object by introducing a dedicated AwaitContext, which stores the generator object into the extension slot (instead of misusing a regular FunctionContext here). Also unify the allocation+initialization of these contexts in the await-related builtins (both for async functions and generators). The rationale behind this is that for (zero-cost) async stack traces, we will need to dig into these contexts and we can do better checking with a dedicated instance type there. As an additional benefit, we save one word per await context, since we just use (the otherwise unused) extension slot to remember the generator object. As yet another benefit we will never accidentally use any of these contexts in the regular scope chain lookups, meaning we can also catch bugs there. And last but not least the objects printing machinery understands these contexts now and can even print the generator object for AwaitContexts for short printing, which is really valuable for debugging. Tbr: ulan@chromium.org Bug: v8:7253, v8:7522, v8:8015 Change-Id: I86955f5701e694e8a10b91ebe5f52705aa90968d Reviewed-on: https://chromium-review.googlesource.com/1249491Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eb7ca76..e76ff65 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7453eba..d525ef3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c5434e9..003e878 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic48e0bc7b178093fe7a029f466aebd4a9eea9b40 Reviewed-on: https://chromium-review.googlesource.com/1253183 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Frank Tang authored
Remove Unpack* methods from all Intl objects Make the icu data in Intl objects more consistent in naming Bug: v8:8248 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If81a3010265e91919b548dad2dbd11c5ae8e4abd Reviewed-on: https://chromium-review.googlesource.com/1252883Reviewed-by:
-
Frank Tang authored
Bug: v8:7684 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifbdce635d190bd379414d3410aed1208412a9530 Reviewed-on: https://chromium-review.googlesource.com/1251587Reviewed-by:
-
- 28 Sep, 2018 18 commits
-
-
Deepti Gandluri authored
This CL mirrors the ia32 SIMD conversion, Alltrue/AnyTrue operations with minor cleanliness changes to use TempRegisters instead of ScratchRegisters Change-Id: I84d3e148200dd611a72380b24404b75c73c5352d Reviewed-on: https://chromium-review.googlesource.com/1174096 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#56297}
-
Frank Tang authored
Remove numbering_system and change the type of locale to reduce memory usage of JSDateTimeFormat Bug: v8:8066 Change-Id: I8a319e05312ffa62f22a382bf150bbe9b48f5f54 Reviewed-on: https://chromium-review.googlesource.com/1242093 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
- we can avoid using regexps, - this CL also fixed a bug. R=alph@chromium.org Bug: chromium:870957 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9799507b85942be454a7c20d2768fe7442fc965e Reviewed-on: https://chromium-review.googlesource.com/1250403 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#56295}
-
Alexey Kozyatinskiy authored
New method was added to console spec [1]. This CL implements it. [1] https://console.spec.whatwg.org/#timelog R=dgozman@chromium.org,yangguo@chromium.org Bug: chromium:854474 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie5f249795979bb886cf824ae9f950c5ef78ce04d Reviewed-on: https://chromium-review.googlesource.com/1247641 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
Sometimes we do not have promise on stack, e.g. Promise.reject call, but we need to attribute this pause with promise rejection. TBR=yangguo@chromium.org Bug: chromium:755728 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03ca1e1cd6c21677f0a12ece626e2c8a1938437b Reviewed-on: https://chromium-review.googlesource.com/1249942Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56293}
-
Georg Neis authored
This is necessary to be able to share the data for read-only objects amongst multiple broker instances. Bug: v8:7790 Change-Id: I0da58f8a9eded06ac6e994bc540a3a1bc481d6a7 Reviewed-on: https://chromium-review.googlesource.com/1251308Reviewed-by:
-
Mathias Bynens authored
Bug: v8:8015, v8:7467 Change-Id: I0a25fdd7631447235839680c993505179a1cd793 Reviewed-on: https://chromium-review.googlesource.com/1238656Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:890222 Change-Id: I3c3f8902cc0775edfcdcc85bb0cbc3320bf6c1ef Reviewed-on: https://chromium-review.googlesource.com/1251523 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Daniel Clifford authored
This CL adds a bit more rigor to the handling of length properties in JSObject-derived classes that explicitly contain that property inline. This involves: - Introducing a new superclass of JSArgumentsObject called JSArgumentsObjectWithLength that is shared with other object instances that also have a fixed length property. - Adding JSArgumentsObjectWithLength to the type hierarchy in Torque, including adding fast-cases for leading the length property for all classes deriving from JSObjectWithLength. - Adding more rigor to Context and NativeContext handling in base.tq. This is useful for the map checks required to verify objects are argument object types derived from JSArgumentsObjectWithLength. Change-Id: I2f0a20601ffcb90b3767cbaeb766e9998d3462ec Reviewed-on: https://chromium-review.googlesource.com/1248661 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56289}
-
Clemens Hammacher authored
We have the generic {no_reg} and {no_dreg}, other definitions are dead. Currently even {no_dreg} is dead, but I am keeping this because I can see future need for that. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I0de597fead6b3def18fd5c530419d3c149f235a8 Reviewed-on: https://chromium-review.googlesource.com/1251123Reviewed-by: -
Igor Sheludko authored
It was accidentally removed in CL that introduced BoundedPageAllocator. This CL also cleans up the CodeRangeAddressHint a bit. Bug: v8:8096, chromium:887252 Change-Id: Idc84796dd1ff1b440cbe3515732984264defcf2d Reviewed-on: https://chromium-review.googlesource.com/1249125 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#56287}
-
Clemens Hammacher authored
Pending phantom handle callbacks are not reliably executed if the heap shuts down. This can cause to memory leaks or other unwanted behaviour, like in wasm where the NativeModules (held in Managed objects implemented via phantom handles) unregister from the WasmEngine in the second-pass callback. This must be executed before tearing down the WasmEngine. This CL fixes this by running pending callback synchronously on heap tear down. R=ulan@chromium.org, mlippautz@chromium.org Bug: v8:8208 Change-Id: I27b630c4d8f1fb12309040ea2179b64eed38710a Reviewed-on: https://chromium-review.googlesource.com/1249101 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Minor refactoring, for readability and performance. R=ahaas@chromium.org Bug: v8:8015 Change-Id: I30c4a76998c8867aea0e08fd982b4425d4ae8fef Reviewed-on: https://chromium-review.googlesource.com/1251163Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56285}
-
Igor Sheludko authored
Trimming may free up some allocatable pages that can be reused by subsequent allocations. This CL also fixes base::AddressRegion::contains(Address, size_t). Bug: v8:8096 Change-Id: I3b7381fd32f7dbf186dffc1a26d5a88cd8a30d2f Reviewed-on: https://chromium-review.googlesource.com/1249127Reviewed-by:
-
Toon Verwaest authored
|this| cannot be an ambiguous declaration. Actual declarations are inserted upon function scope creation, so we can simply parse as reference and it will resolve correctly. Change-Id: I3aaa1a2666b4caffbf8524caec7068125e10240b Reviewed-on: https://chromium-review.googlesource.com/1251162Reviewed-by:
-
Clemens Hammacher authored
This reverts commit e4c650ad. Reason for revert: Break Linux nosnap: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/20786 Original change's description: > [heap] Free dead young generation large objects. > > Bug: chromium:852420 > Change-Id: I77479c3a96bcae6041ddce316c5062f129447edd > Reviewed-on: https://chromium-review.googlesource.com/1249124 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56280} TBR=hpayer@chromium.org,mlippautz@chromium.org Change-Id: If35a09497e09f5cc7ceef8ec33a7c86761f2a336 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/1251124Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56282}
-
Florian Sattler authored
PreParser now does not longer track which kind of error occurred. If we see an error we reparse with the parser and report the error. Furthermore, this fixes tests in test-parsing. Change-Id: I1860949fab4d65ff4a5a1b63796c7574494f9d50 Reviewed-on: https://chromium-review.googlesource.com/1231173 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I77479c3a96bcae6041ddce316c5062f129447edd Reviewed-on: https://chromium-review.googlesource.com/1249124 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
