- 22 Aug, 2017 11 commits
-
-
Ross McIlroy authored
Does a couple of cleanups on interpreter assembler: - Adding naming to the variable fields to improve debugability - Grouping functions which deal with loading the state passed between bytecode handlers (e.g. bytecode array / offset / etc.). - Fix some comments in interpreter-generator.cc Change-Id: I9decefebbdf7830a7ce75dd46e8a69a1db3c4cc8 Reviewed-on: https://chromium-review.googlesource.com/625797Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47499}
-
Marja Hölttä authored
This stopped working because of r47337 ( https://chromium-review.googlesource.com/c/v8/v8/+/605949/8/src/compiler.cc#418 ). Also enhanced the test so that it would've caught this. BUG=v8:5516 Change-Id: I933a8b5d787c3eb8b2cc230e2b35df1f25b500e7 Reviewed-on: https://chromium-review.googlesource.com/625618Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47498}
-
Michael Starzinger authored
This makes sure that shift expressions (not wrapped in parentheses) can appear as part of the index in a valid heap access expression. Only the last operand of a sequence of shift expressions is taken into account when validating the heap access. R=jarin@chromium.org TEST=mjsunit/regress/regress-6700 BUG=v8:6700,chromium:754751 Change-Id: Icc7a71bd64461da4d3daea41b995964e3dfc6dc6 Reviewed-on: https://chromium-review.googlesource.com/623811 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#47497}
-
Peter Marshall authored
Bug: v8:6333 Change-Id: I189aa2938287e634bb4fec3b0e7c16acb6d66a11 Reviewed-on: https://chromium-review.googlesource.com/623249 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47496}
-
jgruber authored
If the elements fixed array is large enough, it must be allocated in large-object space. This fixes two cases in which we'd incorrectly assume elements fits into new space. There are potentially quite a few other spots affected by a similar issue, and we should find a more robust solution. See also: crbug.com/636391. Bug: v8:6716 Change-Id: I91f09355ac6b7cf399e13cc21d34113a506e58fb Reviewed-on: https://chromium-review.googlesource.com/623808Reviewed-by:
-
Michael Lippautz authored
This reverts commit 9e839fce. Reason for revert: Wrong fix as we are not allowed to cache wrappers. Original change's description: > [heap] Fix incremental wrapper tracing toggle > > The flag is always on and support for turning it off is broken with > conservative barriers. > > Bug: > Change-Id: I1ff548f95d220bf0fcb6df7a1bf5f8a342163696 > Reviewed-on: https://chromium-review.googlesource.com/624494 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47482} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I90bc547a88cb8220c7261c607ef359df38e3bdf2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/623868Reviewed-by:
-
Juliana Franco authored
There's no need for this code to be completely architecture specific. Bug: v8:6563 Change-Id: I90aa1aa76fa266a247d8f374459a6eb6469c8c75 Reviewed-on: https://chromium-review.googlesource.com/612340 Commit-Queue: Juliana Patricia Vicente Franco <jupvfranco@google.com> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a049c43..fedc7df Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/85ae813..837e443 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I8a037a61a9e891d5287160eb2039ace12d71e2ba Reviewed-on: https://chromium-review.googlesource.com/624876Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47492}
-
Sathya Gunasekaran authored
Now that we no longer store the hash in the hash_code_symbol, we can do a fast lookup on the kPropertiesOrHash offset instead. Bug: v8:5717 Change-Id: I8724db3c9eb82c3f98aef650b54ae36b76fd12fd Reviewed-on: https://chromium-review.googlesource.com/624377 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
There's no need for these to be static. Bug: v8:5717 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia704cdcb9ee9666c7724b78d58c56217cd5876ae Reviewed-on: https://chromium-review.googlesource.com/624869 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47490}
-
Sathya Gunasekaran authored
This no longer causes allocation, so it's safe to unhandlify. This will allow us to use directly call into C++ (via CallCFunction) to calculate the hash instead of going through the runtime (via %GenericHash). Bug: v8:5717 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia561efb4d89d7a3d10c28913537b45b3ce477bb3 Reviewed-on: https://chromium-review.googlesource.com/624519Reviewed-by:
-
- 21 Aug, 2017 29 commits
-
-
Sathya Gunasekaran authored
Bug: v8:5717 Change-Id: I9841ddaed2f1e3d30dc580aad8b665e905f9edd7 Reviewed-on: https://chromium-review.googlesource.com/624533Reviewed-by:
-
Jaideep Bajwa authored
PPC instr has 16bits to represent an imm, load constant in register if imm is not in the range [-2^15, 2^15) R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com Log=N Bug: Change-Id: Id9aa97538b1f93f01d5a297b6256e1b082f06ca1 Reviewed-on: https://chromium-review.googlesource.com/624714Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47487}
-
Jakob Kummerow authored
Change-Id: Id4cb4e226834da47bc66c60a3de64f67f9079029 Reviewed-on: https://chromium-review.googlesource.com/620189 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47486}
-
Josh Wolfe authored
This feature is a stage 3 proposal implemented as a wrapper around ICU that categorizes singular/plural/etc grammatical forms based on a number and locale. Based on littledan's work started here: https://codereview.chromium.org/2736543002/ Bug: v8:5601 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I4107cd28be72413ec43aa1ff0f4fe6e181a290f4 Reviewed-on: https://chromium-review.googlesource.com/562298 Commit-Queue: Josh Wolfe <jwolfe@igalia.com> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47485}
-
Jakob Kummerow authored
Bug: v8:6409 Change-Id: I2902d9ad87bab3559c776593ca99d275eeaca8c0 Reviewed-on: https://chromium-review.googlesource.com/622411Reviewed-by:
-
Jakob Kummerow authored
This is a performance experiment. We will revert it if it causes regressions. The idea is that many map transitions are only performed once; but if they are done by a non-UNINITIALIZED StoreIC, we would always create a handler for them. With this CL, handler creation is postponed until the second time a given transition is done. The first time, the IC simply remains in its previous state. Change-Id: I0fb2989bb675a09ed7b329520346048ad2049f94 Reviewed-on: https://chromium-review.googlesource.com/622147Reviewed-by:
-
Michael Lippautz authored
The flag is always on and support for turning it off is broken with conservative barriers. Bug: Change-Id: I1ff548f95d220bf0fcb6df7a1bf5f8a342163696 Reviewed-on: https://chromium-review.googlesource.com/624494 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47482}
-
Roberto Oliveira authored
Some C libraries, notably Musl, define the regs member as a void pointer, hence we need to use the gp_regs member instead. Change-Id: I1ca2dbdba79a03ff81c25438c87c767d7a7cece4 Reviewed-on: https://chromium-review.googlesource.com/602327Reviewed-by:
Jaideep Bajwa <bjaideep@ca.ibm.com> Reviewed-by:
-
Alexey Kozyatinskiy authored
This API generates inspectRequested call with hints.queryObjects flag. It's not possible to expose this method by itself since command line API methods can leak. R=pfeldman@chromium.org Bug: v8:6732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3c582186f65d84a25eed910925a1b6ab36966a72 Reviewed-on: https://chromium-review.googlesource.com/622370Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47480}
-
Albert Mingkun Yang authored
The new node behave the same as its counterpart, CallCFunction, with the additional saving and restoring caller saved registers before and after the function call. Bug: chromium:749486 Change-Id: I0a1dfb2e4e55f7720541a00e6d16fd20220f39ed Reviewed-on: https://chromium-review.googlesource.com/620709 Commit-Queue: Albert Mingkun Yang <albertnetymk@google.com> Reviewed-by:
-
Alexey Kozyatinskiy authored
Runtime.queryObjects method: 1. force gc, 2. iterate through heap and get all objects with passed constructorName or with passed constructor name in prototype chain, 3. return these objects as JSArray. Main use case is regression tests for memory leaks. R=pfeldman@chromium.org,alph@chromium.org,ulan@chromium.org Bug: v8:6732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I52f0803366f14bb24376653615d870a4f21f83e7 Reviewed-on: https://chromium-review.googlesource.com/619594Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
R=jgruber@chromium.org Bug: chromium:752019 Change-Id: I9911b2d3cd65f41e0d1b94af05c9222f9a4f9ba8 Reviewed-on: https://chromium-review.googlesource.com/611618Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47477}
-
Michael Lippautz authored
Performance sheriffs: This CL adds better accounting and can thus cause regressions. Also-By: cbruni@chromium.org Bug: Change-Id: I38cdb702af201033e180741af40c4c5915553798 Reviewed-on: https://chromium-review.googlesource.com/623867Reviewed-by:
-
Jaroslav Sevcik authored
When merging effect phis, we currently do not try to merge information for any variables that are merged by phis on the same control merge. This CL implements a very limited version of merging map information for nodes: If all the map information for all inputs of the phi is the same, we assign that map information to the phi itself. This is somewhat consistent with merging map information for a node: there we also combine the information only if in all incoming paths we have teh same set of maps. In theory, we could union the sets of maps. Also, we could consider merging other information (such as abstract fields). This yields some small improvement (~2%) on the Octane deltablue benchmark. Bug: v8:5267 Change-Id: I9447732e3f0d06eb44632db492782fa35529f9fd Reviewed-on: https://chromium-review.googlesource.com/622792 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#47475}
-
Ross McIlroy authored
Changes the contract of the parser to have a valid character stream passed in the ParseInfo rather than the current situation where either: - it is passed explicitly (e.g., for streaming scripts) - a Script is passed and a character stream is created for this - or a source and encoding is passed in ParseInfo and the character stream is created from this. The parse info also now owns the character stream (in a unique_ptr). It can be destroyed using a new ResetCharacterStream() function. This will enable the character stream to be kept live if any functions are asm.js modules which were parsed, in order to be reused by the asm.js parser. BUG=v8:5203 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ifda167391b2eadb38ebf9fcb2f565d2ed9ea3c6f Reviewed-on: https://chromium-review.googlesource.com/616767 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47474}
-
Michael Starzinger authored
R=jarin@chromium.org BUG=v8:5653,v8:6409 Change-Id: I3a7e7173afbcba9bb0bb7b1baafe9e78e22bb696 Reviewed-on: https://chromium-review.googlesource.com/612174 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This reverts commit a241576f. Bytecode array visitor has a side-effect of incrementing the age counter. This patch makes the increment atomic and thus safe for the concurrent marker. Bug: chromium:694255 Change-Id: Ibe1d75714a5911385b06e52ed50b5f152ec6b73d Reviewed-on: https://chromium-review.googlesource.com/622432 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
jgruber authored
The CASE_BODY macro is inconvenient for debugging, as gdb points only at the SINGLE_CASE line, not the actual expanded line. Converting it into a templatized function should preserve optimization opportunities for the compiler while making debugging much easier. Bug: v8:6624 Change-Id: I864eff190e39e3230c529ced5c4919aa875763b1 Reviewed-on: https://chromium-review.googlesource.com/612084 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
This reverts commit 1e08466b. Reason for revert: Test run complete. Original change's description: > Revert "Revert "[parser] FLAG_aggressive_lazy_functions = true for a test run."" > > This reverts commit aee29a9f. > > Reason for revert: Bot is alive again, doing this test run now. > > Original change's description: > > Revert "[parser] FLAG_aggressive_lazy_functions = true for a test run." > > > > This reverts commit 0d51a259. > > > > Reason for revert: Bot is broken; makes no sense to run the experiment now. > > > > Original change's description: > > > [parser] FLAG_aggressive_lazy_functions = true for a test run. > > > > > > Just to get the RuntimeCallstats data. To be reverted soon. > > > > > > BUG=v8:5516 > > > NOTREECHECKS=true > > > > > > Change-Id: I4bb436900a79bb383bf8132002a129b601efdfe3 > > > Reviewed-on: https://chromium-review.googlesource.com/618987 > > > Reviewed-by: Adam Klein <adamk@chromium.org> > > > Commit-Queue: Marja Hölttä <marja@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#47416} > > > > TBR=adamk@chromium.org,machenbach@chromium.org,marja@chromium.org > > > > Change-Id: I8506ae7e1e16a4d0b320a486f743c01f7f82e0f2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: v8:5516 > > Reviewed-on: https://chromium-review.googlesource.com/620749 > > Reviewed-by: Marja Hölttä <marja@chromium.org> > > Commit-Queue: Marja Hölttä <marja@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#47425} > > TBR=adamk@chromium.org,machenbach@chromium.org,marja@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: v8:5516 > Change-Id: I09d8da398da33076db1656f3241e3de8e05757b7 > Reviewed-on: https://chromium-review.googlesource.com/623047 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47460} TBR=adamk@chromium.org,machenbach@chromium.org,marja@chromium.org Change-Id: Ic2d97d05b9e611fe93a0128671f55e9e74fe1909 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5516 Reviewed-on: https://chromium-review.googlesource.com/623407Reviewed-by:
-
Ulan Degenbaev authored
This replaces custom Release_CompareAndSwap implementation with a call to compiler intrinsic / std:atomic, which is TSAN friendly. Bug: chromium:694255 Change-Id: Iab67c8f5a3a2329b18030a70f3dbf3cb5530374e Reviewed-on: https://chromium-review.googlesource.com/622431 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This makes live byte count updates on the main thread non-atomic. Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I84da2b0647f63ad9d8f2be757d305d58945a00ff Reviewed-on: https://chromium-review.googlesource.com/613623 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Camillo Bruni authored
The quite common empty object literal doesn't need an AllocationSite since it starts off with the general ElementsKind. By using a separate bytecode we can directly instantiate the empty object without jumping to the runtime first. Note: this experimentally disables pretenuring for empty object literals. Depending on the outcome of our benchmarks pretenuring will be enabled again or fully removed for empty object literals. Bug: v8:6211 Change-Id: I2fee81cbefc70865fc436dbd3bc5fc8de04db91c Reviewed-on: https://chromium-review.googlesource.com/577555 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:Adam Klein <adamk@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Enrico Bacis authored
This CL introduces 4 tests that verify that the effects of a grow_memory instruction executed inside a loop are visible also when the loop is over. The tests verify the output of the current_memory instruction and the result of loading a variable stored in the grown memory inside the loop in the following cases: * the memory is grown inside the loop (no memory operation outside); * the memory is grown both inside and outside the loop; R=ahaas@chromium.org,clemensh@chromium.org,gdeepti@chromium.org Change-Id: I1670aa4d8274f6c54dced98cced7b51534552c36 Reviewed-on: https://chromium-review.googlesource.com/619207Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Enrico Bacis <enricobacis@google.com> Cr-Commit-Position: refs/heads/master@{#47466}
-
Camillo Bruni authored
Change-Id: Icd5dcb9fe58fec7d405e03ca09648d2e426bd204 Reviewed-on: https://chromium-review.googlesource.com/452458 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The effect of array/string trimming on space size is postponed until sweeping completes. This simplifies runtime code and fixes live byte update race with the concurrent marker. This patch restores monotonicity of PromotedSinceLastGC by notify the heap when sweeper discovers more free space than estimated. Bug: chromium:694255 Change-Id: I7a8c24f2c3398bc0c8a43ffd1d35ace68010cd65 Reviewed-on: https://chromium-review.googlesource.com/621326 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Marja Hölttä authored
As specified in Annex B.3.6., initializers are allowed in sloppy mode var declarations in for-in loops. As a consequence, "in" is one of the tokens that can follow an AssignmentExpression - this was not recognized before. BUG=v8:6715 Change-Id: Idbf79bda39beef4e568d630e0b5e239a34397952 Reviewed-on: https://chromium-review.googlesource.com/620728Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:6731 Change-Id: I6b07ac90a7d86d0ff915b1e89238df5af6b07926 Reviewed-on: https://chromium-review.googlesource.com/620648Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:757175 Change-Id: I6c566475a730084e8ab35e6f8505a12c466644ff Reviewed-on: https://chromium-review.googlesource.com/622430Reviewed-by:
-
Marja Hölttä authored
This reverts commit aee29a9f. Reason for revert: Bot is alive again, doing this test run now. Original change's description: > Revert "[parser] FLAG_aggressive_lazy_functions = true for a test run." > > This reverts commit 0d51a259. > > Reason for revert: Bot is broken; makes no sense to run the experiment now. > > Original change's description: > > [parser] FLAG_aggressive_lazy_functions = true for a test run. > > > > Just to get the RuntimeCallstats data. To be reverted soon. > > > > BUG=v8:5516 > > NOTREECHECKS=true > > > > Change-Id: I4bb436900a79bb383bf8132002a129b601efdfe3 > > Reviewed-on: https://chromium-review.googlesource.com/618987 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Commit-Queue: Marja Hölttä <marja@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#47416} > > TBR=adamk@chromium.org,machenbach@chromium.org,marja@chromium.org > > Change-Id: I8506ae7e1e16a4d0b320a486f743c01f7f82e0f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:5516 > Reviewed-on: https://chromium-review.googlesource.com/620749 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47425} TBR=adamk@chromium.org,machenbach@chromium.org,marja@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:5516 Change-Id: I09d8da398da33076db1656f3241e3de8e05757b7 Reviewed-on: https://chromium-review.googlesource.com/623047Reviewed-by:
-
