Commits · e21d3d7e21b2ff37dc60c54902e8362953000a63 · Linshizhi / V8

07 Nov, 2014 5 commits

Revert r24922 "Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s." · e21d3d7e

ulan@chromium.org authored Nov 07, 2014

SystemTimeToTzSpecificLocalTime doesn't work correctly inside Chrome sandbox.

BUG=chromium:417640
LOG=Y
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/710643002

Cr-Commit-Position: refs/heads/master@{#25211}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e21d3d7e

[turbofan][arm64] Optimize shifts combined with truncations or extensions. · 57ae5420

baptiste.afsa@arm.com authored Nov 07, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/705983002

Cr-Commit-Position: refs/heads/master@{#25210}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

57ae5420

[arm64] Bug fix in sapefoint recording. · dc686a53

baptiste.afsa@arm.com authored Nov 07, 2014

cp is handled by the register allocator and doesn't necessarily hold the
context pointer on arm64.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/695323005

Cr-Commit-Position: refs/heads/master@{#25209}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dc686a53

Perform context disposal garbage collections only if contexts disposals happen at a high rate. · c0ac2ab9

hpayer@chromium.org authored Nov 07, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/710603003

Cr-Commit-Position: refs/heads/master@{#25208}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25208 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c0ac2ab9

Try avoiding MISS for callic monomorphic case. · 98d4a8bd

mvstanton@chromium.org authored Nov 07, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/704143003

Cr-Commit-Position: refs/heads/master@{#25207}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25207 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

98d4a8bd

06 Nov, 2014 28 commits

Enable inlining tests that pass with new scheduler. · 47ee0b02

mstarzinger@chromium.org authored Nov 06, 2014

R=titzer@chromium.org
TEST=test-run-inlining/InlineTwiceDependentDiamond

Review URL: https://codereview.chromium.org/704293002

Cr-Commit-Position: refs/heads/master@{#25205}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25205 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

47ee0b02

Enable ES6 numeric literals by default · 32f3277e

arv@chromium.org authored Nov 06, 2014

BUG=v8:2783
LOG=Y
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/703943002

Cr-Commit-Position: refs/heads/master@{#25204}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

32f3277e

Disable ranging for modulus in hopes it will fix arm. · 9eba79df

titzer@chromium.org authored Nov 06, 2014

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/705113002

Cr-Commit-Position: refs/heads/master@{#25203}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9eba79df

MIPS: Turn ToNumberStub into a PlatformCodeStub again. · 700d7a2d

balazs.kilvady@imgtec.com authored Nov 06, 2014

Port 724a15e8bf3fb8697a950c8e0f96158c8e56ec71
Port r25187

The HydrogenCodeStub is too expensive and there's no easy way to reduce
this cost, so turning it into a PlatformCodeStub solves that problem
until we can use TurboFan for code stubs.

TEST=mjsunit
BUG=
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/707863002

Cr-Commit-Position: refs/heads/master@{#25202}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25202 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

700d7a2d

[turbofan] move label generation to code generator · 720dc926

dcarney@chromium.org authored Nov 06, 2014

R=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/707803002

Cr-Commit-Position: refs/heads/master@{#25201}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25201 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

720dc926

[turbofan] Allocate a small amount of slack space to graph builder environments. · e0cbbd2d

titzer@chromium.org authored Nov 06, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/709463003

Cr-Commit-Position: refs/heads/master@{#25200}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e0cbbd2d

[turbofan] Lower asm.js truncations to JSToNumber. · 6f18c1aa

bmeurer@chromium.org authored Nov 06, 2014

- JSBitwiseOr(x, 0) => Word32Or(NumberToInt32(JSToNumber(x)), 0)
- JSMultiply(x, 1) => NumberMultiply(JSToNumber(x), 1)

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/706863003

Cr-Commit-Position: refs/heads/master@{#25198}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6f18c1aa

Fix O(n^2) successor traversal in ControlReducer. · fb0a5a61

titzer@chromium.org authored Nov 06, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/703163002

Cr-Commit-Position: refs/heads/master@{#25197}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fb0a5a61

[turbofan] Combine JSToNumber and ChangeTaggedToFloat64 for fast SMI case. · 88efe28d

bmeurer@chromium.org authored Nov 06, 2014

This does the following optimization during ChangeLowering:

 ChangeTaggedToFloat64(JSToNumber(x)) =>
   if IsSmi(x) then ChangeSmiToFloat64(x)
   else let y = JSToNumber(x) in
     if IsSmi(y) then ChangeSmiToFloat64(y)
     else LoadHeapNumberValue(y)

Also cleanup/rearrange some code duplication in ChangeLowering.

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/703103003

Cr-Commit-Position: refs/heads/master@{#25195}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

88efe28d

Revert "Remove workaround for successors on end block from scheduler." · 9734f236

mstarzinger@chromium.org authored Nov 06, 2014

TBR=titzer@chromium.org

Review URL: https://codereview.chromium.org/705043002

Cr-Commit-Position: refs/heads/master@{#25194}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9734f236

[turbofan] (reland) Compute tighter ranges for modulus in Typer. · b309f3d2

titzer@chromium.org authored Nov 06, 2014

R=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/694703004

Cr-Commit-Position: refs/heads/master@{#25193}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b309f3d2

Fix marking time in cumulative gc stats. · 652e1355

hpayer@chromium.org authored Nov 06, 2014

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/708483004

Cr-Commit-Position: refs/heads/master@{#25192}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

652e1355

[turbofan] phis cannot take registers as inputs · a350f0d6

dcarney@chromium.org authored Nov 06, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/704153002

Cr-Commit-Position: refs/heads/master@{#25191}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25191 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a350f0d6

Allow JSArray fast moving elements even if the array's proto isn't... · f26d93e6

verwaest@chromium.org authored Nov 06, 2014

Allow JSArray fast moving elements even if the array's proto isn't Array.prototype in original state
Otherwise array builtins don't work on internal arrays.

BUG=v8:3681
LOG=n
R=machenbach@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/706703005

Cr-Commit-Position: refs/heads/master@{#25190}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f26d93e6

[turbofan] Push TruncateFloat64ToInt32 into phis. · 35cc4af7

bmeurer@chromium.org authored Nov 06, 2014

TEST=unittests
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/707683003

Cr-Commit-Position: refs/heads/master@{#25189}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25189 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

35cc4af7

Remove workaround for successors on end block from scheduler. · f9575cef

mstarzinger@chromium.org authored Nov 06, 2014

R=titzer@chromium.org
TEST=cctest/test-scheduler/RPOLoop

Review URL: https://codereview.chromium.org/708763002

Cr-Commit-Position: refs/heads/master@{#25188}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f9575cef

Turn ToNumberStub into a PlatformCodeStub again. · 9b72f14c

bmeurer@chromium.org authored Nov 06, 2014

The HydrogenCodeStub is too expensive and there's no easy way to reduce
this cost, so turning it into a PlatformCodeStub solves that problem
until we can use TurboFan for code stubs.

TEST=mjsunit
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/683913008

Cr-Commit-Position: refs/heads/master@{#25187}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9b72f14c

Skip json2 on 64 bits debug. · d04038bd

machenbach@chromium.org authored Nov 06, 2014

BUG=3681
LOG=n
TBR=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/701353003

Cr-Commit-Position: refs/heads/master@{#25186}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d04038bd

Fix for an assertion failure in Map::FindTransitionToField(...). Appeared after r25136. · e1f93a82

ishell@chromium.org authored Nov 06, 2014

BUG=chromium:430846
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/704183002

Cr-Commit-Position: refs/heads/master@{#25185}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e1f93a82

Reuse RPO traversal stack in the scheduler. · 0b985c49

mstarzinger@chromium.org authored Nov 06, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/695303003

Cr-Commit-Position: refs/heads/master@{#25184}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0b985c49

Skip tests that timeout on arm64 · 89617f06

ishell@chromium.org authored Nov 06, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/709443002

Cr-Commit-Position: refs/heads/master@{#25183}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

89617f06

The idea behind of this solution is to use the existing "relocation info"... · d56a21eb

svenpanne@chromium.org authored Nov 06, 2014

The idea behind of this solution is to use the existing "relocation info" instead of consumption the CodeLinePosition events emitted by the V8 compilers.
During generation code and relocation info are generated simultaneously.
When code generation is done you each code object has associated "relocation info".
Relocation information lets V8 to mark interesting places in the generated code: the pointers that might need to be relocated (after garbage collection),
correspondences between the machine program counter and source locations for stack walking.

This patch:
1. Add more source positions info in reloc info to make it suitable for source level mapping.
The amount of data should not be increased dramatically because (1) V8 already marks interesting places in the generated code and
(2) V8 does not write redundant information (it writes a pair (pc_offset, pos) only if pos is changed and skips other).
I measured it on Octane benchmark - for unoptimized code the number of source positions may achieve 2x ('lin_solve' from NavierStokes benchmark).

2. When a sample happens, CPU profiler finds a code object by pc, then use its reloc info to match the sample to a source line.
If a source line is found that hit counter is increased by one for this line.

3. Add a new public V8 API to get the hit source lines by CDT CPU profiler.
Note that it's expected a minor patch in Blink to pack the source level info in JSON to be shown.

4.Add a test that checks how the samples are distributed through source lines.
It tests two cases: (1) relocation info created during code generation and (2) relocation info associated with precompiled function's version.

Patch from Denis Pravdin <denis.pravdin@intel.com>;

R=svenpanne@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/682143003

Patch from Weiliang <weiliang.lin@intel.com>.

Cr-Commit-Position: refs/heads/master@{#25182}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d56a21eb

Avoid redundant work in scheduler loop header/depth calculation. · 361d7b0f

mstarzinger@chromium.org authored Nov 06, 2014

R=jarin@chromium.org

TEST=cctest/test-scheduler/LoopedFloatingDiamond2

Review URL: https://codereview.chromium.org/702683002

Cr-Commit-Position: refs/heads/master@{#25181}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

361d7b0f

[turbofan] Turn various diamonds into selects. · 8798c410

bmeurer@chromium.org authored Nov 06, 2014

TEST=cctest/test-changes-lowering,mjsunit/asm,unittests
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/704463004

Cr-Commit-Position: refs/heads/master@{#25180}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8798c410

Retry: Parser & internalization fix: ensure no heap allocs during GetString(Handle<String>). · abb5fd1e

marja@chromium.org authored Nov 06, 2014

The bug has always been there: when the parser is operating in the "immediately
internalize" mode and calls GetString, we get FlatContent of a string and then
do heap allocation.

The bug was uncovered by https://codereview.chromium.org/693803004/ (which put
the parser to the "immediately internalize" mode more often), but looking at the
code, it's possible that it can happen in other cases too.

This CL makes AstValueFactory handle this situation gracefully: it won't try to
internalize inside GetString(Handle<String>); it's unnecessary anyway since we
have the Handle<String> already.

BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/706533005

Cr-Commit-Position: refs/heads/master@{#25179}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

abb5fd1e

[turbofan] extend register allocator testing with control flow · 57b42dc5

dcarney@chromium.org authored Nov 06, 2014

R=bmeurer@chromium.org, jarin@chromium.org

BUG=

Review URL: https://codereview.chromium.org/699083003

Cr-Commit-Position: refs/heads/master@{#25178}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

57b42dc5

MIPS: Skip embenchen tests on big-endian. · a7277a9b

bmeurer@chromium.org authored Nov 06, 2014

Emscripten requires little-endian arch. It has assertion for endianness:

assert(HEAPU8[0] === 255 && HEAPU8[3] === 0,
    'Typed arrays 2 must be run on a little-endian system');

TEST=mjsunit/asm/embenchen/*
BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/708663003

Patch from Paul Lind <paul.lind@imgtec.com>.

Cr-Commit-Position: refs/heads/master@{#25177}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25177 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a7277a9b

[turbofan] Transform x * -1.0 to -0.0 - x. · 881cece8

bmeurer@chromium.org authored Nov 06, 2014

TEST=msjunit/asm,unittests
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/683753004

Cr-Commit-Position: refs/heads/master@{#25176}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

881cece8

05 Nov, 2014 7 commits

MIPS: Fix uint32div bug after r25103. · f3b633cc

paul.lind@imgtec.com authored Nov 05, 2014

The div and mod instructions on MIPS are not safe for rhs 0.

TEST=test/mjsunit/asm/uint32div.js
BUG=
R=akos.palfi@imgtec.com

Review URL: https://codereview.chromium.org/704013002

Cr-Commit-Position: refs/heads/master@{#25174}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f3b633cc

Whitespace change to trigger bots (5) · b19ecf97

machenbach@chromium.org authored Nov 05, 2014

Cr-Commit-Position: refs/heads/master@{#25173}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b19ecf97

Whitespace change to trigger bots (4) · 2593eb3d

machenbach@chromium.org authored Nov 05, 2014

Cr-Commit-Position: refs/heads/master@{#25172}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2593eb3d

Whitespace change to trigger bots (3) · 394a5d3c

machenbach@chromium.org authored Nov 05, 2014

Cr-Commit-Position: refs/heads/master@{#25171}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

394a5d3c

Whitespace change to trigger bots (2) · 6e48921a

machenbach@chromium.org authored Nov 05, 2014

Cr-Commit-Position: refs/heads/master@{#25170}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6e48921a

Whitespace change to trigger bots (1) · e55a95d1

machenbach@chromium.org authored Nov 05, 2014

Cr-Commit-Position: refs/heads/master@{#25169}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25169 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e55a95d1

MIPS: Fix instruction selection test expectations after r25120. · 032ae8e8

dusan.milosavljevic@imgtec.com authored Nov 05, 2014

TEST=unittests/InstructionSelectorCmpTest.Parameter,
     InstructionSelectorTest.Word32EqualWithZero
BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/706633003

Cr-Commit-Position: refs/heads/master@{#25167}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

032ae8e8