- 07 Jun, 2018 21 commits
-
-
Simon Zünd authored
This CL extracts code for loading a NumberDictionary element from "EmitElementLoad" to its own function in the CSA. This is done in preparation for a fast path in Torque for dictionary elements. R=jgruber@chromium.org Change-Id: I3bb9897910183cd50be127bae771e531a61d57be Reviewed-on: https://chromium-review.googlesource.com/1090832Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#53586}
-
Junliang Yan authored
R=szuend@google.com, cbruni@chromium.org, jgruber@chromium.org Bug: v8:7382,v8:7806,chromium:849293 Change-Id: I95874713038d14fa6ae294a23679dfaff70c65ba Reviewed-on: https://chromium-review.googlesource.com/1089141Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53585}
-
Dominik Inführ authored
JSWeakCollection does not have any weak references anymore. Special handling of Ephemerons can now be implemented in VisitEphemeronHashTable. Bug: chromium:844008 Change-Id: I9f4d8ad6a32cc7a55b715803f6a83ff8d2743ce8 Reviewed-on: https://chromium-review.googlesource.com/1090274 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53584}
-
Simon Zünd authored
This is a reland of 91bab558 This CL contains two major changes w.r.t to the original CL: The random state is removed from the Smi root list and we pre-seed the RNG on each sort with the length of the array. To cut down on the length of the arguments list and to keep track of the random state across recursive calls, we move most of the sort arguments into a FixedArray and reload from the array for each recursion. Original change's description: > [array] Use random middle element to determine pivot during sorting > > This CL adds a "random state" to the Smi Root list and implements a > basic Linear congruential pseudo random number generator in Torque. > > The RNG is used to determine the pivot element for sorting. This will > prevent the worst cases for certain data layouts. > > Drive-by-fix: Make sorting of ranges and execution pauses for profviz > deterministic by adding a secondary sorting criteria. > > Bug: v8:7382 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ieb871e98e74bdb803f821b0cd35d2f67ee0f2868 > Reviewed-on: https://chromium-review.googlesource.com/1082193 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Simon Zünd <szuend@google.com> > Cr-Commit-Position: refs/heads/master@{#53524} Bug: v8:7382 Change-Id: Ia7bef7ed1c0e904ffe43bc428e702f64f9c6a60b Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1087888Reviewed-by:
-
Clemens Hammacher authored
Struct fields should not end in an underscore according to the style guide. Drive-by: Add {TurboAssembler} constructor which receives an {IsolateData} directly, to allow creating a {TurboAssembler} in a background thread. R=mstarzinger@chromium.org Change-Id: I32800476690f4c8619059519b7d27b06f5d4be95 Reviewed-on: https://chromium-review.googlesource.com/1090278 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53582}
-
Tobias Tebbi authored
Bug: v8:7824 Change-Id: Ifdf0fbe13b3c8229bc6d44cb6d68298b016fa071 Reviewed-on: https://chromium-review.googlesource.com/1090724Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53581}
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I377d6f9d26a193f7fd829f7b74f9fdabc1337dc0 Reviewed-on: https://chromium-review.googlesource.com/1089053 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Creddy authored
Bug: v8:7796 Change-Id: If5e40fa943798cdc0d7dbdc640750c7b7ad4439b Reviewed-on: https://chromium-review.googlesource.com/1087957 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This makes all runtime calls compiled by Liftoff load the respective CEntry builtin from the instance object instead of embedding it into the instruction stream. Another step towards making the code independent of the originating Isolate. As a drive-by this also changes one implicit runtime call in the stack check in the TurboFan backend in a similar fashion. R=clemensh@chromium.org BUG=v8:7424 Change-Id: Ifab5995aa95250d6fae60ef5debb98aee2b6fc0c Reviewed-on: https://chromium-review.googlesource.com/1089067 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53578}
-
Dominik Inführ authored
This will allow the GC to differentiate between regular HashTables and EphemeronHashTables. Bug: chromium:844008 Change-Id: I2f9009ac25eb117de03786b110dd362b829c5e9e Reviewed-on: https://chromium-review.googlesource.com/1089066Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
With lazy compilation, not every exported function has code assiciated with it. {WasmExportedFunction} provides the function index though, which can be used to check whether code exists and access that code. R=mstarzinger@chromium.org Bug: v8:7758 Change-Id: Id80285fec46bf5be4af49875734aa0fe28d732c9 Reviewed-on: https://chromium-review.googlesource.com/1090273Reviewed-by: -
Michael Starzinger authored
This makes the WebAssembly runtime stubs load the correct CEntry stub from the instance object instead of embedding the address within the instruction stream. It effectively makes those stubs independent of the underlying Isolate. R=clemensh@chromium.org BUG=v8:7424 Change-Id: I0e7f3ecf7642d3fb1ee7adf83a8f0e6cc4d38fdf Reviewed-on: https://chromium-review.googlesource.com/1086997 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reads much nicer than the for loop with {num_imported_functions_} and {num_functions}, and is potentially even faster, because we access the code table directly and not via function index. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I83e5c0253d8f78c22982a79d878431ba75cfc027 Reviewed-on: https://chromium-review.googlesource.com/1090271Reviewed-by: -
Leszek Swirski authored
This reverts commit ceb9c812. Reason for revert: Tanks compile time Original change's description: > [sfi] Remove SFI function literal id field > > SharedFunctionInfos store their original function literal's id. This is > also their index in the Script's SFI list. > > Since the function literal id is only needed for lazy compilation and live > edit, we can calculate it on-the-fly by linear search in the Script SFI list, > and save a field on the SFI. > > If this regresses compile performance, we could alternatively store the > function literal id on the preparsed scope data as future work. > > Bug: chromium:818642 > Change-Id: I5468cea0e115921f1c864d94e567d749a4349882 > Reviewed-on: https://chromium-review.googlesource.com/1082480 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53523} TBR=hpayer@chromium.org,leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:818642 Bug: chromium:850417 Change-Id: If2fd21331b7062532c04004a51e705f7e9d0a151 Reviewed-on: https://chromium-review.googlesource.com/1090494Reviewed-by:
-
Dominik Inführ authored
JSWeakCollection should use EphemeronHashTable as backing store instead of ObjectHashTable such that the GC can handle these structures differently in the future. Bug: chromium:844008 Change-Id: Icc6df60c975a942877e2507ef45e0d235e5f72be Reviewed-on: https://chromium-review.googlesource.com/1089063 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
-
Jaroslav Sevcik authored
As a first step towards moving accesses to the broker, this moves heap accesses from BitsetType::Lub to the broker. Bug: v8:7790 Change-Id: Ie240b84b979717caae42cb8aa06ee8d9877a446d Reviewed-on: https://chromium-review.googlesource.com/1088695 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53571}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a429f60..2e17643 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/893eb86..6f4dae2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/517100c..93a962f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf4aced..e89dcf7 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/afac8ec..adae55a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c893c7e..7e986fd Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/ff0709d..4cc6820 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/3543e21..281c390 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iaffee27a98872b52bc238038c352e8c7c03728a9 Reviewed-on: https://chromium-review.googlesource.com/1090329 Commit-Queue: <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#53570}
-
Dan Elphick authored
Use a passed in Isolate/Heap directly rather than using GetIsolate() on HeapObjects which may not in future be tied to an isolate. Bug: v8:7786 Change-Id: I89d8706544aa135049434cf20c4e1308474c678b Reviewed-on: https://chromium-review.googlesource.com/1089334Reviewed-by:
-
Jaroslav Sevcik authored
Remove unused methods, duplicate logic. Bug: v8:7790 Change-Id: Ic8e47158084df5239e3f4b4bf1df7d266c7d2585 Reviewed-on: https://chromium-review.googlesource.com/1090490Reviewed-by:
-
Hannes Payer authored
Change-Id: Ieec4dccdf8a5241f439bde9fffc75f4f300930e1 Reviewed-on: https://chromium-review.googlesource.com/1089333Reviewed-by:
-
Eric Holk authored
This CL adds the simplest version of a trap handler fallback. At instantiation time, we check whether the module was compiled to use trap handlers and the memory is guarded. If the memory is not guarded but the module is supposed to use trap handlers, we recompile the module with bounds checks so that we can use an unguarded memory. The compiled module is replaced with a bounds checking version, meaning future instances from this module will also use bounds checks. Some likely desirable features that are current missing but can be added future CLs include: * Disabling trap handler mode entirely. * Recompiling all old instances so that trap handler and bounds checked code does not coexist in the same process. Bug: v8:7143 Change-Id: I161fc0d544133b07dc4a93cc6af813369aaf3efe Reviewed-on: https://chromium-review.googlesource.com/1018182 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53566}
-
- 06 Jun, 2018 19 commits
-
-
Dan Elphick authored
Removes most explicit calls to GetIsolate/GetHeap from heap/ and implicit calls via the single argument Handle constructor and handle function by passing it in through calling functions. (One GetHeap remains in FreeList in heap/spaces.cc for now). Bug: v8:7786 Change-Id: I14fd099d26f94b9afbcfad41aa873c8f843297dd Reviewed-on: https://chromium-review.googlesource.com/1087002Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53565}
-
Dan Elphick authored
Explicitly pass Isolate* to the Handle constructor even if it means calling GetIsolate. (Shortly, I want to remove that constructor completely since its an invisible source of implicit GetIsolates). Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3454e8c92e12bf5c5eb1d4e2018dff7c42949d26 Reviewed-on: https://chromium-review.googlesource.com/1089058 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I16961e0943f19e8120a340d8bcd8eeb51f78b79e Reviewed-on: https://chromium-review.googlesource.com/1089010 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53563}
-
Daniel Clifford authored
This allows redifinitions of generics with the same name but differing parameter type lists, e.g. macro coerce<Dest: type>(from: HeapObject): Dest; coerce<int32>(from: HeapObject): int32 {...} macro coerce<Dest: type>(from: Smi): Dest; coerce<int32>(from: Smi): int32 {...} In order to allow multiple overloads of generic macros with the same name, a more nuanced lookup of calls has been implemented using the ParameterDifference utility class. There is still work to be done to unify when ParameterDifference is used for lookup (e.g. removing it from operator lookup when operators become simple aliases for macro names), but that work will be done in a separate CL. As part of this CL, the custom handling of "cast<>" operator in the .g4 grammar has been removed and replaced by a handful of equivalent overloads of a generic "cast" macro. Bug: v8:7793 Change-Id: Ibb2cdd3d58632b7f7f7ba683499f9688ae07f4f8 Reviewed-on: https://chromium-review.googlesource.com/1087873 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: -
Dominik Inführ authored
Change-Id: I15b43383d7f9d44f98be866bf77274635242e4ff Reviewed-on: https://chromium-review.googlesource.com/1088709 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
-
Clemens Hammacher authored
This lead to link errors in an unrelated CL. The function was declared with "const PrintableInstructionBlock&", but defined with "PrintableInstructionBlock&". R=mstarzinger@chromium.org Change-Id: I08a9837dc44dc9d8f508c914da92549179a6790e Reviewed-on: https://chromium-review.googlesource.com/1088910Reviewed-by:
-
Clemens Hammacher authored
On Android, %DebugPrint should output to the Android log instead of stdout. R=mstarzinger@chromium.org Bug: v8:7820 Change-Id: Ia2ab14f1e4ae15914a1e0e721457f83b288683ff Reviewed-on: https://chromium-review.googlesource.com/1088691 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This will prevent failures like this one: https://ci.chromium.org/p/v8/builds/b8945509831610302560 R=machenbach@chromium.org No-Try: true Bug: chromium:831171 Change-Id: I3f5c5ce6ea2148c22e4ef0b18495e10e37fd3fed Reviewed-on: https://chromium-review.googlesource.com/1074367Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53558}
-
Michael Starzinger authored
This avoids embedding {RelocInfo::CODE_TARGET} addresses into WasmCode by calling a WebAssembly runtime stub instead. The stubs themselves are not yet independent of the Isolate, but will be made so soon. Note that this also introduces a proper {compiler::TrapId} to avoid accidental parameter type confusion with {TrapIf} and {TrapUnless} operators. R=clemensh@chromium.org BUG=v8:7424 Change-Id: I32ef5a1253f336fc739d2192247826e9458456df Reviewed-on: https://chromium-review.googlesource.com/1086937Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Andreas Haas authored
The typical use of assertThrowsEquals is to check that a specific object is thrown. However, assertEquals only does a proper equality check for primitive types, not for complex types. Using assertSame does a reference equality check on objects, which is more what you would expect from assertThrowsEquals. For exception kind testing, assertThrowsEquals actually did not work correctly, assertThrows is better for that case. R=clemensh@chromium.org, mythria@chromium.org Change-Id: I24fb22e75fa33ebe90eb4bae40825119a054bba5 Reviewed-on: https://chromium-review.googlesource.com/1087952Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53556}
-
Bill Budge authored
This reverts commit 3c4d0316. Reason for revert: Breaks MSAN on ARM64 https://ci.chromium.org/buildbot/client.v8/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21425 'enabled' field not initialized in constructor? Original change's description: > [async] Expose async hooks to d8 > > This implementation follows the Node.js API as a guideline. > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > Reviewed-on: https://chromium-review.googlesource.com/1065818 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53551} TBR=ofrobots@google.com,gsathya@chromium.org,bmeurer@chromium.org,mslekova@chromium.org Change-Id: I8b2bedb51cba18c77578d4e223474015d819e428 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1088811Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53555}
-
Stephan Herhut authored
Using DCHECK seems to be the common V8 style. Change-Id: I6dab91e5225a222cbfe07ebeeec4ed1b274fe5bd Reviewed-on: https://chromium-review.googlesource.com/1088698Reviewed-by:
-
Théotime Grohens authored
This CL fully implements the DataView getters for the Uint8, Int8, Uint16, Int16, Uint32 and Int32 types in Torque, and removes the runtime implementation that is not needed anymore. There should be a light but visible performance increase compared to the former runtime implementation. Change-Id: I7d85097fd5953b9629f3ac6bed93b068889712b2 Reviewed-on: https://chromium-review.googlesource.com/1078349 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
-
Ivica Bogosavljevic authored
Add code to measure timer resolution on POSIX systems Change-Id: I980f7e416725effe1872f2c5e75805d753e3b0ae Reviewed-on: https://chromium-review.googlesource.com/1086994 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#53552}
-
Maya Lekova authored
This implementation follows the Node.js API as a guideline. Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 Reviewed-on: https://chromium-review.googlesource.com/1065818 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53551}
-
Sreten Kovacevic authored
Also, fix latency for NEG_S and NEG_D on mips. Change-Id: I74626a787c67f79d430e55e715446d21b39ef937 Reviewed-on: https://chromium-review.googlesource.com/1088611Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53550}
-
Michael Starzinger authored
This makes sure {WasmCode} object are printed right after they have been added to a {NativeModule} instead of waiting until the module is done. This way debug output can be inspected as early as possible and works even when there are issues later before the module is finished. R=herhut@chromium.org BUG=chromium:849713 Change-Id: Icced39cfaad7c033de569fbec21c26506f5796a6 Reviewed-on: https://chromium-review.googlesource.com/1088614Reviewed-by:Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53549}
-
Ivica Bogosavljevic authored
Test ThreadTicks.ThreadNow fails on systems with low resolution thread timers because the tests detects that no time elapsed since the beginning of the test. This CL adds a counting loop that makes sure the thread timer has progressed by at least one tick. TEST=unittests/ThreadTicks.ThreadNow Change-Id: I910309208b3a154798cbc43813d41d3755ab819d Reviewed-on: https://chromium-review.googlesource.com/1082352 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
-
Camillo Bruni authored
Drive-by-fix: - improve log parsing by not wrapping single lines in arrays Change-Id: Ic4c5fdeb7875c8c5db57843f583e93285026ff74 BUG: chromium:757467, chromium:850038 Reviewed-on: https://chromium-review.googlesource.com/1078753 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
