- 16 Aug, 2021 13 commits
-
-
Clemens Backes authored
We currently only use the predictable platform if --verify-predictable is passed, which is confusing and not following the comment on the --predictable flag ("enable predictable mode"). This CL fixes that and makes --verify-predictable imply --predictable to also allow to only pass --verify-predictable. R=ahaas@chromium.org CC=mlippautz@chromium.org Bug: v8:11879 Change-Id: Ifb9683ddc4fab374ce519169533c90244175bb48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094010Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#76305}
-
Manos Koukoutos authored
We need to drop the object and the rtt from the liftoff stack before loading the result. Bug: v8:7748 Change-Id: Idbd4878ededc35892c951cafb3f8a8298133adff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094015Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#76304}
-
Jakob Kummerow authored
The static limit didn't account for possible S128 elements. This patch makes the limit element type specific. Fixed: chromium:1237024 Change-Id: Ic1e37656e2882c0eb7ea6400c83e4094eb747e88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097269Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#76303}
-
Santiago Aboy Solanes authored
This reverts commit a4a152ec. Reason for revert: We haven't seen the flakes in a while, we can re-enable functionality Original change's description: > Reland "[debugger] Try to trigger pause-on-oom flakes with an extra printf" > > This is a reland of 8f7e9158 > > Original change's description: > > [debugger] Try to trigger pause-on-oom flakes with an extra printf > > > > We have an issue that we can't repro locally. Enable back the > > pause-on-oom tests with an extra printf with DEBUG. We will be able to > > better assess the failures when they appear on the bot. > > > > Bug: v8:10876 > > Change-Id: I066539c4b5865ecb6f2e589e9543e8c9ebd4830b > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474782 > > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#70558} > > Bug: v8:10876 > Change-Id: Ice31c9455830da320ab057293c341f69e1f0c510 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2484799 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70643} Bug: v8:10876 Change-Id: I901d31e1e92bfef0b2917ea611354618e5cda585 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071404Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#76302}
-
Omer Katz authored
The snapshot merges nodes with their back ref if one exists. The implementation assumed that the back ref state already has its node set. However it's possible for the node to be set later. If the node is not set yet, we stash the back ref and update it after setting the node. Bug: chromium:1239144 Change-Id: If6e18cdc0e25ff13bd09218791e3f1052ea0dda8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094009 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76301}
-
Timo Teräs authored
Bug: v8:12092 Change-Id: Ibca6082c28cfd5b23680d554b692bc8ab60cb416 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094013Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76300}
-
Omer Katz authored
The assumption doesn't necessarily hold on linux and Android either. Bug: chromium:1056170, chromium:1239287 Change-Id: Ibb0d8f5f814580bff4e8a7dce9a3397df1385896 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097273Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76299}
-
Georg Neis authored
- Remove flag --block-concurrent-recompilation and its implementation, including %UnblockConcurrentCompilation. - Rewrite tests that used it in terms of the primitives introduced in my previous CL: https://chromium-review.googlesource.com/c/v8/v8/+/3071400/ - Remove "sync"/"no sync" arguments from %GetOptimizationStatus, assertOptimized, etc. These are now always "no sync": they don't do any magic. - Remove "if %IsConcurrentRecompilationSupported then quit" from some tests in favor of --concurrent-recompilation in their Flags line. Bug: v8:12041, v8:7790 Change-Id: I966aae4fec85e6f9e7aeed2ba2c12e9198a3991f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3077149Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76298}
-
Camillo Bruni authored
This reverts commit 91c8be95. RCS should not be exposed through the API or the inspector protocol as they are meant as an internal debugging feature. The only regularly tested and supported way is through chrome-tracing. Given that this was used mostly for an experiment to analyse chrome's performance, we can use pprof support as a replacement. Original change's description: > [DevTools] Implemented DevTools protocol API to retrieve V8 RunTime Call Stats. > > The new APIs are: > enableRuntimeCallStats > disableRuntimeCallStats > getRuntimeCallStats > > The RunTime Call Stats are collected per isolate. > > Change-Id: I7e520e2c866288aa9f9dc74f12572abedf0d3ac8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1881601 > Commit-Queue: Peter Kvitek <kvitekp@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64784} Change-Id: Ia7575436e97d3420dd7e68414d89477e6a86bb05 Bug: v8:11395 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998585Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#76297}
-
Lu Yahan authored
There is still a place to simplify. Bug: v8:11420, v8:11421 Change-Id: I774139c52d911323f162350532a493e70f518643 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
finalizer-trait.h:79:49: error: the address of ‘static void cppgc::internal::FinalizerTrait<T>::Finalize(void*) [with T = Rope]’ will never be NULL [-Werror=address] static constexpr bool HasFinalizer() { return kCallback; } Fixes: Change-Id: I368138e37189440d786f130a1bce3577b7c0220f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097267 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76295}
-
Lu Yahan authored
The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj. Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#76294}
-
Nico Weber authored
Bug: chromium:1066980 Change-Id: I03a6b5253043bfb9825a1a64a1d9b060958e5a98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094866 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
- 15 Aug, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/edc2713..a0d5191 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If566c6ace9aec4ec9b2ba5bbf7acba3323471a28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3095709Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#76292}
-
- 14 Aug, 2021 2 commits
-
-
Michael Lippautz authored
In Blink's version of Oilpan, GCInfo objects would reside in .bss and a table would translate between an index and the .bss address. Upon retrieving a GCInfoIndex, the slow path merely passes a .bss pointer to a slow path setup method to create the table mapping. In cppgc, we set up GCInfo entries directly in the table. This is slightly faster for actually using GCInfo objects as there's no indirection between table and .bss, and it also saves one pointer (the indirection) per type that is set up. The downside of this approach is that individual components of a GCInfo objects, that are all type-dependent, need to be passed to the conditional setup method. Since GCInfo indices must be retrieved on each allocation, this pollutes the fast path with additional instructions. However, GCInfo components are actually known at compile-time for many objects. In such cases, we can use a compile-time static dispatch to encode the known parameters in different functions. This saves around 40KiB of memory on ChromePublic.apk and also creates a more compact fast path for allocation. Bug: chromium:1238884, chromium:1056170 Change-Id: Iedd809a8baefcc02f131d2b2c77d341b0abe43bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094007Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5c5313f..edc2713 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/37dc929..6810b87 Rolling v8/third_party/aemu-linux-x64: 21LVieOtkkse_Rl-9YyxWMe3RIxZ3Gpb_MUUrgwitckC..kjigTwWNxlU1rn_26vpSH5hoVlSnC4w1rFJHyivz5PQC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bd47f22..126f6a8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/699d70d..0c42eff Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/47f819c..0134d73 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7c13cee3230eab4f038103b6fb6724b17adaa043 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093203Reviewed-by:
-
- 13 Aug, 2021 15 commits
-
-
Shu-yu Guo authored
To free up some ArchOpcode bits (especially for arm64), encode all atomic opcodes that are duplicated between 32bit and 64bit widths with a single opcode and encode the width in another field. Bug: v8:12093 Change-Id: Ide05e8f0b2aa877ea776851e47df60dd410deae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093257Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#76289}
-
Rakhim Khismet authored
We add multiple tables to the fuzzed module. We only can use externref or function references for tables. Bug: v8:11954 Change-Id: Ibb7b34203169a3ca97514b87273fa4ea0f6ca99a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093145 Commit-Queue: Rakhim Khismet <khismet@google.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#76288}
-
Ng Zhi An authored
Use movsd/vmovsd instead of pblendw/vpblendw. It is two bytes shorter, and avoids mixing integer and floating-point domain instructions. Bug: v8:12074 Change-Id: Ia41072fbf8da7d99618a55d59634f7399a7105ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088358Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#76287}
-
Ng Zhi An authored
We no longer require dst == src (output = input[0]) in all cases, only when AVX is not supported. This can help remove an extra move when AVX is supported. Also in many cases (when input[0] is an immediate), we require less temporary registers. Bug: v8:11589 Change-Id: I0d272df12de54f55b4c7a0a330c38ccaca82e927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092553Reviewed-by:
-
Frank Tang authored
Repalce old C style function pointer declaration Bug: v8:12083 Change-Id: I0e7b0c808a7c195989cc75da5d6617d7295918f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088357Reviewed-by:
-
Clemens Backes authored
This is identical to https://crrev.com/c/3094011, but for 16-bit values. We introduce another instruction to differentiate between 16->32 bit sign extensions and 16->64 bit sign extensions. R=ahaas@chromium.org, mslekova@chromium.org Bug: chromium:1239116 Change-Id: I2742e9d9c2b4a038fc7a0b1715faf8f25fa20b1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094012 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Clemens Backes authored
InstructionSelector::ZeroExtendsWord32ToWord64 assumes that a Load[kRepWord8|kTypeInt32] generates a zero-extended value. This assumption makes sense, but was not fulfilled by the instruction selector which emitted an "ldrsb" instruction which sign-extended to the full 64-bit register. This CL fixes that by introducing a separate "LdrsbW" instruction which is selected if we are sign-extending an 8-bit value to 32-bit. R=ahaas@chromium.org, mslekova@chromium.org CC=v8-arm-ports@googlegroups.com Bug: chromium:1239116 Change-Id: I2da1ad6062805acf5558f3e66b8db9a50e830302 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094011 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit 2261e053. Reason for revert: No issues with the CL, but it is taking the last two available opcodes on arm64 (we use 9 bits to encode it, so we are limited to 512 opcodes). We need to land a security fix which includes the addition of two opcodes. Before relanding this, we need to figure out a strategy to either reduce opcodes, or use one more bit to encode them. Original change's description: > [arm64][wasm] Use NEON S/Usra for Wasm SIMD add(shr(x, imm), y) > > A single AArch64 SIMD signed/unsigned Shift Right and Accumulate can be > used to implement Wasm SIMD add(shr(x, imm), y). This gives a 1-1.5% > improvement on some compute intensive Wasm benchmarks on Neoverse-N1. > > Mla and Adalp optimisations were refactored to match the style of the > added code. > > Change-Id: Id5959a31ca267e02b7d60e7ff6f942adb029b41e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089157 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Cr-Commit-Position: refs/heads/master@{#76280} Change-Id: Ifad0625ed8a6b66e7a7a74da11ad7d60941207e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094014 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#76282}
-
Ross McIlroy authored
No longer required. BUG=chromium:1003890 Change-Id: I98fb188ec2e7cd71203cd699b7484ecc26477ed1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086461 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#76281}
-
Ilja Iskovs authored
A single AArch64 SIMD signed/unsigned Shift Right and Accumulate can be used to implement Wasm SIMD add(shr(x, imm), y). This gives a 1-1.5% improvement on some compute intensive Wasm benchmarks on Neoverse-N1. Mla and Adalp optimisations were refactored to match the style of the added code. Change-Id: Id5959a31ca267e02b7d60e7ff6f942adb029b41e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089157Reviewed-by:
-
Nicolò Ribaudo authored
Previously V8 was reusing the error fur duplicate declarations, using the private name for class fields or the class name for class methods as the redeclared identifier. class A { constructor(o) { return o } } class B extends A { #x } class C extends A { #x() {} } let D = (0, class extends A { #x() {} }); new B(new B({})) // Identifier '#x' has already been declared new C(new C({})) // Identifier 'C' has already been declared new D(new D({})) // Identifier '' has already been declared This patch changes it to use error messages that better explain what's happening: new B(new B({})) // Cannot initialize #x twice on the same object new C(new C({})) // Cannot initialize private methods of // class C twice on the same object new D(new D({})) // Cannot initialize private methods of // class anonymous twice on the same object I initially tried to use the same message for both fields and methods, but the problem with that is that when initializing fields we only have access to the field name, while when initializing methods we only have access to the class name (using the "private brand" symbol). However, almost all the error messages are different for private fields and for methods so this shouldn't be a problem. Bug: v8:12042 Change-Id: Iaa50c16e4fa5c0646ad9ef2aa7e65bb649b3fce2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3078362Reviewed-by:Joyee Cheung <joyee@igalia.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#76279}
-
Manos Koukoutos authored
Loops with function calls are not unrolled. This should not include calls to kWasmStackGuard, which exist in many loops. Bug: v8:11298, v8:12047, chromium:1238752 Change-Id: I62a17e708eaca9872f8244175be80ba22a68454c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090338 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#76278}
-
Lu Yahan authored
Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
-
Benedikt Meurer authored
Previously the V8 inspector would report native accessors, whose getter evaluates to a value without causing a side effect, as own data properties. But then the DevTools front-end will not be able to tell whether that accessor was actually an own property or just an inherited accessor. The reason for reporting them as own properties in the first place was to ensure that these properties show up in the object's preview. But that we can handle differently by just marking these properties as synthetic internally and including them in the preview. Bug: chromium:1076820 Change-Id: I223299af7954e7b1a4a16bb5180d4ceff50f170f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094005 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#76276}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bbf7f0e..5c5313f Rolling v8/buildtools/linux64: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/24e92c2..671803f Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/b825591..83f8edb Rolling v8/third_party/aemu-linux-x64: qWiGSH8A_xdaUVO-GsDJsJ5HCkIRwZqb-HDyxsLiuWwC..21LVieOtkkse_Rl-9YyxWMe3RIxZ3Gpb_MUUrgwitckC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/abc7ba7..bd47f22 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/49a703f..699d70d Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/75e34bc..a38aef9 Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/7c54c1f..6ac5f7e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6a8e571..f1ab49b Rolling v8/tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 Rolling v8/tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 Rolling v8/tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I341085653d5e8ce7f76f4dbe0d3d34c6183b1377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093309Reviewed-by:
-
- 12 Aug, 2021 9 commits
-
-
Zhi An Ng authored
This reverts commit a3b2c4ec. Reason for revert: UBSan https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8839060153390139249/+/u/Check/gdbjit Original change's description: > [wasm][diagnostics] Support WasmCode in gdb JIT integration > > - Add new enum WASM_CODE to JitCodeEvent::CodeType > - Use AddressRegion instead of AddressRange (remove the latter) > - Change CodeDescription constructor to take an AddressRegion, > both JIT_CODE and WASM_CODE use this > - Add a simple mjsunit test that sets --gdbjit to check that > we don't crash. > - Add a api test for adding WASM_CODE > > Bug: v8:11908 > Change-Id: I6e87fadc2df67978144d78caf9800c3982bc3705 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067754 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#76271} Bug: v8:11908 Change-Id: Ic1a74a9239e8ef6107efd36f61c089ae6bfc5b6c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093365 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#76274}
-
Milad Fa authored
Change-Id: I89694796962d46b4fb1ae244ee39639576659465 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092025Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76273}
-
Ng Zhi An authored
Use punpcklqdq/punpckhqdq instead of pshufd. Bug: v8:12075 Change-Id: I0260136d3727fde7bae4359df015d2b0090e8b29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092554Reviewed-by:
-
Ng Zhi An authored
- Add new enum WASM_CODE to JitCodeEvent::CodeType - Use AddressRegion instead of AddressRange (remove the latter) - Change CodeDescription constructor to take an AddressRegion, both JIT_CODE and WASM_CODE use this - Add a simple mjsunit test that sets --gdbjit to check that we don't crash. - Add a api test for adding WASM_CODE Bug: v8:11908 Change-Id: I6e87fadc2df67978144d78caf9800c3982bc3705 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067754Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Rakhim Khismet authored
We add struct.set operation to the fuzzed module by choosing random structtype field and generating corresponding type. Bug: v8:11954 Change-Id: I858bd64dd4b7242f20d6d7a0a507f34469de49c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086469 Commit-Queue: Rakhim Khismet <khismet@google.com> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/ab353c6e7..45a913c0 Bug: v8:7834, v8:12085, v8:12086, v8:120448 Change-Id: I3fa00574d99dbeb5a87d1ecb2fcba92a2e2ff79c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3091646Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#76269}
-
Ng Zhi An authored
Move the implementation into shared macro-assembler. TurboFan and Liftoff for both ia32 and x64 can now share the implementation. No functionality change expected. Bug: v8:11589 Change-Id: Ia1f680ba139fca627e82e7dc0a9cf1c833e483cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088513 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Joyee Cheung authored
Landing define-class-fields microbencharks upstream before optimization so that the benefit is visible. Bug: v8:9888 Change-Id: Ie3bd2bd2cdd5710f43e398aa834985b5faa973d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999030 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#76267}
-
Samuel Groß authored
Bug: chromium:1218005 Change-Id: I52368a70c448b8b928fb0cd04a9b7a72f86fafad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3090973 Auto-Submit: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
