Commits · e13a39dd7f4062898709d7c68900677df0513995 · Linshizhi / V8

22 May, 2015 10 commits

Hook up more import/exports in natives. · e13a39dd

yangguo authored May 22, 2015

R=jkummerow@chromium.org

Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9
Cr-Commit-Position: refs/heads/master@{#28573}

Review URL: https://codereview.chromium.org/1154483002

Cr-Commit-Position: refs/heads/master@{#28578}

e13a39dd

Remove obsolete JSFunction::IsOptimizable predicate. · eb055cb3

mstarzinger authored May 22, 2015

This just delegates to SharedFunctionInfo::optimization_disabled and
was primarily used for assertions. Removing it due to misleading name
because already optimized functions reported being "non-optimizable".

This relands commit 181d7b85.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/1146423002

Cr-Commit-Position: refs/heads/master@{#28577}

eb055cb3

VectorICs: Create a StoreICState to more easily create matching code stubs. · 3ce81e19

mvstanton authored May 22, 2015

This follows the logic of the load ics, in that the base extra ic state is
better encapsulated.

Introduce flag vector_stores to aid development of vector-based store ics.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1151253004

Cr-Commit-Position: refs/heads/master@{#28576}

3ce81e19

[turbofan] Don't mix up name/property accesses. · 5f11a5fa

bmeurer authored May 22, 2015

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/1149663003

Cr-Commit-Position: refs/heads/master@{#28575}

5f11a5fa

Revert of Hook up more import/exports in natives. (patchset #2 id:20001 of... · 4c2690a4

machenbach authored May 22, 2015

Revert of Hook up more import/exports in natives. (patchset #2 id:20001 of https://codereview.chromium.org/1154483002/)

Reason for revert:
[Sheriff] Breaks nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6943

Original issue's description:
> Hook up more import/exports in natives.
>
> R=jkummerow@chromium.org
>
> Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9
> Cr-Commit-Position: refs/heads/master@{#28573}

TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1154793003

Cr-Commit-Position: refs/heads/master@{#28574}

4c2690a4

Hook up more import/exports in natives. · 7a918ac9

yangguo authored May 22, 2015

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1154483002

Cr-Commit-Position: refs/heads/master@{#28573}

7a918ac9

Unbreak %DebugPrint output. · cb55675a

svenpanne authored May 22, 2015

Review URL: https://codereview.chromium.org/1155773003

Cr-Commit-Position: refs/heads/master@{#28572}

cb55675a

Android IA32: enable PIE · 6726406c

jing.bao authored May 22, 2015

BUG=

Review URL: https://codereview.chromium.org/1145513006

Cr-Commit-Position: refs/heads/master@{#28571}

6726406c

[turbofan] Pick word representation for phis with Type::Internal(). · 03aae819

danno authored May 22, 2015

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1154463004

Cr-Commit-Position: refs/heads/master@{#28570}

03aae819

Revert of Revert of Pass GC flags to incremental marker and start incremental... · 67c0dcbe

machenbach authored May 22, 2015

Revert of Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #1 id:1 of https://codereview.chromium.org/1151143002/)

Reason for revert:
Wasn't the reason...

Original issue's description:
> Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/)
>
> Reason for revert:
> [Sheriff] Speculative revert because chromebook is really misbehaving:
> http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109
>
> I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland.
>
> Original issue's description:
> > Pass GC flags to incremental marker and start incremental marking with
> > reduce memory footprint in idle notification.
> >
> > BUG=
> >
> > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc
> > Cr-Commit-Position: refs/heads/master@{#28567}
>
> TBR=hpayer@chromium.org,ulan@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7
> Cr-Commit-Position: refs/heads/master@{#28568}

TBR=hpayer@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1157613002

Cr-Commit-Position: refs/heads/master@{#28569}

67c0dcbe

21 May, 2015 30 commits

Revert of Pass GC flags to incremental marker and start incremental marking... · 634c58a4

machenbach authored May 21, 2015

Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/)

Reason for revert:
[Sheriff] Speculative revert because chromebook is really misbehaving:
http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109

I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland.

Original issue's description:
> Pass GC flags to incremental marker and start incremental marking with
> reduce memory footprint in idle notification.
>
> BUG=
>
> Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc
> Cr-Commit-Position: refs/heads/master@{#28567}

TBR=hpayer@chromium.org,ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1151143002

Cr-Commit-Position: refs/heads/master@{#28568}

634c58a4

Pass GC flags to incremental marker and start incremental marking with · 46563081

ulan authored May 21, 2015

reduce memory footprint in idle notification.

BUG=

Review URL: https://codereview.chromium.org/1156463002

Cr-Commit-Position: refs/heads/master@{#28567}

46563081

Fixing Heap::Available() to return total of all spaces. · 3f162d41

ssid authored May 21, 2015

The Heap::Available method adds up the available size from only 4 of
the spaces. This CL fixes the method to return total of all spaces.

BUG=481504
LOG=N

Review URL: https://codereview.chromium.org/1141693003

Cr-Commit-Position: refs/heads/master@{#28566}

3f162d41

[destructuring] Grand for statement parsing unification. · 7ffdb519

dslomov authored May 21, 2015

Also support patterns in ``for (var p in/of ...)``

This CL extends the rewriting we used to do for ``for (let p in/of...)`` to
``for (var p in/of ...)``. For all for..in/of loop declaring variable,
we rewrite
   for (var/let/const pattern in/of e) b
into
   for (x' in/of e) { var/let/const pattern = e; b }

This adds a small complication for debugger: for a statement
   for (var v in/of e) ...
we used to have
   var v;
   for (v in/of e) ...
and there was a separate breakpoint on ``var v`` line.
This breakpoint is actually useless since it is immediately followed by
a breakpoint on evaluation of ``e``, so this CL removes that breakpoint
location.

Similiraly, for let, it used to be that
  for (let v in/of e) ...
became
  for (x' in/of e) { let v; v  = x'; ... }
``let v``generetaed a useless breakpoint (with the location at the
loop's head. This CL removes that breakpoint as well.

R=arv@chromium.org,rossberg@chromium.org
BUG=v8:811
LOG=N

Review URL: https://codereview.chromium.org/1149043005

Cr-Commit-Position: refs/heads/master@{#28565}

7ffdb519

Prepare GetProperty(Attributes)WithInterceptor to support elements · a40e85d6

verwaest authored May 21, 2015

BUG=v8:4137
LOG=n

Review URL: https://codereview.chromium.org/1147863002

Cr-Commit-Position: refs/heads/master@{#28564}

a40e85d6

Set V8_HAS_DECLSPEC_SELECTANY for clang-cl · e5140152

hans authored May 21, 2015

This macro is used for defining static data members with
STATIC_CONST_MEMBER_DEFINITION. Clang-cl mimics MSVC's
behaviour here, so it also needs __declspec(selectany).

This change was prompted by Clang r237787 which changed
a bug where Clang would previously not emit symbols for
some static data members.

BUG=82385
LOG=N

Review URL: https://codereview.chromium.org/1145213004

Cr-Commit-Position: refs/heads/master@{#28563}

e5140152

Reland "Avoid excessive GCs in small heaps." · b59fda16

ulan authored May 21, 2015

Original issue's description:
> Avoid excessive GCs in small heaps.
>
> Small heaps and small heap growing factor can lead to excessive GCs in corner cases.
>
> Consider function F(old_gen_size, factor) that returns the number of bytes that
> have to be allocated in the old generation to start incremental marking.
>
> F(4MB, 1.1) = 4MB (because of kMinimumOldGenerationAllocationLimit)
> F(6MB, 1.1) = 2MB (because of kMinimumOldGenerationAllocationLimit)
> F(8MB, 1.1) = 800KB
>
> Funtion F should be monotonic in old_gen_size, but it currently has a minimum
> at kMinimumOldGenerationAllocationLimit.
>
> This CL makes F monotonic.
>
> BUG=
>
> Committed: https://crrev.com/22b1da99732b4db0754bf267ec470a2831216fb2
> Cr-Commit-Position: refs/heads/master@{#28549}

TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/1148953005

Cr-Commit-Position: refs/heads/master@{#28562}

b59fda16

[test] Apply more detailed origin tracking in MSAN builds. · 643c85a7

machenbach authored May 21, 2015

BUG=chromium:425187
LOG=n
TBR=svenpanne@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1148333004

Cr-Commit-Position: refs/heads/master@{#28561}

643c85a7

PPC: [es6] Spread in array literals · fc146e9e

mbrandy authored May 21, 2015

Port 9502e91a

Original commit message:
This allows you to put iterables into your array literals
and the will get spread into the array.

  let x = [0, ...range(1, 3)];  // [0, 1, 2]

This is done by treating the array literal up to the first
spread element as usual, including using a boiler plate
array, and then appending the remaining expressions and rest
expressions.

R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1149873005

Cr-Commit-Position: refs/heads/master@{#28560}

fc146e9e

Adjust GetPropertyWithFailedAccessCheck to support elements · 10329be6

verwaest authored May 21, 2015

BUG=v8:4137
LOG=n

Review URL: https://codereview.chromium.org/1155503003

Cr-Commit-Position: refs/heads/master@{#28559}

10329be6

Revert of Avoid excessive GCs in small heaps. (patchset #1 id:1 of... · e8c593c4

ulan authored May 21, 2015

Revert of Avoid excessive GCs in small heaps. (patchset #1 id:1 of https://codereview.chromium.org/1144223002/)

Reason for revert:
Regressed Sunspider.

Original issue's description:
> Avoid excessive GCs in small heaps.
>
> Small heaps and small heap growing factor can lead to excessive GCs in corner cases.
>
> Consider function F(old_gen_size, factor) that returns the number of bytes that
> have to be allocated in the old generation to start incremental marking.
>
> F(4MB, 1.1) = 4MB (because of kMinimumOldGenerationAllocationLimit)
> F(6MB, 1.1) = 2MB (because of kMinimumOldGenerationAllocationLimit)
> F(8MB, 1.1) = 800KB
>
> Funtion F should be monotonic in old_gen_size, but it currently has a minimum
> at kMinimumOldGenerationAllocationLimit.
>
> This CL makes F monotonic.
>
> BUG=
>
> Committed: https://crrev.com/22b1da99732b4db0754bf267ec470a2831216fb2
> Cr-Commit-Position: refs/heads/master@{#28549}

TBR=hpayer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1152533002

Cr-Commit-Position: refs/heads/master@{#28558}

e8c593c4

[test] Raise timeout for js-perf-tests. · b7eae801

machenbach authored May 21, 2015

TBR=dslomov@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1147323002

Cr-Commit-Position: refs/heads/master@{#28557}

b7eae801

Simplify GetProperty helpers to ease element support · c2670d61

verwaest authored May 21, 2015

BUG=v8:4137
LOG=n

Review URL: https://codereview.chromium.org/1148583002

Cr-Commit-Position: refs/heads/master@{#28556}

c2670d61

Add a TurboFan skeleton for StringAddStub. · f91503f2

svenpanne authored May 21, 2015

Currently the stub simply calls out to the runtime, this will be
improved in a later CLs. The current state at least avoids bit-rot and
later merging horror.

Fixes frame construction logic for stubs, too, and contains quite a few
tiny cleanups in stub-land.

Review URL: https://codereview.chromium.org/1150673002

Cr-Commit-Position: refs/heads/master@{#28555}

f91503f2

Revert of Remove obsolete JSFunction::IsOptimizable predicate. (patchset #1... · 9d9acf55

mstarzinger authored May 21, 2015

Revert of Remove obsolete JSFunction::IsOptimizable predicate. (patchset #1 id:1 of https://codereview.chromium.org/1150683002/)

Reason for revert:
Causes assertions to fire when serializing optimized code.

Original issue's description:
> Remove obsolete JSFunction::IsOptimizable predicate.
>
> This just delegates to SharedFunctionInfo::optimization_disabled and
> was primarily used for assertions. Removing it due to misleading name
> because already optimized functions reported being "non-optimizable".
>
> R=titzer@chromium.org
>
> Committed: https://crrev.com/181d7b85977eb752b19e1de902093783e31330ef
> Cr-Commit-Position: refs/heads/master@{#28551}

TBR=titzer@chromium.org,bmeurer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1148973005

Cr-Commit-Position: refs/heads/master@{#28554}

9d9acf55

Fix typo in standalone.gypi · 9ebf94c8

jochen authored May 21, 2015

without the % we can't override the value which makes the Makefile thing
not work

R=vogelheim@chromium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/1147273002

Cr-Commit-Position: refs/heads/master@{#28553}

9ebf94c8

Reduce new space size during idle times only in memory mode after scavenge,... · 2b8a40e1

hpayer authored May 21, 2015

Reduce new space size during idle times only in memory mode after scavenge, full gc, or finalized incremental full gc.

BUG=

Review URL: https://codereview.chromium.org/1143973003

Cr-Commit-Position: refs/heads/master@{#28552}

2b8a40e1

Remove obsolete JSFunction::IsOptimizable predicate. · 181d7b85

mstarzinger authored May 21, 2015

This just delegates to SharedFunctionInfo::optimization_disabled and
was primarily used for assertions. Removing it due to misleading name
because already optimized functions reported being "non-optimizable".

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/1150683002

Cr-Commit-Position: refs/heads/master@{#28551}

181d7b85

[turbofan] Fix UnifyReturn magic in the inliner. · 1dbe83d9

bmeurer authored May 21, 2015

The inliner previously assumed that there will only be returns reaching
the end node, but that's not true.  This refactoring will make it
possible to also hook up Deoptimize, Throw and Terminate nodes reaching
end properly.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/1146393002

Cr-Commit-Position: refs/heads/master@{#28550}

1dbe83d9

Avoid excessive GCs in small heaps. · 22b1da99

ulan authored May 21, 2015

Small heaps and small heap growing factor can lead to excessive GCs in corner cases.

Consider function F(old_gen_size, factor) that returns the number of bytes that
have to be allocated in the old generation to start incremental marking.

F(4MB, 1.1) = 4MB (because of kMinimumOldGenerationAllocationLimit)
F(6MB, 1.1) = 2MB (because of kMinimumOldGenerationAllocationLimit)
F(8MB, 1.1) = 800KB

Funtion F should be monotonic in old_gen_size, but it currently has a minimum
at kMinimumOldGenerationAllocationLimit.

This CL makes F monotonic.

BUG=

Review URL: https://codereview.chromium.org/1144223002

Cr-Commit-Position: refs/heads/master@{#28549}

22b1da99

Dropping iterations and speedup from perf results. · d04de62b

bradnelson authored May 21, 2015

The dashboard displays everything on one scale.
This isn't very useful.
Dropping these two fields as they're not really that
interesting anyway.

BUG=https://code.google.com/p/v8/issues/detail?id=4124
LOG=N
TEST=None
NOTRY=true
TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/1144263002

Cr-Commit-Position: refs/heads/master@{#28548}

d04de62b

[destructuring] Implement pattern matching in lexcal for-of/for-in. · 8925b848

dslomov authored May 21, 2015

R=arv@chromium.org,rossberg@chromium.org
BUG=v8:811
LOG=N

Review URL: https://codereview.chromium.org/1152503002

Cr-Commit-Position: refs/heads/master@{#28547}

8925b848

Start adding support for elements to the LookupIterator · 16484824

verwaest authored May 21, 2015

BUG=

Review URL: https://codereview.chromium.org/1144883002

Cr-Commit-Position: refs/heads/master@{#28546}

16484824

[turbofan] Ship TF for "with" and "for-of" constructs. · 11e1e207

mstarzinger authored May 21, 2015

R=danno@chromium.org
BUG=v8:4131
LOG=N

Review URL: https://codereview.chromium.org/1148653005

Cr-Commit-Position: refs/heads/master@{#28545}

11e1e207

[turbofan] Prepare mechanism to enable TF on language subset. · 54b34bdd

mstarzinger authored May 21, 2015

This allows enabling TurboFan on a certain subset of language features
in the AstNumberingVisitor. The heuristics of when to optimize remain
unchanged, only the choice of which optimizing compiler to use changes.

R=bmeurer@chromium.org
BUG=v8:4131
LOG=N

Review URL: https://codereview.chromium.org/1155503002

Cr-Commit-Position: refs/heads/master@{#28544}

54b34bdd

[turbofan] Enable deoptimization for non-asm.js TurboFan code. · c9a49da0

bmeurer authored May 21, 2015

Replace the --turbo-deoptimization flag with --turbo-asm-deoptimization
and enable deoptimization for non-asm.js TurboFan code unconditionally.

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/1153483002

Cr-Commit-Position: refs/heads/master@{#28543}

c9a49da0

Check in hello world example so it stays up to date · 3996dc5d

jochen authored May 21, 2015

BUG=none
R=vogelheim@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1148063003

Cr-Commit-Position: refs/heads/master@{#28542}

3996dc5d

Generalize HeapObject alignment requirements. · ebee0aa2

bbudge authored May 21, 2015

Removes EnsureDouble* methods.
Adds a RequiredAlignment method.
Changes call sites.

LOG=N
BUG=v8:4124

Review URL: https://codereview.chromium.org/1150953002

Cr-Commit-Position: refs/heads/master@{#28541}

ebee0aa2

[turbofan] Add bounds check to Node::InputAt(index) and fix tests that go out of bounds. · 41795b8a
titzer authored May 21, 2015
```
BUG=

Review URL: https://codereview.chromium.org/1149563004

Cr-Commit-Position: refs/heads/master@{#28540}
```
41795b8a

Debugger: use weak cells to implement ScriptCache. · 720d9c28

yangguo authored May 21, 2015

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/1145183004

Cr-Commit-Position: refs/heads/master@{#28539}

720d9c28