- 24 Feb, 2017 10 commits
-
-
clemensh authored
The only remaining allowed occurence of a context is in WASM_TO_JS code, which is regenerated for each instance. This CL removes all the rest, to avoid subtle bugs where we might forget to patch it. By renaming the BuildCallToRuntime method, we make sure that noone accidentially calls the version which embeds a context. For consistency, I even remove it from the WasmRunInterpreter stub, which is never reused for new instantiations. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2708743003 Cr-Commit-Position: refs/heads/master@{#43409}
-
ivica.bogosavljevic authored
In instruction selector, in the reduction of Word64And(Word64Shr(val,0), 0xFFF...) to EXT instruction, the case where shift value is 0 and mask is 0xFFFFFFFFFFFFFFFF was not supported. We now generate NOP for this case since no bit extraction is necessary. We implement the same behavior for MIPS32 even though there are no tests that are failing. TEST=cctest/test-run-machops/Regression5951 BUG= Review-Url: https://codereview.chromium.org/2718433002 Cr-Commit-Position: refs/heads/master@{#43408}
-
bmeurer authored
We can make Heap::UpdateAllocationSite cheaper for TurboFan, because there's no need to check for allocation mementos on Strings in case of the TurboFan pipeline. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2710303002 Cr-Commit-Position: refs/heads/master@{#43407}
-
yangguo authored
TBR=kozyatinskiy@chromium.org BUG=chromium:695631 Review-Url: https://codereview.chromium.org/2718543005 Cr-Commit-Position: refs/heads/master@{#43406}
-
Jochen Eisinger authored
This is used for internal security checks in eval(). Expose this to enable the embedder to implement similar security checks. R=yangguo@chromium.org BUG= Change-Id: I10819713b19527622de5ffffac313d126a887c05 Reviewed-on: https://chromium-review.googlesource.com/446106Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#43405}
-
machenbach authored
Revert of [inspector] removed unused #include "include/v8-debug.h" (patchset #2 id:20001 of https://codereview.chromium.org/2710243002/ ) Reason for revert: breaks presubmit on CI which runs checkdeps Original issue's description: > [inspector] removed unused #include "include/v8-debug.h" > > We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. > > BUG=none > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2710243002 > Cr-Commit-Position: refs/heads/master@{#43398} > Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024c2249 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2719433002 Cr-Commit-Position: refs/heads/master@{#43404}
-
Michael Achenbach authored
BUG=chromium:695777 NOTRY=true TBR=tandrii@chromium.org Review-Url: https://codereview.chromium.org/2714893003 . Cr-Commit-Position: refs/heads/master@{#43403}
-
shiyu.zhang authored
Enable using BaseWithIndexAndDisplacement addressing mode for an address used by multiple load/stores. It can reduce one instruction to calculate the address and one register to store the address. BUG= Review-Url: https://codereview.chromium.org/2620293004 Cr-Commit-Position: refs/heads/master@{#43402}
-
bmeurer authored
For a + b, where both a and b are known strings at compile time, and the combined length of a and b doesn't overflow the maximum allowed string length, we can constant-fold the string concatenation during compilation. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2713093003 Cr-Commit-Position: refs/heads/master@{#43401}
-
kozyatinskiy authored
With inline breakpoints DevTools are ready for break position aligned breakpoints instead of statement aligned. BUG=chromium:695236 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2709263002 Cr-Original-Commit-Position: refs/heads/master@{#43385} Committed: https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b6ccf0 Review-Url: https://codereview.chromium.org/2709263002 Cr-Commit-Position: refs/heads/master@{#43400}
-
- 23 Feb, 2017 15 commits
-
-
bradnelson authored
BUG=v8:4203 R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2715743004 Cr-Commit-Position: refs/heads/master@{#43399}
-
kozyatinskiy authored
We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43398}
-
bradnelson authored
Adding a full run of checkdeps to tools/presubmit.py so that we keep checkdeps green. PRESUBMIT.py checks only incremental changes. Temporarily disabling a check rule that's broker in the inspector, pending owners fix. BUG= R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org Review-Url: https://codereview.chromium.org/2705333005 Cr-Commit-Position: refs/heads/master@{#43397}
-
Ross McIlroy authored
This reverts commit 8307ab70. Reason for revert: Breaks TSAN Original change's description: > [Counters] Add HistorgramTimers for optimized compile. > > Will be used for UMA to track time spent optimizing code in the wild. > > Change-Id: Ibc01540552eac4cb9224f1cb6cc11a55aae5834d > Reviewed-on: https://chromium-review.googlesource.com/444345 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#43374} TBR=rmcilroy@chromium.org,mvstanton@chromium.org,machenbach@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1cfc2ee599b9ba0132e69c8a61b21ff32c74f68e Reviewed-on: https://chromium-review.googlesource.com/446360Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43396}
-
machenbach authored
Revert of [inspector] use BREAK_POSITION_ALIGNED for breakpoints (patchset #7 id:120001 of https://codereview.chromium.org/2709263002/ ) Reason for revert: breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13747 which blocks rolling. See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] use BREAK_POSITION_ALIGNED for breakpoints > > With inline breakpoints DevTools are ready for break position aligned breakpoints instead of statement aligned. > > BUG=chromium:695236 > R=dgozman@chromium.org,yangguo@chromium.org > > Review-Url: https://codereview.chromium.org/2709263002 > Cr-Commit-Position: refs/heads/master@{#43385} > Committed: https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b6ccf0 TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:695236 Review-Url: https://codereview.chromium.org/2709313003 Cr-Commit-Position: refs/heads/master@{#43395}
-
adamk authored
The source code of those functions is simple a ternary operator, and the test seems to have been designed as a "regression" test for the previous implementation (which used a macro, and thus evaluated its arguments multiple times). I don't think the test is worth the weight of supporting importing JS natives from tests. This patch removes the last test that depends on JS natives. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2711833002 Cr-Commit-Position: refs/heads/master@{#43394}
-
adamk authored
The test itself was for an issue that's handled statically since https://codereview.chromium.org/1302313013 (we were missing some instance types in a switch statement). This leaves us with only a single test that depends on the JS native import system. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2707133005 Cr-Commit-Position: refs/heads/master@{#43393}
-
neis authored
BUG=v8:1569 Review-Url: https://codereview.chromium.org/2711123002 Cr-Commit-Position: refs/heads/master@{#43392}
-
neis authored
This changes the bytecode decoder such that --print-bytecode will print ... CallRuntime [GeneratorGetResumeMode] ... ... InvokeIntrinsic [CreateIterResultObject] ... instead of ... CallRuntime [762] ... ... InvokeIntrinsic [2] ... The printing of CallJSRuntime remains unchanged. R=gsathya@chromium.org, rmcilroy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2712943002 Cr-Commit-Position: refs/heads/master@{#43391}
-
jbroman authored
The entry points to the deserializer are responsible for ensuring that an exception is pending by the time they return. Some failures throw exceptions themselves, while others (like errors in the format) are exceptions caused by the deserializer, not coming from the runtime. Like the non-legacy path, a default deserialization exception should be thrown in such cases. BUG=chromium:693411 Review-Url: https://codereview.chromium.org/2712713002 Cr-Commit-Position: refs/heads/master@{#43390}
-
Marja Hölttä authored
Non-simple parameters are only disallowed when a function declares itself strict, but they're otherwise ok in strict mode. Enabling these tests will expose more problems when scope data for arrow functions is tested (in a future CL). BUG=v8:5516 R=vogelheim@chromium.org Change-Id: I839ad37d46305975a56aff20e8ca70505c16bf1d Reviewed-on: https://chromium-review.googlesource.com/446497Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#43389}
-
Marja Hölttä authored
BUG=v8:5294 Change-Id: If45f25aae8de526027b7851cb4efe0ccf4a7c4b1 Reviewed-on: https://chromium-review.googlesource.com/444226 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43388}
-
ivica.bogosavljevic authored
Fix crashes in two tests cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes and cctest/test-wasm-interpreter-entry/TestArgumentPassing_float_double related to accessing double value through unaligned pointer. This issue is present on those architectures that do not support unaligned access. TEST=cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes, cctest/test-wasm-interpreter-entry/TestArgumentPassing_float_double BUG= Review-Url: https://codereview.chromium.org/2705253003 Cr-Commit-Position: refs/heads/master@{#43387}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8b6a679..2383361 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/a7cc7a3..7e53759 Rolling v8/test/wasm-js: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/bfb1fc4..1e5c9c4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/d9036c9..56214f6 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/9cd2828..450be73 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8da96ea..9982bd3 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Iaedc4e09880836813a74a374f912e891c1769dc1 Reviewed-on: https://chromium-review.googlesource.com/446597Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#43386}
-
kozyatinskiy authored
With inline breakpoints DevTools are ready for break position aligned breakpoints instead of statement aligned. BUG=chromium:695236 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2709263002 Cr-Commit-Position: refs/heads/master@{#43385}
-
- 22 Feb, 2017 15 commits
-
-
bakkot authored
This implements the proposal at https://github.com/tc39/proposal-template-literal-revision staged behind a flag --harmony-template-escapes. The proposal allows invalid octal, unicode, and hexadecimal escape sequences to appear in tagged template literals, instead of being a syntax error. These have a 'cooked' value of 'undefined', but are still accessible through the 'raw' property. BUG=v8:5546 Review-Url: https://codereview.chromium.org/2665513002 Cr-Commit-Position: refs/heads/master@{#43384}
-
titzer authored
R=mtrofin@chromium.org BUG=chromium:575167,chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Original-Commit-Position: refs/heads/master@{#43368} Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef59262997 Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43383}
-
bjaideep authored
Port 73d45c96 Original Commit Message: With this CL the out-of-line code of TrapIf will call a builtin instead of doing a direct runtime call, which is cheaper. In the best case, the out-of-line code now consists of a single call instruction. The builtin will load the trapID and then call the runtime to throw a trap. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2713433003 Cr-Commit-Position: refs/heads/master@{#43382}
-
littledan authored
Also drive-by naming fix from the previous patch. R=binji Review-Url: https://codereview.chromium.org/2702153005 Cr-Commit-Position: refs/heads/master@{#43381}
-
bjaideep authored
Port 3f303da2 R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2672813002 Cr-Original-Commit-Position: refs/heads/master@{#42898} Review-Url: https://codereview.chromium.org/2704303006 Cr-Commit-Position: refs/heads/master@{#43380}
-
Ross McIlroy authored
During scavanges multiple different ThinStrings can end up pointing to the same internalized string. This means that the same key/value pair can be re-inserted during rehash operations, so the values_[index] might not be null when inserting the value. BUG=chromium:695029 Change-Id: I5f693586bb60d5a2bbe89f05cb5b7f5fe26a23b2 Reviewed-on: https://chromium-review.googlesource.com/446380Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43379}
-
Michael Lippautz authored
Have clear prologue and epilogue steps. For a minor MC we can then templatize the prologue without changing the actual evacuation routine. BUG=chromium:651354 Change-Id: Ia238748e90bc6b616cd813d31198de182fe11498 Reviewed-on: https://chromium-review.googlesource.com/445898Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43378}
-
jkummerow authored
Convenience wrapper around building with gn/ninja and running tests. Follows Makefile syntax, but is more flexible; see --help. Pro tip: alias gm="tools/dev/gm.py" NOTRY=true Review-Url: https://codereview.chromium.org/2713663002 Cr-Commit-Position: refs/heads/master@{#43377}
-
Michael Starzinger authored
This fixes a corner-case where the call reduction of the aforementioned getter did not simulate the {ToObject} conversion of the receiver value as required by the spec. This caused the wrong prototype to be constant promoted (i.e. {null} instead of wrapper object prototype). R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-694709 BUG=chromium:694709 Change-Id: Idf3a37071949d9ddaf5ef43974570c06fd31c0c9 Reviewed-on: https://chromium-review.googlesource.com/445818Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43376}
-
Michael Starzinger authored
This reverts commit 14de196a. Reason for revert: Tanks Mandreel, fix is in flight, but we want a stable baseline first. Will reland again next week. Original change's description: > [turbofan] Handle comparison operations in early lowering. > > This handles relational comparison operations (no equality yet) having > number feedback during the early type-hint lowering (i.e. during graph > construction). > > R=bmeurer@chromium.org > > Change-Id: I0ac1539f85de1770c3d518855754550932f6fcd3 > Reviewed-on: https://chromium-review.googlesource.com/445716 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#43365} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org,rmcilroy@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I103d976c9b9b73ca67af6f6a32ea47a52d04c123 Reviewed-on: https://chromium-review.googlesource.com/446358Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43375}
-
Ross McIlroy authored
Will be used for UMA to track time spent optimizing code in the wild. Change-Id: Ibc01540552eac4cb9224f1cb6cc11a55aae5834d Reviewed-on: https://chromium-review.googlesource.com/444345Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43374}
-
machenbach authored
Revert of [wasm] Remove support for experimental version 0xD. (patchset #3 id:40001 of https://codereview.chromium.org/2709753003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13730 Original issue's description: > [wasm] Remove support for experimental version 0xD. > > R=mtrofin@chromium.org > BUG=chromium:575167,chromium:694657 > > Review-Url: https://codereview.chromium.org/2709753003 > Cr-Commit-Position: refs/heads/master@{#43368} > Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef59262997 TBR=ahaas@chromium.org,mtrofin@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167,chromium:694657 Review-Url: https://codereview.chromium.org/2706303004 Cr-Commit-Position: refs/heads/master@{#43373}
-
Ross McIlroy authored
This reverts commit 087e95ba. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Compiler] Use IdentityMap to store jobs in CompilerDispatcher. > > Stores jobs in an IdentityMap keyed by their SharedFunctionInfo to enable > fast checking of whether a job is enqueued. > > BUG=v8:5203 > > Change-Id: I6c37972093515a27077f79594cad27e32e1a4e7c > Reviewed-on: https://chromium-review.googlesource.com/444768 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#43370} TBR=rmcilroy@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Change-Id: I5d1101bdae6939378dad595b26698fe2aaaad35e Reviewed-on: https://chromium-review.googlesource.com/446357Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43372}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2695933005 Cr-Commit-Position: refs/heads/master@{#43371}
-
Ross McIlroy authored
Stores jobs in an IdentityMap keyed by their SharedFunctionInfo to enable fast checking of whether a job is enqueued. BUG=v8:5203 Change-Id: I6c37972093515a27077f79594cad27e32e1a4e7c Reviewed-on: https://chromium-review.googlesource.com/444768Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#43370}
-