- 09 Mar, 2021 18 commits
-
-
Thibaud Michaud authored
... and after creating the debug side table entry. The safepoint and the debug side table entry should be generated right after the call, so that they are associated with the return address of the previous call. R=clemensb@chromium.org Bug: v8:11453 Change-Id: I71395851c5a7f4e2c873907454245c9d04f972f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739629 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73302}
-
Seth Brenith authored
The generated Torque files class-verifiers.cc and class-debug-readers.cc currently include files which are part of v8_initializers, despite being used in unrelated build targets. This change removes the unnecessary inclusions. There is still a lot of code included via all-objects-inl.h, but that's because these files require full class definitions for every object type. Bug: v8:11528 Change-Id: Ib26496f2a30ef576f1101636e0aca2cafbfd1f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743087 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73301}
-
Maya Lekova authored
This CL removes the caching of the stack slot used for the fallback mechanism in V8, as the current implementation is incorrect and needs to be reworked. Bug: chromium:1185753 Change-Id: I9f77bc42bfd649e0dbcd294b000b48c928cf99d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743886 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73300}
-
Sathya Gunasekaran authored
Lazy native accessors require special handling to rewrite the accessor into a data property, so transition to a slow handler for this case. Bug: v8:11485 Change-Id: I01636c6e624562619a216fea5e836ae85c7da93f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743882Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73299}
-
Clemens Backes authored
This ensures that after the function-entry stack check, the instance will still be available in a register. The cost is having to reload it from the stack in the OOL code for the stack check, even though it is not clear if that register will still be used. This does not affect code size significantly (~0.25% reduction), but can improve performance a little bit if there are memory accesses or other instructions that require the instance right at the beginning of the function. R=thibaudm@chromium.org Bug: v8:11336 Change-Id: Ib72db172813d55120f527b31014b69a734934ff3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743878Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73298}
-
Michael Achenbach authored
Bug: chromium:1154223 Change-Id: I9545db5ce76f973f8402cefe588d994d1519135b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745137Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#73297}
-
Santiago Aboy Solanes authored
Reading the descriptor array from a map has been safe for a while. Bug: v8:7790 Change-Id: Ib06e12727b7da26c09822db45530addc11e2cf00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739637Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73296}
-
Thibaud Michaud authored
Push the caught exception on the value stack, so that we can access it from an inner catch block and rethrow it. R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ibc5e653a07c3e4436e252c001b53bc2d3402abc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739974Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73295}
-
Jakob Kummerow authored
With the value stack refactoring in 1b5c7e15 / r73193, the combination of helper functions called by PeekArgs() ended up checking the stack height repeatedly. This CL avoids that by introducing a ValidateArgType() helper that does not check stack height. Bonus: achieve a small speedup by special-casing two of the most common opcodes in the decoder's main dispatcher. Fixed: chromium:1185082 Change-Id: I6d51aca844ef9377d203147f74ff8137e12a23e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745341 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73294}
-
pthier authored
This is a reland of a8b61ef5 The main reason for the revert was not related to this CL and was fixed with https://crrev.com/c/2739646 In addition debug output in d8.test.verifySourcePositions was removed due to TSAN complaints. Original change's description: > [sparkplug] Change bytecode offset mapping and introduce iterator. > > Previously, we recorded pairs of (bytecode offset, sparkplug pc) to > create a mapping of bytecode offset <-> sparkplug pc. > These pairs were only recorded after builtin/runtime calls. > In preparation for deoptimizing to Sparkplug, we need a more precise > mapping. > With this CL, we record positions for every bytecode. Instead of storing > a pair of (bytecode offset, sparkplug pc), we store only the pc, > calculating the bytecode offset from the index in the mapping table. > For easier use an iterator to access the mapping is introduced. > > Drive-by: Reduce sampling interval in cpu-profiler cctest to get rid of flaky failures. > > Bug: v8:11420, v8:11429 > Change-Id: I36a9171f43a574eb67880cbca6cf9ff7ab291e60 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720189 > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Auto-Submit: Patrick Thier <pthier@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73186} > > Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6 Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745335Reviewed-by: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73293}
-
Leszek Swirski authored
Do --always-sparkplug compilations in a separate function, and allow that function to return false if a sparkplug compilation fails. Similarly, don't assert that --always-sparkplug requires a function to have baseline code, in case a previous sparkplug compilation failed. Fixed: chromium:1185735, chromium:1185739 Change-Id: I363fcf271395afa2ec47228fff7a28a76c157f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744735 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73292}
-
Dan Elphick authored
Removes unneeded dependency on src/builtins/torque-csa-header-includes.h from debug-macros.h and adds swiss-name-dictionary.h and ordered-hash-table.h to debug-macros.cc. Additionally adds a v8_libbase dep to torque_generated_definitions. As a result, gn check errors are reduced by 2. Bug: v8:7330 Change-Id: I0ff666eebd6814e4d52d776e455fd269db36b589 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744040Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#73291}
-
Ulan Degenbaev authored
Bug: v8:9877 Change-Id: I55cedfd2748f00f989172d804eec735aa6c19365 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742618Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73290}
-
Liu Yu authored
Port: 75d7d127 Bug: v8:11238 Change-Id: I5369875fe66d2297cbd342db91b1ffd99a361616 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2738792Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73289}
-
Clemens Backes authored
This excludes more targets and tests that won't work without webassembly: - wee8 - multi_return_fuzzer - wasm-js - wasm-spec-tests - wasm-api-tests - several cctests R=jkummerow@chromium.org Bug: v8:11238 Change-Id: I6d6ac43869a2b4a91e5b0e7e3183a476a98bf0af Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742617 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73288}
-
Adam Barth authored
These functions do the same thing, but Fuchsia will eventually remove support for protect2. Change-Id: I9f2b4153efa2f78238eb020e9f422f666ae5b7bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743635 Auto-Submit: Adam Barth <abarth@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73287}
-
pthier authored
Instead of using addresses of prototype and constructor (which can be movedby GC) when computing the hash of a Map, we use the addresses of the prototype map (which won't be compacted). The prototype map is in a 1:1 relation with the prototype. In addition the prototype points to the constructor in most cases. Bug: v8:11519 Change-Id: Ibc47e5870955d7721509be07fae7719a93da9a26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739646 Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73286}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/baef8bb..077f859 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/27d20f0..a5cc843 Rolling v8/third_party/aemu-linux-x64: UNqI4KV2QmdCbFaMAYUJ340CZT7YjUKiV11WNfMPFF8C..dBlHF6-1NU-vr6DU068Y8_WQHCWdk_yovRmg225wIr0C Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4ec3fd3..75c9832 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03ac61daec32bd0a968d7bdc9ce56d1a4aa8915a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744974Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73285}
-
- 08 Mar, 2021 22 commits
-
-
Bill Budge authored
This reverts commit 19b62d0b. Reason for revert: Undefined behavior https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/15449 Original change's description: > [v8windbg] Add more items in the Locals pane > > Add more items in the Locals pane representing the JS function name, > source file name, and character offset within the source file, so > that the user doesn’t need to dig through the shared_function_info to > find them. > > Change-Id: I5d42b3c9542885a72e81613503d1d5abf51870b5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712310 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#73282} Change-Id: I616cd642379b97dff5fb0c66aeb6488e2f9b298b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744420 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#73284}
-
Ng Zhi An authored
Bug: v8:11384 Change-Id: I5efbcd661242b8c8e23225f921b9170db66d98dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2740486Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73283}
-
Z Nguyen-Huu authored
Add more items in the Locals pane representing the JS function name, source file name, and character offset within the source file, so that the user doesn’t need to dig through the shared_function_info to find them. Change-Id: I5d42b3c9542885a72e81613503d1d5abf51870b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712310 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73282}
-
Michael Lippautz authored
When objects are recorded for conservative handling and the GC is finalized conservatively, with a different stack, we rely on MarkNotFullyConstructedObjects(). In this method, the objects are initially marked, only to be forwarded to handlers that try to mark them again. Bug: chromium:1056170 Change-Id: I942e7b0ec88aae08e3fe06b7cb3ff4a86dc42f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744074 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73281}
-
Georg Neis authored
... where TF doesn't see that the property is deleted and re-added. Bug: chromium:1161847 Change-Id: I599a25fa8d29154b5bfede45f6655a1eac44a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739592 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73280}
-
Bill Budge authored
- Adds some missing types, to appease the fuzzers. Bug: chromium:1185464 Change-Id: I08c4ebe5f4ae0d036da9819b805aeac93be384fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742017 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73279}
-
Seth Brenith authored
This change relands the last part of https://crrev.com/c/2601880 . ScopeInfo has a vestigial 'length' field from when it used to be a FixedArray. This change removes that field, which saves some memory. More specifically: - Make ScopeInfo inherit from HeapObject, not FixedArrayBase which supplied the 'length' field. - Change FactoryBase::NewScopeInfo to allocate the updated object shape. It maintains the existing behavior of filling the newly-allocated object with undefined, even though that's not a valid ScopeInfo and further initialization is required. - Change a few length computations to use HeapObject::kHeaderSize rather than FixedArray::kHeaderSize. - Remove an unnecessary heap verifier function. Change-Id: I9b3980157568fdb0402fa31660949966b401fd31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2733037Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73278}
-
Michael Lippautz authored
Resize() may be used to adjust additional trailing bytes of an object. It is up to the embedder to ensure correctness in case of shrinking. Bug: chromium:1056170 Change-Id: I954df6c7440b77275cd62e4b802e8f5d39c06f9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739652 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73277}
-
Ng Zhi An authored
Bug: v8:11384 Change-Id: I230548625908512753e5d05dcf4f19c593d9cb19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739449Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73276}
-
Milad Fa authored
Change-Id: Ice30aa43344e7bd010a03c49efa9b6389193e98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742627Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73275}
-
Bill Budge authored
- arm64 aligns the frame, which guarantees an even number of return slots. Change RoundUp call to DCHECK. Bug: v8:9198 Change-Id: I9a6949b93d14109f83f09800ffe75ebba6387b04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2740481Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#73274}
-
Junliang Yan authored
Port c2a1d633 Drive-by: port code-generator-s390.cc changes Change-Id: I2090cf136d62cc9db1f17d158b88a1e58cc430d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2740341Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73273}
-
Leszek Swirski authored
Rather than doing a set lookup for each bytecode offset during iteration, rely on the fact that bytecode offsets are monotonically increasing, and store the handler offsets in a sorted array with a "next offset" cursor that the iteration can increment when a handler is found. Bug: v8:11420 Change-Id: I50e40043540d37e6c6ecb3e39a9a92c28b65e3d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742621 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73272}
-
Maya Lekova authored
Bug: chromium:1185753 Change-Id: Ic59de63d3db745356b2b3dddca0064185e5ad57b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739593 Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#73271}
-
Santiago Aboy Solanes authored
Change-Id: Ie555be4ee5c44dcd6a1b4f5a6716b7ce38213191 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742620Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73270}
-
Junliang Yan authored
Port c2a1d633 Change-Id: I2062ce41260b3e55fdcfff7e47de3aab5132d391 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739247Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73269}
-
Manos Koukoutos authored
This CL enables full csa optimization for wasm code. To take advantage of csa load elimination, it switches from Load/Store to LoadFromObject/ StoreToObject operators in the wasm compiler (where possible). Bug: v8:11510 Change-Id: Ibecd8ba81e89a76553b12ad2671ecad520e9e066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2727407Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73268}
-
Michael Lippautz authored
Reduce the granularity to 4 bytes: - Saves some memory on 32bit configurations - Allows uniformly reasoning about HoH::ObjectSize() with RoundUp<kAllocationGranularity>(sizeof(T)) Change-Id: Ic87aa25839d9b8a99916c07d64e5e49864a6cb53 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739628Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73267}
-
Marja Hölttä authored
As of https://chromium-review.googlesource.com/c/v8/v8/+/2452689 , ObjectCacheIndexMap uses IdentityMap which deals with GC gracefully. Change-Id: I6d43ee2c1e330556b0ab7e4a6c313d5b37086343 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742615Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73266}
-
Victor Gomes authored
Change-Id: Idece4925aa0ffa99bc34db39d20b24a41d59f84f Bug: v8:11421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715064Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73265}
-
Omer Katz authored
This CL adds missing locks to the PersistentRegions for (Weak)CrossThreadPersistents. To make sure no locks are missed in the future, this CL also splits PersistentRegion and introduces CrossThreadPersistentRegion that checks whether a lock is taken whenever it is accessed. Bug: chromium:1056170 Change-Id: Iaaef4a28af0f02bcb896706e9abf1ee5ad2ee1e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737299 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73264}
-
Clemens Backes authored
Before dropping a value we should validate that there is indeed a value on the stack. R=jkummerow@chromium.org Bug: chromium:1184964 Change-Id: Iec3ac061df2545717749e664b10c383765d67c9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739588Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73263}
-