Commits · e066a3667d1dc838923b4c8f4540727efe6eb807 · Linshizhi / V8

28 Nov, 2013 19 commits

Move responsibility for definition of ExtraICState bits into the ICs. · e066a366

mvstanton@chromium.org authored Nov 28, 2013

Currently it's in the Code object for some ICs and in ICs for other ICs.
This should make it easier to alter bits as needed.

2) Recover an extra bit in the code object to give us 6 bits for the extra ic state. We'll need it soon to store contextual state.

3) Cleanup code that treated StrictMode enum and ExtraICState enum as interchangeble.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/91803003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e066a366

Fix bug in inlining Function.apply. · f2351945

yangguo@chromium.org authored Nov 28, 2013

R=jkummerow@chromium.org
BUG=323942
LOG=Y

Review URL: https://codereview.chromium.org/95123003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f2351945

Fix load elimination: can only .Equals() GVN-able instructions. · bbdd21eb

titzer@chromium.org authored Nov 28, 2013

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/95193002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18133 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bbdd21eb

Cleanup in the CallStubCompiler. · bb86f024

verwaest@chromium.org authored Nov 28, 2013

BUG=
R=ishell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/91963003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bb86f024

Move more logic from AST to oracle, pt 2 · b974978e

rossberg@chromium.org authored Nov 28, 2013

(More to follow)

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/95163002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18130 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b974978e

Ensure that length is Smi in TypedArrayFromArrayLike constructor. · 73725966

dslomov@chromium.org authored Nov 28, 2013

R=jkummerow@chromium.org
BUG=324028
LOG=Y

Review URL: https://codereview.chromium.org/94473002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

73725966

Undeprecate Persistent::ClearAndLeak · 52649593

jochen@chromium.org authored Nov 28, 2013

We depend on this in blink, and won't be able to replace it in
the near future

R=svenpanne@google.com, svenpanne@chromium.org
BUG=none
LOG=n

Review URL: https://codereview.chromium.org/95003004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18128 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

52649593

Swap cp and pp registers on Arm such for work on OOL Constant Pool. · adbcede1

rmcilroy@chromium.org authored Nov 28, 2013

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/94723002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18127 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

adbcede1

Fix quickcheck make target. · 35160020

machenbach@chromium.org authored Nov 28, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/95073002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

35160020

Use the HandlerFrontendHeader in most call compilers. · bbef8af1

verwaest@chromium.org authored Nov 28, 2013

R=ishell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/83753002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bbef8af1

Fix allocation memento bookeeping code for js arrays. · 0e95ffdd

hpayer@chromium.org authored Nov 28, 2013

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/95053002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18124 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0e95ffdd

Prepare push to trunk. Now working on version 3.23.15. · 7b924a32

machenbach@chromium.org authored Nov 28, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/95033002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b924a32

Add fast make and test all target. · 59ff4ec6

machenbach@chromium.org authored Nov 28, 2013

The new target called "quickcheck" builds and tests with several configurations using recent test runner speed improvements.

Runtime from scratch (after make clean): < 8 min
Runtime tests only: < 3 min

TEST=make quickcheck
R=jkummerow@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/94703002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18120 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

59ff4ec6

Move more type collection logic from AST to oracle. · 5532af44

rossberg@chromium.org authored Nov 28, 2013

(More to come in follow-up CL.)

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/91863003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18119 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5532af44

ARM: Optimize fixed double arguments · 843fca16

m.m.capewell@googlemail.com authored Nov 28, 2013

Optimize fixed double arguments to arithmetic Lithium instructions.

TEST=none
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/91113003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

843fca16

Added tracing support for pretenuring. · 0213fc90

hpayer@chromium.org authored Nov 28, 2013

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/94493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0213fc90

Fix missing bounds check in n-arguments Array constructor. · d53e3877

mstarzinger@chromium.org authored Nov 28, 2013

LOG=N
R=mvstanton@chromium.org
BUG=v8:3027
TEST=mjsunit/regress/regress-3027

Review URL: https://codereview.chromium.org/92103003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18116 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d53e3877

Shorten autogenerated error message. · ea43173c

yangguo@chromium.org authored Nov 28, 2013

R=rossberg@chromium.org
BUG=v8:3019
LOG=Y

Review URL: https://codereview.chromium.org/88393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18115 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea43173c

Mark deprecated APIs with relatively little use as deprecated · c1da40c0

jochen@chromium.org authored Nov 28, 2013

BUG=none
R=svenpanne@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/91503002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18114 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c1da40c0

27 Nov, 2013 11 commits

Harmony promises · e943623b

rossberg@chromium.org authored Nov 27, 2013

Based on prototype at

https://github.com/rossberg-chromium/js-promise

which informed the latest spec draft version at

https://github.com/domenic/promises-unwrapping/blob/master/README.md

Activated by --harmony-promises.

Feature complete with respect to the draft spec, plus the addition of .when and .deferred methods. Final naming and other possible deviations from the current draft will hopefully be resolved soon after the next TC39 meeting.

This CL also generalises the Object.observe delivery loop into a simplistic microtask loop. Currently, all observer events are delivered before invoking any promise handler in a single fixpoint iteration. It's not clear yet what the final semantics is supposed to be (should there be a global event ordering?), but it will probably require a more thorough event loop abstraction inside V8 once we get there.

R=dslomov@chromium.org, yhirano@chromium.org
BUG=

Review URL: https://codereview.chromium.org/64223010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e943623b

Prepare push to trunk. Now working on version 3.23.14. · 8903dcba

machenbach@chromium.org authored Nov 27, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/91763002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8903dcba

ARM/MIPS compilation error. · d18a103e

mvstanton@chromium.org authored Nov 27, 2013

Due to an error during platform porting.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/91583002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18106 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d18a103e

The goal is to discover the appropriate heap space for objects created in full · f3a22f96

mvstanton@chromium.org authored Nov 27, 2013

code. By the time we optimize the code, we'll be able to decide on new or old
space based on the number of surviving objects after one or more gcs.

The mechanism is a "memento" placed behind objects in the heap. It's currently
done for array and object literals, with plans to use mementos for constructed
objects as well (in a later CL).

The feature is behind the flag allocation_site_pretenuring, currently off.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/40063002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18104 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f3a22f96

Remove the strict-mode flag from store handlers. It's only relevant to the IC stub. · 50a4bb50

verwaest@chromium.org authored Nov 27, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/91413003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18103 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50a4bb50

Avoid trying to decode the raw inline constant which is part of the aged code prologue. · 49627050

rmcilroy@chromium.org authored Nov 27, 2013

BUG=v8:3007
LOG=N
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/88303003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18097 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

49627050

Add ES specification reference to DateNow. · 52587635

yangguo@chromium.org authored Nov 27, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/89353002

Patch from Victor Costan <costan@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

52587635

Split Persistent into Persistent and UniquePersistent · 89fb55c4

dcarney@chromium.org authored Nov 27, 2013

R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/88013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18093 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

89fb55c4

Avoid useless #ifdef DEBUG checks for the --trace-ic flag. · a02ef8ff

bmeurer@chromium.org authored Nov 27, 2013

FLAG_trace_ic is constant false in non-DEBUG builds anyways.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/91003002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a02ef8ff

Provide "freeBuffer()" primitive for testing under ASan. · f7927265

dslomov@chromium.org authored Nov 27, 2013

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/85883002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18091 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f7927265

Avoid copying flow-sensitive state when only a goto separates blocks. · ddb4ad85

titzer@chromium.org authored Nov 27, 2013

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/48353007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18090 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ddb4ad85

26 Nov, 2013 10 commits

MIPS: Optimize Integer32ToSmi. · b558a10c

palfia@homejinni.com authored Nov 26, 2013

Port r18084 (426bc19)

Original commit message:
Optimize register constraints and code generated for Integer32ToSmi Lithium
instruction.

TEST=none
BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/88623004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18089 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b558a10c

Increase test runner speed. · c95173b2

machenbach@chromium.org authored Nov 26, 2013

Let the test runner preserve the order of test suites to let suites with long running tests run first.

Mark some tests as slow that can now be skipped via --slow-tests=skip.

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/88343002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18086 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c95173b2

Make optimized debug builds compile with all optimizations. · 0dd03f7c

machenbach@chromium.org authored Nov 26, 2013

This results in a speed-up of around 30% on all architectures. For local developer builds only. The bots will continue to use level 1 for now.

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/88563002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18085 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0dd03f7c

ARM: Optimize Integer32ToSmi · f6a5a262

m.m.capewell@googlemail.com authored Nov 26, 2013

Optimize register constraints and code generated for Integer32ToSmi Lithium
instruction.

TEST=none
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/88383002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18084 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f6a5a262

Increase precision for base conversion for large integers. · ab966311

yangguo@chromium.org authored Nov 26, 2013

R=jkummerow@chromium.org
BUG=v8:3025
LOG=Y

Review URL: https://codereview.chromium.org/88583002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18082 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ab966311

Flatten cons string for single character substrings. · 4240cd25

yangguo@chromium.org authored Nov 26, 2013

For substrings of non-flat cons strings, we bail out
to runtime. For single character substrings, we forget
to flatten it. This causes successive bailouts.

R=bmeurer@chromium.org
BUG=323041
LOG=Y

Review URL: https://codereview.chromium.org/88173002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4240cd25

Removed dead ceiling function. · 57a0c1fe

svenpanne@chromium.org authored Nov 26, 2013

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/88133002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

57a0c1fe

Range info propagation through HBoundsCheck. · f951a2e8

ishell@chromium.org authored Nov 26, 2013

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/86233002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f951a2e8

Prepare push to trunk. Now working on version 3.23.13. · f4c28204

machenbach@chromium.org authored Nov 26, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/88363002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18075 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f4c28204

Implement Math.ceil via Math.floor. · afdf6156

svenpanne@chromium.org authored Nov 26, 2013

This way we get all the Crankshaft goodness and avoid always going
through the runtime: Less code + even some small speedup in Kraken.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/88053002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18072 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

afdf6156