- 19 Oct, 2015 27 commits
-
-
cbruni authored
Separately collect element keys from property keys to avoid slow corner-cases. Partly deal with keys generated by Proxies. BUG=chromium:536790 LOG=N Review URL: https://codereview.chromium.org/1397063002 Cr-Commit-Position: refs/heads/master@{#31378}
-
mstarzinger authored
This adds a test case that ensures calling Debug.scripts without any listener attached fails gracefully. For now we are throwing the string "illegal access", this might change in the future to be a dedicated exception. R=yangguo@chromium.org TEST=mjsunit/debug-scripts-throw Review URL: https://codereview.chromium.org/1411193002 Cr-Commit-Position: refs/heads/master@{#31377}
-
machenbach authored
Fix after https://codereview.chromium.org/1413023002/ BUG=chromium:535160 LOG=n NOTRY=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1411973003 Cr-Commit-Position: refs/heads/master@{#31376}
-
bmeurer authored
This fixes a small inconsistency when the accessor is on a prototype, because the property access has to respect the holder (and not always go to the receiver unconditionally). R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1409273005 Cr-Commit-Position: refs/heads/master@{#31375}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#31374}
-
machenbach authored
Revert of Always give class literals a block scope (patchset #2 id:20001 of https://codereview.chromium.org/1413903002/ ) Reason for revert: [Sheriff] Breaks vector stores: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%20vector%20stores/builds/536 Original issue's description: > Always give class literals a block scope > > Class methods always have the class scope on their scope chain in order > to implement strong mode checks. Previously, that scope wasn't attached > to the ClassLiteral for anonymous classes (since the scope contained > no bindings). > > This patch simply puts that same scope on the ClassLiteral, anonymous > or not, which simplifies other code that needs to reason about the scope > of a class and its methods. > > Committed: https://crrev.com/cf13dda1ba25e8293ea143f33c6c5f6233a39c86 > Cr-Commit-Position: refs/heads/master@{#31371} TBR=mstarzinger@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1416583002 Cr-Commit-Position: refs/heads/master@{#31373}
-
jarin authored
Review URL: https://codereview.chromium.org/1412153002 Cr-Commit-Position: refs/heads/master@{#31372}
-
adamk authored
Class methods always have the class scope on their scope chain in order to implement strong mode checks. Previously, that scope wasn't attached to the ClassLiteral for anonymous classes (since the scope contained no bindings). This patch simply puts that same scope on the ClassLiteral, anonymous or not, which simplifies other code that needs to reason about the scope of a class and its methods. Review URL: https://codereview.chromium.org/1413903002 Cr-Commit-Position: refs/heads/master@{#31371}
-
machenbach authored
BUG=chromium:535160 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1411213002 Cr-Commit-Position: refs/heads/master@{#31370}
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1411693004 Cr-Commit-Position: refs/heads/master@{#31369}
-
hablich authored
LOG=N R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1415533004 Cr-Commit-Position: refs/heads/master@{#31368}
-
machenbach authored
BUG=v8:4499 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1411203003 Cr-Commit-Position: refs/heads/master@{#31367}
-
rmcilroy authored
Adds support for throwing exceptions. Adds the bytecode Throw. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1410863002 Cr-Commit-Position: refs/heads/master@{#31366}
-
bmeurer authored
This adds support to also optimize loads from special JSObject field accessors, like String::length and JSArray::length. R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1417503002 Cr-Commit-Position: refs/heads/master@{#31365}
-
machenbach authored
BUG=v8:4499 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1411933003 Cr-Commit-Position: refs/heads/master@{#31364}
-
machenbach authored
Depends on https://codereview.chromium.org/1413023002/ BUG=chromium:535160 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1414713002 Cr-Commit-Position: refs/heads/master@{#31363}
-
mvstanton authored
The dispatcher failed to MISS properly when configured as a monomorphic keyed string store, causing a crash. BUG=v8:4495 LOG=N R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1415533003 Cr-Commit-Position: refs/heads/master@{#31362}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#31361}
-
machenbach authored
The test suite is ran in 60% of the bots anyway and the step is very short. For swarming, it's better to run this together in one step as each step triggers a different bot. BUG=chromium:535160 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1413023002 Cr-Commit-Position: refs/heads/master@{#31360}
-
machenbach authored
BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1411143002 Cr-Commit-Position: refs/heads/master@{#31359}
-
bmeurer authored
Use %_ToLength for TO_LENGTH, implemented via a ToLengthStub that supports a fast path for small integers. Everything else is still handled in the runtime. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel BUG=v8:4494 LOG=n Review URL: https://codereview.chromium.org/1412963002 Cr-Commit-Position: refs/heads/master@{#31358}
-
verwaest authored
[IC] Ensure we don't transition receivers when there's a data property in the hidden prototype chain. BUG=chromium:542647 R=cbruni@chromium.org LOG=n Review URL: https://codereview.chromium.org/1406873002 Cr-Commit-Position: refs/heads/master@{#31357}
-
bmeurer authored
R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1410353002 Cr-Commit-Position: refs/heads/master@{#31356}
-
mstarzinger authored
This removes all locally constructed SimplifiedOperatorBuilder instances and uses the one passed along the JSGraph. It ensures that the correct zone is used to allocate operators, no matter where the reducer is used. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1410003002 Cr-Commit-Position: refs/heads/master@{#31355}
-
bmeurer authored
The typer can infer true/false for ObjectIsSmi if the argument has a fixed/known representation (i.e. is either known to be smi or heap object). R=jarin@chromium.org Review URL: https://codereview.chromium.org/1412673003 Cr-Commit-Position: refs/heads/master@{#31354}
-
jarin authored
This introduces an explicit lazy bailout. It is wrapped in the call node, mostly because the lazy deoptimization processing is married to the call processing in the instruction selector and the code generator. It is still a terrible hack. R=bmeurer@chromium.org,mstarzinger@chromium.org BUG=chromium:543994,v8:4195 LOG=n Review URL: https://codereview.chromium.org/1412443003 Cr-Commit-Position: refs/heads/master@{#31353}
-
bmeurer authored
Native context specialization now lowers monomorphic and polymorphic accesses to data and constant data properties on object and/or prototype chain. We don't deal with accessors yet, and we also completely ignore proxies (which is compatible with what Crankshaft does). The code is more or less the straightforward implementation. We will need to refactor that and extract common patterns once the remaining bits for full load/store support is in. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/3a0bf860b7177f7abef01ff308a53603389d958e Cr-Commit-Position: refs/heads/master@{#31340} Review URL: https://codereview.chromium.org/1396333010 Cr-Commit-Position: refs/heads/master@{#31352}
-
- 18 Oct, 2015 4 commits
-
-
alph authored
BUG=v8:4406 LOG=N Review URL: https://codereview.chromium.org/1406293003 Cr-Commit-Position: refs/heads/master@{#31351}
-
alph authored
BUG=v8:4406 LOG=N Review URL: https://codereview.chromium.org/1411023002 Cr-Commit-Position: refs/heads/master@{#31350}
-
alph authored
BUG=v8:4406 LOG=N Review URL: https://codereview.chromium.org/1411743003 Cr-Commit-Position: refs/heads/master@{#31349}
-
alph authored
BUG=v8:4406 LOG=N Review URL: https://codereview.chromium.org/1406353003 Cr-Commit-Position: refs/heads/master@{#31348}
-
- 17 Oct, 2015 1 commit
-
-
jarin authored
Removes a branch that checks for a condition that has been checked on dominators of the branch. This introduces a new reducer that propagates the list of checked conditions (and their boolean values) through the control flow graph. If it encounters a branch checking a condition with a known value, the branch is eliminated. The analysis relies on loops being reducible: if a condition has been checked on all paths to loop entry, then it is checked in the loop (regardless what of the conditions checked inside the loop). The implementation is fairly naive and could be improved: - all the operation on the condition lists could be made allocation-free when revisited. - we could try to use a map structure rather than a linked list (to make lookups faster). - the merging of control flow could be changed to take into account conditions from non-dominating paths (as long as all paths check the condition). Review URL: https://codereview.chromium.org/1376293005 Cr-Commit-Position: refs/heads/master@{#31347}
-
- 16 Oct, 2015 8 commits
-
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1409143002 Cr-Commit-Position: refs/heads/master@{#31346}
-
rmcilroy authored
Adds support for creating RegExp literals and adds some tests. Adds the CreateRegExpLiteral bytecode. BUG=v8:4280 LOG=N TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1410853002 Cr-Commit-Position: refs/heads/master@{#31345}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1411713004 Cr-Commit-Position: refs/heads/master@{#31344}
-
rmcilroy authored
Adds support for local context loads and stores. Also adds support for creation of new block contexts (e.g., for let variables) and initializing const / let variables with the hole appropriately. Also adds some checks to ensure BytecodeArrayBuilder::context_count is set appropriately and fixes tests to do so. Adds the bytecode StaContextSlot. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1403943004 Cr-Commit-Position: refs/heads/master@{#31343}
-
rmcilroy authored
Adds basic support for iterating interpreter stack frames for GC. Currently InterpreterStackFrames are treated just like JavaScriptStackFrames since the JavaScriptFrame::IterateExpressions() will correctly iterate over all the local / temp interpeter Registers, and will iterate over the interpreter_entry_trampoline pc address. There is no need to explicitly iterate over the BytecodeArray object since that is held in a machine register in the bytecode handler which is marked as kMachTaggedAny by TurboFan, and so will get iterated appropriately when iterating the bytecode handler stub's stack frame. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1407513003 Cr-Commit-Position: refs/heads/master@{#31342}
-
jarin authored
Revert of [turbofan] Initial support for monomorphic/polymorphic property loads. (patchset #3 id:100001 of https://codereview.chromium.org/1396333010/ ) Reason for revert: Waterfall redness. Original issue's description: > [turbofan] Initial support for monomorphic/polymorphic property loads. > > Native context specialization now lowers monomorphic and > polymorphic accesses to data and constant data properties on > object and/or prototype chain. We don't deal with accessors > yet, and we also completely ignore proxies (which is compatible > with what Crankshaft does). > > The code is more or less the straightforward implementation. We > will need to refactor that and extract common patterns once the > remaining bits for full load/store support is in. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel > R=jarin@chromium.org > BUG=v8:4470 > LOG=n > > Committed: https://crrev.com/3a0bf860b7177f7abef01ff308a53603389d958e > Cr-Commit-Position: refs/heads/master@{#31340} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470 Review URL: https://codereview.chromium.org/1408123002 Cr-Commit-Position: refs/heads/master@{#31341}
-
bmeurer authored
Native context specialization now lowers monomorphic and polymorphic accesses to data and constant data properties on object and/or prototype chain. We don't deal with accessors yet, and we also completely ignore proxies (which is compatible with what Crankshaft does). The code is more or less the straightforward implementation. We will need to refactor that and extract common patterns once the remaining bits for full load/store support is in. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1396333010 Cr-Commit-Position: refs/heads/master@{#31340}
-
rmcilroy authored
Adds the bytecode StaGlobalStrict and replaces StaGlobal with StaGlobalSloppy. BUG=v8:4280 LOG=N TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1406183002 Cr-Commit-Position: refs/heads/master@{#31339}
-