- 15 Feb, 2018 1 commit
-
-
Toon Verwaest authored
instance_class_name takes up space unnecessarily, and %_ClassOf and class_name implement [[Class]] which isn't part of ES2015+ anymore. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3a73f732ad83a616817fde9992f4e4d584638fa8 Reviewed-on: https://chromium-review.googlesource.com/776683Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#51309}
-
- 25 Oct, 2016 1 commit
-
-
cbruni authored
Object.create(null) is most likely to be used for dictionary-like objects. Hence it would be beneficial to directly create a slow-mode object and avoid additional overhead later-on. BUG= Review-Url: https://codereview.chromium.org/2430273007 Cr-Commit-Position: refs/heads/master@{#40551}
-
- 20 May, 2016 1 commit
-
-
yangguo authored
R=jochen@chromium.org, verwaest@chromium.org Review-Url: https://codereview.chromium.org/1922603006 Cr-Commit-Position: refs/heads/master@{#36392}
-
- 05 Apr, 2016 1 commit
-
-
cbruni authored
BUG=v8:4882 LOG=n Review URL: https://codereview.chromium.org/1863543002 Cr-Commit-Position: refs/heads/master@{#35255}
-
- 11 Mar, 2016 1 commit
-
-
adamk authored
ES2015 Object.prototype.toString semantics were enabled in version 4.9, which has been in stable Chrome for nearly two weeks at this point. R=littledan@chromium.org Review URL: https://codereview.chromium.org/1784033002 Cr-Commit-Position: refs/heads/master@{#34732}
-
- 11 Feb, 2016 1 commit
-
-
mvstanton authored
BUG= Committed: https://crrev.com/5833e8e8a437cd66405784263ccc45e73470fd42 Cr-Commit-Position: refs/heads/master@{#33870} Review URL: https://codereview.chromium.org/1683043003 Cr-Commit-Position: refs/heads/master@{#33890}
-
- 10 Feb, 2016 2 commits
-
-
machenbach authored
Revert of Implement symbol @@hasInstance for ES6 instanceof support. (patchset #2 id:20001 of https://codereview.chromium.org/1683043003/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/1382/ Original issue's description: > Implement symbol @@hasInstance for ES6 instanceof support. > > BUG= > > Committed: https://crrev.com/5833e8e8a437cd66405784263ccc45e73470fd42 > Cr-Commit-Position: refs/heads/master@{#33870} TBR=bmeurer@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1686123002 Cr-Commit-Position: refs/heads/master@{#33871}
-
mvstanton authored
BUG= Review URL: https://codereview.chromium.org/1683043003 Cr-Commit-Position: refs/heads/master@{#33870}
-
- 02 Dec, 2015 2 commits
-
-
yangguo authored
R=bmeurer@chromium.org BUG=v8:4581 LOG=N Review URL: https://codereview.chromium.org/1495473002 Cr-Commit-Position: refs/heads/master@{#32494}
-
bmeurer authored
Sanitize ConstructStub handling and add a test case to ensure that the Symbol constructor is using the correct context. R=jarin@chromium.org BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1489323002 Cr-Commit-Position: refs/heads/master@{#32491}
-
- 27 Oct, 2015 1 commit
-
-
littledan authored
When == is invoked on a Symbol or SIMD vector and an object, the object should be converted to a primitive with ToPrimitive and then compared again. This means, for example, that for a Symbol or SIMD vector s, s == Object(s). This patch makes that change in the implementation of ==. Only the runtime function needed to be changed, as the code stubs and compiler specializations don't operate on Symbols or SIMD vectors, and on these types, a fallback to the runtime function is always used. BUG=v8:3593 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1421413002 Cr-Commit-Position: refs/heads/master@{#31614}
-
- 06 May, 2015 1 commit
-
-
conradw authored
https://codereview.chromium.org/1125783002 did not handle all cases for some architectures. These cases are now covered, and tests have been extended to check them. BUG=v8:4073 LOG=N Review URL: https://codereview.chromium.org/1128143002 Cr-Commit-Position: refs/heads/master@{#28266}
-
- 05 May, 2015 1 commit
-
-
arv authored
When comparing a symbol to istself using <, <=, > or >= we need to throw a TypeError. This is correctly handled in the runtime function so if we are comparing a symbol fall back to use the runtime. BUG=v8:4073 LOG=Y R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1125783002 Cr-Commit-Position: refs/heads/master@{#28226}
-
- 18 Mar, 2015 1 commit
-
-
rossberg authored
R=dslomov@chromium.org BUG=460083,v8:3970,v8:3971 LOG=Y Review URL: https://codereview.chromium.org/1018923002 Cr-Commit-Position: refs/heads/master@{#27272}
-
- 21 Oct, 2014 1 commit
-
-
dslomov@chromium.org authored
Updates Object.prototype.toString() to use algorithm described in harmony drafts. Currently, the behaviour is essentially the same as ES262's version, however this changes when internal structures such as Promise make use of symbolToStringTag (as they are supposed to, see v8:3241), and changes further once Symbol.toStringTag is exposed publicly. BUG=v8:3241, v8:3502 LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/546803003 Patch from Caitlin Potter <caitpotter88@gmail.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Oct, 2014 1 commit
-
-
dslomov@chromium.org authored
BUG=v8:3443 LOG=Y R=arv@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/613283002 Patch from Caitlin Potter <caitpotter88@gmail.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24638 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Sep, 2014 1 commit
-
-
arv@chromium.org authored
Using String as a function and passing a symbol should return the same value as if Symbol.prototype.toString was called. http://people.mozilla.org/~jorendorff/es6-draft.html#sec-string-constructor-string-value BUG=v8:3554 LOG=Y R=rossberg@chromium.org, rossberg Review URL: https://codereview.chromium.org/564863002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23923 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Aug, 2014 1 commit
-
-
dslomov@chromium.org authored
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-tonumber Based on patch from caitp <caitpotter88@gmail.com> https://codereview.chromium.org/454233002/ BUG=v8:3499 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/458753004 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23057 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Aug, 2014 1 commit
-
-
rossberg@chromium.org authored
R=yangguo@chromium.org BUG=v8:3401 LOG=Y Review URL: https://codereview.chromium.org/455743002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22994 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Aug, 2014 1 commit
-
-
rossberg@chromium.org authored
Also, add some bits missing from turn-on-symbols CL R=adamk@chromium.org, dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/441943002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22910 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Aug, 2014 1 commit
-
-
adamk@chromium.org authored
In doing so also remove all references to the --harmony-collections flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default. Depends on ES6 Symbols: https://codereview.chromium.org/421313004 BUG=v8:1622 LOG=Y R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/427723002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
adamk@chromium.org authored
In doing so also remove all references to the --harmony-symbols flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default. BUG=v8:2158 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/421313004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jul, 2014 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG=v8:3442 LOG=Y Review URL: https://codereview.chromium.org/389263003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22426 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2014 3 commits
-
-
rossberg@chromium.org authored
Second try; implementation that doesn't rely on external arrays. R=mstarzinger@chromium.org BUG=v8:3440 Review URL: https://codereview.chromium.org/391713002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22378 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
TBR=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/394443002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22373 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG=v8:3440 LOG=Y Review URL: https://codereview.chromium.org/391683002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22370 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 May, 2014 1 commit
-
-
rossberg@chromium.org authored
R=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/286133002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21344 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 May, 2014 1 commit
-
-
rossberg@chromium.org authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/266243003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 1 commit
-
-
jochen@chromium.org authored
> R=mstarzinger@chromium.org > BUG= > > Committed: https://code.google.com/p/v8/source/detail?r=20211 > > Review URL: https://codereview.chromium.org/206163004 R=rossberg@chromium.org TBR=rossberg@chromium.org LOG=y BUG=n Review URL: https://codereview.chromium.org/219303002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20353 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20211 Review URL: https://codereview.chromium.org/206163004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20313 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
Reason: breaks Blink layout tests. R=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/210853003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20233 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Mar, 2014 2 commits
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/206163004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
R=arv@chromium.org, mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/208423013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Mar, 2014 3 commits
-
-
rossberg@chromium.org authored
Only change relative to original CL is the updated assertion condition at objects-inl.h:2119 R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/204913006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
TBR=yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/204353004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org, arv@chromium.org BUG= LOG=Y Review URL: https://codereview.chromium.org/203243004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
Split collections flag into weak and non-weak. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/201593004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20019 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Feb, 2014 1 commit
-
-
rossberg@chromium.org authored
Refresh the implementation of Symbols to catch up with what the specification now mandates: * The global Symbol() function manufactures new Symbol values, optionally with a string description attached. * Invoking Symbol() as a constructor will now throw. * ToString() over Symbol values still throws, and Object.prototype.toString() stringifies like before. * A Symbol value is wrapped in a Symbol object either implicitly if it is the receiver, or explicitly done via Object(symbolValue) or (new Object(symbolValue).) * The Symbol.prototype.toString() method no longer throws on Symbol wrapper objects (nor Symbol values.) Ditto for Symbol.prototype.valueOf(). * Symbol.prototype.toString() stringifies as "Symbol("<description>"), valueOf() returns the wrapper's Symbol value. * ToPrimitive() over Symbol wrapper objects now throws. Overall, this provides a stricter separation between Symbol values and wrapper objects than before, and the explicit fetching out of the description (nee name) via the "name" property is no longer supported (by the spec nor the implementation.) Adjusted existing Symbol test files to fit current, adding some extra tests for new/changed behavior. LOG=N R=arv@chromium.org, rossberg@chromium.org, arv, rossberg BUG=v8:3053 Review URL: https://codereview.chromium.org/118553003 Patch from Sigbjorn Finne <sigbjornf@opera.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19490 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Jan, 2014 1 commit
-
-
rossberg@chromium.org authored
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-object.getownpropertysymbols This allows you to get the symbols used as property keys for an object. var object = {}; var sym = Symbol(); object[sym] = 42; assert(Object.getOwnPropertySymbols(object)[0] === sym); This is only available with --harmony-symbols BUG=v8:3049 R=rossberg@chromium.org, rossberg LOG=Y Review URL: https://codereview.chromium.org/108083005 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Nov, 2013 1 commit
-
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/85163003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18070 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-