- 12 Jul, 2018 14 commits
-
-
Dan Elphick authored
Uses Heap::FromWritableHeapObject where the object must be mutable and otherwise pass Isolate in. String and subclasses should now be free of GetIsolate/GetHeap. Bug: v8:7786 Change-Id: Ic9d55250ea4afebbebda87be9415ccdaa4fc8779 Reviewed-on: https://chromium-review.googlesource.com/1131736Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54395}
-
Dan Elphick authored
Happily this also removes a use of GetIsolate(). Also delete Descriptor::Init which is no longer needed and some friend declarations. Bug: v8:7786 Change-Id: Ica803ef6c8963b38aef72121ff4fb737c9780920 Reviewed-on: https://chromium-review.googlesource.com/1133982Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54394}
-
Andreas Haas authored
This is the first CL to refactor WebAssembly.instantiateStreaming to make it spec compliant again. The design doc where the whole change is discussed is available in the tracking bug. The tracking bug also references prototype implementations of the whole change, which includes the changes in this CL. Tests for the new API functions will be added with the second V8 CL which adds the implementation of the API functions. R=ulan@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia1048b7ca0291c824ef4212ebde2c6054e102069 Reviewed-on: https://chromium-review.googlesource.com/1127667Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54393}
-
Clemens Hammacher authored
On {Isolate::PrintStack}, we currently only print the pc offset for wasm compiled frame. This CL changes this to also print the absolute PC. R=ahaas@chromium.org Change-Id: Ic72b7ad140ef74d2f284fdd8827b858cc78cf1c0 Reviewed-on: https://chromium-review.googlesource.com/1133985 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54392}
-
Michael Lippautz authored
Preserve flags for GC finalization triggered by EmbedderHeapTracer. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie3d039bc1b69771ce9830dddb5e4d4375581981f Reviewed-on: https://chromium-review.googlesource.com/1134766Reviewed-by:
-
Dan Elphick authored
Converts the Shape functions IsKey and IsLive to take ReadOnlyRoots rather Isolate. This allows HashTableBase::FindEntry and ObjectHashTableBase::Lookup to also take ReadOnlyRoots rather than Isolate. Bug: v8:7786 Change-Id: I37efea1d20139f394d6365569438755cb8fc44c4 Reviewed-on: https://chromium-review.googlesource.com/1133391Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:842083 Change-Id: Idc04f9ddea326df4ac48a8c58321620660b21549 Reviewed-on: https://chromium-review.googlesource.com/1129520Reviewed-by:
-
Hannes Payer authored
Bug: chromium:842083 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a8d8327bfbab95cf9bdddb096804b65270cdfed Reviewed-on: https://chromium-review.googlesource.com/1127944 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Dan Elphick authored
Bug: v8:7786 Change-Id: Ifb866cbb2d02f1231b3706358930e0ace54b0db0 Reviewed-on: https://chromium-review.googlesource.com/1133158Reviewed-by:
-
John Barboza authored
Change-Id: I60aed7bf8207703fa6ceddb6165e173e68b5ff5f Reviewed-on: https://chromium-review.googlesource.com/1103533 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54386}
-
Hannes Payer authored
Bug: chromium:842083 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b3f60526718f782b075bd450282646d97f6f9b5 Reviewed-on: https://chromium-review.googlesource.com/1131124Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54385}
-
Dominik Inführ authored
Was only used when concurrent marking was disabled at compile-time. Change-Id: I3977a2cbcfb27e527b2bca4b49887558595c4215 Reviewed-on: https://chromium-review.googlesource.com/1128959Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/11ac8d7..6ff84ae Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/345d332..39de3d2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c3975e5..32e3d1e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4a57a4ebfa818a19e9057d4c3746087acaf89645 Reviewed-on: https://chromium-review.googlesource.com/1134593 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54383}
-
Frank Tang authored
R=bstell@chromium.org, cira@chromium.org, yangguo@chromium.org Bug: v8:7869 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia7176016ecd6da317b3b0eb7af7bf482f99c8129 Reviewed-on: https://chromium-review.googlesource.com/1121657Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#54382}
-
- 11 Jul, 2018 12 commits
-
-
Brian Stell authored
No change in functionality, this only changes spelling. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8dad2315288e82b23782545b050e9502d0320de5 Reviewed-on: https://chromium-review.googlesource.com/1133679Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#54381}
-
Leszek Swirski authored
Move some of PreParsedScopeData's santity checks, such as the magic value separating skippable function data from scope data, to be debug only, to save memory. Start position of inner skippable functions is still kept, because it's too good at catching bugs, but we may want to remove it in the future as well. Relanding unchanged after the (unrelated) flake it exposed is fixed in: https://chromium-review.googlesource.com/1131503 Bug: chromium:818642 Change-Id: Id1d9fe757875cd05ea9a92b41e7256c3ee86fc8e Reviewed-on: https://chromium-review.googlesource.com/1131505 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54380}
-
Leszek Swirski authored
A module's exported variables are assigned a cell index based on their order in the exported variable map. This map is keyed by the variable name, an AstRawString*. Unfortunately, these string pointers are not guaranteed to increase monotonically as variables are encountered, which means that this map isn't stable across parses. In particular, it can cause failures for setVariableValue if the parser is unlucky. This patch adds a custom comparator to these AstRawString* keyed maps, which is stable across parses. Change-Id: Ie6e88fc2d252d873de661d7fc5278feba3955727 Reviewed-on: https://chromium-review.googlesource.com/1131503Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54379}
-
Michael Lippautz authored
Allows embedders using the EmbedderHeapTracer to synchronously finalize an already running garbage collection Bug: chromium:843903 Tbr: ulan@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iea01451ea2c1204c34dc7904732abae6b63e1704 Reviewed-on: https://chromium-review.googlesource.com/1128971 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9b4b413..11ac8d7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0c92958..345d332 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2024df9..e9cc24f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie9af862f1196d6f2ee2d7b12264c171ae715fd07 Reviewed-on: https://chromium-review.googlesource.com/1133119Reviewed-by:
-
Jungshik Shin authored
See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 for ICU changes. Fix tests for ICU 61/Unicode 11/CLDR 33.1 * Update mjsunit/harmony/regexp-property-script-extensions.js per ScriptExtensions.txt in Unicode 11 * Update mjsunit/intl-numberformat-formattoparts.js for CLDR 33.1 * Mark an invalid Mozilla test (Georgian uppercasing) * Fix currency format test (U+00A0 instead of U+0020) * Enable Script_Extensions tests (test262) * Add support for Extended_Pictographic in regex Ref. https://github.com/tc39/ecma262/issues/1219. Bug: chromium:850334, v8:7825 Test: intl/*, test262/intl402/* Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I146080cdc1164db4a71f484918723cf302666df8 Reviewed-on: https://chromium-review.googlesource.com/1111857Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54376}
-
Michael Achenbach authored
This reverts commit 5b744bfb. Reason for revert: Breaks node.js install: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20node.js%20integration/1546 Original change's description: > Fix and extend lldbinit > > 1) Define all commands in one file. > 2) Add logic to make 'jco' print current pc by default. > 3) Add a comment to explain how to load the lldb_commands.py file. > 4) Minor refactorings. > > R=ahaas@chromium.org > No-Try: true > > Bug: v8:7754 > Change-Id: I553f2ce4cefedad05466c692a8665a570372b76a > Reviewed-on: https://chromium-review.googlesource.com/1127892 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54329} TBR=ahaas@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7754 Change-Id: Iecaaf53ce6536395f83a78046f0375ec77003356 Reviewed-on: https://chromium-review.googlesource.com/1132878Reviewed-by:
-
Leszek Swirski authored
Make PreParsedScopeData a new array-like instance type, which holds its child data inline, rather than indirecting to a FixedArray. Should save one map word per PreParsedScopeData. Reland of https://chromium-review.googlesource.com/1127055, adding padding clearing to keep MSAN happy. TBR=jarin@chromium.org,marja@chromium.org,ulan@chromium.org Bug: chromium:818642 Change-Id: I536db452047959e75d5116ddded4f511d05a04d9 Reviewed-on: https://chromium-review.googlesource.com/1131512Reviewed-by:
-
Dan Elphick authored
Removes GetHeap/GetIsolate from FixedArray::Shrink and FixedArray::SetAndGrow. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8db2680f5ef69e901383e0b2cb60198c1b8dd316 Reviewed-on: https://chromium-review.googlesource.com/1131184Reviewed-by:
-
Sathya Gunasekaran authored
To help with reviewing and porting intl.js Bug: v8:5751 Change-Id: Ic8ad425e7ff14ed39ff28e907f9d1e83a3629398 Reviewed-on: https://chromium-review.googlesource.com/1132821 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: If2670e2b8e64a34f5de7855615e2288b6f2f3133 Reviewed-on: https://chromium-review.googlesource.com/1131193 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54371}
-
Bill Budge authored
- Uses a different technique to do the multiplies, saving one instruction and one temporary register on SSE and AVX. ug: v8:6020 Change-Id: I4f3ff6186dae5eb10d90cda31c7d16b651a00d7e Reviewed-on: https://chromium-review.googlesource.com/1132522Reviewed-by:
Jing Bao <jing.bao@intel.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54370}
-
- 10 Jul, 2018 14 commits
-
-
Aseem Garg authored
This is a reland of 5301cdc3 Original change's description: > [wasm] add 64 bit atomic ops to interpreter > > R=gdeepti@chromium.org > BUG=v8:6532 > > Change-Id: I532bf67f1631c692e12f9b054b29601a57b76f05 > Reviewed-on: https://chromium-review.googlesource.com/1130635 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54365} Bug: v8:6532 Change-Id: I22af58646b898ee2f54ccb64467d9fb978a645c5 Reviewed-on: https://chromium-review.googlesource.com/1132155 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54369}
-
Junliang Yan authored
Port 4c4c3437 Original Commit Message: This fixes the special stack check we emit for very large frames to no longer embed the limit address but load it from the instance object instead. It makes sure WasmCode remains independent of the Isolate. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:7424 LOG=N Change-Id: I35e662ee89fbad679a6c103518e4d1feb2c8dce0 Reviewed-on: https://chromium-review.googlesource.com/1131996Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54368}
-
Bill Budge authored
- Dup (broadcast) shuffles are always swizzles (single operand), which are canonicalized to only use the first input, so we don't need to check the index and switch operands. Bug: v8:6020 Change-Id: I3ef8ba8071775dfbd21c0cab3fdf24db17f496bb Reviewed-on: https://chromium-review.googlesource.com/1129540Reviewed-by:
-
Aseem Garg authored
This reverts commit 5301cdc3. Reason for revert: Failing on mips Original change's description: > [wasm] add 64 bit atomic ops to interpreter > > R=gdeepti@chromium.org > BUG=v8:6532 > > Change-Id: I532bf67f1631c692e12f9b054b29601a57b76f05 > Reviewed-on: https://chromium-review.googlesource.com/1130635 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54365} TBR=gdeepti@chromium.org,aseemgarg@chromium.org Change-Id: Id56d3bb1228b38b6e2ad29876ea78542658e8310 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6532 Reviewed-on: https://chromium-review.googlesource.com/1132154Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#54366}
-
Aseem Garg authored
R=gdeepti@chromium.org BUG=v8:6532 Change-Id: I532bf67f1631c692e12f9b054b29601a57b76f05 Reviewed-on: https://chromium-review.googlesource.com/1130635Reviewed-by:
-
Maya Lekova authored
Bug: chromium:856119 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5c87ac92742ee2a4f7b4b80654299a718ccc4c6a Reviewed-on: https://chromium-review.googlesource.com/1131741 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54364}
-
Clemens Hammacher authored
This makes js-to-wasm wrappers module-independent, so that we can eventually share them isolate-wide. R=mstarzinger@chromium.org Bug: chromium:862123 Change-Id: I3d9571cf247b95330ffb17f41901278a5dfacca0 Reviewed-on: https://chromium-review.googlesource.com/1131187 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Bill Budge authored
- Dup shuffles broadcast a single lane from a source operand to all lanes of the destination. Conceptually similar to a splat, they require special handling since the splatted value must be extracted from a source. The 32x4 case is already well handled (pshufd) but 16x8 and 8x16 currently generate the general shuffle code sequence. - Adds IA32S16x8Dup, IA32S8x16Dup opcodes. Bug: v8:6020 Change-Id: Ia4f044aa7e25cae30e8f9007c2488db738ca6cfc Reviewed-on: https://chromium-review.googlesource.com/1128513Reviewed-by:
-
Dan Elphick authored
Remove GetHeaps from String::MakeExternal by first checking the String is not in RO_SPACE (by checking the MemoryChunk's identity) and only then getting the heap from the chunk. Also changes String::CanMakeExternal in api.cc to not use GetHeap. Also remove check GetHeap()->Contains(this/map) that attempts to print INVALID POINTER/INVALID MAP as it's much more likely that the code will crash in either GetHeap or Contains before printing anything. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id27ba84eb2ba78c71158d6f2e94a3b4176c34609 Reviewed-on: https://chromium-review.googlesource.com/1131128 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This fixes the special stack check we emit for very large frames to no longer embed the limit address but load it from the instance object instead. It makes sure WasmCode remains independent of the Isolate. R=clemensh@chromium.org BUG=v8:7424 Change-Id: I8dc40a31a3a4de04aeb6b0b800694cce2321f837 Reviewed-on: https://chromium-review.googlesource.com/1131186Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54360}
-
Frank Tang authored
Spec: http://tc39.github.io/proposal-intl-relative-time/ Design Doc: go/add-intl.relativetimeformat-to-v8 Test: test262/intl402/RelativeTimeFormat/*, intl/relative-time-format/* R=gsathya@chromium.org, mstarzinger@chromium.org Bug: v8:7869 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic1ef2e26d164275791dfdbe37d016ba350256d94 Reviewed-on: https://chromium-review.googlesource.com/1125539 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec: http://tc39.github.io/proposal-intl-relative-time/ Design Doc: go/add-intl.relativetimeformat-to-v8 Test: test262/intl402/RelativeTimeFormat/*, intl/relative-time-format/* R=gsathya@chromium.org, mstarzinger@chromium.org Bug: v8:7869 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2cfe8dba9d3a99957ad4b444023c89bbdae08c7c Reviewed-on: https://chromium-review.googlesource.com/1124121Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This gathers TurboFan compilation statistics for WebAssembly separately from the JavaScript statistics. It is a preparation to having multiple Isolates trigger TurboFan compilations in a shared engine. By adding compilation statistics to the engine, their lifetime is independent of any particular Isolate. R=ahaas@chromium.org Change-Id: I1bd0fbe6d6bde65ca813ccfd1154558ea6cddb07 Reviewed-on: https://chromium-review.googlesource.com/1131121 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7921 Change-Id: I82a1c5cff7fd00603a509221b448b11d82edee7e Reviewed-on: https://chromium-review.googlesource.com/1131176Reviewed-by:
-
