- 27 Jul, 2020 7 commits
-
-
Zeynep Cankara authored
This CL adds a generic Event Class to unify common methods of IC and Map events. The Entry Class for IC Events and V8Map Class for Map Events inherits from this generic Event Class. Bug: v8:10644, v8:10735 Change-Id: I77d68fb40ee0ffbe297fcd1a13c3e2b746938168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317309 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69066}
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I9e62a60911d69aec20a59e92f989208f8eac6cb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243219Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69065}
-
Thibaud Michaud authored
This is a reland of 06bdd8d6 Original change's description: > [liftoff][tail-call] Add indirect tail calls > > R=clemensb@chromium.org > > Bug: v8:10693 > Change-Id: Ic71d873bf7099ba671b9db1e87392d54aeebd7cf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312096 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68996} Bug: v8:10693 Change-Id: Ia360be2fff1e98fab969dd4ffa14b5991ec743af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316304 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69064}
-
Thibaud Michaud authored
If the types allow it, sometimes generate a return call instead of a regular call in the wasm-compile fuzzer. R=clemensb@chromium.org Bug: v8:10693 Change-Id: Ie5e92f2b012f655b9d7d5847dba4a669152635c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316297 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
Only the first four elements of the array will be used. Also, the fifth element sais 'stepInfo' instead of 'stepInto'. R=thibaudm@chromium.org Change-Id: I258a8b95795f0cfbcaf500b7d174786680914d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316110Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69062}
-
Dominik Inführ authored
Introduce explicit fast path for allocation from LAB. The slow path refills the LAB and allocates again. Other changes: 1) Move slow path methods out of the header file 2) AllocateRaw(Aligned|Unaligned) are now private methods. All allocations need to go through AllocateRaw for NewSpace now. Bug: v8:10315 Change-Id: Iee2bd7b74aa49be8b20d89fefeb2e087575d532c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319987Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#69061}
-
Dominik Inführ authored
Add methods NotifyBytes(), NotifyObject() and NextBytes() to AllocationCounter. Methods are unused for now. Move AllocationObserver::Step after AllocationCounter methods as well. Use SetTopAndLimit as bottleneck instead of allocation_info_.Reset. Bug: v8:10315 Change-Id: I30049cb02e873bb08ebce606a491d99130421227 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316103 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
- 26 Jul, 2020 2 commits
-
-
Clemens Backes authored
This *partially* reverts commit b983076b (only the v8/build roll). Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64/35550 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bdbc779..f99e62d > > Rolling v8/third_party/aemu-linux-x64: -zGqW99um_GNQKURMgzhK855VvGi_CfraQRvXhNduEQC..BSmiob0gPivtoM5FO4ByhQHofOIKJ7KxRVPyfzhrjTkC > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b2282fe..342ad52 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cebfb4e..a58287b > > TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I696aa9bbd31a36830f2b13ea51b8a75a03cf717d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319386 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#69058} TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I711b8a94ed2ef9c3df6bdcbcda4752881e50aff2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1049569 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317868Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bdbc779..f99e62d Rolling v8/third_party/aemu-linux-x64: -zGqW99um_GNQKURMgzhK855VvGi_CfraQRvXhNduEQC..BSmiob0gPivtoM5FO4ByhQHofOIKJ7KxRVPyfzhrjTkC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b2282fe..342ad52 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cebfb4e..a58287b TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I696aa9bbd31a36830f2b13ea51b8a75a03cf717d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319386Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#69058}
-
- 24 Jul, 2020 29 commits
-
-
Bill Budge authored
- Adds a SharedArrayBuffersEnabled callback and uses it to enable/disable SABs per context. The feature flag is used if no callback is registered. Bug: chromium:923807 Change-Id: I4d3472fcd79b158cb50dc98793aece6dbbb81d93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316901Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#69057}
-
Zeynep Cankara authored
This CL adds a Timeline Class to handle data interaction between panels. The timeline class enables to filter the data based on selected time range. Bug: v8:10644, v8:10735 Change-Id: I7fbbe1741abc69d2889b0547113e5da10b7f5510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315983 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
Bill Budge authored
- Changes runtime return value / parameter checks to check for subtype of StrongTagged. Bug: v8:10047,v8:9891 Change-Id: Ie86bacf138c67092983fc72f37b1a13bffa904a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2314828Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#69055}
-
Jakob Kummerow authored
Now the following command builds mkgrokdump for x64.release and runs it to update v8heapconst.py: gm.py mkgrokdump Building the binary for other architectures still works as before. No-Try: true Change-Id: Iacfa1a50702b0452d00ba18e1306423b161ffe65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317352 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#69054}
-
Frank Tang authored
Bug: v8:10753 Change-Id: Icbdc6d7ee0634d32b262860dd64c4bfccebdcc00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317064Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69053}
-
Ng Zhi An authored
Using uint8_t[] causes decay to pointer issue, which manifests in copying garbage values in the call to WriteLittleEndianValue. Change it to use a std::array, which doesn't have the decaying behavior. Also add a regression test from comment#6 of the linked bug. Bug: v8:10731 Change-Id: I4a1ca69fe99806642e9931625ca7aeab6663f955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316465Reviewed-by:
-
Ng Zhi An authored
These functions match on specific patterns of shuffle that have more optimized implementations. Moving them out of instruction-selector allows us to reuse them in Liftoff. Most of these pattern matching functions do not depend on InstructionSelector, since they work on byte arrays. (The only one is CanonicalizeShuffle, which swaps node inputs.) This is only the first pass of moving those functions out. In particular we can clean things up more by moving the tests out of instruction-selector as well. Those will come in follow-up changes. Bug: v8:10696 Change-Id: I4a4333cd8c0259875a672179e72d34dad5f7a008 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308057 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Z Nguyen-Huu authored
csuite.py compare command currently throws exception "_csv.Error: iterator should return strings, not bytes (did you open the file in text mode?)" This should fix it. Change-Id: I69c0ec43575a8c3627dac81dc99e47ba6adf6f61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316833Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#69050}
-
Maya Lekova authored
Bug: v8:9506 Change-Id: Ie343a4d49e769293d8a10d26bcfc3847b9d433ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316109Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69049}
-
Dominik Inführ authored
We don't use the updated size anywhere. Bug: v8:10315 Change-Id: Iba1fd484fef062d109aa4e5a2c1b40d0a838f80b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317320Reviewed-by:
-
Andreas Haas authored
As there are not enough registers on ia32 to execute the platform- independent code, the CL also adds ia32-specific code to liftoff-compiler.cc. For this we first retrieve the memory index from the stack, do a bounds check, and calculate the final address. Only afterwards we pop all other values from the stack and pass them to the platform-dependent code. R=clemensb@chromium.org Bug: v8:10108 Change-Id: I741266a9523c8b5c46acc0b29817fd143a75752e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316305Reviewed-by:
-
Tobias Tebbi authored
This flag is already baked into the snapshot by enabling more write-barrier elimination, so changing it at runtime would be a bug. Change-Id: I3bc73f3c880285ec46b69b0c44934f64b49912ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290856 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Adds support for register allocation within a block to the fast register allocator. Also adds some unittests covering basic register allocation. No support yet for spill slot allocation, so functions that spill don't work yet. BUG=v8:9684 Change-Id: I91d0fc0660d7b65f59235242fd5e3b1a7618d813 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2297467 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Seth Brenith authored
Otherwise, a failure message from a common macro like UnsafeCast<A> is not particularly meaningful. With this change, the failure message would show the line number in the top-level builtin and each in-between macro that resulted in calling UnsafeCast<A>. This does not include plain CSA macros, only those generated by Torque. Bug: v8:7793 Change-Id: If0b9b7d2755f579ceacf47eef2440d97ec84a2ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2303598 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
-
Maya Lekova authored
This CL includes the following minor cleanups: * Renames MakeRaisesException -> MakeWithErrorSupport * Removes remaining WrapperTraits related code * Makes the public header follow the IWYU principle Bug: chromium:1052746 Change-Id: I60e730fa15f9bde421a7b6273093c84870666a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316296 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#69043}
-
Ross McIlroy authored
This is a reland of ab7e89f1 Original change's description: > [TurboProp] Add PendingOperand for use by fast register allocator. > > Adds a pending operand type for use with the fast register allocator. > These operands chain together multiple operands together, enabling > the allocator to keep track of multiple pending operands, then > replace them all with the allocated operand in one go. > > BUG=v8:9684 > > Change-Id: I5d8150f3f26549a747a2e89e32e31135e89dff9c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292302 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69019} Bug: v8:9684 Change-Id: I60b902be82b766d98c0f08c9394fcac72d3b914a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315994Reviewed-by:
-
Clemens Backes authored
Out of the four listed reasons, two are obsolete now, since stepping does not modify the code table any more. The first reason also cannot happen any more, since removing a breakpoint will also patch the stack of the isolate, and even if not, removing a breakpoint which is not set will have no effect (not even a stack rewriting). The same applies for the last listed reason. So overall, this code is not needed any more, since it has no effect. R=thibaudm@chromium.org Bug: v8:10611 Change-Id: I773ac2515b66e8bf66cb035c315db552024485c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316299Reviewed-by:
-
Manos Koukoutos authored
Change-Id: I920a7b8aeda0d92eb0301962589a78e0258f33e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315986Reviewed-by:
-
Dominik Inführ authored
Right now the allocation observer counters are increased by the LAB size when allocating the LAB and are decreased later when retiring the rest of the LAB. In the future counters will be monotonic by increasing them by the actual used size when retiring a LAB. The start of the LAB is required for that. Bug: v8:10315 Change-Id: Ibeca34914f61abcea2a1c1a7b9a042c9be14a589 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316100Reviewed-by:
-
Santiago Aboy Solanes authored
Remove ParameterMode from: * AllocatePropertyArray * InitializePropertyArrayLength * GetPropertyArrayAllocationSize Bug: v8:9708, v8:6949 Change-Id: I6b596a52bf06a0e126fa3cf2dd0e4ddedd526c52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310354 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#69038}
-
Manos Koukoutos authored
Change-Id: I6a2ef3d1c46ea57b17234d050b8f0be12e27a197 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315985Reviewed-by:
-
Igor Sheludko authored
... that controls whether the TF graph zones should support compression. Bug: v8:9923 Change-Id: Ifbe237b75e9c92e62eb32b69d6b3b1a818269b83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308347 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#69036}
-
Igor Sheludko authored
* Added GN flag v8_enable_zone_compression. * AccountingAllocator supports allocation of zone segments via both malloc/free and bounded page allocator. The latter implementation is known to be not efficient yet. This issue will be addressed in a follow-up CLs. * Add support_compression flag to Zone constructor/instance. Bug: v8:9923 Change-Id: I12ee2d85267dd16f455b1b47edc425dc90c57bcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308345Reviewed-by:
-
Benedikt Meurer authored
This adds an internal property [[IsDetached]] to the inspector preview of ArrayBuffer instances, which indicates whether the ArrayBuffer was detached (i.e. transfered via `postMessage`). Previously it was rather impossible to tell whether an ArrayBuffer was detached, you had to know that V8 violates the ECMAScript specification and simply sets the byteLength accessor to 0 upon detaching an ArrayBuffer (but even then it was still impossible to tell whether that ArrayBuffer wasn't simply an empty one from the get go). Before: https://imgur.com/UcOF83c After: https://imgur.com/WjmTehZ Fixed: chromium:1109102 Change-Id: I8fb6e2be2fbfe5c62b05dc9d2a0f18378eb4de6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316075 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#69034}
-
Dominik Inführ authored
Bug: v8:10315 Change-Id: I124642564d6644f864235c7fa89687e64b1e79c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315995Reviewed-by:
-
Leszek Swirski authored
Allow "iterative" finalization when off-thread finalization is enabled, meaning that each compiled function is finalized immediately after compilation, rather than all functions being first compiled and then finalized. This is what we do on the main thread, and it reduces peak Zone memory usage by being able to discard empty compilation Zones earlier. One necessary functionality for this was being able to defer the finalization of asm.js functions until the main thread pause, since they can't be finalized off-thread -- previously we would just bail out of doing the off-thread finalization if any inner function was asm.js. Bug: chromium:1011762 Change-Id: I21ff69d62eaa93b5ff908624b7115601e36f70f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282536Reviewed-by:
-
Zeynep Cankara authored
This CL adds a link to v8.dev/tools to direct to all available versions of the tool. Also fixes margin in between text and card div. Bug: v8:10664 Change-Id: I8c0b137ffbdd88c4a41fd1ab8038985595056ada Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315988Reviewed-by:
-
Milad Farazmand authored
To match the behaviour of other architectures, Float32ToInt32 needs to return INT32_MIN as an overflow indicator instead of 0. Change-Id: I68140daf06f8575fc38fb857033b5c56fec6bb2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316398Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69030}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7e2f4d2..bdbc779 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8bd1a6c205ca1edae9040e1b3a2fca7efed2fc81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315053Reviewed-by:
-
- 23 Jul, 2020 2 commits
-
-
Michael Lippautz authored
The following adds support for JSMember through the existing GlobalHandles implementation also used for TracedReference. In addition, JSMember now supports set, clear, copy, move, comparison and interaction with Local. Bug: chromium:1056170 Change-Id: Ia50218bcfe4c056b3533a5b14eea954ade1da243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310357Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Clemens Backes authored
cmov is often much faster than branches (in particular if the branches cannot be predicted). It also has a much more predictable performance, and is shorter. This CL uses cmov on x64 for now. Other platforms (maybe using other instructions than cmov) can be added later. R=thibaudm@chromium.org Bug: v8:10740 Change-Id: Ifab3d570b8eea784376e1f768d6ba3828efcc01a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315978Reviewed-by:
-
