- 10 Dec, 2018 14 commits
-
-
Clemens Hammacher authored
Names of external references are statically known, so there is no need to store them in the dynamically generated ExternalReferenceTable. This saves 7.4kB per Isolate, plus ~46.4kB binary size. R=mstarzinger@chromium.org Bug: v8:8562 Change-Id: Ia494de38474e0a7308563ab6d1797ff488b0a072 Reviewed-on: https://chromium-review.googlesource.com/c/1369947Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58128}
-
Andreas Haas authored
When the --debug-code flag is turned on, we create code now which checks if the thread-in-wasm flag has the expected value. If not, we abort execution. R=clemensh@chromium.org Bug: v8:5277, v8:8554 Change-Id: I74c4e6a60b874b48f13ded9b5cee81f602e4c9fd Reviewed-on: https://chromium-review.googlesource.com/c/1370025Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#58127}
-
Dan Elphick authored
Bug: chromium:911416 Change-Id: I04d3faa5ee042c99a400294e2a6dbed99c8d7020 Reviewed-on: https://chromium-review.googlesource.com/c/1366616 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58126}
-
Predrag Rudic authored
MIPS32 doesn't have instructions to properly handle 64-bit atomic instructions. Skipping those test on MIPS64 simulator because they have flaky TIMEOUT on buildbots. Change-Id: I31511dfce70a933b9326a7c270509c5f31af743a Reviewed-on: https://chromium-review.googlesource.com/c/1367450Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#58125}
-
Leszek Swirski authored
This reverts commit 92db073f. Reason for revert: Breaks devtools test https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Win/15539 Devtools seems to parse our error messages, e.g. https://cs.chromium.org/chromium/src/third_party/blink/renderer/devtools/front_end/object_ui/JavaScriptAutocomplete.js?type=cs&q=isExpressionComplete+javascriptautocomplete&sq=package:chromium&g=0&l=612 Original change's description: > [parser] Improve error message for unclosed function bodies > > This patch changes the output from: > > function fn() { > ^ > SyntaxError: Unexpected end of input > > to: > > function fn() { > ^ > SyntaxError: missing '}' after function body > > Bug: v8:6513, v8:7321 > Change-Id: I4ca8a40fa0be246da2a3ff776b3fb3c87b4ba4e0 > Also-By: gsathya@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1367448 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58116} TBR=marja@chromium.org,gsathya@chromium.org,mathias@chromium.org Change-Id: Ia2ac413d67fda39eda903c056002ae632df73df9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6513, v8:7321 Reviewed-on: https://chromium-review.googlesource.com/c/1370026Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58124}
-
Igor Sheludko authored
which used to treat off-heap slots as on-heap ones and implement embedded objects visitation in derived visitor classes. Bug: v8:8518 Change-Id: Ia40d8135078379cca990e9167d3f1bebb3b5be0a Reviewed-on: https://chromium-review.googlesource.com/c/1367747Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58123}
-
Michael Starzinger authored
This is a reland of 9c2c8f15 Original change's description: > [wasm] Support encoding s128 simd types in exceptions. > > This adds support for having simd type values (i.e. s128) stored in an > exception. It is the natural combination of the simd propsal and the > exception handling proposal. > > R=clemensh@chromium.org > TEST=mjsunit/wasm/exceptions-simd > BUG=v8:8390 > > Change-Id: I01079f82a6ba4d9152de4dae63e3db1584ca7cd8 > Reviewed-on: https://chromium-review.googlesource.com/c/1363141 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58098} Bug: v8:8390 Change-Id: I333c50cd766055f74b023df626d0fd90fdef3bac Reviewed-on: https://chromium-review.googlesource.com/c/1370024Reviewed-by:
-
Igor Sheludko authored
which used to treat off-heap slots as on-heap ones and implement code target visitation in derived visitor classes. Bug: v8:8518 Change-Id: I477bf3a4a8a3de0c67bc15e2e20d8ecee6493da8 Reviewed-on: https://chromium-review.googlesource.com/c/1367745Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58121}
-
Andreas Haas authored
CompileJsToWasmWrappers only needs a WasmModule, so we should not pass in a NativeModule. R=clemensh@chromium.org Bug: v8:8562 Change-Id: Ic38f1bee2eab3a06921c27f56fd175b51688ad5f Reviewed-on: https://chromium-review.googlesource.com/c/1367748Reviewed-by:
-
Peter Marshall authored
Right now, this is the limit implicitly imposed for spread/apply calls as to actually do a spread/apply call through CallVarargs, you need to pass a FixedArray with the args to be pushed. Likewise, turbofan can only materialize an arguments object with a backing store of length FixedArray::kMaxLength. The practical limit that users will actually hit is the stack - this change doesn't change that, it just documents what the actual limit is. This would actually allow an embedder/custom fork to increase stack size and still be able to make spread/apply calls with a large number of args. Change-Id: If5e66a61ed3f9df36031eb098646d48fc2ca2507 Reviewed-on: https://chromium-review.googlesource.com/c/1367451Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#58119}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ie4f40314eb41957c6983796e43eeefe655458160 Reviewed-on: https://chromium-review.googlesource.com/c/1367806 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Yang Guo authored
R=delphick@chromium.org, jgruber@chromium.org Bug: chromium:911416 Change-Id: Ib23ba11f3219fde183b4b9b352b13564b6e9e1e2 Reviewed-on: https://chromium-review.googlesource.com/c/1362952Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Mathias Bynens authored
This patch changes the output from: function fn() { ^ SyntaxError: Unexpected end of input to: function fn() { ^ SyntaxError: missing '}' after function body Bug: v8:6513, v8:7321 Change-Id: I4ca8a40fa0be246da2a3ff776b3fb3c87b4ba4e0 Also-By: gsathya@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1367448 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#58116}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c017b42..e09a3df TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I065c6b38f01a05c9faeb27776a893bb9dee07740 Reviewed-on: https://chromium-review.googlesource.com/c/1369334Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58115}
-
- 09 Dec, 2018 2 commits
-
-
Daniel Clifford authored
Bug: v8:7793 Change-Id: I31cae67edfce6a0ba925df34d496d3d62bc7d5ef Reviewed-on: https://chromium-review.googlesource.com/c/1358519 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58114}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/70dc33c..6fd29b2 Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/89ae39c..4408f60 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4be60ee..03ee2d6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I204383a4f19ff008c8c213128ce561e7f0acc3fc Reviewed-on: https://chromium-review.googlesource.com/c/1369092Reviewed-by:
-
- 08 Dec, 2018 3 commits
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I1d74ffe9e5478b4b8bc0acbf088d20919d458d50 Reviewed-on: https://chromium-review.googlesource.com/c/1363822 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58112}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9e9ea82..70dc33c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5d7bcad..c017b42 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f94f910..4be60ee Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f6641a3..1bc365f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia24ad0df626f9b89d7f93a6f9e27b47cf13439a6 Reviewed-on: https://chromium-review.googlesource.com/c/1369088Reviewed-by:
-
Alexei Filippov authored
That should prevent leak of objects when page is reloaded. BUG=chromium:906847 Change-Id: I90928a5c4979c0ddc01c201bf60a693e2b03863a Reviewed-on: https://chromium-review.googlesource.com/c/1366449 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#58110}
-
- 07 Dec, 2018 21 commits
-
-
Vasili Skurydzin authored
Change-Id: I3b504d7d22da475b317f5877bc0a5a642017754f Reviewed-on: https://chromium-review.googlesource.com/c/1363531Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#58109}
-
Clemens Hammacher authored
If we create a second foreground task, only the second one will be registered with the AsyncCompileJob, so the first one will not be cancelled, which can lead to use-after-free of the AsyncCompileJob. In a debug build, a DCHECK will fail when creating the second foreground task. R=ahaas@chromium.org Bug: chromium:907937, chromium:910920 Change-Id: Iefefc4a85e7b35b32051cfe8cd5cbbfc4e95b843 Reviewed-on: https://chromium-review.googlesource.com/c/1367684 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Mythri authored
Updates the following bytecode handlers to handle cases when feedback vector is not allocated: StaDataPropertyLiteral CreateRegExpLiteral CreateArrayLiteral EmptyArrayLiteral CreateObjectLiteral GetTemplateObject ForInPrepare ForInNext Bug: v8:8394 Change-Id: I854cca8dd69539f7e8a17dd8eddb0f9f6d42f762 Reviewed-on: https://chromium-review.googlesource.com/c/1362992 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58107}
-
Daniel Clifford authored
Moving Frame-inspection functionality to Torque is a prerequisite for porting the CSA-based arguments code, which is a great candidate to simplify/cleanup with Torque. Change-Id: I1f4cb94cb357aae5864c2e84f3bf5a07549b27f8 Reviewed-on: https://chromium-review.googlesource.com/c/1357050 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Igor Sheludko authored
in order to make it also work with optional registers. Bug: v8:8562 Change-Id: Iaea905913cc9fd1637026b83e9356c740965e128 Reviewed-on: https://chromium-review.googlesource.com/c/1367807 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port 8c7a29b2 Original Commit Message: This addresses follow-up comments to https://crrev.com/c/1354887/. Use DCHECKs instead of CHECKs and make the branch order consistent across architectures. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic974e31905e15d91efae026837095693f0c01b66 Reviewed-on: https://chromium-review.googlesource.com/c/1365681 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#58104}
-
Marja Hölttä authored
BUG=v8:5402,v8:8238 Change-Id: I61afd09ecd80dba4fbb89e3ae4b71fca1138cec2 Reviewed-on: https://chromium-review.googlesource.com/c/1367449Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 9c2c8f15. Reason for revert: New test crashes: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/28948 Original change's description: > [wasm] Support encoding s128 simd types in exceptions. > > This adds support for having simd type values (i.e. s128) stored in an > exception. It is the natural combination of the simd propsal and the > exception handling proposal. > > R=clemensh@chromium.org > TEST=mjsunit/wasm/exceptions-simd > BUG=v8:8390 > > Change-Id: I01079f82a6ba4d9152de4dae63e3db1584ca7cd8 > Reviewed-on: https://chromium-review.googlesource.com/c/1363141 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58098} TBR=mstarzinger@chromium.org,gdeepti@chromium.org,clemensh@chromium.org Change-Id: Iedcfba36af925249131a2b0e9aebd92321ae72f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8390 Reviewed-on: https://chromium-review.googlesource.com/c/1367808Reviewed-by:
-
Jakob Gruber authored
This is a reland of f849396c Original change's description: > [nojit] Remove code stubs > > All stubs have been migrated to builtins. This CL removes most related > code. > > Bug: v8:7777, v8:5784 > Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad > Reviewed-on: https://chromium-review.googlesource.com/c/1365284 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58093} Tbr: mstarzinger@chromium.org,yangguo@chromium.org,jkummerow@chromium.org,bmeurer@chromium.org Bug: v8:7777, v8:5784 Change-Id: I005ee2a820d49a75a90481d262a310e4ccfd1391 Reviewed-on: https://chromium-review.googlesource.com/c/1367746Reviewed-by:
-
Michael Achenbach authored
This makes the roll branch diffs smaller again. TBR=hablich@chromium.org NOTRY=true Bug: v8:8546 Change-Id: Ic5223593dfe086c61119bd82bfd51075160aab85 Reviewed-on: https://chromium-review.googlesource.com/c/1367749Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58100}
-
Clemens Hammacher authored
We need to be able to serialize a NativeModule, which is not bound to any Isolate. Hence we should not want to pass any Isolate to the serializer. This CL removes the dependence by not using the ExternalReferenceTable from the Isolate, but instead using its own ExternalReferenceList for serialization and deserialization. This ExternalReferenceList only contains isolate-independent external references. R=mstarzinger@chromium.org Bug: chromium:912043, chromium:912031 Change-Id: Iea5abd95dce9c54e618255cc577b6b43f002ac5d Reviewed-on: https://chromium-review.googlesource.com/c/1363135 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds support for having simd type values (i.e. s128) stored in an exception. It is the natural combination of the simd propsal and the exception handling proposal. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-simd BUG=v8:8390 Change-Id: I01079f82a6ba4d9152de4dae63e3db1584ca7cd8 Reviewed-on: https://chromium-review.googlesource.com/c/1363141 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port bec0234f Original Commit Message: been converted to builtins themselves and are thus immovable. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I5e08b7a894ab72647028735521d7851b15ef5f12 Reviewed-on: https://chromium-review.googlesource.com/c/1363566Reviewed-by:
-
Yuki Shiino authored
https://crrev.com/c/1343709 fixed GetIncumbentContext to work with ASan, however, GetIncumbentContext didn't work well with MSan because MSan uses a simulator which supports yet another separate stack frame. This patch fixes GetIncumbentContext so that it works well with not only ASan but also MSan simply following the same way as v8::TryCatch does. i::GetCurrentStackPosition() solves the issue of ASan and SafeStack (native but separate stack frame), and i::SimulatorStack solves the issue of MSan (simulator stack frame). Bug: chromium:888867, chromium:866610 Change-Id: Id803cbfd17fb1b1d9b8ee34c4802768f3a2f8e79 Reviewed-on: https://chromium-review.googlesource.com/c/1356691 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit f849396c. Reason for revert: arm64: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/24229 Original change's description: > [nojit] Remove code stubs > > All stubs have been migrated to builtins. This CL removes most related > code. > > Bug: v8:7777, v8:5784 > Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad > Reviewed-on: https://chromium-review.googlesource.com/c/1365284 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58093} TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,jgruber@chromium.org,bmeurer@chromium.org Change-Id: I52c3abd3f4e5872fe26ed7e527a58b118e02b387 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777, v8:5784 Reviewed-on: https://chromium-review.googlesource.com/c/1367804Reviewed-by:
-
Michael Lippautz authored
Allow a V8 step after doing an embedder step if there's time left. This will speed up marking in certain situations. Bug: chromium:909788, chromium:911053, chromium:843903 Change-Id: Ie15c30d5ce8443caf7217a834a120a19d0bb292b Reviewed-on: https://chromium-review.googlesource.com/c/1367455 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Jakob Gruber authored
All stubs have been migrated to builtins. This CL removes most related code. Bug: v8:7777, v8:5784 Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad Reviewed-on: https://chromium-review.googlesource.com/c/1365284 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Gerrit seems to concatenate several commit messages on uploading branch creation CLs. Now we pass the commit message of the branch commit to the upload script to prevent this. NOTRY=true Bug: v8:8546 Change-Id: Ia4673261aad2f40bcda4384889a0428039adae74 Reviewed-on: https://chromium-review.googlesource.com/c/1367454Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58092}
-
Igor Sheludko authored
(mostly for roots, handles and stack locations). Thi CL also changes RootVisitor interface to use FullObjectSlots instead of ObjectSlots. Bug: v8:8518 Change-Id: I217c7ae176387a8c64f4754e62339727bdb36018 Reviewed-on: https://chromium-review.googlesource.com/c/1366035Reviewed-by:
-
Marja Hölttä authored
Should help the case where the single existing transition matches. BUG=v8:8547 Change-Id: Ic459357a10311346499ea054447d6cc42352fc0d Reviewed-on: https://chromium-review.googlesource.com/c/1363133Reviewed-by:
-
Tamer Tas authored
R=machenbach@chromium.org Change-Id: Ib049f88cbbf72fd33b5a962f074ac98948d6ae1c Reviewed-on: https://chromium-review.googlesource.com/c/1360631Reviewed-by:
-
