- 04 Jun, 2021 8 commits
-
-
Manos Koukoutos authored
So far, initializer-expression evaluation was tied to setting global values. We now need it to operate independently of globals, so that we can implement new constant expressions like struct.new, which need their arguments to be computed before they can be initialized. Changes: - Move type computation of WasmInitExpr into WasmInitExpr::type. - Fix WasmInitExpr::type kRttSub case for rtts without depth. - Introduce InstanceBuilder::EvaluateInitExpression(). - Rename InstanceBuilder::GetRawGlobalPointer() -> GetRawUntaggedGlobalPointer(). - Simplify InstanceBuilder::InitGlobals using EvaluateInitExpression(). - Introduce ValueType::is_numeric. - Add Simd128(byte*) constructor. - Introduce WasmValue::CopyTo() for numeric types. Change-Id: Ic502b611f3998187abd9fc6ec377c2954c27abdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939982 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74949}
-
Manos Koukoutos authored
Changes: - Merge all immediates which read a u32_v index into IndexImmediate. Refactor overloaded Validate(const byte*, [Type]Immediate) functions to Validate[Type](const byte*, IndexImmediate). - Move MemoryIndexImmediate/MemoryAccessImmediate validation into their own Validate functions. Remove CheckHasMemory(), move its functionality into these Validate() functions. - Refactor MemoryInitImmediate, TableInitImmediate and CallIndirectImmediate as composite immediates. - Change field initializations for some Immediates to constructor initializers. This helps us drop some useless default constructors. - Use the correct pc in StackEffect for struct.new_default. Bug: v8:11831 Change-Id: I878f69a33f8473dc275184995b3b7b88fe0dfc8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928498Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74948}
-
Andreas Haas authored
R=thibaudm@chromium.org Change-Id: I6fcd78ffb2683ed92e056d67ec4ef792c0d2ec0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939986Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74947}
-
Vicky Kontoura authored
This CL introduces an ExplicitRealmScope in d8 for entering an existing Realm on demand. Bug: v8:11525, v8:11706 Change-Id: I3b556aed85fc615bb5efbd4a072e075534617258 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936602 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74946}
-
Georg Neis authored
Tbr: nicohartmann@chromium.org Bug: chromium:1198705, chromium:1199345, chromium:1200490 Change-Id: I4a486df636e084279423e6cd3b867137bfe3fd6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939984Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74945}
-
Sigurd Schneider authored
The V8 roll is stuck due to a compile error: https://chromium-review.googlesource.com/c/chromium/src/+/2933917 This CL adds the defined() to a preprocessor guard to make it compile Change-Id: I744c6b9c3b92380a80fd50393e86f48392042b9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939985 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74944}
-
Georg Neis authored
Change-Id: I9a3c43418b17447741b5886d4706ccd1db9b38e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933662 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74943}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/20ee3d5..1da98aa Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/cd7b8c0..eb65cc3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ec690bb..712eb08 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c8f63d3..9705687 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/f022e29..a0718d4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/19eadef..af7a363 Rolling v8/tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 Rolling v8/tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 Rolling v8/tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I09959737175560509e13ec3060dd0b6dc5feb108 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939065Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74942}
-
- 03 Jun, 2021 8 commits
-
-
Milad Fa authored
Change-Id: Ie16a4542179a9661991a4e1696d1b7a952b0e305 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936605Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74941}
-
Junliang Yan authored
Change-Id: I57e46d779e8336b4a456b2a0932a0a6126fcb873 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2937256 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74940}
-
Milad Fa authored
vcgd/vcdg with 32-bit FP inputs are only supported on z15 and above. For older machines we need to use scalar instructions. This is a partial revert of this CL: https://crrev.com/c/2697389 Change-Id: I61deb9357efd424c3b94dddc8be37e7e4c42d334 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936640Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74939}
-
Lu Yahan authored
Port 97def807 Change-Id: If4f135be03e7ab719e091f02bdace49f9bcafcfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928143 Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74938}
-
Lu Yahan authored
Port 2b77ca20 Change-Id: Ie953a1d54f5529423ae35d1b1cd3ca25e8101c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931577 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74937}
-
Vicky Kontoura authored
This CL updates WebSnapshotSerializer::TakeSnapshot() to accept exports as a Local<PrimitiveArray>. Bug: v8:11525, v8:11706 Change-Id: Ie3a752ac7dbcc51fc4fb258eb44ce42d0cfc6a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930173Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#74936}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/315c86c..20ee3d5 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/da3e6cb..7e3b768 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/c0776fc..950faee Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/053e386..ec690bb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cd3696c..c8f63d3 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/a3460d1..53495a2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d663c27..19eadef Rolling v8/tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e Rolling v8/tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e Rolling v8/tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I6bc8406c512b4dd51654874d785827b77820ef3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936147Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74935}
-
Liu Yu authored
Port 2b77ca20 Bug: v8:11809 Change-Id: Idbbbc10d1339d6c8463686b6e701fb601a217cab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931557Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74934}
-
- 02 Jun, 2021 24 commits
-
-
Frank Tang authored
R4T: https://groups.google.com/a/chromium.org/g/blink-dev/c/e4Ict1TT9FE/m/aq69ne3rBAAJ Spec: https://tc39.es/proposal-intl-extend-timezonename/ https://chromestatus.com/guide/edit/4506375298220032 Bug: v8:11661 Change-Id: Ifa7571f4bb23c1852ada6c0f13e27611f7e5791d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2924525Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#74933}
-
Stephan Hartmann authored
LiftoffRegister::gp() and LiftoffRegister::fp() are constexpr. Therefore, VRegister::from_code() needs to be constexpr as well. Bug: chromium:819294 Change-Id: I5a75d6ae0dc79fce0a42a45c5f7928aa61ac5520 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922887Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Stephan Hartmann <stha09@googlemail.com> Cr-Commit-Position: refs/heads/master@{#74932}
-
Vicky Kontoura authored
No-Try: true Change-Id: I8ba97cd2fe3ba0b7fa23960aa2ed9880454996a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933660Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74931}
-
Deepti Gandluri authored
Bug: chromium:1190951 Change-Id: I2c314a143c77a9fee288f7822fea84f900c3059b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2921033Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#74930}
-
Georg Neis authored
Bug: chromium:1215514, chromium:1211215 Change-Id: I6ebc1d4138d6bee66c3fd9a8369741b8df960807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933663 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74929}
-
Toon Verwaest authored
Change-Id: I33a6f165b36eb0a948712d0de2b3a926efcd3cb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931808 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#74928}
-
Junliang Yan authored
Clean up 32 bit Load/Store Change-Id: I5bab0d33830039d3c4a501eba6e7cf95f4b9559e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933597Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#74927}
-
Clemens Backes authored
This reverts commit 81dd3f42. Reason for revert: Does not compile on MSVC: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20msvc/18017/overview Original change's description: > Reland "[bigint] Karatsuba multiplication" > > This is a reland of 59eff3bf > > Original change's description: > > [bigint] Karatsuba multiplication > > > > The Karatsuba algorithm is used for BigInts with 34 or more internal > > digits, and thanks to better asymptotic complexity provides greater > > speedups the bigger the inputs. > > > > Bug: v8:11515 > > Change-Id: I5ab0e318173ea4a02ced3f156d3c17e0259c5036 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782283 > > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#74916} > > Bug: v8:11515 > Change-Id: I5ece2ff29ef11ea304980c053887d9746cfc80bc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933497 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74922} Bug: v8:11515 Change-Id: Ie4a80256174fc8d9f714c01f012ac2dc6247a220 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933665 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74926}
-
Shu-yu Guo authored
This is a reland of 360c7afc Changes since revert: - Read the unregister token using a relaxed read during marking Original change's description: > [weakrefs] Clear unregister token-related fields when clearing weak cells > > Bug: chromium:1213770 > Change-Id: Ic063e79bfa8f3dabdd29d1cc9ed74c7af44d0c31 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2923294 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74890} Bug: chromium:1213770 Change-Id: I8d0b946359b85a4760113e26dbaeaa9479e3b5fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930554Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74925}
-
Dominik Inführ authored
The concurrent marker needs to first read the object's content into a buffer. Only then the marker can try to mark the object black, if this succeeds the content in the snapshot is valid. If not, the main thread has changed the layout of the object concurrently. Change-Id: Ia8bb26953ee78771baf6d4e67af5f86ee3fe8095 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933142Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74924}
-
Vicky Kontoura authored
This CL fixes WebSnapshotDeserializer::DeserializeFunctions(), so that the new Script is created after both the SharedFunctionInfoTable and SharedFunctionInfo are allocated. Also, this CL re-enables mjsunit tests for web snapshots (disabled in https://chromium-review.googlesource.com/c/v8/v8/+/2931806). Bug: v8:11842, v8:11525, v8:11706 Change-Id: I13503eab3fa70b128ba1faae75eed62b6c5bb636 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933145Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#74923}
-
Jakob Kummerow authored
This is a reland of 59eff3bf Original change's description: > [bigint] Karatsuba multiplication > > The Karatsuba algorithm is used for BigInts with 34 or more internal > digits, and thanks to better asymptotic complexity provides greater > speedups the bigger the inputs. > > Bug: v8:11515 > Change-Id: I5ab0e318173ea4a02ced3f156d3c17e0259c5036 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782283 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74916} Bug: v8:11515 Change-Id: I5ece2ff29ef11ea304980c053887d9746cfc80bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933497Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74922}
-
Milad Fa authored
Few of the changes added under https://crrev.com/c/2891656 do not compile if sparkplug is not implement on a platform. Bug: v8:11790, v8:11421 Change-Id: Iec40e89ab56a6923b30a5567e4a49e4f1763eece Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933656Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74921}
-
Jakob Kummerow authored
This instruction is a non-standard V8-only experiment for now, hidden behind the --experimental-wasm-gc-experiments flag. The motivation is to provide a way to set up non-canonicalized RTT hierarchies, to enable expressing the type system of Java-like languages in terms of WasmGC constructs. Bug: v8:7748 Change-Id: Idf1c18e9944c983f40f1e01b2032ee5fdc2fd81b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930478Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74920}
-
Leszek Swirski authored
Since we always call the out-of-line Prologue, we can preload the accumulator in there with undefined instead of having to emit an undefined load in every Sparkplug code header. Change-Id: Ie0385316b0ee8bf96cd0069cda0496d05a4fb1eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933144Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#74919}
-
Maya Lekova authored
This reverts commit 59eff3bf. Reason for revert: Breaks UBSan - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/16697/overview Original change's description: > [bigint] Karatsuba multiplication > > The Karatsuba algorithm is used for BigInts with 34 or more internal > digits, and thanks to better asymptotic complexity provides greater > speedups the bigger the inputs. > > Bug: v8:11515 > Change-Id: I5ab0e318173ea4a02ced3f156d3c17e0259c5036 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782283 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74916} Bug: v8:11515 Change-Id: Ifd3d651a26441ba36a23724c6eb1a9915f6e41a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933496 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74918}
-
Clemens Backes authored
Different platforms have different limits for growing memory, thus the correctness fuzzer should crash instead of failing to grow. This will make the fuzzer ignore the test case. Instead of using the minimum of {wasm::max_mem_pages()} and the declared maximum as the limit for growing, we can just use the declared limit. {wasm::max_mem_pages()} will already be checked in the called methods. All we need is a check for the --correctness-fuzzer-suppressions flag if growing actually fails (either because of the platform-specific limit, or because of an actual OOM). Drive-by: unify the duplicated call to {BackingStore::GrowWasmMemoryInPlace}. R=ahaas@chromium.org Bug: chromium:1213320 Change-Id: I7f219e1f93824225946d8a2136f15874c091e234 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931815Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74917}
-
Jakob Kummerow authored
The Karatsuba algorithm is used for BigInts with 34 or more internal digits, and thanks to better asymptotic complexity provides greater speedups the bigger the inputs. Bug: v8:11515 Change-Id: I5ab0e318173ea4a02ced3f156d3c17e0259c5036 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782283 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#74916}
-
Clemens Backes authored
This reverts commit b0c70710. Reason for revert: Lots of compile errors. Original change's description: > [heap] Remove unused LocalSpace class > > LocalSpace was introduced for off-heap spaces with concurrent bytecode > compilation finalization. However, finalization ended up using > LocalHeap for concurrent allocations. LocalSpace is therefore unused > and can be removed. > > This CL removes LocalSpace and renames all mentions of local space to > compaction space. Compaction space was the only local space left. > > Change-Id: I12a8a2724f777a77ddb9957fe2d8e89febfebbaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930169 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74914} Change-Id: I3a654da0ddb556c1fb8767f8401ecd3b46786bea No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933140 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74915}
-
Dominik Inführ authored
LocalSpace was introduced for off-heap spaces with concurrent bytecode compilation finalization. However, finalization ended up using LocalHeap for concurrent allocations. LocalSpace is therefore unused and can be removed. This CL removes LocalSpace and renames all mentions of local space to compaction space. Compaction space was the only local space left. Change-Id: I12a8a2724f777a77ddb9957fe2d8e89febfebbaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930169Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74914}
-
Patrick Thier authored
Instead of compiling a function with baseline immediately when the interrupt budget is hit, we compile functions in batches to save some memory protection flips on code pages. This CL introduces batch compilation behind --baseline-batch-compilation (enabled on future) and adds a flag --baseline-batch-compilation-threshold to control the size of batches. Bug: v8:11790 Change-Id: I3efc360424a14e4b07c6570e48860509ae59e591 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891656Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74913}
-
Manos Koukoutos authored
- Maintain the correct stack in unreachable code for all type casts. - Compute the correct type for the pushed stack value for ref.cast. - Check if current_code_reachable_and_ok_ instead of checking the popped values' types against bottom. - Add unit tests. Bug: v8:7748 Change-Id: I02c26f526060f40884c4ff1e541315f71d8ad90a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928191Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74912}
-
Clemens Backes authored
After https://crrev.com/c/2910080 we can define the histogram as a proper boolean histogram with minimum 0, maximum 1, and 2 buckets. This will map to a chromium histogram with maximum 2, and 3 buckets, but that conversion will happen on chromium's side. R=jkummerow@chromium.org Bug: chromium:1207318 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Change-Id: I176cf2467949591bcc3aa5ad0635cb8b12f20e9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930479Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74911}
-
Camillo Bruni authored
os.system seems to be flaky on certain bots. Disabling this until we have a proper fix. Change-Id: I075542772ba8eb968c96942923f76b87a2f18d47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931809Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74910}
-