- 03 May, 2021 27 commits
-
-
Andreas Haas authored
Additionally a bug in the wasm-to-C wrapper got fixed, which caused problems with the thread-in-wasm flag: An invalid effect-chain got constructed. With the write of the thread-in-wasm flag not being properly placed in the effect chain, the write got scheduled too late. R=jkummerow@chromium.org Bug: v8:11713 Change-Id: I351bf622081850b7b0c7aebfd798d1e73ae34a4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867468 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74340}
-
Michael Achenbach authored
This reverts commit a4c37558. Reason for revert: Speculative revert. Seems to break all gpu builders, e.g.: https://ci.chromium.org/p/v8/builders/ci/Linux%20V8%20FYI%20Release%20(NVIDIA)/14577 See shards for detailed output, e.g.: https://chromium-swarm.appspot.com/task?id=534a8fbeaca4df10 Check failed: valid_arguments. V8.WasmMemoryProtectionKeysSupport Original change's description: > [wasm] Add PKU alloc/free and support counter > > To enforce W^X for the WebAssembly code space, we want to explore using > Intel memory protection keys for userspace, also known as MPK, PKEYs, or > PKU. Instead of flipping page protection flags with mprotect (which > incurs a high syscall overhead; and which switches flags for the whole > process), this associates a key with each page once, and then changes > the permissions of that key with a fast thread-local register write. > That is, this gives both finger-grained permissions (per-thread) and > more performance. > > This CL is starts experimenting with PKUs by > (1) trying to allocate a protection key once per {WasmEngine} in x64 > Linux systems, and > (2) adding a counter for recording the sucess/failure of that, to assess > the support for PKUs on the target machine. > > The low-level PKU allocating functions should be moved into base/platform > long-term, but are inside wasm/ for this CL. > > R=clemensb@chromium.org > CC=jkummerow@chromium.org > > Bug: v8:11714 > Change-Id: Ia4858970ced4d0b84cc8c2651e86dceb532c88a7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850932 > Commit-Queue: Daniel Lehmann <dlehmann@google.com> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74319} Bug: v8:11714 Change-Id: I70349d413ac9092e2f033d138887678bfecaae17 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2868607 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74339}
-
Michael Achenbach authored
This reverts commit 6eee152b. Reason for revert: Revert causes more problems and build failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20builder/52914 Original change's description: > Revert "[compiler] Slightly generalize type assertions" > > This reverts commit ccbfa918. > > Reason for revert: Speculative revert for: > https://ci.chromium.org/p/v8/builders/ci/V8%20NumFuzz%20-%20debug/14050 > > Original change's description: > > [compiler] Slightly generalize type assertions > > > > ... to also apply to common integer bitset types. > > > > Bug: v8:11724 > > Change-Id: I41077488688e924e4235911d3a90e15044c229bd > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865747 > > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > > Commit-Queue: Georg Neis <neis@chromium.org> > > Auto-Submit: Georg Neis <neis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#74330} > > Bug: v8:11724 > Change-Id: I52268d5d553ba271e0a383b6af89b971892a67da > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2868605 > Auto-Submit: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#74337} Change-Id: I60eb5930c4c532fe52865b8e198bae8d08dec23b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11724 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2868606 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74338}
-
Michael Achenbach authored
This reverts commit ccbfa918. Reason for revert: Speculative revert for: https://ci.chromium.org/p/v8/builders/ci/V8%20NumFuzz%20-%20debug/14050 Original change's description: > [compiler] Slightly generalize type assertions > > ... to also apply to common integer bitset types. > > Bug: v8:11724 > Change-Id: I41077488688e924e4235911d3a90e15044c229bd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865747 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Auto-Submit: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74330} Bug: v8:11724 Change-Id: I52268d5d553ba271e0a383b6af89b971892a67da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2868605 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74337}
-
Anton Bikineev authored
Fix crash on Mac64 Debug build. The reason of the failure: misaligned stack. Fix: apply attribute to force the stack be realigned. Original description: > The previous attempt has broken the tsan bot. The only reliable way to > make sure that registers are not clobbered is by doing direct call from > inline assembly, which is what this CL does. > Change-Id: I6adbd5e735949a7cc4cc7fc686ee8c428863ffb9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859947 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74313} Change-Id: I842d6876c2cf287cfe74e53e7cb45028dff61a56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865748 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74336}
-
Georg Neis authored
The DCHECK was outdated since my last change. Tbr: nicohartmann@chromium.org Bug: chromium:1205054, v8:11724 Change-Id: If9dc9614f4cf298e1e29c74abcc1718886197db9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2868265Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74335}
-
Igor Sheludko authored
When fast deleting properties generalize all outgoing transitions to mutable instead of generalizing when property is reconfigured. Bug: chromium:1201938 Change-Id: I080f2f43de1691a742be2a2bec5cd20d02d78dbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859960 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#74334}
-
Thibaud Michaud authored
R=jkummerow@chromium.org Change-Id: Ibc772d81765e10331fa8753e8b7dfd3d18509819 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859864 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Change-Id: I8a8ce7008887f807726ddafdbd8048b64e1e1b84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867472 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#74332}
-
Thibaud Michaud authored
Some cctests set the FLAG_stack_size in the TEST() macro which is run after the cctest runner initializes the main isolate. The flag is only used during isolate initialization, so this did not have any effect. This fixes it by using the UNINITIALIZED_TEST() macro, creating the isolate after setting the flag and passing it through to the WasmRunner. See also https://crrev.com/c/2862778 which fixes JS cctests. R=jkummerow@chromium.org Change-Id: I46df22b80a283d93c48c1dbd250eb3e4ea5ad4a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865749 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Georg Neis authored
... to also apply to common integer bitset types. Bug: v8:11724 Change-Id: I41077488688e924e4235911d3a90e15044c229bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865747Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74330}
-
Camillo Bruni authored
- Add CollapsableElement helper - Collapse all panels by default - Only update panels if they are opened - Only update CodePanel Select element if the data has changed - Fix focusing SourcePosition selection Bug: v8:10644 Change-Id: Id9b5159e86623c7ca0f437dd9db6b0faff3ec573 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859952 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74329}
-
Nico Hartmann authored
This reverts commit 296fa964. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Arm%20-%20debug/18616/overview Original change's description: > [elements] Avoid racy data reads/writes > > Instead of annotating those racy reads / writes to be ignore by TSan, > just use relaxed atomics. This makes us not rely on undefined behaviour, > and is unlikely to introduce noticeable overhead. > > This removes the only uses of TSAN_ANNOTATE_IGNORE_WRITES_BEGIN and > friends, which allows us to remove the whole tsan.h header. > > R=ulan@chromium.org > CC=mlippautz@chromium.org > > Bug: v8:11704 > Change-Id: Ie6694c0ae5b40856b56fb97253ce626ec1f4c263 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859957 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74321} Bug: v8:11704 Change-Id: Ia14b39eccfc02051728a562685a3a8eb8ffde4b6 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867475Reviewed-by:
-
Almothana Athamneh authored
Bug: v8:11694 Change-Id: I52e21a07b3a90d43d321fe9d680b129eb8f9aca7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2866770 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Camillo Bruni authored
We have to take the slow path in Promise.all if context promise hooks are set. The fast-path doesn't create intermediate promises by default. Bug: chromium:1204132, v8:11025 Change-Id: Ide92de00a4f6df05e0ddbc8814f6673bd667f426 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2866771Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74326}
-
Jakob Gruber authored
In the near future we'll have more cases where Ref construction is not guaranteed to succeed. Currently, we don't have convenient patterns to support optional construction. This CL adds the following helpers: base::Optional<FooRef> ref = TryMakeRef(broker, o); if (!ref.has_value()) return {}; // bailout // .. use ref. Or, in the case where construction is guaranteed to succeed: FooRef ref = MakeRef(broker, o); // .. use ref. Bug: v8:7790 Change-Id: I759235c314056c080d79ec413125d3957452c64c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859169Reviewed-by: -
Leszek Swirski authored
In the 'extra' variant, replace turboprop_as_toptier (which is mostly covered by turboprop) with always_sparkplug, to increase Sparkplug's coverage on tests. Bug: v8:11420 Change-Id: I43b7009d184a03cb163d78f1f8bd05233ef7c34e Fixed: v8:11686 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862769 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
.. to avoid the GetIsolate() call. Change-Id: Ia8bf7a4e835d681decbc3965b582c0e788472877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857639 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#74323}
-
Jakob Gruber authored
BigInts are immutable after initialization, thus safe to access concurrently if the Heap::IsPendingAllocation predicate returns false. Bug: v8:7790 Change-Id: Icf3954b1e50af2132846eca5304c7947afb8f298 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856535 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#74322}
-
Clemens Backes authored
Instead of annotating those racy reads / writes to be ignore by TSan, just use relaxed atomics. This makes us not rely on undefined behaviour, and is unlikely to introduce noticeable overhead. This removes the only uses of TSAN_ANNOTATE_IGNORE_WRITES_BEGIN and friends, which allows us to remove the whole tsan.h header. R=ulan@chromium.org CC=mlippautz@chromium.org Bug: v8:11704 Change-Id: Ie6694c0ae5b40856b56fb97253ce626ec1f4c263 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859957Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74321}
-
Michael Lippautz authored
The marking verifier used to run on a different stack than the marker which could lead to it finding more objects than the marker. Fix this by recording a stack end from which the verification starts. This ensures that the verifier only finds a subset of the objects that the actual stack scan finds. Bug: v8:11709 Change-Id: I44fe7b247e56e75deded45b64c25379f1ad9e381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859848 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Daniel Lehmann authored
To enforce W^X for the WebAssembly code space, we want to explore using Intel memory protection keys for userspace, also known as MPK, PKEYs, or PKU. Instead of flipping page protection flags with mprotect (which incurs a high syscall overhead; and which switches flags for the whole process), this associates a key with each page once, and then changes the permissions of that key with a fast thread-local register write. That is, this gives both finger-grained permissions (per-thread) and more performance. This CL is starts experimenting with PKUs by (1) trying to allocate a protection key once per {WasmEngine} in x64 Linux systems, and (2) adding a counter for recording the sucess/failure of that, to assess the support for PKUs on the target machine. The low-level PKU allocating functions should be moved into base/platform long-term, but are inside wasm/ for this CL. R=clemensb@chromium.org CC=jkummerow@chromium.org Bug: v8:11714 Change-Id: Ia4858970ced4d0b84cc8c2651e86dceb532c88a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2850932 Commit-Queue: Daniel Lehmann <dlehmann@google.com> Reviewed-by:Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74319}
-
Jochen Eisinger authored
This task calls through the V8 API, so it needs to create a microtasks scope. Bug: chromium:728583 Change-Id: I47108a64575f1bd670eaea6c8a06720dd4d5552c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865605Reviewed-by:
-
Wenyu Zhao authored
* Mostly are heap/space/page checks. Bug: v8:11641 Change-Id: Ia1726f414109ac5e8a3bdb18ccaa46a63db6bc95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2849823 Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by:
-
Michael Achenbach authored
This will give extra coverage of the mode on the numfuzz tsan bot. No-Try: true Bug: chromium:11655 Change-Id: Ifcc4ad304116fa1b0331cc48e41c07405193d514 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862809 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74316}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d928fcd..3309cd8 Rolling v8/third_party/aemu-linux-x64: BGSmhPgYrPBnQ9dUEMh0QHNL988lWdkmpI87DIIfwkoC..IkJe_PGoF9FZE4NgmhuVPlSogmI0pgjjHezTAckYoEYC TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I43457e9a36ca72417b75ff3e63003482530c6a7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865718Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74315}
-
Michael Achenbach authored
This reverts commit c4cb14c7. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20-%20debug/33969 Original change's description: > cppgc: Try to fix test IteratePointersFindsCalleeSavedRegisters, vol.2 > > The previous attempt has broken the tsan bot. The only reliable way to > make sure that registers are not clobbered is by doing direct call from > inline assembly, which is what this CL does. > > Change-Id: I6adbd5e735949a7cc4cc7fc686ee8c428863ffb9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859947 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74313} Change-Id: I00260aeacdac8704475b37fd99d4ef552c523249 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865746 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74314}
-
- 02 May, 2021 2 commits
-
-
Anton Bikineev authored
The previous attempt has broken the tsan bot. The only reliable way to make sure that registers are not clobbered is by doing direct call from inline assembly, which is what this CL does. Change-Id: I6adbd5e735949a7cc4cc7fc686ee8c428863ffb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859947 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f292eb8..d928fcd Rolling v8/tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 Rolling v8/tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 Rolling v8/tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I972c30f88b7e49a4110608ea2f88c43c3f67cb1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2865309Reviewed-by:
-
- 01 May, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8cc6617..f292eb8 Rolling v8/third_party/aemu-linux-x64: kswh0qF56RoEDBXJbyo1IWPAJ9F7WGAvMHGyWGbpBtUC..BGSmhPgYrPBnQ9dUEMh0QHNL988lWdkmpI87DIIfwkoC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bbfed50..00b6eba Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0d1afc9..f663e54 Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/64cb55e..ba9a763 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ba668f1..7bc447f TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I61de01e618ebe21d4a2cd55b9f0d78bf74dc9857 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2864566Reviewed-by:
-
- 30 Apr, 2021 10 commits
-
-
Clemens Backes authored
This fixes a compiler warning on gcc 7.4. R=ahaas@chromium.org CC=machenbach@chromium.org Bug: v8:11716 Change-Id: I385765f1ac3de17eea1bb56109869636f8ae9d95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862779 Commit-Queue: Clemens Backes <clemensb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Using the default cctest TEST(...) macro causes later writes to FLAG_stack_size to have no effect, because the StackGuard reads that flag's value during Isolate initialization, which is done before the test body is executed. This patch changes the two existing tests that accidentally did this to UNINITIALIZED_TEST, putting them in charge of Isolate creation, thereby ensuring that the intended stack size is configured correctly. Change-Id: Ib030795ef46f23d576f6dbbd26b347ac804b5085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862778Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74309}
-
Dan Elphick authored
This is a reland of e13a744a Fixed jsoncpp BUILD.gn errors by removing missing files. Original change's description: > [build] Fix gn check failures in v8/third_party > > This removes the blanket exclusion for third_party but leaves > third_party/icu excluded (which is the same as chrome). > > Most fixed issues are to do with previously removed header files and > missing dependencies. > > Bug: v8:7330 > Change-Id: I7e634e35c0620a1f3db9aba01119921e4f781e3e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856838 > Auto-Submit: Dan Elphick <delphick@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74295} Bug: v8:7330 Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Change-Id: I4c2c63cc3cb6fb3fabe33717b20ac4a1efeec09b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862772Reviewed-by:
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=mlippautz@chromium.org Bug: v8:11717 Change-Id: I41c4c18dd3f70ec255e9d2769ffd25a38f6f2784 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862764Reviewed-by:
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=pthier@chromium.org Bug: v8:11717 Change-Id: Id930a72e938a82e4dd8117cb2d4834d9dfb7e9e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862763Reviewed-by:
-
Nico Hartmann authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/cab90cb..d5bb24e Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/94367a1..8cc6617 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/5dbd89c..5da6005 Rolling v8/buildtools/linux64: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/f6a8e55..5f51521 Rolling v8/third_party/aemu-linux-x64: KmvDYKZZ-xQz7ZzzSKBh3HrWPpQv89vfFY9mBp6RDq4C..kswh0qF56RoEDBXJbyo1IWPAJ9F7WGAvMHGyWGbpBtUC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ca2c407..bbfed50 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ae1b2b1..0d1afc9 Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/835951a..64cb55e Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/0949050..e8da4da Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 Rolling v8/tools/luci-go: git_revision:a3a1f3a2e925eb44367c62783877c922c9ef7289..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id081f2b8d4214852d1bb19eab4df82379db03ba5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862144Reviewed-by:
-
Vicky Kontoura authored
This CL adds support for oddballs false, true, null and undefined. Bug: v8:11525, v8:11706 Change-Id: I0dc870f05578c0eb9ff06bf2ccd2474e18464566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2856843 Commit-Queue: Vicky Kontoura <vkont@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74304}
-
Jochen Eisinger authored
Tracking the context is not enough, as we might clear the context to avoid repeatedly reentering the same context. Also fix unittests that relied on the default microtask queue getting automatically processed instead of the one of the current context. Bug: chromium:728583 Change-Id: Ia9a51c513fc7363a518af86cc54c5bda26b5fbe8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859850Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#74303}
-
Clemens Backes authored
cpplint rules change over time, and we change the exact rules we enable for v8. This CL removes NOLINT annotations which are not needed according to the currently enabled rules. R=jkummerow@chromium.org Bug: v8:11717 Change-Id: I29e8dfca88f871b5d6b4c6422d036157021514da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2862762Reviewed-by:
-
Benedikt Meurer authored
Previously we'd attach source positions to implicit returns that are generated when leaving an async function with a promise rejection. This was due to the use of `kNoSourcePosition` on the `end_position` in the `ReturnStatement` nodes as indicator to pick the return position from the function literal, instead of really not putting a source position on that specific `Return` bytecode. This CL adds a dedicated marker to `ReturnStatement` to express that the `BytecodeGenerator` should put the return position from the function literal there instead of overloading the meaning of `kNoSourcePosition`. Bug: chromium:901819, chromium:782461 Fixed: chromium:1199919, chromium:1201706 Change-Id: I3647e0c3d711e9c3d6ae44606b70ec92ad82e1cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859945 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
