- 24 Feb, 2021 38 commits
-
-
Austin Eng authored
- Add a CFunctionBuilder interface to allow adding modifier flags to argument types. This will be used to support IDL attributes like [EnforceRange], [Clamp], and [AllowShared]. This CL adds only the interface, but the actual modifier flags do not exist yet as they would not be implemented. - Remove the internals of the old CFunction type inference and implement it on top of CFunctionBuilder. Bug: chromium:1052746 Change-Id: I09a7cba07105097517a8426a8eeb891393883ac6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2686686Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#73024}
-
Omer Katz authored
Two threads might get the same PersistentNode because the BasicCrossThreadPersistent ctor wasn't taking a lock. Then if one thread frees the node and the other initalizes it or updates its owner, we get some random object in our free list of PersistentNodes. I debug a crash in Assign(Unsafe) and Clear where the PersistentNode seemed to be allocated on stack. Empirically, adding this guard resolved it. I can't confirm in the code that the scenario above is what was happening. Drive-by: adding a few DCHECKs. Bug: chromium:1056170 Change-Id: I37d8ed5bb942a124c98d7524b7f04fe8ccb2aefd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718144 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73023}
-
Igor Sheludko authored
... to match what the builtin expects. Bug: v8:11499, v8:11429 Change-Id: I6e784f6c5109f8d92446e98b8abb7274d5a166a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718151 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73022}
-
Milad Fa authored
Change-Id: I9b40a06bdfd3b38aa25d05f2c3b8605f480b1236 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718465Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73021}
-
Frank Emrich authored
This CL is part of a series that adds the C++ implementation of SwissNameDictionary, a deterministic property backing store based on Swiss Tables. This CL adds the Add, DeleteEntry, Rehash, and Shrink operations, as well as some helpers required by those. Bug: v8:11388 Change-Id: I81a181e99e679095c2acc877a293e81b6a581db4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715192Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73020}
-
Thibaud Michaud authored
This was staged through a back-merge in v8.9. Also stage it for the upcoming v9.0 release. R=clemensb@chromium.org Bug: v8:8091 Change-Id: Ib9e8c33ca258c8b9e407fbcca5db9f0227b558b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718150Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73019}
-
Seth Brenith authored
Currently, some ScopeInfo fields are defined as indexed fields with a length of either one or zero, because the field might be present or it might not. Based on comments in https://crrev.com/c/v8/v8/+/2601880 , this strategy is not sustainable and we need a better way to represent optional fields so that we don't have to pass zero when accessing their only element. This change is a proposal to fix that problem. Syntax: I'm proposing using a question mark because TypeScript does, and Torque syntax looks somewhat like TypeScript. I don't feel strongly about this though, and I'm open to other suggestions. field_name?[condition_expression]: FieldType; Internal Torque compiler representation: Internally, I've updated the Torque compiler to still treat these fields as indexed, but with an extra flag saying they're optional. When getting a LocationReference for a field access expression on an optional field, Torque produces a Slice like it would for any other indexed field and subsequently calls AtIndex(0) to get a Reference. AtIndex can crash the process if the index is out of bounds (which is good), so some other parts of the Torque compiler need minor adjustments so that it doesn't take references to optional fields unless it actually needs them. Initialization: This proposal doesn't include any changes to initialization logic, so an optional field can still be initialized using '...' and an iterator. Perhaps we could introduce an Optional<T> struct for prettier initialization in a future change. Bug: v8:7793 Change-Id: I37649495f4c259e685261f53e4cf2859da66a31f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2706306 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73018}
-
Junliang Yan authored
Port 96a0677a The precise type is only used for validation. For code generation, knowing the kind is more than enough. Hence, only store and pass the ValueKind in Liftoff, and not the full ValueType. Change-Id: Ia3a07df393b2f93d8d8c51bd41b3bd3a3bd6c6fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715987Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73017}
-
Thibaud Michaud authored
This reverts commit 1db61fb3. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/34083/overview Original change's description: > [wasm][eh] Stage exception handling > > This was staged through a back-merge in v8.9. Also stage it for the > upcoming v9.0 release. > > R=ahaas@chromium.org > > Bug: v8:8091 > Change-Id: Ie9e6d25bbc5d428e5c9128345209f95f2078b733 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715524 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73013} Bug: v8:8091 Change-Id: I18b9706e8aab4883a3d3c120a6cd06e7232aecf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718148 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73016}
-
Seth Brenith authored
This is a partial reland of https://crrev.com/c/v8/v8/+/2601880 . I think it makes more sense to list ScopeInfos under "(system)" in the dev tools, like most other V8 internal types. Change-Id: If85f869e805d7c374fc7584a79155bb4f400e4b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707249Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73015}
-
Manos Koukoutos authored
Some helpers that depend on a MachineGraph or WasmGraphAssembler are moved into WasmGraphAssembler. Also, GetAsmJsOOBValue is inlined. Change-Id: I8760218cdba1e0f1564cdb044def4a68b348eac3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717303Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73014}
-
Thibaud Michaud authored
This was staged through a back-merge in v8.9. Also stage it for the upcoming v9.0 release. R=ahaas@chromium.org Bug: v8:8091 Change-Id: Ie9e6d25bbc5d428e5c9128345209f95f2078b733 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715524 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73013}
-
Mike Stanton authored
Perform relaxed reads/writes on the builtin index. Bug: v8:11478, v8:7790 Change-Id: I488fd30e6635f39bb46440e9d5230ab311825e7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716290Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#73012}
-
Milad Fa authored
Port 31aab838 Original Commit Message: Extract code sequence into macro-assembler for sharing between Liftoff and TurboFan. Relax the register aliasing requirements (remove the DCHECKS), this will not affect codegen for TurboFan since the instruction selector already sets the correct restrictions, but makes it more flexible for use in Liftoff. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I729095aae0412fce70ec97a1d7c5f27d32b1a932 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718143Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73011}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: Ib2b2788c7d59f873583e26a0716bacbf16766c93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716291Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73010}
-
Manos Koukoutos authored
Design doc: https://docs.google.com/document/d/1AsUCqslMUB6fLdnGq0ZoPk2kn50jIJAWAL77lKXXP5g/ Currently, wasm loop unrolling is disabled by default. We intend to further investigate its compilation time cost and running time benefits before enabling it. Additional changes: - Introduce LoopFinder::FindUnnestedLoopFromHeader() as a lightweight loop analysis. - Move EliminateLoopExit into LoopPeeling and expose it. - Introduce loop_info_ field into WasmGraphBuildingInterface, fill it up in Loop(). - Break after encountering the first loop in BuildNestedLoopExits. - Introduce struct WasmLoopInfo. A WasmLoopInfo vector is instantiated in ExecuteTurbofanWasmCompilation, passed to BuildGraphForWasmFunction to be filled up by WasmGraphBuildingInterface, and then passed to GenerateCodeForWasmFunction to be used in WasmLoopUnrollingPhase. - Introduce WasmLoopUnrollingPhase and insert it into the wasm compilation pipeline. - Fix an issue where exception values were not wrapped in WasmGraphBuilderInterface. - Update --wasm-loop-unrolling flag description. Bug: v8:11298 Change-Id: I4b57cf2ea8520931f60769f843ffd57b3ca6399b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697349 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73009}
-
Kim-Anh Tran authored
This adds a re-compilation of top level functions in getPossibleBreakpoints if no candidates could be found. This step is necessary as the GC may remove SharedFunctionInfo about top-level functions. Bug: chromium:1137141 Change-Id: I8830438d78751ba318d65f43d790ee98f306a57e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696154Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#73008}
-
Junliang Yan authored
Change-Id: I60b9cb6e0f7552fbdc35b62b6b379c8ac5f203e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716323Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73007}
-
Jakob Gruber authored
The available constants are now: JSObject { kMaxElementCount = kMaxUInt32, kMaxElementIndex = kMaxElementCount - 1, } JSArray { kMaxArrayLength = JSObject::kMaxElementCount, kMaxArrayIndex = JSObject::kMaxElementIndex, } I also updated the codebase to use the new constants. Change-Id: I3142f9ff9627c9acb1d4493729b490150fdcdf50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712755Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73006}
-
Georg Neis authored
It had essentially become a synonym for BytecodeArrayAccessor. This removes the BytecodeArrayIterator class and renames BytecodeArrayAccessor to BytecodeArrayIterator. Change-Id: I79cf8574f3c8804822f90c8f921c17ca7ab85f48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715523 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73005}
-
Gus Caplan authored
Bug: v8:10855 Change-Id: I0f28603421ba36176d177bfcc25f18a26a097c29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716062Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Gus Caplan <snek@chromium.org> Cr-Commit-Position: refs/heads/master@{#73004}
-
Leszek Swirski authored
We were using CmpInstanceType instead of CmpObjectType in some places, which meant that we were reading the value at the instance type field offset within objects directly, rather than first loading their map and reading the instance type there. Bug: chromium:1180434 Change-Id: I4771b4f8f9a32bdc35944c6e6cd30c54e4ac8b6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716292 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73003}
-
Sathya Gunasekaran authored
Bug: v8:11321 Change-Id: Ica350e9a613d6dddb17569ce5b2df072ceb2c050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717156 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#73002}
-
Manos Koukoutos authored
These functions are defined in WasmGraphBuilder, so we do not need to invoke them in mcgraph() or gasm_. Change-Id: Ibd97add56d22bff7eb99addd78bf599057b21041 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717302Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73001}
-
Omer Katz authored
Assert that the lock is help whenever AssignUnsafe is called. LazyMutex::AssertHeld resolves to a DCHECK so this should not regress production performance (other than the call itself that might not be inlined). Bug: chromium:1056170 Change-Id: Ic2005d180e6960c24dff7743aa3e0d5e57a63d80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716286Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73000}
-
Georg Neis authored
Bug: v8:7790 Change-Id: Iae4374e352aea0169d4fe1eba5d825c16efe3940 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715198 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#72999}
-
Emanuel Ziegler authored
When calling new WebAssembly.Table, the returned error message refers accidentally to the WebAssembly.Module() constructor. There will be a corresponding Chromium CL fixing expected error messages in WPTs. R=ahaas@chromium.org Bug: v8:11356 Change-Id: I57f5e071d5c542615523345283d7c3613fb7a616 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2663155Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#72998}
-
Clemens Backes authored
The precise type is only used for validation. For code generation, knowing the kind is more than enough. Hence, only store and pass the ValueKind in Liftoff, and not the full ValueType. R=manoskouk@chromium.org Bug: v8:11477 Change-Id: Ia42c0fa419f75b508bd2f210c767b631e93d3398 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707170 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72997}
-
Dan Elphick authored
These are headers that are used by the inspector, debugger and other parts of chrome so they should be in the main v8_headers target. test-api-interceptors.cc does not use anything from v8-util.h so remove the include and some other unneeded using declarations. Bug: v8:7330 Change-Id: Iea1546de3fc2dbc1c41f0dd7109b6c7ef5557045 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716384 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72996}
-
Jakob Gruber authored
Upcoming CLs will need atomic accessors for non-smi values. This CL adds the full set of relaxed and acquire/release indexed accessors, and I also take the opportunity to update the old `synchronized_set(i, v)` style to `set(i, v, ReleaseStoreTag)`. Bug: v8:7790 Change-Id: Ic4fa4ec52319ec943415f0e9ae515a00b04cbbc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717305 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72995}
-
Michael Achenbach authored
No-Try: true Bug: v8:11134 Change-Id: Ic63d0ffc0d64a3f06048cf811a526afd46e34cae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2714548 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#72994}
-
Dan Elphick authored
Add missing dependencies to wasm_test_common and lib_wasm_fuzzer_common, reducing gn check errors from 174 to 170. Bug: v8:7330 Change-Id: I30eaba6e411e714ee3648eb2df165239b3cff5e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716382 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#72993}
-
LiuYu authored
Besides, implement extended add pairwise and i64x2.abs in liftoff. Port: aee85229 Port: 8136e399 Port: 31aab838 Bug: v8:11086 v8:11416 Change-Id: I77539c745b67c6b9d4205b4e5e96504e5ad3da13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717150 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72992}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ac7b73c..446bf3e Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/80d14c9..4c78ef9 Rolling v8/third_party/aemu-linux-x64: GzdPpQtyS5ZFre4nU7kS8n0fu_RX5NV9C2PkWL0tWEYC..qI8e328VwkWv64EapCvG3Xj9_hDpKQFuJWeVdUHz7W0C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/832539c..81c9d30 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e71d028..5fe664f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/bf8c8f3..cfd0f62 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I611cd60376faf9e6aa611143e7dbf704f46a8f44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716636Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72991}
-
LiuYu authored
Besides, skip write barrier for storing Smis. Port: a3776a63 Port: 1c507667 Change-Id: I4626c1811e3e23e06adccd65fabc8bc41b6628f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717301 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72990}
-
Ng Zhi An authored
Use external refs to load the masks neded for i8x16.swizzle. Before it would need 3 instructions (2 moves + 1 pshufd), now it requires 2 moves. Also on AVX we can relax the dst == src requirement, which can potentially save a move too. Bug: v8:11346 Change-Id: If350529de7272a7b178e12778a5e02813b34631c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2713168Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72989}
-
Ng Zhi An authored
Compact some of the name definitions for wasm opcodes. With the proposal being in phase 4, the instruction set is fixed, we can now merge some of the adhoc i64x2 instructions in with the rest. Bug: v8:11384 Change-Id: I94553b9f2daaa4804deaf1bb18933847897a4213 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2708759Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72988}
-
Ng Zhi An authored
Extract code sequence into macro-assembler for reuse between Liftoff and TurboFan. Bug: v8:11086 Change-Id: I914051dd8126e89f297e892da1b5c1917b47d7f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707763Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72987}
-
- 23 Feb, 2021 2 commits
-
-
Ng Zhi An authored
Extract code sequence out into macro-assembler for sharing between Liftoff and TurboFan. Bug: v8:11415 Change-Id: I76a5124eea917dc15385c90ce82fccdb31619295 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707772Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72986}
-
Ng Zhi An authored
Extract code sequence into macro-assembler for sharing between Liftoff and TurboFan. Bug: v8:11416 Change-Id: I8cdce30db8081f6b6c96cca1cbacd035dfc03de4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707768 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72985}
-