- 21 Jul, 2022 18 commits
-
-
Jakob Kummerow authored
Prints information about frequency and aggregate size of instructions. Change-Id: Ia745c0e5e26fbc5e24437302ba171bd05600577d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773779Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81875}
-
Omer Katz authored
Bug: v8:12612 Change-Id: I4d9de4446d343040ae29e25d23a09cf4c740bde0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743448 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81874}
-
Thibaud Michaud authored
Add a test where the GC gets called during parameter conversion, and fix two related issues: - Reorder spilled references so that they are at the top of the stack before the builtin call - Add the missing frame marker on the new stack R=ahaas@chromium.org Bug: v8:12191 Change-Id: I3f68c675123c726543df6942d110fe06bc6c0efb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780530 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#81873}
-
Omer Katz authored
See a description of the different classes and how they integrate in https://docs.google.com/document/d/1wNj_akGSh6RBMC2RvH8HIlSUqkjWrpGkxI_BTZ-zdXE/edit# Bug: v8:12612 Change-Id: I0f2141f4ada5c964e985d109133902172d1ab605 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641178Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#81872}
-
Camillo authored
The CpuProfile previously emitted a CpuProfileMaxSamplesCallbackTask if there was a sample where V8 could not resolve the stack. This resulted in a premature "samplebufferfull" events for the self-profiling API. Skipping over samples without a resolved stack solves this issue. Bug: chromium:1334366 Change-Id: If7a375dbf533c391307e8e506b37c0e3705f63b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776680Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81871}
-
Liviu Rau authored
Bug: v8:12785 Change-Id: Icae27e743824a234d51946747402c2c4e2bb9ec2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779686 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81870}
-
V8 Autoroll authored
Change-Id: Ibc132bb36976c8286e641155955f31e7fdf24331 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780298Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#81869}
-
ishell@chromium.org authored
... by removing the unused Code* argument. Bug: v8:11880 Change-Id: Icec0c448e844a371ec1751a30419f79dc11876d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3777717 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81868}
-
Andreas Haas authored
R=clemens@chromium.org Bug: v8:12926 Change-Id: Ie0744464f0f849e2ee4ec09cfc318bbf1f8b2dc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757890Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#81867}
-
Clemens Backes authored
The previous declaration was failing on GCC, because the argument types did not match the actual constructor. The second parameter needs to be a reference. R=jkummerow@chromium.org Bug: v8:13069 Change-Id: I151b44e05cd8b45da8f737ab84da063e491f3292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779683Reviewed-by:
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I1cba243972ac9a22ef4a5873d6d6d1e55b99cb55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779678 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Introduce `TraceStrongContainer()` to retain containers strongly. This makes the use of `Trace(T*)` obsolete as all other use cases should refer to Member overloads. Bug: v8:13089 Change-Id: Ib0e762bf3298f1818528e45cc842d14a63f2c684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779680Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81864}
-
ishell@chromium.org authored
... in various components. Bug: v8:11880 Change-Id: I1e4411ec38a4b15e505bda35a92987972e89d9d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3777718 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Some tests and testing infrastructure had to be changed because it relied on nominal types. Drive-by: Support function supertypes in wasm-module-builder.js. Bug: v8:7748 Change-Id: Ife92431d1842ff9de91e296a50421aa48f02c0de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776197Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81862}
-
Thibaud Michaud authored
See https://github.com/llvm/llvm-project/issues/56560 R=ahaas@chromium.org Bug: chromium:1344641 Change-Id: I1cc475e1bb678029f7418cb440c52a150eba9a8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3778717Reviewed-by:
-
Lu Yahan authored
Change-Id: I0b7b4daf5b88341ba56076137b8d34bdfcd45c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773329Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#81860}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7aa2227..be25fb2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7fe7c6720f856a8db4eb38df498f292fb8446361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779225 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81859}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0c6b8d6..abcd8ba Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9585c93..39e33e6 Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220719.2.1..version:9.20220720.2.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ibe9163f4977034279eb7fb1afa61a9e80ad40a7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779221 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81858}
-
- 20 Jul, 2022 22 commits
-
-
Milad Fa authored
Change-Id: Ia45248a3d8566dbb4f2702a8b1ea6959157dc76b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776949 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81857}
-
Seth Brenith authored
Background: In order to show custom content in the "Locals" pane in WinDbg, v8windbg replaces the getter function for a built-in debug model property named "Debugger.Models.StackFrame.LocalVariables". This is the property that the debugger fetches when determining what to display in "Locals". The new implementation of that getter, V8LocalVariables::GetValue, can either call the original getter (so that WinDbg displays the usual content for normal C++ frames) or produce a custom result (for builtins and JIT-compiled JS frames). The current problem: In new builds of WinDbg, users of v8windbg no longer see any content in the Locals pane for stack frames that correspond to builtins or JIT-compiled code. This is because of a behavior change in WinDbg: previously, attempting to get Debugger.Models.StackFrame.LocalVariables would eagerly attempt to find the symbols for the frame and return an error code if symbols were not found, but now it returns a lazy object which does not perform symbol lookup until you iterate its properties. V8LocalVariables::GetValue currently starts with an early-exit path based on checking whether the original getter succeeded, so the new lazy implementation causes us to always take that early exit. Proposed fix: Rather than relying on the return value from the original getter, which is not guaranteed to work consistently, we can base our decisions on the instruction pointer. If it points outside any module, or if it points to within a function in the module containing V8 whose name starts with "Builtins_", then we can build a custom result for the Locals pane. Change-Id: I6644071d5d83a25b964d9f4018265532528cc85c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3759228Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#81856}
-
Dominik Inführ authored
In order to make the shared code write barrier thread-safe, we simply lock the page mutex when appending to the typed_slot_set. We can later improve this when performance isn't good enough. Bug: v8:13018 Change-Id: I5e12f83f459f8976c22ec488cfa9b6f16d4a8a8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763867Reviewed-by:
-
ishell@chromium.org authored
... in favour of Builtins::name(). Bug: v8:11880 Change-Id: I1e06314aec71ea367cd8096316e8fb9aceb63feb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776686 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
Enable a clang warning that embedders might enable, and fix issues found by it. R=ahaas@chromium.org, nicohartmann@chromium.org, mlippautz@chromium.org Bug: v8:13069 Change-Id: I935f18872178f4421b441f33ef8ab1d8f030dfc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3760443Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
Instead of one big test which tests multiple functions, split the unit test into multiple smaller tests. Also, use TestWithZone instead of TestWithIsolate, because the isolate is never used. R=jkummerow@chromium.org Bug: v8:12425 Change-Id: I32148e40b5ed2b006cc647d42bdfe564ccc6d0ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776676 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Marja Hölttä authored
This reverts commit 218d17d3. Reason: Temporary things should be temporary. Bug: v8:11111 Change-Id: Ic7c9d01d4c75863ceee89efe8493da3a84eb0894 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776683 Auto-Submit: Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: I09e9d919751945e99e0178168358a3f269fa34a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776679 Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Reviewed-by:
-
Clemens Backes authored
Setting the highest bit first saves cost for repeatedly growing the underlying bitvector. R=jkummerow@chromium.org Bug: v8:13063 Change-Id: Ic324caa20c91dd6f55760944c3dafe7f1dc018b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776340 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Pop the correct number of bytes from the stack on return from the WasmResume builtin. R=ahaas@chromium.org Bug: v8:13078 Change-Id: Ie1fffe1d02baab0ed91deca7dccadf1539068dd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776338Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I62b5d90dac8f4424488aa89569494fccff09ca89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776196Reviewed-by:
-
Manos Koukoutos authored
This way we make tests more flexible wrt. future changes, especially when it comes to module offsets. Bug: v8:12868 Change-Id: Ie99806603603e5c731c61267469b14f81c88ffac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776195Reviewed-by:
-
Jakob Kummerow authored
By making "v8_heap_base_headers" a "v8_header_set" instead of a "v8_source_set". Reported by Paul Harris on v8-users@. Change-Id: I33263230631766e73f5d13aab497c47c98f807b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776339 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Some follow-up after getting rid of `let`. Change-Id: I073372f4edd0847c4ffa428595a6f74158c87a98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773515Reviewed-by:
-
Maya Lekova authored
This CL hardens a test to avoid static_cast-ing doubles that don't fit into the 32-bit integer range. Bug: chromium:1344965 Change-Id: I1f3a05800158cda9dc582bfa4427516932db9679 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776337 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: chromium:1284275 Change-Id: Id429806b802282b7b045628fd8a3371618eb9f7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3774123 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Now that the main thread has its own LocalHeap, we don't need a separate instance of MarkingBarrier in Heap for the main thread anymore. We can just use the MarkingBarrier in main_thread_local_heap(). This makes code between main and background threads more uniform. Bug: v8:13018 Change-Id: I3d2dab1b11815df9a92c2fa7eebf52bf2cb130f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769687Reviewed-by:
-
Andreas Haas authored
Tasks may contain Globals, which have to get destroyed before isolate shutdown. R=cbruni@chromium.org Bug: chromium:1345081 Change-Id: I915baafd870c7bb8475b19736878179d8a22ca5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3770108 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Backes authored
Normalize flag names, and print boolean flags using the canonical "--no-<foo>" syntax. Before (with fuzzing): Cycle in flag implications: assert_types -> concurrent_recompilation = 0 stress_concurrent_inlining -> concurrent_recompilation = 1 After (with fuzzing): Cycle in flag implications: --assert-types -> --no-concurrent-recompilation --stress-concurrent-inlining -> --concurrent-recompilation Before (no fuzzing): Contradictory flag implications from --assert_types and --stress_concurrent_inlining for flag concurrent_recompilation After (no fuzzing): Contradictory flag implications from --assert-types and --stress-concurrent-inlining for flag --concurrent-recompilation R=tebbi@chromium.org Bug: chromium:1336577 Change-Id: Id82cff4845d845e964c43b922067905b8b378a0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750935Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81839}
-
Andreas Haas authored
This reverts commit 9981f2e5. Reason for revert: This CL landed by accident, we decided back then to land a different CL. Original change's description: > [d8] quit() should not dispose the isolate > > R=cbruni@chromium.org > > Bug: chromium:1338150 > Change-Id: I5e5f8ede942dd37112766812a3c84a356f0b6ca9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714355 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81827} Bug: chromium:1338150 Change-Id: Ib058d90a0c09e7cc65bdecee20580dd9e1f184d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773776 Commit-Queue: Clemens Backes <clemensb@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: chromium:1340816 Change-Id: Ic49c5e00a90085b575465bbb463645977ee1d34b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3768987 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This CL re-structures the write barrier slow path in order to prepare for adding the shared write barrier. Behavior remains the same in this CL, only code structure changes a bit (e.g. the branch for when marking is off, got moved up to the IsMarking() check). Bug: v8:13018 Change-Id: I991f896abb88e0c85de3123fa67d8f47282f632d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771840 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
