- 22 May, 2017 15 commits
-
-
bmeurer authored
Introduce a new Symbol comparison feedback bit in the lattice and collect that feedback on Equal/StrictEqual in Ignition. Utilize this feedback in TurboFan by adding a dedicated CheckSymbol operator to check for symbol inputs. This way we can optimize Symbol comparison where TurboFan doesn't know anything statically about either side, or abstract equality comparisons where TurboFan doesn't statically know anything about one side. BUG=v8:6278,v8:6344,v8:6423 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2893263002 Cr-Commit-Position: refs/heads/master@{#45455}
-
Raphael Kubo da Costa authored
Most of the plumbing is already present in the non-public API. According to ES2016, Symbols are also accepted in calls to getOwnProperty(), and taking them is required in Blink for proper record<K,V> WebIDL conversions. R=jochen@chromium.org,verwaest@chromium.org Bug: chromium:724481 Change-Id: I0dfe0e57f6d811f04ecbfd8ec0c97e44c9f02c96 Reviewed-on: https://chromium-review.googlesource.com/509611Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#45454}
-
Ross McIlroy authored
Special cases addition expressions where one of the sides is known to be a string to enable chains of string additions to be transformed into a series of ToPrimitiveToString operations followed by a single string concatenation at the end of the chain of additions. This should avoid creating temporary strings for each of the string additions (in essence this is an automated string builder). BUG=v8:6243 Change-Id: I44977d6dad00ee906f251c4bd9cab27e160c09d1 Reviewed-on: https://chromium-review.googlesource.com/493966 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#45453}
-
Michael Starzinger authored
This makes sure that function imports without a single call site within the asm.js module are still preserved in the WebAssembly module, hence preserving intended JavaScript semantics during module instantiation. R=clemensh@chromium.org TEST=mjsunit/regress/regress-crbug-722348 BUG=chromium:722348 Change-Id: I624d0e52b32b864c1e3002187a99a0a63834a4b0 Reviewed-on: https://chromium-review.googlesource.com/509450Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45452}
-
predrag.rudic authored
BUG= Review-Url: https://codereview.chromium.org/2890613003 Cr-Commit-Position: refs/heads/master@{#45451}
-
Ross McIlroy authored
Add support for direct jumping on True/False for strict equals of boolean literals. This improves the score for such comparisons by around 75% on baseline code, and by around 40x on optimized code for the added performance test. Bug=v8:6403 Change-Id: I81ea16a057e081eb6d159cd64c8e8615f65f9abb Reviewed-on: https://chromium-review.googlesource.com/509570 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Andreas Haas authored
With this CL we do not spawn a FinishCompilationUnit foreground task for every WebAssembly function we compile, but instead spawn one foreground task which finishes all existing compilation units (FinishCompilationUnits). A new FinishCompilationUnits task is spawned whenever a compilation task sees that there in no FinishCompilationUnits to finish its compilation unit. In addition the FinishCompilationUnits task gets a time limit. Whenever it is executed for longer than 1ms (this value is also used by the GC), then the task stops and reschedules itself. Thereby we make sure that we do not block the main thread for too long. Change-Id: Ib4f2aed91c60f9c8952b6ba4dd7e5052301417a3 Reviewed-on: https://chromium-review.googlesource.com/508708 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Camillo Bruni authored
BUG: v8:6211 Change-Id: Ief28872f6ce97ff326f9a86367f872e321b2612a Bug: Reviewed-on: https://chromium-review.googlesource.com/508650 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#45448}
-
Jochen Eisinger authored
R=danno@chromium.org CC=sshruthi@chromium.org TBR=verwaest@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,rossberg@chromium.org Change-Id: I32e09193fa6e847ac3336eab62b6d85c46d71164 Reviewed-on: https://chromium-review.googlesource.com/509508 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#45447}
-
Ross McIlroy authored
Only FullCodegen code ever gets flushed by code flushing. Since we are deprecating the old pipeline, the added complexity introduced by code flushing is no longer worth it. This CL removes it (but keeps code aging, which is used to unlink SFIs from the compilation cache). BUG=v8:6389,v8:6379,v8:6409 Change-Id: I90de113a101f86dbeaaf0511c61a090ef12aa365 Reviewed-on: https://chromium-review.googlesource.com/507388 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45446}
-
jgruber authored
Revert of [csa] Add assertions to CSA (patchset #14 id:260001 of https://codereview.chromium.org/2847923003/ ) Reason for revert: Linux-nosnap failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/13282 Original issue's description: > [csa] Add assertions to CSA > > This adds a bunch of assertions to CSA, mostly about documenting and checking > parameter types. > > Drive-by-change: Removed unused function. > > BUG=v8:6325 > > Review-Url: https://codereview.chromium.org/2847923003 > Cr-Original-Commit-Position: refs/heads/master@{#45398} > Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd > Review-Url: https://codereview.chromium.org/2847923003 > Cr-Commit-Position: refs/heads/master@{#45443} > Committed: https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b701dda TBR=cbruni@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6325 Review-Url: https://codereview.chromium.org/2893253002 Cr-Commit-Position: refs/heads/master@{#45445}
-
mvstanton authored
An oversight in Friday's CL. Thx to neis@chromium.org for the tip! BUG=v8:6351 TBR=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2893223002 Cr-Commit-Position: refs/heads/master@{#45444}
-
jgruber authored
This adds a bunch of assertions to CSA, mostly about documenting and checking parameter types. Drive-by-change: Removed unused function. BUG=v8:6325 Review-Url: https://codereview.chromium.org/2847923003 Cr-Original-Commit-Position: refs/heads/master@{#45398} Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd Review-Url: https://codereview.chromium.org/2847923003 Cr-Commit-Position: refs/heads/master@{#45443}
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2892153003 Cr-Commit-Position: refs/heads/master@{#45442}
-
dgozman authored
BUG=none Review-Url: https://codereview.chromium.org/2894773003 Cr-Commit-Position: refs/heads/master@{#45441}
-
- 21 May, 2017 2 commits
-
-
gdeepti authored
Currently SIMD integer comparison ops are implemented using Lt/Le, this is sub-optimal on Intel, because all compares are done using pcmpgt(d/w/b) that clobber the destination register, and will need additional instructions to when using Lt/Le as the base implementation. This CL proposes moving to Gt/Ge as the underlying implementation as this will only require swapping operands on MIPS and is consistent with x86/ARM instructions. BUG=v8:6020 R=bbudge@chromium.org, bmeurer@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2874403002 Cr-Commit-Position: refs/heads/master@{#45440}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c11a9f7..1caf3a6 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I9f6bc987a022b085a0baaf1eb67ea23fa5513794 Reviewed-on: https://chromium-review.googlesource.com/509232Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#45439}
-
- 20 May, 2017 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8da5cdf..c11a9f7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/b1c6aa7..08a6e0a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ba46613..05f3060 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I4e2d640fd4963ca190325ffeb1dce6a71e4346e5 Reviewed-on: https://chromium-review.googlesource.com/509174Reviewed-by:
-
- 19 May, 2017 22 commits
-
-
Loo Rong Jie authored
Bug:v8:6055 Change-Id: Ifeac048e5bee2d1782cdaaabe9f5257129b7be0e Reviewed-on: https://chromium-review.googlesource.com/508528Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Loo Rong Jie <loorongjie@gmail.com> Cr-Commit-Position: refs/heads/master@{#45437}
-
Eric Holk authored
The WebAssembly code now uses these new APIs to allocate memory with guard regions. Guarded array buffers are no longer always external, which eliminates a lot of special cases around WebAssembly memory. Bug: chromium:720302 Change-Id: I355b74ac30a05a18c8b363bd256d57458742849f Reviewed-on: https://chromium-review.googlesource.com/505715Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#45436}
-
thomasanderson authored
All targets (at least on sanitizer builds) unconditionally depend on //build/config/sanitizers:deps. It is necessary for bug 593874 that all targets now also depend on //buildtools/third_party/libc++:libcxx_proxy. This requires adding a new "global dependency": //build/config:exe_and_shlib_deps. This CL updates references to sanitizers:deps to instead refer to //build/config:exe_and_shlib_deps. BUG=chromium:723069 R=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2894013003 Cr-Commit-Position: refs/heads/master@{#45435}
-
mvstanton authored
GeneratorClose is pretty simple, we can handle it in the interpreter. BUG=v8:6351 Review-Url: https://codereview.chromium.org/2891353002 Cr-Commit-Position: refs/heads/master@{#45434}
-
Camillo Bruni authored
This CL enforces passing an AssemblerDebugInfo object to Bind, most convently acheived by the BIND macro. Change-Id: I092714f10803f529d01d2fe716b96275b2bee806 Reviewed-on: https://chromium-review.googlesource.com/508729Reviewed-by:
-
Camillo Bruni authored
Change-Id: Id3b29978232ab7838224d6a38da345915fa00f22 Reviewed-on: https://chromium-review.googlesource.com/507307 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:720477 Change-Id: I49af460d06f045731d847d68b7276edae72d95a4 Reviewed-on: https://chromium-review.googlesource.com/509690Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45431}
-
Franziska Hinkelmann authored
Call the templated handle(T) function instead of Handle<T>() as it's slighly simpler to read. Bug: Change-Id: I7d8dc6ffae1dc1c609cd6bce230adbe62aaf451b Reviewed-on: https://chromium-review.googlesource.com/509568 Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This fixes crashes during validation when trying to construct modules with excessively large function tables. The {WasmModuleBuilder} now gracefully checks against existing WebAssembly implementation limits. R=clemensh@chromium.org TEST=mjsunit/regress/regress-crbug-715455 BUG=chromium:715455 Change-Id: Ia9738cb0b49a1eb4caf073b75301c0303f295699 Reviewed-on: https://chromium-review.googlesource.com/509530 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Mythri authored
In the current implementation the decision to inline polymorphic function calls applies to all functions. Either we inline all of them or none of them. Also, we decide to inline if the size of one of function is less than the FLAG_max_inlined_nodes. This cl changes it to a decision on individual functions. In the case of polymorphic calls, we might inline some of the functions and not inline others. Bug: Change-Id: I2f4049b5e55445b4858b260d289c96090c6aaa74 Reviewed-on: https://chromium-review.googlesource.com/508668 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
ulan authored
On map change of an object this patch checks that - either GC was notified about this change, - or the change leaves the slot set of the object the same. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2886223002 Cr-Commit-Position: refs/heads/master@{#45427}
-
Georg Neis authored
This is in order to avoid triggering the generation of deopt entries later during code assembly. R=jarin@chromium.org Bug: v8:6048 Change-Id: I51fb508cfc5d715b6a5b2fded90b19c9f21d4d9f Reviewed-on: https://chromium-review.googlesource.com/508789 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#45426}
-
Michael Lippautz authored
Task creation often dominates the actual work that is being done. Bug: chromium:722989 Change-Id: Ibdd6ffa6f3154f17dc6ccbd30475710b97e802e7 Reviewed-on: https://chromium-review.googlesource.com/508783Reviewed-by:
-
Tobias Tebbi authored
Bug: chromium:723802 Change-Id: I8f23d016a5aaf785fcd27cd139a196a148a37069 Reviewed-on: https://chromium-review.googlesource.com/508712 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
[builtins] Enable %TypedArray%.prototype.{some,every,reduce,reduceRight,map} CSA builtins by default R=danno@chromium.org Change-Id: I3365642b2682c09d745b7bcc9f983179604e7c3a Reviewed-on: https://chromium-review.googlesource.com/509549 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: -
Michael Lippautz authored
Currently only relies on private stacks of segments, i.e., doesn't steal anything, yet. Bug: chromium:651354 Change-Id: Icedad3e3169b61afe988a1ece10f73f3a973bdb2 Reviewed-on: https://chromium-review.googlesource.com/508351 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds reporting of linking failures (i.e. module instantiation) similar to the existing reporting for validation failures. Note that the messages in question are deterministic and can be tested. R=clemensh@chromium.org Change-Id: Ibecebefb86f1d878f626702c05fd0cb21189dc2a Reviewed-on: https://chromium-review.googlesource.com/507488 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
martyn.capewell authored
Revert of Add DEPS.chromium for recursive DEPS tracking. (patchset #1 id:1 of https://codereview.chromium.org/2880293002/ ) Reason for revert: Going a different way with this, as Chromium don't want the additional files. Original issue's description: > Add DEPS.chromium for recursive DEPS tracking. > > DEPS.chromium allows the Chromium build system's DEPS to recurse into V8's own > dependencies. Initially, this is populated with some tests files for the ARM64 > simulator. > > BUG=chromium:718439 > > Review-Url: https://codereview.chromium.org/2880293002 > Cr-Commit-Position: refs/heads/master@{#45310} > Committed: https://chromium.googlesource.com/v8/v8/+/f8a6c6c48e79ef4267d03c80aa768e8362341e4a TBR=machenbach@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:718439 Review-Url: https://codereview.chromium.org/2891323002 Cr-Commit-Position: refs/heads/master@{#45420}
-
Michael Starzinger authored
This simplifies the growing strategy used in {ZoneBuffer} and also tunes the initial sizes used for various instances of these buffers. Note that such a {ZoneBuffer} is used for entire modules and individual function bodies. R=clemensh@chromium.org Change-Id: I99a0898589984e1830c681845fabb0ed5f8317ab Reviewed-on: https://chromium-review.googlesource.com/508711 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
mvstanton authored
We can avoid some runtime calls by implementing intrinsics. BUG= Review-Url: https://codereview.chromium.org/2889973002 Cr-Commit-Position: refs/heads/master@{#45418}
-
Andreas Haas authored
In a recent CL I moved the corpus of the wasm fuzzer and of the wasm-asmjs fuzzer to a different directory (wasm_corpus and wasm_asmjs_corpus) so that the corpus is not executed on the try-bots. With this CL I remove the old corpus from the .gitignore file. In addition I removed the hooks for wasm_corpus and wasm_asmjs_corpus from the V8 DEPS file, because in a V8 checkout they are not used anyway. I also added code to the test runner to delete all *.wasm files from the directories test/fuzzer/wasm and test/fuzzer/wasm_asmjs. This code should be removed in a week, but it will help my coworkers to cleanup their V8 checkout. R=bradnelson@chromium.org CC=machenbach@chromium.org Change-Id: I9fdf9d77b71b133f84f7e744763d65fdf127d624 Reviewed-on: https://chromium-review.googlesource.com/505614 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45417}
-
Michael Achenbach authored
NOTRY=true TBR=franzih@chromium.org Bug: v8:6154 Change-Id: Ief1e1acb353ba1c857616c32607979aec462207a Reviewed-on: https://chromium-review.googlesource.com/509488Reviewed-by:
-
