Commits · d965561862db87fdbfc197d306e3ae321cc42ffe · Linshizhi / V8

03 May, 2012 6 commits

Fix register clobbering in LoadIC for interceptors. · d9655618

mstarzinger@chromium.org authored May 03, 2012

This fixes a corner-case where the receiver register was clobbered by
LoadICs for interceptors and inlined followup code still relied on the
receiver to be intact in case of prototype changes.

R=vegorov@chromium.org
BUG=chromium:125988
TEST=cctest/test-api/Regress125988

Review URL: https://chromiumcodereview.appspot.com/10358010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11492 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d9655618

Implement clearing of CompareICs. · c810016e

mstarzinger@chromium.org authored May 03, 2012

This allows CompareICs to be cleared during garbage collection to avoid
cross-context garbage retention through maps stored in CompareIC stubs
for the KNOWN_OBJECTS state.

R=vegorov@chromium.org
BUG=v8:2102

Review URL: https://chromiumcodereview.appspot.com/10263008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11491 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c810016e

Prepare push to trunk. Now working on version 3.11.0. · 7f5920dc

danno@chromium.org authored May 03, 2012

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10354006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11488 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7f5920dc

Fix assert triggered in fast/regex/pcre-test-4.html We were not filtering out · baf7ebd6

erik.corry@gmail.com authored May 03, 2012

all the nodes that had non-ASCII characters. That has been fixed, but because
of the protection against over-deep recursion when filtering it is wrong to
assert that all nodes were filtered. This change therefore also makes sure we
can cope with non-filtered nodes by adding back some code removed in
https://chromiumcodereview.appspot.com/10174017/
Review URL: https://chromiumcodereview.appspot.com/10358008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11487 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

baf7ebd6

Clean up Makefile, enable MIPS cross-compilation · 10b0eee0

jkummerow@chromium.org authored May 03, 2012

Review URL: https://chromiumcodereview.appspot.com/10268010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11486 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

10b0eee0

ARM: Ensure reload of elements pointer in StoreFastDoubleElement stub · eb059173

danno@chromium.org authored May 03, 2012

R=mstarzinger@chromium.org
TEST=test/mjsunit/regress/regress-125515.js
BUG=chromium:125515

Review URL: https://chromiumcodereview.appspot.com/10298010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eb059173

02 May, 2012 5 commits

Sort functions when doing megamorphic dispatch/inlining so their · cb8df6e6

erik.corry@gmail.com authored May 02, 2012

order does not depend on the hash seed.
Review URL: https://chromiumcodereview.appspot.com/10270032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb8df6e6

Enable code flushing even when objects were marked incrementally, · bd3c2c02

erik.corry@gmail.com authored May 02, 2012

since the incremental visitor is setting the gc_age fields correctly.
This means the ResetSharedFunctionInfoCountersDuringIncrementalMarking
test passes even if it hits a marking stack overflow.
Review URL: https://chromiumcodereview.appspot.com/10258001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11481 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd3c2c02

Small patch to save one jump instruction and one label bind in JSEntryStub. · ce8f4df9

yangguo@chromium.org authored May 02, 2012

BUG=v8:2105
TEST=

Review URL: https://chromiumcodereview.appspot.com/10249003
Patch from Zhongping Wang <kewpie.w.zp@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11480 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ce8f4df9

Ensure reload of elements pointer in StoreFastDoubleElement stub. · 908e77a5

danno@chromium.org authored May 02, 2012

R=mstarzinger@chromium.org
TEST=test/mjsunit/regress/regress-125515.js
BUG=chromium:125515

Review URL: https://chromiumcodereview.appspot.com/10260014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11479 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

908e77a5

MIPS: Fix LFastLiteral to check boilerplate elements kind. · 2c645920

mstarzinger@chromium.org authored May 02, 2012

Port r11470 (621f96c0)

Original commit message:
Fix LFastLiteral to check boilerplate elements kind.

Adds a missing check that the elements kind of the boilerplate object
still has the expected elements kind, unoptimized code can transition
the boilerplate. Corner cases might cause the optimized code to be
reentered again.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10271018
Patch from Akos Palfi <palfia@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11474 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2c645920

30 Apr, 2012 9 commits

Fix mistakes in r11472 · 0133965d

jkummerow@chromium.org authored Apr 30, 2012

TBR=vegorov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10274008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0133965d

Fixed corner cases in truncation behavior when storing to TypedArrays. · f6dacfe8

jkummerow@chromium.org authored Apr 30, 2012

Also simplified ia32 KeyedStoreStubCompiler::GenerateStoreExternalArray a bit.

BUG=v8:2110
TEST=mjsunit/regress/regress-2110

Review URL: https://chromiumcodereview.appspot.com/10260011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11472 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f6dacfe8

Don't ignore return value of CommitCodePage in AllocateAlignedMemory. · 49989753

vegorov@chromium.org authored Apr 30, 2012

Release the mapping as whole if commit failed to avoid leaking virtual address space.

R=mstarzinger@chromium.org
BUG=chromium:118625

Review URL: https://chromiumcodereview.appspot.com/10260012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

49989753

Fix LFastLiteral to check boilerplate elements kind. · b54ca31f

mstarzinger@chromium.org authored Apr 30, 2012

Adds a missing check that the elements kind of the boilerplate object
still has the expected elements kind, unoptimized code can transition
the boilerplate. Corner cases might cause the optimized code to be
reentered again.

R=danno@chromium.org
TEST=mjsunit/regress/regress-fast-literal-transition

Review URL: https://chromiumcodereview.appspot.com/10254006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b54ca31f

Make sure idle notifications perform a round of incremental GCs after context disposal. · bc46d6c4

ulan@chromium.org authored Apr 30, 2012

BUG=v8:2107

Review URL: https://chromiumcodereview.appspot.com/10209026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bc46d6c4

Fixed preparser for try statement. Tiny cleanup. · 6aceff1f

svenpanne@chromium.org authored Apr 30, 2012

BUG=v8:2109
TBR=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10270007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6aceff1f

Prepare push to trunk. Now working on version 3.10.8. · a1fe6f3b

danno@chromium.org authored Apr 30, 2012

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10268006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1fe6f3b

Revert r11425 because of V8 benchmark performance regression. · 8768af54

ulan@chromium.org authored Apr 30, 2012

Original CL: https://chromiumcodereview.appspot.com/10202007 "Re-enable optimization for hot functions that have optimization disabled due to many deopts."

Review URL: https://chromiumcodereview.appspot.com/10265008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11464 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8768af54

One more register change missing from r11460. · 347d28f2

jkummerow@chromium.org authored Apr 30, 2012

Also re-enable disabled test (reverts r11461).

BUG=v8:2108
TEST=mozilla tests pass

Review URL: https://chromiumcodereview.appspot.com/10178039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11463 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

347d28f2

27 Apr, 2012 3 commits

Temporarily disable crashing mozilla test · cb95d208

jkummerow@chromium.org authored Apr 27, 2012

BUG=2108

Review URL: https://chromiumcodereview.appspot.com/10252008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb95d208

ia32: Redefine register usage in LoadIC/KeyedLoadIC to match StoreIC and KeyedStoreIC · 28bf8bfc

jkummerow@chromium.org authored Apr 27, 2012

Review URL: https://chromiumcodereview.appspot.com/10254005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11460 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28bf8bfc

MIPS: Removed unused variables. · 03e8d039

yangguo@chromium.org authored Apr 27, 2012

These were found by compilation errors with gcc 4.6.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10253004
Patch from Daniel Kalmar <kalmard@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11459 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

03e8d039

26 Apr, 2012 13 commits

Issue 2081: Expose function's (closure's) inner context in debugger. · 569eba39

peter.rybin@gmail.com authored Apr 26, 2012

This is against the correct branch (bleeding_edge).

Review URL: https://chromiumcodereview.appspot.com/10171003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

569eba39

Print compare-state with --print-code-stubs. · 94e5a8df

mstarzinger@chromium.org authored Apr 26, 2012

R=vegorov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10235006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11457 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

94e5a8df

Fix spurious bugs in GrowAndShrinkNewSpace when the · f7b4a96b

erik.corry@gmail.com authored Apr 26, 2012

min and max new space sizes are equal.
Review URL: https://chromiumcodereview.appspot.com/10241002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11456 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f7b4a96b

Remove more assumptions from debug tests. Even though a function · 292e007c

erik.corry@gmail.com authored Apr 26, 2012

is optimized, does not mean all frames on the stack are optimized.
Also, when we ask for the list of scripts we may get more or less
depending on GC timing.  Also fixed a presubmit error and made
%GetOptimizationStatus a little more honest.
Review URL: https://chromiumcodereview.appspot.com/10234007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

292e007c

Reduce size of LIR instruction by one word and remove dead code. · f46906d7

fschneider@chromium.org authored Apr 26, 2012

Until now we always recorded two deoptimization environments for instructions
that are marked as calls. We actually don't need two for all LIR
instructions except one (LInstanceOfKnownGlobal) where there is a lazy
deoptimization point in deferred code.

This change remove on of them and uses one virtual function instead
to make LInstanceOfKnownGlobal work as before.

Additionally, this change removes an unused predicate save_doubles_ from LIR
instructions and removes some helper functions that are used only in one place.
Review URL: https://chromiumcodereview.appspot.com/10035021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11454 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f46906d7

Remove unwarranted assumptions about inlining from a debugger test. · ad4f2b99

erik.corry@gmail.com authored Apr 26, 2012

Review URL: https://chromiumcodereview.appspot.com/10239003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ad4f2b99

Use simple concat of substrings instead of ReplaceStringBuilder for non-global replacements. · 657ffd88

yangguo@chromium.org authored Apr 26, 2012

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10134057

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11448 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

657ffd88

Add missing literal pool guards. · 9e55943b

ulan@chromium.org authored Apr 26, 2012

BUG=V8:2095
TEST=see issue

Review URL: https://chromiumcodereview.appspot.com/10233006
Patch from Rodolph Perfetta <rodolph.perfetta@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11447 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9e55943b

Reenable some heap verification and fix test to keep · 7783ba5d

erik.corry@gmail.com authored Apr 26, 2012

heap in a consistent state.
Review URL: https://chromiumcodereview.appspot.com/10227002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11446 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7783ba5d

Regexp: Remove nodes from the regexp that cannot match because · d511b69e

erik.corry@gmail.com authored Apr 26, 2012

they contain non-ASCII characters and the input string is ASCII.
Remove unused Clone() method.
Review URL: https://chromiumcodereview.appspot.com/10174017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11445 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d511b69e

Reduce expense of TraceGVN when --trace-gvn is off · 4b920a20

danno@chromium.org authored Apr 26, 2012

R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10233004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11444 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4b920a20

Prepare push to trunk. Now working on version 3.10.7. · 86396a1c

yangguo@chromium.org authored Apr 26, 2012

R=jkummerow@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10233003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

86396a1c

Remove unused variable in src/platform-solaris.cc. · c5b9783e

yangguo@chromium.org authored Apr 26, 2012

Based on a patch contributed by Heinz Gies <heinz@licenser.net>

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10231004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11440 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c5b9783e

25 Apr, 2012 4 commits

Add "step in recommended" to LiveEdit response object. · 53eb3b02

peter.rybin@gmail.com authored Apr 25, 2012

Review URL: https://chromiumcodereview.appspot.com/10185006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11439 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

53eb3b02

Fix 64-bit windows size_t assert · b3f6c0b2

danno@chromium.org authored Apr 25, 2012

R=mstarzinger@chromium.org
TEST=Windows 64 bit build goes green

Review URL: https://chromiumcodereview.appspot.com/10221006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11438 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b3f6c0b2

Eliminate redundant array bound checks (checks already performed earlier in the DT). · 93113da5

mmassi@chromium.org authored Apr 25, 2012

As a special case, for checks on index expressions with the form (expr + constant) if a smaller constant is checked later in the DT also eliminate the check.
Finally, if a larger constant is checked later in the same BB do the more general check (larger constant) earlier instead of the less general one.
This will not cause useless deoptimizations because, since we are in the same BB, all the checks would have been executed anyway.
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10032029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

93113da5

Fix deopted construct stub frame to contain code object. · 21fc0fef

mstarzinger@chromium.org authored Apr 25, 2012

R=danno@chromium.org
BUG=chromium:124594
TEST=mjsunit/regress/regress-124594

Review URL: https://chromiumcodereview.appspot.com/10155024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

21fc0fef