- 05 Jul, 2018 10 commits
-
-
Maya Lekova authored
Fixes V8 correctness failure when there's a proxy in the global object prototype chain and unsuccessful attempt is made to access a property. Bug: chromium:849024 Change-Id: I829e1a6c038982b7c7a77f8bdefb61facb4614f0 Reviewed-on: https://chromium-review.googlesource.com/1124446 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54237}
-
Sigurd Schneider authored
The code target vector is used by backends whenever initial code creation uses immediates that cannot hold a code pointer: An index into the vector is used instead, and the vector contains the corresponding code object. This CL makes the code target vector available on all platforms. Bug: v8:6666 Change-Id: I2026acd6a77a3465fe2285b84d47866c3b794855 Reviewed-on: https://chromium-review.googlesource.com/1118885 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54236}
-
Yang Guo authored
If the first object in the space already exceeds the target chunk size, we would leave the first chunk empty. That violates some assumptions later when we allocate for deserialization. R=hpayer@chromium.org, jgruber@chromium.org TBR=hpayer@chromium.org Bug: v8:7887 Change-Id: Iee8147fe1205bb6b1c893d48acde1099b5032a14 Reviewed-on: https://chromium-review.googlesource.com/1126763Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I053eac9c9b49c65a2f751b1b107e32f7603e63a9 Reviewed-on: https://chromium-review.googlesource.com/1126113Reviewed-by:
-
Clemens Hammacher authored
This just fixes the text for the '--liftoff' and '--trace-liftoff' flags to avoid calling Liftoff "experimental". R=ahaas@chromium.org Bug: v8:6600 Change-Id: Iff9032070fe0e18ee77debf376f5453d1a61480e Reviewed-on: https://chromium-review.googlesource.com/1126114Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54233}
-
Dominik Inführ authored
After a certain number of iterations in the fixpoint iteration switch to a linear algorithm. This algorithm uses a key-to-values map for weak collections contents to avoid checking all EphemeronHashTables again. Bug: chromium:844008 Change-Id: I044fede5911e0a780d088d1ba2bb5343317d9b7a Reviewed-on: https://chromium-review.googlesource.com/1105835 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54232}
-
Yang Guo authored
This reverts commit 5f2f418d. Reason for revert: Speculative revert for LayoutTest timeouts https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064/24596 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20-%20future/4707 https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064%20(dbg)/12467 Original change's description: > [scanner] Rewrite character streams by separating underlying bytestreams from buffering. > > Additionally now we only scan over flat heap strings. > > Change-Id: Ic449b19aecd7fc3f283a04a3df6a39772d471565 > Reviewed-on: https://chromium-review.googlesource.com/1125854 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54224} TBR=marja@chromium.org,verwaest@chromium.org Change-Id: Ica3026f318a85ec6bb24a38a8cd998f12c146d7e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1126819Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54231}
-
Peter Marshall authored
This is just derived from is_wasm_memory. Change-Id: I2f77fb5e32e325c51de9af4228ca33313c21abc6 Reviewed-on: https://chromium-review.googlesource.com/1126107Reviewed-by:
-
Daniel Clifford authored
Only pass around the unadulterated value identifier in the VisitResult class until the very last moment before code generation, at which point the declaration that was used to originally define the value is used to generate the correct final source code string in the context of a l-value or r-value. Bug: v8:7793 Change-Id: Ifd0c0d245b2eb65c7f3ddb1ad4c87ee235c54a82 Reviewed-on: https://chromium-review.googlesource.com/1125063 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54229}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/de0662d..0cc2895 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib114c478943e00e4bfb6b688e5471569217e070e Reviewed-on: https://chromium-review.googlesource.com/1126569 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54228}
-
- 04 Jul, 2018 30 commits
-
-
Junliang Yan authored
Port 34225a6a Original Commit Message: For spread calls with arrays with double elements but zero length, we skip the box-as-heapnumber step; so in this corner case the Call builtin sees a FixedDoubleArray, which is fine because it doesn't read any of the raw double values from it. This patch doesn't change the implementation, it only updates the assert to match reality. R=jkummerow@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iafa52f21fb0bbee5656fdfd6c5f3a50894ff683f Reviewed-on: https://chromium-review.googlesource.com/1126212Reviewed-by:
Michael Dawson <michael_dawson@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54227}
-
Hannes Payer authored
This DCHECK does not hold for compaction spaces that may go over the limit with large semi-spaces and small old generation size maxima. Bug: chromium:855960 Change-Id: I39eea4c974b94c170e7314471fb1c50f9a1a2b45 Reviewed-on: https://chromium-review.googlesource.com/1126392Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54226}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7ac2934..de0662d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/153acbd..8221306 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/605dd31..5484b86 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/b334665..272de12 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/39163b8..d8cde7f Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/0e27f88..e3d4003 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie71d071d1a3a818a61c4db617b0d09ee41304552 Reviewed-on: https://chromium-review.googlesource.com/1126446 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Toon Verwaest authored
Additionally now we only scan over flat heap strings. Change-Id: Ic449b19aecd7fc3f283a04a3df6a39772d471565 Reviewed-on: https://chromium-review.googlesource.com/1125854Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#54224}
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Change-Id: I315e63a30ca6f3077f18eb1a5004daefba9bc673 Reviewed-on: https://chromium-review.googlesource.com/1125929 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=jarin@chromium.org Change-Id: I3a6759468f1a21b84ab9a294a2ca41d70b9cec99 Reviewed-on: https://chromium-review.googlesource.com/1123829Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54222}
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Change-Id: Ib3c45c1023d76bec5e1f4bc8f971062880b6c53f Reviewed-on: https://chromium-review.googlesource.com/1126240Reviewed-by:
-
Ross McIlroy authored
Changes SharedFunctionInfo to store a function_token_offset, relative to the start_position, instead of the full function_token_position. This enables us to reduce both FunctionTokenPosition and ExpectedNofProperties to 16 bits each, saving 32 bits per SFI. BUG=chromium:818642,chromium:783853 TBR=yangguo@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I45aefcec605c1da502053c23c73564ceaed6c9b5 Reviewed-on: https://chromium-review.googlesource.com/1122982 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54220}
-
Marja Hölttä authored
BUG=chromium:859809 Change-Id: I9ac81585c7f141cb1839ff7de237e0930f44e634 Reviewed-on: https://chromium-review.googlesource.com/1124450Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54219}
-
Maya Lekova authored
This is a reland of ade7f55b Previously landed as: ade7f55b / 1125679 Previously landed as: 3c4d0316 / 1065818 Previously landed as: 8e0f67be / 1088890 Original change's description: > Reland ^2 "[async] Expose async hooks to d8" > > This is a reland of 8e0f67be > Bug: chromium:850530 Change-Id: I536cfb9443d80d62937d9c3dc6a53b52b209d5c7 Reviewed-on: https://chromium-review.googlesource.com/1125683 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Théotime Grohens authored
This CL creates a new Operator called LoadDataViewElement, similar to LoadTypedArray, for DataView getters. This operator will be used as a wrapper around all the computations that DataViews need to do when loading values, due to the endianness parameter of DataView loads. Change-Id: Ie67d63c9669142e539a5c8d7ae82dc1018ce5858 Reviewed-on: https://chromium-review.googlesource.com/1125928 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I4a5fb4bc70169874d003d9c31f1713f52e2bba93 Reviewed-on: https://chromium-review.googlesource.com/1126118Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54216}
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Change-Id: I631fa1e44d2b9998a5567c96c6977955ac86d5a1 Reviewed-on: https://chromium-review.googlesource.com/1125931Reviewed-by:
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Change-Id: I6a7fb375411e379681637469bb3fb360635e6bbe Reviewed-on: https://chromium-review.googlesource.com/1126111Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I6edaa7c3e0a07eb69fa497fdeddeacf082cdadc8 Reviewed-on: https://chromium-review.googlesource.com/1126109Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2265a852. Reason for revert: https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064%20(dbg)/12451 https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/12451/layout-test-results/results.html Original change's description: > [snapshot] Reduce serialization chunk size to 4K. > > This change may slow down deserialization of the snapshot but may result in less fragmentation. > > Bug: v8:7887 > Change-Id: Id8bb9f1a561b08b7ae0f10b80aa77bc00eb23172 > Reviewed-on: https://chromium-review.googlesource.com/1125722 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54198} TBR=yangguo@chromium.org,hpayer@chromium.org Change-Id: I3066426550f8c51de87fcf330a13aba5cebd7164 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7887 Reviewed-on: https://chromium-review.googlesource.com/1126219Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54212}
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Change-Id: I67420b74440c7620b0eb3aa7980b08c0e43a1e75 Reviewed-on: https://chromium-review.googlesource.com/1125729Reviewed-by:
-
Benedikt Meurer authored
The JSCallReducer could in theory inline the default resolve and reject functions passed to the executor in the Promise constructor. But that inlining is almost never triggered because we don't have SFI based feedback in the CallIC. Also the use of the Promise constructor is discouraged, so we shouldn't really need to squeeze the last bit of performance out of this even in the future. Getting rid of this optimization will make significantly easier to implement the Swallowed Rejection Hook, as there's less churn on the TurboFan side then. Bug: v8:7919 Change-Id: If0c54f1c6c7ce95686cd74232be6b8693ac688c9 Reviewed-on: https://chromium-review.googlesource.com/1125926 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: I1b3792dd678757eed8739de1f1c37c77838c52d9 Reviewed-on: https://chromium-review.googlesource.com/1125850Reviewed-by:
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: Ia874ff087fd4cd56e829e0c0d2b19586dc5b5040 Reviewed-on: https://chromium-review.googlesource.com/1125848Reviewed-by:
-
jgruber authored
Recent changes in SerializerReferences (see https://crrev.com/c/1113930) opened up these minor improvements to the builtin serializer allocator, since we now have dedicated BuiltinReferences. R=yangguo@chromium.org Bug: v8:7887 Change-Id: Ie76a52a88ef4075c63c5eb2eaa81382c52325688 Reviewed-on: https://chromium-review.googlesource.com/1125844Reviewed-by:
-
Clemens Hammacher authored
No need to iterate over imported functions just to skip them in the loop body anyway. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I8dabf8d6ee7d0cc029b6236cef319cf8e70e4a5b Reviewed-on: https://chromium-review.googlesource.com/1125802Reviewed-by:
-
Yang Guo authored
This reverts commit e438d5d4. Reason for revert: TSAN failures - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21357 Original change's description: > [heap] Make objects allocated in new_lo_space look like young generation objects. > > The scavenger still does not handle young generation large objects correctly. > This will be added in a follow-up CL. > > Bug: chromium:852420 > Change-Id: I2587509d6e7f329aeff3db246d949bb30b3a91a5 > Reviewed-on: https://chromium-review.googlesource.com/1124477 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54197} TBR=ulan@chromium.org,hpayer@chromium.org Change-Id: Ief44cfd841278f2d53d51f3a21c03b70b8025a7a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/1125979Reviewed-by:
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: If9b235868905b818912109f0684b888335c75e80 Reviewed-on: https://chromium-review.googlesource.com/1125845Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2ab1ca18a900828e4e116f1b087925319d41bf97 Reviewed-on: https://chromium-review.googlesource.com/1124845Reviewed-by:
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2f2c031c03d56d360ef940fc925e0583e6ae31dc Reviewed-on: https://chromium-review.googlesource.com/1125720Reviewed-by:
-
Michael Starzinger authored
R=ahaas@chromium.org Change-Id: I9cf40958978f8ebcc34d4c9d15ea301e54829229 Reviewed-on: https://chromium-review.googlesource.com/1125076 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:860153 Change-Id: I1ad6c81f672efe2e705d5285b80e2855af828254 Reviewed-on: https://chromium-review.googlesource.com/1125726Reviewed-by:
-
Dan Elphick authored
In future the RO_SPACE root accessors in Heap will become private, so instead convert them all to use ReadOnlyRoots. Splits HEAP_CONSTANT_LIST into HEAP_MUTABLE_IMMOVABLE_OBJECT_LIST and HEAP_IMMUTABLE_IMMOVABLE_OBJECT_LIST. The CSA accessors then use the appropiate ReadOnlyRoots or Heap accessor to get hold of the object. Bug: v8:7786 Change-Id: I3bdf868b5e224f8794c85307e1b4569480cebd1c Reviewed-on: https://chromium-review.googlesource.com/1125725Reviewed-by:
-
Hannes Payer authored
This change may slow down deserialization of the snapshot but may result in less fragmentation. Bug: v8:7887 Change-Id: Id8bb9f1a561b08b7ae0f10b80aa77bc00eb23172 Reviewed-on: https://chromium-review.googlesource.com/1125722Reviewed-by:
-
