- 18 Mar, 2019 8 commits
-
-
Andreas Haas authored
Anyfunc globals are very similar to anyref globals. This CL is mostly about extending the conditions which guard the anyref globals code. R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ia92ac4560102cc3ed0060342f92758db28f415ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526004Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#60281}
-
Andreas Haas authored
R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ica85ba80c29d6d5c5b9163df8cf743c0f1da7f4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520715 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit acadb202. Reason for revert: chromium:941952 Original change's description: > [turbofan] add fast path for String.p.startsWith > > Add a fast path for String.p.startsWith(str) when length of str is 1. > > Bug: v8:8400 > Change-Id: I65e657549902dc3ad064a213d815dd098ce6455f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491872 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60091} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8400 Change-Id: Iabd66b8db0d6958686ea15a042d8567955700c9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524205 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60279}
-
Jakob Gruber authored
This was always the intended behavior: when --embedded-variant is not passed, we should assume "Default". What actually happened in this case was that we'd initialize to nullptr. This CL adds the missing nullptr check. Bug: v8:6666 Change-Id: I87247c6c6cfec20da86d2714732a2f6044bb9b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526193 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60278}
-
Sigurd Schneider authored
This reverts commit 6d209c9b. Reason for revert: chromium:941952 Original change's description: > [turbofan] add CheckSmi call to String.p.startsWith > > Add a CheckSmi call to the value of the position argument to > String.prototype.startsWith(search, [position]). > > Bug: v8:8400, chromium:939746 > Change-Id: I7462bebe0d3fde605a4c27a34c0d9bb3f0cc1c20 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514198 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60216} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8400, chromium:939746 Change-Id: Ifee58b9e57313bbf93bca293e92d88af279a0261 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524204 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 4925495c. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20nosnap%20-%20shared/32627 https://ci.chromium.org/p/v8/builders/ci/V8%20Win64/29699 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e8b8ab7..c899486 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/24b5f90..efe902b > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I439f9415dd63820d8f665550a5ff89372e8620c3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1527555 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60274} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I62fa43fc614c1b1dffd841aa22a7a590c3a63cd1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528232Reviewed-by:
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: I8569f99d498b79d943c1c178eafea48629d68fc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526017Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60275}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e8b8ab7..c899486 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/24b5f90..efe902b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I439f9415dd63820d8f665550a5ff89372e8620c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1527555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60274}
-
- 16 Mar, 2019 4 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ae9325..e8b8ab7 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c79f348..a14f996 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f8e2315..4e9bccd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/04600b4..24b5f90 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icfe9aaa08e5ab196c1ce375a9fbfc753a44ccc8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526729Reviewed-by:
-
Michael Achenbach authored
This ports: https://crrev.com/c/1519726 TBR=tmrts@chromium.org Bug: chromium:930050 Change-Id: I3afcfd28e8fdd5b97946e327997a58a488d4f1a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526014Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60272}
-
Alexei Filippov authored
This is a reland of 5a61630d Original change's description: > [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > BUG=v8:8988 > > Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60227} TBR=dgozman@chromium.org Bug: v8:8988 Change-Id: I9b1db01856a43636c1eb8ad2ec36e3727353228d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524668 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60271}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/a2b5691..2f5d8e7 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/2f5d8e7 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/0e1021a Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/b65f68d Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/2c9b327 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/5ad5fe2 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/b2fefbd Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/2478368 Normative: Read the imports synchronously in WebAssembly.instantiate(Module). (Ms2ger) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/16a91bd ... TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I33cb12bc8c456517c809485e4d8aca1c19df0605 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526725Reviewed-by:
-
- 15 Mar, 2019 21 commits
-
-
Matt Gardner authored
The existing has property handling did not account for the fact an IC can have LOAD_IGNORE_OUT_OF_BOUNDS while some of the maps in the IC do not allow out of bounds loads. bug: chromium:942068 Change-Id: I935402d9d72e9c0228510ef69154ea130d1c71f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525876Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60269}
-
Santiago Aboy Solanes authored
We have a version for each (Any, Pointer, Signed) Bug: v8:8977 Change-Id: I1df994f96e24183a136c25818bf4917d9f8126d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524481Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#60268}
-
Michael Starzinger authored
This slot has become obsolete now that all CEntry stubs are builtins (which are part of the rootset) and no longer need to be kept alive explicitly by a slot in the frame. R=verwaest@chromium.org BUG=v8:8834 Change-Id: I7b791cc509ef800bcf7aa5faab31ddf35370f944 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520725Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60267}
-
Clemens Hammacher authored
This asserts that we run e.g. GC finalization tasks. Without that, we might run ouf of memory. R=ahaas@chromium.org Bug: chromium:938739 Change-Id: Ic80074f877183bcabb3353fbeff94842a534efab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526007Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60266}
-
Sigurd Schneider authored
Change-Id: I5c391f606994ba1fc3dfb53483a0cc0f1caa25e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521107Reviewed-by:
-
Clemens Hammacher authored
We were just counting the number of stack elements instead of their actual memory usage. This limits recursion a lot more and helps avoiding OOM situations. R=titzer@chromium.org Bug: chromium:938739 Change-Id: I0e0ec2949f9fbad9c9e2c8677ec0223d5cd6a24b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526006Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60264}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/77c810a..6ae9325 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1c2fa0f..04600b4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I97e0449cc11eb30e890862c044cfde59172ed75d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525864Reviewed-by:
-
Michael Starzinger authored
This changes gcmole's bootstrapping script so that it always creates binaries that link libstdc++ statically (both plugin and Clang) and do not link against unneeded libraries (only Clang). For deployment of gcmole on our infrastructure, it is much easier to have fewer external dependencies. R=machenbach@chromium.org BUG=v8:8813 Change-Id: If6f2f3cc3b1f661f7dafbb406eaaf2e639981640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526002Reviewed-by:
-
Simon Zünd authored
Compiling without -fno-exceptions causes compilation errors, this CL fixes that. The reason for the compilation error is a mismatch of "V8_NOEXCEPT" on mixins for base::Optional where it is not present for deleted copy/move constructors, but present on base::Optional for defaulted ones. Bug: v8:8985 Change-Id: I54af77496657fde44292c050221d11533a54db03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518175 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60261}
-
Michael Achenbach authored
Bug: v8:8813 Change-Id: I3c173a0c8846a2728e020581fbcaac269f850162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523786Reviewed-by:
-
Michael Starzinger authored
This is a false positive of a potential evaluation order problem flagged by the newest version of gcmole. While this is strictly speaking safe, it is not statically known that the default argument of the fourth parameter to {AbsoluteAndNot} is a nullptr and hence not a stale raw reference. Since this is the only false positive of this kind in the code base, I would vote to just avoid it by sequencing the operations. R=jkummerow@chromium.org BUG=v8:8813 Change-Id: I4a8f2ed4eb09766ce98e4e3d32f680a3a84eedf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523548Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60259}
-
Tom Anderson authored
Clang crashes in this configuration. See https://crbug.com/942347 for context. BUG=chromium:942347 R=machenbach CC=thakis Change-Id: Iffcad9556ed92ecfbd4ee062a5ed7f8c8cac1914 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524639 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit ba00d8b7. Reason for revert: Breaks arm64 bots (native & simulator) - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim/17252 Original change's description: > Reland: [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > BUG=v8:8988 > TBR=dgozman@chromium.org > > Change-Id: I6f7da07c4c9ae35b5252aabddb98b693ec77b4e8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524662 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60255} TBR=dgozman@chromium.org,alph@chromium.org Change-Id: I04e3616d46620f33d0ec349fb7b0c393f276dc0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524484Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60257}
-
Aseem Garg authored
This CL allows for either of 'minimum' or 'initial' for MemoryDescriptor and TableDescriptor. It also adds a flag for the reflection features. R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: Icfd4825f63e1eb784a39d10f740d55e81489eba7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1485243 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#60256}
-
Alexei Filippov authored
Introduces the setMaxCollectedScriptsSize Debugger protocol method. If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) scripts up to the specified total size of their sources. > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> BUG=v8:8988 TBR=dgozman@chromium.org Change-Id: I6f7da07c4c9ae35b5252aabddb98b693ec77b4e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524662Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#60255}
-
Ben Smith authored
Bug: v8:7226 Change-Id: Ia2ed97b193e77a016aa10e7abd50ce59ea38f7a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518558 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Ben Smith authored
This CL only provides the implementation of memory.{init,copy,fill} and data.drop. Bug: v8:8965 Change-Id: I439f2520bfee8f147e4b0d1d31f954aaad2e14ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510575 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: -
Aseem Garg authored
R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: I5b9a614dd0c8b028d756cbd401c803de4cb9437f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513159 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/dae979a..a2b5691 Editorial: Extract an "asynchronously instantiate a WebAssembly module" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/a2b5691 Editorial: Extract an "instantiate the core of a WebAssembly module" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/4ecc1b1 Editorial: Remove an unnecessary local variable in "create an instance object". (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/e4bea69 Editorial: Extract a "create an instance object" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/0555abc Editorial: Extract a "read the imports" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/e738239 Editorial: Stop breaking lists to insert a note. (Ms2ger) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/e692daa TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: If5d941a44b9c37d5ad2f2f76e3a726cefa9557fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525098Reviewed-by:
-
Aseem Garg authored
This CL also changes the constructor for WasmTableObject so that the maximum_length is set to undefined instead of a default value if there's no maximum provided. R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: I6310224e9997464bf69c198e2694a6cd76e01e8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513156 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2678ddc..77c810a Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/4457947..62f9eb0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2afe880..f8e2315 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/40c1942..1c2fa0f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8a36736..3dd606a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If25a10068d40afd68abab42534b8fbafc0834848 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525097Reviewed-by:
-
- 14 Mar, 2019 7 commits
-
-
peterwmwong authored
Consolidates all the work into a single TFS builtin (CreateHTML) called by all these functions. Reduces the builtin size by about half. Change-Id: I92b2c7889f72db4c8c79d7ef0ce0e61036ab619e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522727 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Matt Gardner authored
Bug: v8:8952 Change-Id: I099de2052941684d4ca714062a52c82ef0bb3850 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1516473 Commit-Queue: Matt Gardner <magardn@microsoft.com> Reviewed-by:
-
Caitlin Potter authored
Fix original imlpementation to support occurrence in eval(), and unskip tests. BUG=v8:8523 r=gsathya@chromium.org, mathias@chromium.org, littledan@chromium.org Change-Id: I80a3e8623357947c564a6cdf865eeff435b8e640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510792Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#60246}
-
Leszek Swirski authored
Since the new Objects were introduced, we can no longer cast integers to and Object pointer and call methods on them in gdb (due to how gdb's expression evaluator deals with temporaries). So, we add a new helper method to our gdbinit, "$job", which takes an address and returns an Object that is now exists in real (stack) memory. Bug: v8:8994 Change-Id: I760a007e7d2303e3a4b1fecb87e094fb9974e91e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523329 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ib9f423439f418be5ef15e2a65b9118f8f234cb5b Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524201Reviewed-by:
-
Ulan Degenbaev authored
This should have no effect unless the embedder uses an old version of the standard library with missing overloads of <math.h> functions, which causes such functions to perform implicit conversion to double. In such cases, the CL removes the implicit conversion. Change-Id: Ib90a461c81b1f354f7acdf32df88257bff20aca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523549 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Compilation only stores whether an error has been found, but not the exact error or it's location. This is generated by running a validation pass once all wire bytes have been received. This unifies error messages by removing one more location where we generate compilation error messages, and makes it deterministic because a) we always report the error in the first failing function, and b) if names are present, the error message will always contain the function name. R=titzer@chromium.org Bug: chromium:926311, v8:8814 Change-Id: I79551b8bb73dcee503484de343a3ada60a6add4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521112 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
