- 08 Apr, 2020 21 commits
-
-
Milad Farazmand authored
Port 44826509 Original Commit Message: This flips the --debug-in-liftoff flag to be on by default. There are still some outstanding issues with that configuration, but not more than with the interpreter configuration. Thus flip now, such that we can fully focus on stabilizing that config. R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie18137fe5f1b9533a0882b5e57d8c320ee340387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142311 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67066}
-
Paolo Severini authored
This fixes an issue in WasmScript::ClearBreakPoint, which is was still removing breakpoints in the interpreter, even when debugging in Liftoff. The existing test inspector/debugger/wasm-stepping-liftoff.js does not require any changes. Change-Id: I5c60839ffde91cdd11d9f808a3102f2cc1324087 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136872Reviewed-by:
-
Clemens Backes authored
Several JS tests are already skipped in that config. This CL adds a wasm test that also started flaking. TBR=thibaudm@chromium.org Bug: v8:10410, chromium:772010 Change-Id: Ie16d60a5066a56005d9cf1e4951d6ed1c17e4dc7 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2142256Reviewed-by:
-
Daniel Clifford authored
This fix is a bit of overkill, but ensures that verifier methods are available across library boundaries. Change-Id: I120560f8e8e0be0ffcba43b46197efca4db0a62c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141739Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#67063}
-
Philip Pfaffe authored
Change-Id: If7691bc70aac4a8f2ba8fe383bd44a829a9a0bdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2132265Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#67062}
-
Anton Bikineev authored
This change comprises a few tiny changes wrt Member: 1) Move member policies to a separate file so that some of them (CheckingPolicy) can be reused by Persistent; 2) SFINAE out incompatible pointers from heterogeneous ctor/asgnmt; 3) Rename kMemberSentinel to kSentinelPointer. Bug: chromium:1056170 Change-Id: I4482998e6ba61005a5d0861dcae9fab2aa43702c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139587Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#67061}
-
Mythri A authored
For keyed stores we recompute handlers when we see a new map so that we could transition to the most general elements kind we have seen so far. When recomputing these handlers we drop the deprecated maps. Instead we could TryUpdate deprecated maps. This would be inline with what TurboFan does and also may be better for performance. Bug: chromium:1053939 Change-Id: Id38b60538d56f4b376460c0faece20768a18f25f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2130129 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67060}
-
Georg Neis authored
This is still unused but will eventually be used by fuzzers. Bug: v8:10249 Change-Id: Ib592a5a8da1399ad8fb5a277ea94fda68b382058 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141735Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67059}
-
Georg Neis authored
JSNativeContextSpecialization lowered this operator to a regular property store, potentially ignoring a request to set the "name" property of a function. This CL performs the lowering only if there's no such request. Bug: chromium:1068494 Change-Id: Ia2eaf05af9c8402f9e6450ee519a7c36c18cd44e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139581 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#67058}
-
Clemens Backes authored
Debugging with multiple isolates involved is known to be broken. TBR=thibaudm@chromium.org Bug: v8:10359 Change-Id: I2f32cd4b7b53492508948a85e9750167b25b8d89 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140938Reviewed-by:
-
Tobias Tebbi authored
The two refactorings are somewhat orthogonal, but intersect at the class and instance type list generation, which is why it's easier to put them in one CL. For the removal of HasIndexedField, the removal is motivated by the fact that is no longer necessary, and that using a flag to store this kind of information is hacky. For the class list changes, this is a cleanup in that we no longer generate third-order macros, but instead normal macro lists. There is a functional change and bug-fix in that we no longer include abstract classes in lists that refer to instance types or maps. It's still somewhat broken though, so I can't test abstract internal classes yet, though. Coming in a follow-up CL. TBR=ulan@chromium.org Bug: v8:7793 Change-Id: Ided8591370570ca3810d7991f53177ca32e03048 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108034 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67056}
-
Tobias Tebbi authored
The macro magic used to assemble the operator cache in machine-operator.cc was quite involved and difficult to follow. This change replaces many macros with templates and simplifies the logic. Similar changes could also be applied to other operator builders. Change-Id: Ie4268c59b7c663f1aac360c87e9cce3100c90a29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2132246 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67055}
-
Anton Bikineev authored
Bug: chromium:1056170 Change-Id: I98bbff8d2938c6b34fe2c358d504ba6211ec8b54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140931Reviewed-by:
-
Liviu Rau authored
Seems I need a new one No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: If3befbd243d17a885aea360ec27e372fa05bbb2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140934Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#67053}
-
Clemens Backes authored
Debugging with multiple isolates involved is known to be broken. Thus skip another test which flakes currently. TBR=thibaudm@chromium.org Bug: v8:10359 Change-Id: Ib0758794623cca1cf9bdd6d6d8aa673ceffd9d7c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2140933Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67052}
-
Zhou, Zhiguo authored
This reorders the SIMD opcodes together with their implementations on x64, ia32 according to src/wasm/wasm-opcodes.h. Bug: v8:9909 Change-Id: Ib2e75927b3b44ebc951005222c8641c256d8872c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135074Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Cr-Commit-Position: refs/heads/master@{#67051}
-
Anton Bikineev authored
Headers containing only implementation details are better to stay in a separate dir to indicate the user that they shouldn't be included. Bug: chromium:1056170 Change-Id: I10f84ddf709b146396aadc820ec33bc6a49b2dac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139585Reviewed-by:
-
Clemens Backes authored
This is a reland of 44826509. TSan issue were fixed in https://crrev.com/c/2139574. One test failing in the 'stress' variant is skipped for now, until we figure out what the intended behaviour actually is. Original change's description: > [wasm] Debug in Liftoff by default > > This flips the --debug-in-liftoff flag to be on by default. > There are still some outstanding issues with that configuration, but not > more than with the interpreter configuration. Thus flip now, such that > we can fully focus on stabilizing that config. > > R=ecmziegler@chromium.org > > Bug: v8:10351 > Change-Id: I7681f40aa2516557ef3ab4efd9a2c1f88e3b4df7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135727 > Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67018} Bug: v8:10351, v8:10403 Change-Id: I4c2f1af46233546d6ebeb638c7ef10aac56cd92d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139575 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#67049}
-
Yang Guo authored
TBR=verwaest@chromium.org Change-Id: If18d402f9b0b9c500307fd454eafe93de701599c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2141731Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67048}
-
Clemens Backes authored
The compare operations pass a hard-coded first argument to the emit function. Instead of implementing this via a lambda, put it in a separate {BindFirst} helper, similar to {std::bind_front} (C++20). R=zhin@chromium.org Bug: v8:10364 Change-Id: If48c87a3df5ea6fa2b155873e4586af5d6b21119 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139580Reviewed-by: -
Michael Lippautz authored
Neither Member, nor GarbageCollected objects (and friends) should be allocated on the stack. Create a special test fixture that allows for writing idiomatic unit tests that depend on allocation but do not pull in garbage collection. Bug: chromium:1056170 Change-Id: I4118201a51658f7247412434a867d35c91299439 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139583Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67046}
-
- 07 Apr, 2020 15 commits
-
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: Ia680558a03c4de4cf31e233d58e574020a58a0d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137476Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: Ie56a99718ee16b70e93ae812a68a1cb08f95da56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136869Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: I578f797f27c304c5212597fe146d62c3607f8d2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137471Reviewed-by:
-
Clemens Backes authored
This is to avoid a lock inversion problem. In many situation, the {NativeModule} lock is held while getting the {DebugInfo} lock. Hence we should never do is the other way around, otherwise we risk a deadlock. When setting a breakpoint, we hold the {DebugInfo} lock when triggering recompilation, but recompilation accesses the {NativeModule} for creating the {CompilationEnv}, and therefore takes the {NativeModule} lock. This CL fixes this lock inversion by giving up the {DebugInfo} lock before recompiling functions. R=thibaudm@chromium.org Bug: v8:10351 Change-Id: Ic818c6589b2b532006aee4c16bac92b2fe79fa65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139574 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Michael Lippautz authored
This CL adds the necessary traits to dispatch from Member through a visitor implementation for GarabgeCollected and GarbageCollectedMixin. Bug: chromium:1056170 Change-Id: I12680335044aaa842639fb5e8f9a3ac61587f51a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2138431Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I3a49a6208be8e6dd68c261dc423ee80cc891b806 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139577Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67040}
-
Camillo Bruni authored
Print ALL_VARIANTS and VARIANT_ALIASES when passing a wrong --variants argument to tools/run-tests.py. Change-Id: I6d4278633dd11990d0ace1c93f544213fbfc156e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139579 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#67039}
-
Kim-Anh Tran authored
This removes the stack from the local scope, as the stack is now in its own scope. Bug: chromium:1043034 Change-Id: I595604da71ecf4362ef67134ade8b3987086d258 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2128049Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Avoid name clash with Safepoint in src/codgen and use renaming to emphasize that class reaches a safepoint in each background thread. Bug: v8:10315 Change-Id: I391cdcfaf533a0fe0d5923207234eb2a8411eb93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139576Reviewed-by:
-
Michael Lippautz authored
Assumes that (is_clang = false && is_win) => Windows native (MSVC). Cross-compile builds will use clang and not the native tools and thus not fall into this category. This CL adds x86 and x64 MASM trampolines that can be used with the native Windows toolchain (ml.exe, ml64.exe), when using is_clang = false. This reverts commit 8e4a5e97. Bug: chromium:1056170 Change-Id: I7204f15898ec5eddcc5892d4d08266a69d84ab85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139211 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port dd1dbd99 https://crrev.com/c/2134420 Change-Id: Ia1ab8e07a6e126e5b4cdaa5113846d859dd9e9e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2138654Reviewed-by:
-
Dominik Inführ authored
Local is used in other contexts as well, e.g. LocalIsolate or LocalHeap. Make it clear from the name that EvacuationAllocator is only used during collections. Bug: v8:10315 Change-Id: I7483270aabc3dfe1fdecf0e77d1638c6711a8a2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137413Reviewed-by:
-
Michael Lippautz authored
The dummy sweeping algorithm didn't actually remove objects from the internal list. Bug: chromium:1056170 Change-Id: I29a93a2ac7fc36ca95125805076ff5ce257de8a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2138433 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 2de2d3dc. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20GC%20Stress/11982? Original change's description: > [runtime] Amortize descriptor array growing for fast-mode prototypes > > This avoids an O(n^2) algorithm that creates an equal amount of garbage. > Even though the actual final descriptor array might be a little bigger, > it reduces peak memory usage by allocating less. > > Bug: b:148346655 > Change-Id: I984159d36e9e0b37c19bc81afc90c94c9a9d168a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135728 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67031} TBR=ishell@chromium.org,verwaest@chromium.org Change-Id: I366141f1dbba62ff268df7ef625cc318f8423818 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:148346655 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139212Reviewed-by:
-
Toon Verwaest authored
This avoids an O(n^2) algorithm that creates an equal amount of garbage. Even though the actual final descriptor array might be a little bigger, it reduces peak memory usage by allocating less. Bug: b:148346655 Change-Id: I984159d36e9e0b37c19bc81afc90c94c9a9d168a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135728 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#67031}
-
- 06 Apr, 2020 4 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/ae8694b4..62b8fce3 62b8fce Deleting previously valid generated tests by Rick Waldron · 2 days ago master 539c001 Updating test with 'o?.#field' to be valid program by Caio Lima · 2 days ago df59ad6 Add AsyncIteratorClose tests by Alexey Shvayka · 2 days ago fccd9c4 Add IteratorClose tests by Alexey Shvayka · 2 days ago 966fc11 Migrate FinalizationRegistry tests to per-item callback API by Shu-yu Guo · 2 days ago 4199a3b Add integer index property name test by Alexey Shvayka · 3 days ago b69390e Add string property name test by Alexey Shvayka · 3 days ago 00cf7a1 Rename "trap-is-undefined-receiver.js" by Alexey Shvayka · 3 days ago 40a1a6f Improve RegExp LegacyOctalEscapeSequence coverage (#2558) by Alexey Shvayka · 3 days ago 772fd32 Promise.any: remove erroneous SpeciesConstructor tests until a better solution can be found. (#2562) by Rick Waldron · 3 days ago ffaae1f Logical Assignment Operators: additional syntax tests by Rick Waldron · 4 days ago 2778324 Fix tests by Justin Ridgewell · 4 days ago 78dbc40 Add logical-assignment-operators feature by Justin Ridgewell · 4 days ago fdf4675 Add tests for Logical Assignment by Justin Ridgewell · 4 days ago 6499fa6 Adding missing cases of instance field without assignment and static field with assignment by Caio Lima · 4 days ago 740e157 Adding test to cover case where there is a static field named as 'static' by Caio Lima · 4 days ago d279980 Add single quote string literal test by Alexey Shvayka · 4 days ago 4742461 Add double quote string literal test by Alexey Shvayka · 4 days ago 1150fe4 Add template literal test by Alexey Shvayka · 4 days ago b90a11e Add `throw` method test by Alexey Shvayka · 4 days ago 543370c Add `return` method test by Alexey Shvayka · 4 days ago 1bf4e15 Add `next` method test by Alexey Shvayka · 4 days ago Bug: v8:7834, v8:8179, v8:10394, v8:10395, v8:10396, v8:10397 Change-Id: Ib5c0e842179b9592501215f8789529c1070b118b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136291 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67030}
-
Ng Zhi An authored
WasmValue holds a Wasm value with its type. This will be exposed to the inspector (via a to-be-created class in debug_interface.h) for debugging in DevTools. Design at http://doc/1XQlX6DWsv6BPYnRtw-JZSASPEjsRlyXLnke7TTQ9Wrg. Bug: v8:10347 Change-Id: Ib523e617d46fdf1adb13d13bf49749c4ce23a126 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2132720Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This reverts commit cff2617b. Reason for revert: Breaks https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/13100? Original change's description: > cppgc: Stack scanning support for Windows native > > Assumes that (is_clang = false && is_win) => Windows native (MSVC). > > Cross-compile builds will use clang and not the native tools and thus > not fall into this category. > > This CL adds x86 and x64 MASM trampolines that can be used with the > native Windows toolchain (ml.exe, ml64.exe), when using is_clang = > false. > > Bug: chromium:1056170 > Change-Id: Ic37ce721a76ce027ebf45bef441b8fba4789dc9b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137408 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67025} TBR=mlippautz@chromium.org,bikineev@chromium.org Change-Id: I86286d4f438468350a81b3965956d47ae35d1c6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2138432Reviewed-by:
-
Frank Tang authored
Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489Reviewed-by:
-
