- 09 Sep, 2021 4 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/c23a001..1bd8098 Optimized docs installation (#1225) (Vitaly Zaitsev) https://chromium.googlesource.com/external/github.com/google/benchmark/+/1bd8098 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I2fa85b1c9ea2a3bc3422977560b8280f0723d649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149526Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76742}
-
Georg Neis authored
... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76741}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1e4482b..17d097b Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/fc37619..17de752 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/edf77b2..44ea7ab Rolling v8/third_party/aemu-linux-x64: ExffPYjGXL4Gz5i52elIFTU-ZZZ3Rgom_ZGpSi12LBoC..QewYN5289B8deg5Mn6clWEv58UqpocHGKeob2F0T87kC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c678081..664e425 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If5bde624ec64e78723a8e9d83a2cacb385fb1271 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149524Reviewed-by:
-
Zhao Jiazhong authored
The t6-t8 are scratch registers and should not be allocatable. Besides, add s0, s1, s2, s5 and s8 as allocatable registers. Change-Id: I0805cc5273d0e0ec5040a0376bcbfba276202077 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147315 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76739}
-
- 08 Sep, 2021 28 commits
-
-
Ng Zhi An authored
No functionality change is expected. Bug: v8:11217 Change-Id: I131d52794e4de24ec838cc23f15828edbfc656ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131372Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76738}
-
Ng Zhi An authored
Merge the SSE and AVX opcodes for I16x8Eq and I16x8GtS. We delegate to the macro-assembler to check for AVX. No functionality change is expected. Bug: v8:11217 Change-Id: I873b261d6f949bfc6755fe4c0e09b964a02c3684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131371 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Change-Id: I8afa821412ae248ddea990755404a9bf5f33184e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3125434Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/3da1e2f..715537d Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fbef918..1e4482b Rolling v8/third_party/aemu-linux-x64: aSVGWUgGw-Nuh-08X80jtqA2bVKylBoNa1h7D-6Kzf0C..ExffPYjGXL4Gz5i52elIFTU-ZZZ3Rgom_ZGpSi12LBoC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d69b31c..7285666 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/195c102..c678081 Rolling v8/tools/luci-go: git_revision:3e1f1f7a109ed8aefc7feba94fa737f0b5b4847e..git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7 Rolling v8/tools/luci-go: git_revision:3e1f1f7a109ed8aefc7feba94fa737f0b5b4847e..git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7 Rolling v8/tools/luci-go: git_revision:3e1f1f7a109ed8aefc7feba94fa737f0b5b4847e..git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id805d5bb7032f8208273f5e2aaa0532c7b03fc67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149517Reviewed-by:
-
Milad Fa authored
This CL takes advantage of the z15 `store byte reverse element` instructions to optimize Simd StoreLane opcodes. On the simulator we only run `store element` as reversing is not required. Change-Id: I723f6db535799470c46a1e298a9c1af7574ad5b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144373Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#76734}
-
Ng Zhi An authored
Combine the SSE and AVX versions, delegate to the macro-assembler functions to check for AVX support. Change Pand, Por, Pxor to generate the *ps version of the instruction when AVX is not supported. The *ps versions are 1 byte shorter, and have no performance difference on SSE-only processors. Bug: v8:11589 Bug: v8:11217 Change-Id: I9d51054359dcc909efcbb2c3d3bb63d399cd6721 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124101Reviewed-by:
-
Ng Zhi An authored
Do not require that dst == src1, this leaves more flexibility for the operands. We check in the macro-assembler if dst alias any of the input operands, then use vfma231/vfma132/vfma213 appropriately. Bug: v8:11659 Change-Id: I3644f5e0e75bd047d4e5f5b52d4234e54d329d15 Fixed: v8:11659 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131370 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#76732}
-
Francis McCabe authored
Bug: v8:12191 Change-Id: I867e81a62341f9c95cf56466b9d97a877d9debdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145990Reviewed-by:
-
Milad Fa authored
globals are no longer LE enforced after https://crrev.com/c/2944437. LANE is used instead to pick the correct lane on BE machines. Change-Id: I106bebda2633a4673ad4b5165c0440cc445d9475 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148036Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#76730}
-
Jakob Kummerow authored
In addition to inputs consisting entirely of random bits, the bigint test shell now also generates inputs that are powers of two (i.e. have many 0-bits) and inputs with many 1-bits. Empirically, these kinds of inputs are more likely to flush out corner case bugs. Bug: v8:11515 Change-Id: Ib69f12bf215055991b028196dc54ebbc00780bae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055292 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#76729}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:8091 Change-Id: I99546c99de2283c1169b299b5ae3cd89298a8a95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148134Reviewed-by:
-
Jakob Kummerow authored
No multiplications needed, just putting bits directly into the right places. Bug: v8:11515 Change-Id: I65e5658bb5ed12caec9325f414563526f8edbbf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055291 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Clemens Backes authored
This adds some basic tests for WebAssembly code protection, in four different configurations: - no protection - mprotect-based protection - PKU-based protection - PKU with fallback to mprotect If PKU is not supported by the OS or hardware, then PKU is identical to no protection, and PKU with fallback is identical to mprotect. We always execute all four configurations anyway. If protection is effective, we expect code to be writable within a {CodeSpaceWriteScope}, and not writable otherwise. When trying to write to non-writable code, we expect a crash of the process (checked via {ASSERT_DEATH_IF_SUPPORTED}). R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Change-Id: I4ec0ce9426f70ff41a292b9ea25be1e8956a670e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3138210 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76726}
-
Milad Fa authored
This is a port of the following 2 CL on Chromium: https://crrev.com/c/3139927 https://crrev.com/c/2672580 Bug: gn:252 Change-Id: I7c0636fad9d9f07c73e5f77b9b0a342d0326800f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145613Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#76725}
-
Yoshisato Yanagisawa authored
Bug: chromium:1233780 Change-Id: I92d097e04702f9db88113584c1d3e5e940d0f1ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147317 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Also bump the minimum size determined by manually testing with: mjsunit/harmony/modules-import-13 Bug: v8:12197 Change-Id: Ic21d42547ba14cd927d158388ad4bc6f1891f45c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147453 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76723}
-
Leszek Swirski authored
Fixed: v8:12192 Change-Id: Ifcb006bd1746e7bcf3b16c0e31e8cda9c920483c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147590 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#76722}
-
Zhao Jiazhong authored
We should use pc relative branch instruction rather than loading target address from memory for better performance. Besides, just like arm64, currently we assume that none of our relocation types are pc relative pointing outside the code buffer nor pc absolute pointing inside the code buffer. Change-Id: I9cce2e79c0afb00af967638405469f65df1deda2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147314Reviewed-by:
Liu yu <liuyu@loongson.cn> Commit-Queue: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#76721}
-
Thibaud Michaud authored
Bug: v8:8091, chromium:1247119 Change-Id: Icafd0bf9277aed835032396c2512e7d991407e0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144910Reviewed-by:
-
Michael Achenbach authored
These tests require a certain stack-size as otherwise range errors show up in the test expectations, which are compared verbatim. Bug: v8:12197 Change-Id: I0e420fe6b03965241003ac69fd7d96fa61682c1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147592 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
We add an option to BuildTFGraph to not emit stack checks and call tracing and use it in inlined functions. Also, we add tests for zero/multiple return values, as well as infinite loops in the inlined function. Bug: v8:12166 Change-Id: I5f34c57d9870592085804853ff23ba94897cc8d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141589Reviewed-by:
-
Leszek Swirski authored
Change-Id: Ic917bf0e6a3d5f6624f77c72cb9d16626d6508fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145418 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#76717}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/4f80705..c23a001 Remove unused parameter from lambda. (#1223) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/c23a001 add to final releasing step (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/92f50a2 bump version to 1.6 in preparation for release (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/f91b6b4 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I69c037d549e7d2887962e6d7cfa3ba87d990fe2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146793Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/03a089b..fbef918 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d579cbc..d69b31c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/749fd8e..195c102 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I08604eaa678dda32dda55016fcbb2a71183d1387 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145268Reviewed-by:
-
Liu Yu authored
I'm one of the v8 maintainers of mips, and I request to add myself to MIPS_OWNERS. Change-Id: If246f44e54497619d9d58929131e3d2d1dfc9c5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141031 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Lutz Vahl <vahl@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11879 Change-Id: I02cfb6ca7cff418dc3e4ab422a1bc3437f0ea778 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146075Reviewed-by:
-
Ng Zhi An authored
This is a reland of 65515ddd Fix is to use AddWithWraparound for signed additions to avoid UB. Original change's description: > [wasm-simd][arm64] Fuse add and extmul > > We can select a better instruction for add+extmul, using one of the > multiply-long-accumulate instruction. > > Define a helper struct to pattern match Add(x, OP(y, z)) and > Add(OP(x, y) z), and ensure that the matched OP is always on the > LHS, to simplify checking for matches. > > Bug: v8:11548 > Change-Id: I7ab488b262aa9f749785f973549ccd9fad72f4c8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826725 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76708} Bug: v8:11548 Change-Id: I675ab8b78d9c6c30b82a8c96c8e7098a548c6a60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144379 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Andrew Brown authored
A previous change (see ref) added a subset of 256-bit instructions to the x64 assembler--this change adds a disassembly test for the added instructions. ref: https://chromium-review.googlesource.com/c/v8/v8/+/3123648 Change-Id: Ia56be7a7df636b8bf6c04f044912e914d949d19f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3133956 Auto-Submit: Andrew Brown <andrew.brown@intel.com> Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 07 Sep, 2021 8 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/45a913c0..50f3fca Bug: v8:7834, v8:12167, v8:12168, v8:11544 Change-Id: I1cebc0a82cced63fbf9ec46111825f22ac01eeeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3142539Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#76710}
-
Zhi An Ng authored
This reverts commit 65515ddd. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/18117/overview Original change's description: > [wasm-simd][arm64] Fuse add and extmul > > We can select a better instruction for add+extmul, using one of the > multiply-long-accumulate instruction. > > Define a helper struct to pattern match Add(x, OP(y, z)) and > Add(OP(x, y) z), and ensure that the matched OP is always on the > LHS, to simplify checking for matches. > > Bug: v8:11548 > Change-Id: I7ab488b262aa9f749785f973549ccd9fad72f4c8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826725 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76708} Bug: v8:11548 Change-Id: Ic1560616e7ee6df917fcedbb6ad139a1a9773d68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144377 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76709}
-
Ng Zhi An authored
We can select a better instruction for add+extmul, using one of the multiply-long-accumulate instruction. Define a helper struct to pattern match Add(x, OP(y, z)) and Add(OP(x, y) z), and ensure that the matched OP is always on the LHS, to simplify checking for matches. Bug: v8:11548 Change-Id: I7ab488b262aa9f749785f973549ccd9fad72f4c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826725Reviewed-by:
-
Jakob Kummerow authored
On MacOS, `ps -e | grep foo` always finds a match, because `ps` already sees the `grep` command, which matches the search string. Luckily, `pgrep` exists as an elegant alternative. No-Try: true Change-Id: Ieedfe62ab11a59fb9a29ae1ebd39b164eec5193c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144917 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76707}
-
Ng Zhi An authored
Bug: v8:12094 Change-Id: Ibefce881cbfcd4445485197a4a2615bdf0599ada Fixed: v8:12094 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123638 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Fa authored
Change-Id: Iefd76cdf793578acf46717d99c8896c7df7e1970 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145179Reviewed-by:
-
Junliang Yan authored
Change-Id: Id37868f94a9ccebdee0530e9eb450c4acfa2f7c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145414Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76704}
-
Jakob Kummerow authored
Simply putting all features behind --experimental-wasm-gc. The intent is to simplify command lines. Bug: v8:7748 Change-Id: Ibfaa4dc720087a490b177a2b95841620a4d25d89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141583 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76703}
-
