- 30 Jun, 2021 36 commits
-
-
Clemens Backes authored
FLAG_SCOPE_EXTERNAL can be used outside of the v8::internal namespace, while FLAG_SCOPE can not. This CL refactors FLAG_SCOPE such that it can be used anywhere, and removes the redudant FLAG_SCOPE_EXTERNAL macro. Also, UNFLAG_SCOPE_EXTERNAL is removed in favor of FLAG_SCOPE_VAL, as the word "flag" in the macro name is meant to refer to a flag, and not to the verb or action of "flagging" something, hence "unflag" does not match the terminology. R=ahaas@chromium.org Bug: v8:11879 Change-Id: I2d761012c3e4330abb611bf67130eb57ec5bb964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988920 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#75482}
-
Milad Fa authored
regress-crbug-482998 is skipped and regress-331444 is marked as slow. Bug: v8:11875 Change-Id: I01c14dee704c5179d62b79cca0681f833102680d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996842Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75481}
-
Clemens Backes authored
There are instructions that take 7 bytes, e.g. 4881ec10000000 REX.W subq rsp,0x10 Hence increase the padding from 12 characters to 14 characters to restore alignment. Drive-by: Rewrite the padding loop to make it more readable and add a comment. R=jkummerow@chromium.org Change-Id: Iddd6a721574fc47b4a072fe40c2f5e90cb3d1186 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996200Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75480}
-
Clemens Backes authored
The {EnterFrame} and {LeaveFrame} methods will already emit a (scoped) code comment in the form [ EnterFrame ... instructions ... ] Thus skip the additional code comment emitted by Liftoff. R=ahaas@chromium.org Bug: v8:11879 Change-Id: I488568022cb03b16f07a12c1a575d90613691758 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996197Reviewed-by: -
Clemens Backes authored
Extern ref in Liftoff is enabled since M-90 (https://crrev.com/c/2625886), hence remove the flag to simplify the code. R=ahaas@chromium.org Bug: v8:11879 Change-Id: Ie72dfbc006d6f42e2e9e83d44ff78e3c53a82614 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996195Reviewed-by:
-
Clemens Backes authored
We currently merge i32 binary operations with a subsequent if or br_if, and we merge i32.eqz with a subsequent br_if. The combination i32.eqz + if was missing, even thought there is already support for that in the "if" handler. R=ahaas@chromium.org Change-Id: Id4386d0c5d6dcf3605c72ea1146169d2088abe98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996196Reviewed-by:
-
Manos Koukoutos authored
Design doc: https://bit.ly/3xPxWUe This CL introduces two main changes: - Initializer expressions are now decoded by WasmFullDecoder. With wasm-gc, initializer expressions are no longer just constants, and require complex decoding (including stack tracking). This resulted in extensive code duplication. - Initializer expressions are not stored explicitly by module-decoder as an AST (WasmInitExpr), but rather as a WireBytesRef, and are decoded again during module instantiation. This should reduce memory consumption for globals and other module elements with initializer expressions (which has been observed in the 40MB range in some real-world benchmarks. Summary of changes: - Add a static parameter {kFunctionBody, kInitExpression} to the WasmDecoder. Use it to specialize validation to function bodies/init. expressions. - Introduce a new Interface for the WasmFullDecoder for init. expressions. - Differentiate between constant and non-constant opcodes in WasmFullDecoder. - Change representation of init. expressions in WasmModule to WireBytesRef. - Reimplement EvaluateInitExpression in module-instantiate to re-decode initializer expressions. - Remove some now-invalid module decoder tests. Pending changes: - Also refactor initializer expressions for element segment entries. - Reintroduce deleted tests. Bug: v8:11895 Change-Id: I76512bfe1386c8338667d30fa6db93880a1e4b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972910Reviewed-by:
-
Victor Gomes authored
If the object to be trimmed creates a filler object that is located just before the current LAB, then we can immediately give back the memory. Bug: v8:11872, v8:11883 Change-Id: I9ec37443482334003b3752a3f25fc5dcb6a476fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996643Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75475}
-
Clemens Backes authored
Those flags are old, not commonly used, and redundant. People usually rely on external tools to disassembly wasm functions or modules. Also, the name is misleading as Wasm is not an AST (any more). R=ahaas@chromium.org Bug: v8:11879 Change-Id: I0f90d142ae4c7c6b7ee6013ea033951aad6bf133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996194Reviewed-by:
-
Clemens Backes authored
This will automatically skip the test in the stress_snapshot variant, where Wasm is not supported. R=cbruni@chromium.org Bug: v8:11937 Change-Id: I29078e070a7b1526470e15d8667c5256ea4d8fe1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996642Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75473}
-
Clemens Backes authored
This adds back two spaces that went missing in https://crrev.com/c/2978252, removing the space between offset and instruction bytes. After https://crrev.com/c/2978252: 0x21ea0e1e04a0 055 push rbp 0x21ea0e1e04a1 14889e5 REX.W movq rbp,rsp After this CL: 0x2be7c8c604a0 0 55 push rbp 0x2be7c8c604a1 1 4889e5 REX.W movq rbp,rsp R=delphick@chromium.org Change-Id: I6df35aed9b5909da72965fef622b07120c226fae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996199Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75472}
-
Victor Gomes authored
No-Try: true Bug: v8:11234 Change-Id: I93bf3f096bd82faadd21abf08d61f06c0b823f7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996189 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts: 59b9aaf7 8f84d0bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Change-Id: Ieaca12cad2edcab85517cb4cffb58abb1be50674 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996198 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#75470}
-
Victor Gomes authored
Bug: v8:11872 Change-Id: I8511bec7f4eaed5d154094083b46e3895ac0b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992728Reviewed-by:
-
Yoshisato Yanagisawa authored
Bug: chromium:1222951 Change-Id: I41bf941969b5d94ec28ac728f0fe129d8acb83d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2995611 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
.. and make JSGlobalObjectRef bg-serialized. GetPropertyCell was implemented as: LookupIterator it(holder, isolate, name, LookupIterator::OWN); it.TryLookupCachedProperty(); if (it.state() == LookupIterator::DATA) it.GetPropertyCell(); Due to concurrency requirements, we essentially have to reimplement this entire path for use in a concurrent setting: - Reads in some cases have to use relaxed or acquire semantics. - The IsPendingAllocation predicate must be called on some objects before reading into them. - Repeated reads of the same field must be avoided due to the possibility of concurrent modifications. This CL introduces two new methods: ConcurrentLookupIterator::TryGetPropertyCell implements the outer lookup logic, including the repeated lookup for accessors / cached property names. GlobalDictionary::TryFindPropertyCellForConcurrentLookupIterator is a slightly modified HashTable::FindEntry which follows the above rules. Bug: v8:7790 Change-Id: Ic9a52da766afdfedce8efcbda92876845a17eed9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959616Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75467}
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: Ie46c575a9f438f25e7db7c1758beaf7bf0e8b39f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992885 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75466}
-
Victor Gomes authored
Bug: v8:11872 Change-Id: I16c6c0027b905215a789f8d47b19824b1c1f2491 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992725 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: I54eea2deaaa4823b13f8f66e13a1851f951c63c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991241 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: If558b6db7feed50bd0325a814bcab9e98ebd9493 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991239 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This reverts commit 5fefa970. Reason for revert: They are used via CodeT https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20external%20code%20space%20-%20debug%20-%20builder/124/overview Original change's description: > [compiler] Remove unused CodeDataContainerRef/Data classes > > Bug: v8:7790 > Change-Id: I072823ea40b0bd64aaf4a14882603cef29edcf22 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992722 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75456} Bug: v8:7790 Change-Id: I2c7f65c8a772de9967ce5b3aa78d1f46c9c99866 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996188Reviewed-by:
-
Ross McIlroy authored
Adds support for a seperate dynamic map checks trampoline that takes the feedback vector as an argument rather than reading it from the stack frame, to enable it to work for inlined functions. Plumbs the logic through the compiler to select between these trampolines based on the framestate. BUG=v8:9684,chromium:1224367 Change-Id: Ibc7facdc78930aedec4a102693a926f64f6de7e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992724 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#75461}
-
Santiago Aboy Solanes authored
When failing to construct a Ref, it helps debugging knowing which class is the one we failed to create. Bug: v8:7790 Change-Id: I22388920633fe2155c7b4fa712c5dead25a2f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992726Reviewed-by:
-
Clemens Backes authored
This flag only controls whether d8 installs the signal handler for wasm traps. Hence it should be a d8-only flag, to avoid confusion if used in other embeddings. We just introduced --wasm-enforce-bounds-checks to do what you might think --no-wasm-trap-handler would do. R=ahaas@chromium.org Bug: v8:11926 Change-Id: Ic1f33af36236a2981cf060f450bbfd02e51d9793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989130 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Milad Fa authored
`SharedFunctionInfo` is defined under the added header and not having it included causes this compilation error: variable has incomplete type 'v8::internal::SharedFunctionInfo' Change-Id: Ieb0e8f89043f91decdc93f8b3e3c5ed29c0043c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989133 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#75458}
-
Jakob Gruber authored
... but keep/make subclass-specific methods do direct reads. Bug: v8:7790 Change-Id: Ia4b9d207ce75cf28f6f0f33027ab05e27db49ce9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959621Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I072823ea40b0bd64aaf4a14882603cef29edcf22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992722Reviewed-by:
-
Milad Fa authored
The following compilation error is thrown if a platform does not have sparkplug implanted: error: code will never be executed Change-Id: Ifbf2162ec9580f86620ca2bfd1007d96da2a4138 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992889 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Call it NativeContextRef::GlobalIsDetached and implement it on top of Refs such that it can benefit from direct reads. Drive-by: inline a JSNativeContextSpecialization::ReduceGlobalAccess overload into its only callsite. Bug: v8:7790 Change-Id: I1c6891e0fc65a476b0c4587f3fde2c6461b302a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959614Reviewed-by:
-
Clemens Backes authored
There currently is no way to enforce explicit bounds checks if the embedder installed the signal handler for wasm trap handling (queried via {trap_handler::IsTrapHandlerEnabled()}). This CL adds a respective flag and makes all compilation emit explicit bounds checks if it is disabled. R=ahaas@chromium.org Bug: v8:11926 Change-Id: Ie19faab1766d3105f3c22cb4470c0f15398f1d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989129Reviewed-by:Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75453}
-
Jakob Gruber authored
.. now that all JSObjectRef methods can run in concurrent settings. Also change a few subtypes to bg-serialized: - JSArray - JSGlobalProxy - JSTypedArray Bug: v8:7790 Change-Id: I406b0a8eacb4e5bd2c3a24eb106b29df2cf55421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966377Reviewed-by:
-
Camillo Bruni authored
https://crrev.com/c/2972915 previously added more gitignore files to the repository. This left the repo dirty after running mjsunit tests due to lingering .log files. - Add test/mjsunit/tools/tmp dir to keep and ignore temporary log files without the need for a platform specific tmp dir - Use temporary logfiles with --logfile=+ for log-ci.js tests Change-Id: I1b1a47f45603d6c3027c6ca7050c78e8df0664ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992720Reviewed-by:
-
Camillo Bruni authored
MSVC is not happy about conditionally increasing the buffer size for builtin code generation with --code-comments. Previous CL: https://crrev.com/c/2976651 Change-Id: Ic257eecfc9c41835d8ae4cf2de595fd5c427a7e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992721Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/94f845e..19026e2 fix clang-tidy warnings (#1195) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/19026e2 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Ia1d456215ab523ae4e493f2a32d78288089d4771 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989188Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75449}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/73a9443..b342bb3 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/73e7404..d46361b Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/a38ef11..9303368 Rolling v8/third_party/aemu-linux-x64: A1XxYDWVeZi3lNSg1lZdcmGtIB2fA0XTIPYdevon60YC..kZbnq1Wh_y69PWihHdedFiEIQANIiZchdysb5-fpBTEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/11a2ddf..2bc697b Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/6906af9..7c54c1f Rolling v8/third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/0944e71..1b882ef Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/04e2c7e..5633839 Rolling v8/tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef Rolling v8/tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef Rolling v8/tools/luci-go: git_revision:8ed83b4afa51020c8900d121bb57624b35882dec..git_revision:ede472114f4e51eaa068cd84cadcf470773f19ef TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I1f462a8309ddec306f06fe6aae584176eb375aa9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2995605Reviewed-by:
-
Lu Yahan authored
Add Label::Distance flag to control emit Branchshort. Change-Id: I418024ea530ae41788c5684bb8bd2044311a99d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959266 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
Brice Dobry <brice.dobry@futurewei.com> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#75447}
-
- 29 Jun, 2021 4 commits
-
-
Dominik Inführ authored
%SimulateFullSpace uses PauseAllocationObserversScope internally and so does a GC. When there happens to be a GC during %SimulateFullSpace (caused by --stress-concurrent-allocation here), then the DCHECK in AllocationCounter::Pause would fail because it was already paused. Solve this by counting the number of active PauseAllocationObserversScopes. Bug: v8:11936 Change-Id: I86487c24fd33739fd7e6635501b5f0257806c4bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992727Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#75446}
-
Junliang Yan authored
Change-Id: Ib4c3335389d1df0c48a529c3bb096de2382a86a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994727 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75445}
-
Milad Fa authored
Flags are also updated under `instruction-selector` to include these operations. Not having them was causing their Simd versions to remain unused as well. V8 was just interpreting them at runtime. Change-Id: I42677f7412859ad4759b70ba16667ec9d90505af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994803Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75444}
-
Peter Kasting authored
This is a reland of edab8730 It was speculatively reverted but the issue turned out to just be slow tests. Original change's description: > Fix -Wimplicit-int-float-conversions. > > Bug: chromium:989932 > Change-Id: Ief917b023cb079f5ff87dc8963d74f225d074d7a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989096 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75413} Bug: chromium:989932 Change-Id: Iec8ac8ee32705c6a699a2df2f292ffe07cde99f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994802Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#75443}
-
