Commits · d5d7b1d9c1821edb710defcde5d5814da665720c · Linshizhi / V8

16 Sep, 2013 8 commits

Tweak HConstant::EmitAtUses() to eliminate useless constant generation · d5d7b1d9

danno@chromium.org authored Sep 16, 2013

BUG=2881
R=danno@chromium.org

Review URL: https://codereview.chromium.org/23811011

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16731 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5d7b1d9

Make HCompareNumericAndBranch safe for snapshots on ia32. · 73b03b89

bmeurer@chromium.org authored Sep 16, 2013

R=danno@chromium.org

Review URL: https://codereview.chromium.org/24078012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16730 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

73b03b89

Fixed shared_library build on Windows. · 7b41d6d4

svenpanne@chromium.org authored Sep 16, 2013

BUG=v8:2879
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/24054008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16729 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b41d6d4

Remove unused context parameter from AddIncrementCounter(). · 8588b744

bmeurer@chromium.org authored Sep 16, 2013

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23622033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8588b744

ARM: Tweak the integer division operation. · 39f0ccc2

rodolph.perfetta@gmail.com authored Sep 16, 2013

BUG=none
TEST=test/mjsunit/lithium/DivI.js
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23536045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

39f0ccc2

Rename StubType MAP_TRANSITION to TRANSITION. · 223ac69f

verwaest@chromium.org authored Sep 16, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24120007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16726 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

223ac69f

HeapProfiler: replace pointer based matching algorithm with string matching... · 2abe14b8

loislo@chromium.org authored Sep 16, 2013

HeapProfiler: replace pointer based matching algorithm with string matching algorithm for strings_ member.

pros: decreased snapshot size.
cons: increased serialization time.

I've tested the implementation on gmail 90mb heap.
I saw no speed degradation on the serialization step.
The snapshot size lost ~3% of its size. 100Mb -> 97Mb.

BUG=none
R=alph@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/24120006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16725 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2abe14b8

Prepare push to trunk. Now working on version 3.21.17. · 043abcd3

mvstanton@chromium.org authored Sep 16, 2013

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23437040

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16722 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

043abcd3

13 Sep, 2013 23 commits

MIPS: remove getcurrent from stubs. · 6d3b3255

plind44@gmail.com authored Sep 13, 2013

Port r16710 (c5203f8)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/23710046

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16721 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6d3b3255

MIPS: Improve SeqStringSetChar implementation. · 23fc6218

plind44@gmail.com authored Sep 13, 2013

Port r16707 (a25d669)

TEST=/test/mjsunit/lithium/SeqStringSetChar.js
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/23484043

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

23fc6218

Every place where AllocationMemento is initialized with an · 516339cb

mvstanton@chromium.org authored Sep 13, 2013

AllocationSite is now checked to be sure a valid Site goes in.

This is temporary code to diagnose chromium bug 284577.

(This is a second attempt, the first attempt ran into the problem of undefined ordering of function calls in Windows and Mac optimized builds, see the fixes in code-stubs-hydrogen.cc).

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23440035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16719 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

516339cb

revert 16717 for breaking everything · 31105962

dcarney@chromium.org authored Sep 13, 2013

TBR=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23708039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16718 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31105962

line up crashing with chrome · bbaf775d

dcarney@chromium.org authored Sep 13, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23868025

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16717 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bbaf775d

Add Contains(), at(), and a constructor with raw addresses to UniqueSet<T> and Unique<T>. · 25372ac1

titzer@chromium.org authored Sep 13, 2013

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23872027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16716 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25372ac1

Add missing factory method for HDebugBreak. · fe9f9e20

bmeurer@chromium.org authored Sep 13, 2013

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23619052

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16715 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fe9f9e20

Intel: Branch reordering and port arm EmitNumberUntagD() Improvement · 81425a20

olivf@chromium.org authored Sep 13, 2013

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23872026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16714 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81425a20

Fix heap verifier for partially constructed arrays when allocation folding is off. · a8443629

hpayer@chromium.org authored Sep 13, 2013

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/23934008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a8443629

Don't update ICs when the receiver has a deprecated map. · 3824d596

verwaest@chromium.org authored Sep 13, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23658047

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3824d596

remove OS::StackWalk · cb490c99

dcarney@chromium.org authored Sep 13, 2013

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23703013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb490c99

remove getcurrent from stubs · 564a9a68

dcarney@chromium.org authored Sep 13, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23756009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16710 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

564a9a68

Use regular map-checks to guard string-length loading. · ea77a8ed

verwaest@chromium.org authored Sep 13, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23702039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea77a8ed

Handlify JSObject::DeepCopy method. · 50b05676

mstarzinger@chromium.org authored Sep 13, 2013

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/22934006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50b05676

ARM: Improve SeqStringSetChar implementation. · 85401293

bmeurer@chromium.org authored Sep 13, 2013

TEST=/test/mjsunit/lithium/SeqStringSetChar.js
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/23890007

Patch from Rodolph Perfetta <rodolph.perfetta@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16707 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

85401293

Revert "Every place where AllocationMemento is initialized with an" · c29295e8

mvstanton@chromium.org authored Sep 13, 2013

This reverts r16705 for breaking Windows build.

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/23447031

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c29295e8

Every place where AllocationMemento is initialized with an · 25c4f763

mvstanton@chromium.org authored Sep 13, 2013

AllocationSite is now checked to be sure a valid Site goes in.
This is temporary code to diagnose chromium bug 284577.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23622029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25c4f763

Array "splice" changeRecords should be emitted after the performChange has completed (per spec) · 94c4c596

rossberg@chromium.org authored Sep 13, 2013

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23434008

Patch from Rafael Weinstein <rafaelw@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16704 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

94c4c596

Allow implicit conversion of acceptList values to string during Object.observe · f99298bf

rossberg@chromium.org authored Sep 13, 2013

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23464058

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16703 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f99298bf

Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written · e4c179e2

yangguo@chromium.org authored Sep 13, 2013

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23654026

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16702 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e4c179e2

Prepare push to trunk. Now working on version 3.21.16. · 8650fae5

dslomov@chromium.org authored Sep 13, 2013

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23437033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16699 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8650fae5

MIPS: Bugfix: array constructors that expect a type feedback cell that points... · 2cec3754

palfia@homejinni.com authored Sep 13, 2013

MIPS: Bugfix: array constructors that expect a type feedback cell that points to an AllocationSite were being passed the undefined object in some cases. Clearly separate the cases where we have an AllocationSite and where we don't in the general ArrayConstructorStub.

Port r16693 (0852d4ab)

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23451057

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16698 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2cec3754

MIPS: Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. · 617f7546

palfia@homejinni.com authored Sep 13, 2013

Port r16688 (fcae0bcf)

Original commit message:
The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23513045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16697 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

617f7546

12 Sep, 2013 9 commits

Reland Handle non-JSObject heap objects using slow-path IC stub guarded by the map. · e9c4a498

verwaest@chromium.org authored Sep 12, 2013

R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23578030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16696 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9c4a498

MIPS: Improve code generation for the HRandom instruction. · 4f09f428

palfia@homejinni.com authored Sep 12, 2013

Port r16684 (e0f70aa)

Original commit message:
Since the per-context random number generator is now
properly seeded upon context creation, we do not need
to check for lazy-initialization anymore, and so we
can implement the HRandom instruction w/o having to
call into the C function (which means we don't need
to MarkAsCall anymore).

TEST=cctest/test-random
BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23851028

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4f09f428

MIPS: Fix of r16681 · 705d8132

palfia@homejinni.com authored Sep 12, 2013

Use v0 for return value.

BUG=
R=gergely@homejinni.com

Review URL: https://codereview.chromium.org/23437032

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

705d8132

Bugfix: array constructors that expect a type feedback cell that points · 5521e2e8

mvstanton@chromium.org authored Sep 12, 2013

to an AllocationSite were being passed the undefined object in some
cases. Clearly separate the cases where we have an AllocationSite and
where we don't in the general ArrayConstructorStub.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23477071

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16693 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5521e2e8

Revert "Handle non-JSObject heap objects using slow-path IC stub guarded by the map." · ff412d8c

verwaest@chromium.org authored Sep 12, 2013

TBR=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23475039

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16692 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ff412d8c

Reland "Clean up after r16292 (disable optimization for StringWrappers)." · cb10ceb1

yangguo@chromium.org authored Sep 12, 2013

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/23619036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16691 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb10ceb1

NumberUntagD is faster when untagging in a temp register · 5a0d1ba8

olivf@chromium.org authored Sep 12, 2013

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/23684056

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16690 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5a0d1ba8

Handle non-JSObject heap objects using slow-path IC stub guarded by the map. · f375e051

verwaest@chromium.org authored Sep 12, 2013

BUG=chromium:280632
R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23691056

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f375e051

Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1. · 34edb733

mstarzinger@chromium.org authored Sep 12, 2013

The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that they
contain the same fields.

The field order will be:
holder
isolate
return value default value
return value
data
this

This step 1 reorders the PropertyCallbackInfo fields.

BUG=
R=dcarney@chromium.org, mstarzinger@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16673

Review URL: https://codereview.chromium.org/23620036

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16688 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

34edb733