Commits · d5cb9ee440f28661b0865b8bafe579fefac052f8 · Linshizhi / V8

17 Jun, 2014 9 commits

Drop obsolete ES6 TODOs about activating extended mode. · d5cb9ee4

mstarzinger@chromium.org authored Jun 17, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/338363002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21877 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5cb9ee4

Remove unnecessary virtual methods in the serializer. · c41c4358

yangguo@chromium.org authored Jun 17, 2014

R=marja@chromium.org

Review URL: https://codereview.chromium.org/339103005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c41c4358

Rename arguments object support functions to new scheme. · 46d36e81

mstarzinger@chromium.org authored Jun 17, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/338883003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21875 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

46d36e81

Interrupts must not mask stack overflow. · 11368af6

yangguo@chromium.org authored Jun 17, 2014

R=jarin@chromium.org
BUG=385002
LOG=N

Review URL: https://codereview.chromium.org/339883002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21874 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11368af6

Reduce number of writes to DependentCode array when inserting dependent IC. · b624783b

ulan@chromium.org authored Jun 17, 2014

BUG=305878
LOG=Y
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/339843004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21873 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b624783b

Fix: AstValueFactory must be internalized before ThrowPendingError. · 3b53ba87

marja@chromium.org authored Jun 17, 2014

R=rossberg@chromium.org
BUG=385193
LOG=N

Review URL: https://codereview.chromium.org/335373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21872 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b53ba87

Do GC if CodeRange fails to allocate a block. · 944e7f09

ulan@chromium.org authored Jun 17, 2014

BUG=305878
LOG=Y
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/332373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21869 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

944e7f09

Throw syntax error when a getter/setter has the wrong number of params · 5bbc92de

marja@chromium.org authored Jun 17, 2014

We used to allow any number of parameters in getters and setters to
match JSC. This is a violation of ES5.1 and both SpiderMonkey and
Chakra throw on these syntax errors.

BUG=v8:3371
LOG=Y
R=marja@chromium.org

Review URL: https://codereview.chromium.org/329413002

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5bbc92de

Revert "Grow big old generation slower.", tanks SplayHarder. · e0567085

hpayer@chromium.org authored Jun 17, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/331393002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21865 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e0567085

16 Jun, 2014 5 commits

Do not eliminate bounds checks for "<const> - x". · f69bb7fc

jarin@chromium.org authored Jun 16, 2014

Before this change, bounds check elimination treated "<const> - x" as
"x - <const>".

R=yangguo@chromium.org
BUG=385054
TEST=test/mjsunit/regress/regress-385054.js
LOG=N

Review URL: https://codereview.chromium.org/339583003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21859 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f69bb7fc

Add unit test for regression in GVN caused by field type tracking. · 2591003d

bmeurer@chromium.org authored Jun 16, 2014

BUG=v8:3347
LOG=n
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/333273004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21858 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2591003d

Revert "GVN fix, preventing loads hoisting above stores to the same field when... · 4642c2e1

bmeurer@chromium.org authored Jun 16, 2014

Revert "GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's representation is not the same."

This reverts commit r21830 for tanking performance on Deltablue.

TBR=ishell@chromium.org

Review URL: https://codereview.chromium.org/336223002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4642c2e1

Reuse AstValueFactory when optimizing. · 71d07279

marja@chromium.org authored Jun 16, 2014

HOptimizedGraphBuilder::TryInline creates a temporary CompilationInfo and
destroys it, but we don't want the AstValueFactory to be destroyed at the same
time. Reuse the upper CompilationInfo's AstValueFactory.

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/334173003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21851 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71d07279

Fix representation of Phis for mutable-heapnumber-in-object-literal properties · aae24ae4

jkummerow@chromium.org authored Jun 16, 2014

BUG=v8:3392
LOG=y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/328343004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21850 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aae24ae4

13 Jun, 2014 23 commits

Fix x87 compile · 712b0a20

jochen@chromium.org authored Jun 13, 2014

TBR=marja@chormium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/337713003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21847 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

712b0a20

Remove dependency on Vector from platform files · 9c2019b2

jochen@chromium.org authored Jun 13, 2014

Add wrappers to utils.h instead.

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/328343003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21846 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9c2019b2

Fix windows build (size_t vs. int) some more. · 27d7656b

marja@chromium.org authored Jun 13, 2014

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/336803002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21845 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

27d7656b

Fix windows build (size_t vs. int). · 1def5993

marja@chromium.org authored Jun 13, 2014

Sadly, Vector ctor takes an argument "int length".

TBR=dcarney@chromium.org, mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/334903002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21844 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1def5993

Fix gn build. · 2b522959

marja@chromium.org authored Jun 13, 2014

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/338553002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21843 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2b522959

Fix clang build after r21839 · e5351135

jkummerow@chromium.org authored Jun 13, 2014

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/330793003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21842 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5351135

Parser: Delay internalizing strings and values. · a290cf8c

marja@chromium.org authored Jun 13, 2014

This is needed so that we can run Parser on a non-main thread (independent
of the Isolate and the V8 heap).

BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/314603004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21841 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a290cf8c

Optimize Function.prototype.call · 7005abf0

verwaest@chromium.org authored Jun 13, 2014

- May inline the function, or call it directly, instead of going through call
- Supports arguments object escaping when it escapes to builtins (preparation for slice.call(arguments, ...) optimization)
- Both .call and .apply now support inlining when calling builtins indirectly

BUG=
R=verwaest@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/335683002

Patch from Petka Antonov <p.antonov@partner.samsung.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7005abf0

Have one, long-lived map for bound functions. · 6e29768e

jkummerow@chromium.org authored Jun 13, 2014

This avoids creating a new map for every bound function. Bonus: some cleanup in Runtime_FunctionBindArguments.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/335653002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6e29768e

Keep maps when resetting elements. · 9dd1f03c

jkummerow@chromium.org authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/335553004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9dd1f03c

Reland "Rename kIs64BitArch with kRequiresCodeRange." · 510ea9e5

svenpanne@chromium.org authored Jun 13, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/331823002

Patch from Weiliang Lin <weiliang.lin@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21837 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

510ea9e5

Remove one more arch-specific target name. · 3b545740

jkummerow@chromium.org authored Jun 13, 2014

One more target had the architecture added to its name since r14209
originally landed and was missed when that change was reverted. Remove
the architecture from v8_libbase as well.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/334793004

Patch from Richard Coles <torne@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21836 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b545740

Emulate MLS on pre-ARMv6T2. Cleaned up thumbee vs. thumb2 confusion. · d82a6ada

svenpanne@chromium.org authored Jun 13, 2014

This should unbreak things on the Raspberry Pi.

LOG=y
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/331803003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21835 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d82a6ada

Allow all Names to be fast property names · 8334faa0

jkummerow@chromium.org authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/329393005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21834 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8334faa0

Use generic representation when normalizing boilerplate properties · a4d1e01b

jkummerow@chromium.org authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/323403008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21833 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a4d1e01b

Mark timed range in the profile plot. · 2e8a6f5e

yangguo@chromium.org authored Jun 13, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/333643006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21832 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e8a6f5e

Disable regress/regress-2653 until deopt_every_n_garbage_collections is fixed. · 0f69ed32

ulan@chromium.org authored Jun 13, 2014

BUG=3389
LOG=N
R=marja@chromium.org

Review URL: https://codereview.chromium.org/331823003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f69ed32

GVN fix, preventing loads hoisting above stores to the same field when... · 41e9d916

ishell@chromium.org authored Jun 13, 2014

GVN fix, preventing loads hoisting above stores to the same field when HObjectAccess's representation is not the same.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/331493006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21830 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

41e9d916

X87: Fixed flooring division by a power of 2, once again... · fd1ace4d

weiliang.lin@intel.com authored Jun 13, 2014

port r21769

original message:
    Avoid right shifts by zero bits: On ARM it actually means shifting by
    32 bits (correctness issue) and on other platforms they are useless
    (performance issue). This is fix for the fix in r20544.

    BUG=v8:3259
    LOG=y
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/330133004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21829 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd1ace4d

Fixed undefined behavior in RNG. · ac18d082

svenpanne@chromium.org authored Jun 13, 2014

We're basically trading undefined behavior for implementation defined
behavior, which should be OK for UBSan. :-) The generated code should
be identical, at least I checked that for GCC 4.6.3 on x64.

BUG=377790
LOG=y
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/332733002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21828 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ac18d082

Update Lithium AddI, SubI, MulI, BitI, ShiftI, MathMinMax to support x32 port. · 817430f6

haitao.feng@intel.com authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/321373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21827 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

817430f6

Specially handle the key of the LoadKeyed and StoreKeyed instruction for x32 port. · 28e74e13

haitao.feng@intel.com authored Jun 13, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/324913002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21826 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28e74e13

MIPS: Fix register usage after r21822. · 1eac6114

palfia@homejinni.com authored Jun 13, 2014

The at register is no longer in usage, so changed it to "scratch".

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/335753003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21825 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1eac6114

12 Jun, 2014 3 commits

MIPS: Fix r21780 - “Fixed flooring division by a power of 2, once again...” · d773d05b

plind44@gmail.com authored Jun 12, 2014

Initialize scratch register for all possible code paths.

TEST=mjsunit/compiler/division-by-constant.js
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/333713002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21822 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d773d05b

Make timestamp of fuzz harness archives finer grained. · ed61b85c

mstarzinger@chromium.org authored Jun 12, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/329303004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21821 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed61b85c

For-of calls [Symbol.iterator]() on RHS to get iterator · dfb1c7dc

wingo@igalia.com authored Jun 12, 2014

R=rossberg@chromium.org
BUG=http://code.google.com/p/v8/issues/detail?id=2735
LOG=N

Review URL: https://codereview.chromium.org/332663004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dfb1c7dc