- 22 May, 2019 37 commits
-
-
Andreas Haas authored
Up until now, we cached export wrappers per export index. With the anyref proposal potentially many more functions will need export wrappers, e.g. any function that is stored in a table, and any function accessed by the new ref.func instruction. With this CL, we change the caching scheme an do the caching per signature. Thereby we can guarantee that any export wrapper which potentially exists can be stored in the cache. For cctests which use wasm-run-utils, we don't know the size of the cache anymore ahead of time. However, we assume that no more than 5 signatures will be used in any cctest. If this assumption is not true, we can just adjust the number. The cache is now accessed in all code paths where we need an export wrapper. Bug: chromium:962850 Change-Id: I32df60dfa7801d1e71f7d837da091f388198af1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615247 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61752}
-
Andreas Haas authored
The core spec tests need to be generated manually for now, because our bots don't have an ocaml installation. This CL was created automatically by running ./tools/wasm/update-wasm-spec-tests.sh. R=adamk@chromium.org Change-Id: I4c6199b51f30b29f150914a9bffe6009452c8c47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624794Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61751}
-
Clemens Hammacher authored
{Object::operator->} will be removed soon. R=tebbi@chromium.org Bug: v8:9183, v8:3770 Change-Id: Ifb7754c16055aec41dd30a92e81521a830de4f26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624210Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61750}
-
Clemens Hammacher authored
This reverts commit 2ce5da9a. Reason for revert: Fails on several bots, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/26607 Original change's description: > [wasm] Compile big functions first > > Add a special queue to {CompilationUnitQueues} to handle big functions > specially. They are organized in a priority queue (ordered by their > body size), and all threads check this queue first, before executing > the tasks from their own queue. In some benchmarks, this shortens > overall compilation time by 10-20 percent. > > R=ahaas@chromium.org > > Bug: v8:8916, chromium:950493 > Change-Id: I45f36a05304e2f1c4f3ce6b8821ddd4bd08fbba3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622122 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61746} TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Ib47b23ff878d4a561df1993d532e5eeafea64ff6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8916, chromium:950493 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624797Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61749}
-
Jakob Gruber authored
Refactor-only: move the more involved EmbeddedFileWriter methods into the .cc file. Bug: v8:9103 Change-Id: I546c23544a0425a32cbd04cecc759f9b553b7071 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624207 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61748}
-
Georg Neis authored
Use JSObject::FastPropertyAt instead. Also, to avoid adding an immutable-flag to PropertyAccessInfo, use DataConstant (instead of DataField) for properties that are immutable according to their attributes. This is in preparation for serializing the property value for concurrent inlining. Bug: v8:7790 Change-Id: Ib40059bde2e5eb14b26400bcab72d6ea6bb57666 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624790Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61747}
-
Clemens Hammacher authored
Add a special queue to {CompilationUnitQueues} to handle big functions specially. They are organized in a priority queue (ordered by their body size), and all threads check this queue first, before executing the tasks from their own queue. In some benchmarks, this shortens overall compilation time by 10-20 percent. R=ahaas@chromium.org Bug: v8:8916, chromium:950493 Change-Id: I45f36a05304e2f1c4f3ce6b8821ddd4bd08fbba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622122Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61746}
-
Jakob Gruber authored
This is in preparation for better cross-compile support in mksnapshot. Specifically, this CL series will introduce runtime switches to select the target platform for generated embedded.S assembly. Each platform writer will derive from the abstract base class PlatformEmbeddedFileWriterBase. Currently, the code remains functionally unmodified and was just moved to PlatformEmbeddedFileWriterGeneric. This will be split up in future CLs. Bug: v8:9103 Change-Id: Ie7e29bb60ba5a8ff6c0c1edec676943b80a1781b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622854 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61745}
-
Ross McIlroy authored
Change-Id: I68e716ee664ae2295089ee4d6af6a0ea6dbf1c1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624789 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#61744}
-
Mythri A authored
KeyedStoreIC computes the expected transition to the map based on the incoming receiver map, the index and the value that is being stored. Since we already store the element into the object, the runtime would have already computed these transitions and it is possible to use the new map of the object instead of recomputing the map. Though we would need additional checks to see the newly transitioned map is indeed a more generic elements transition and not an unexpected transition. Bug: v8:8394 Change-Id: If6819895e5d20dd76bb062c6064593bf3a920778 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621937 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61743}
-
Simon Zünd authored
This CL also removes the AdaptorWithExitFrame builtin and simplifies respective use-sites. Bug: v8:9183 Change-Id: I97c4e35aa551f586faedcb09cc0b2b837e5307f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624215Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61742}
-
Mythri A authored
FindElementsKindTransitionedMap checks if we could transition from the source map to one of the target maps without requiring any instance rewriting. It does this by replaying all the property transitions of the source map on each elements kind map and seeing if it needs a instance rewrite. Since we already know the elements kind of the target maps, we can avoid doing this for element kinds that are not in target map. Change-Id: Ief9ba89992a411535a0335c3b67221666647f55e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624208Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61741}
-
Igor Sheludko authored
This reverts commit 2d710200. Reason for revert: It's not ready for shipping in M76. > Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64" > > This is a reland of d61a9347 > > 6th attempt. Relanding after fixing TSan/UBSan issues. > > Original change's description: > > [ptr-compr][x64] Temporarily enable pointer compression on x64 > > > > ... and make sure that the x64 ptr-compr bots proceed testing V8 without > > pointer compression in order to keep testing the full pointer mode. > > > > Bug: v8:7703 > > Change-Id: Ib1498609603cb03be2464043658131d5a2f1e012 > > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > > Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559850 > > Commit-Queue: Igor Sheludko <ishell@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#61416} > > Bug: v8:7703 > Change-Id: I1fa0989aef9ea08e54fd6dfd32d6989367332ce3 > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > Cq-Include-Trybots: luci.v8.try:v8_linux64_cfi_rel_ng > Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1607654 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61559} Tbr: machenbach@chromium.org Bug: v8:7703 Change-Id: Ic73b57203bbcb637e33b3577ce8142d43c364796 Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_cfi_rel_ng Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621942 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61740}
-
Jakob Gruber authored
The mksnapshot-specific runtime flag --target-arch, together with --target-os, specifies the target platform for the generated embedded.S file. Bug: v8:9103 Change-Id: Icb03a381101e7ab0db4a5fbbf3be8e23ed0b1a1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624165 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61739}
-
Santiago Aboy Solanes authored
Decompressions before TypedStateValues can be safely skipped since TypedStateValues always decompresses values. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ic3d43c21183c0decda123cb377706ee5c3c12f87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617939 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61738}
-
Clemens Hammacher authored
Since {Handle<T>::location()} just returns the value of {HandleBase::location()}, we can just publicly expose the latter and save some compile time and object file size. R=jkummerow@chromium.org Bug: v8:9183 Change-Id: I9cddba2c9f8b097c26cf1a4e7dbfbe72b03d79c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624211 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61737}
-
Santiago Aboy Solanes authored
Adding the case of having a decompress and a constant (both HeapConstant and Int64Constant). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ic9475e9762575e7f6ca2937d832638f7c9897e1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613253 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61736}
-
Michael Lippautz authored
Provide a global memory controller used to compute limits for combined on-heap and embedder memory. The global controller uses the same mechanism (gc speed, mutator speed) and growing factors as the regular on-heap controller. Rely on V8's mechanisms for configured state that stops shrinking the limit. Reland: - API fixes with overrides and default versions. - Fix of depending on uninitialized values when using the old API. - GCTracer: Fixed issue in speed computation. - GCTracer: Added unittests. This reverts commit 5e043f27. Bug: chromium:948807 Change-Id: I0f81253b3e1a8b49a7ac107c012a15e33cb514d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622852Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61735}
-
Clemens Hammacher authored
Add an {ObjectRef} class to Handle which is returned by {operator->}. Before, it returned {T} directly, and then used {T::operator->} for the chained {operator->}. As a drive-by, this CL also removes {HandleBase::operator*} and implements this in {Handle<T>} directly. R=jkummerow@chromium.org Bug: v8:9183, v8:3770 Change-Id: I0a79fbbc393539543a62773c98a39c7bc2a84b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624206Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61734}
-
Mike Stanton authored
Also, when --trace-heap-broker-verbose is on, we trace bytecode-by-bytecode alterations to the environment. Change-Id: I535a063cefd57f055711fdd7d7473cb63c963c7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622851Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61733}
-
Mike Stanton authored
This CL adjusts the tracing to print addresses of interesting SharedFunctionInfos instead of dereferencing the handles to look at the name. Bug: v8:7790 Change-Id: I25d6f96728bd78d8a8becac6f2212f4f7a030c5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622969Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61732}
-
Yang Guo authored
R=mstarzinger@chromium.org Bug: v8:9247 Change-Id: I6819489dd8ed6d5a6f8e2631a5901c7d4b460960 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621943 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61731}
-
Tobias Tebbi authored
Bug: chromium:965513 Change-Id: I18ff91c98ad6106c5d4df260e6ead6a9e2425dbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622119 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61730}
-
Mythri A authored
KeyedAccessStoreMode is used when creating store handlers to determine which cases to handle (ex: handle cow, grow) and hence choose an approriate builtin. It is also used to specify elements kind transitions which is used when computing ic transitions. The store mode and the transition mode are independent of each other and it would be cleaner to use different enums to represent them. This also reduces the total number of cases in each enum. Change-Id: I96aeff7a765b312b8088e831776743c67c533bd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619751Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61729}
-
Michael Achenbach authored
NOTRY=true Bug: v8:9276 Change-Id: Ifd0ec8d86d880ce29101260833528e1aa230de01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624205Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61728}
-
Sigurd Schneider authored
..without relying on macros directly inside the class. Change-Id: If06934e3b54cdd65b393c23ec6bf62af2fd39dfa Bug: v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615256 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61727}
-
Santiago Aboy Solanes authored
This is a border case that appeared in one of our tests. It seems a good idea to test for it. It does not seem to be common enough to handle it specifically (i.e replacing the Word64Equal with a true bool constant) Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I27e85a2493ab03b92591e788a185d6109904eef1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613252Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61726}
-
Yang Guo authored
Bug: v8:9247 Change-Id: I79e0553e8a0d6dac2aa16b94a6c0e05b6ccde4a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621934 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61725}
-
Michael Achenbach authored
NOTRY=true Bug: v8:9277 Change-Id: If385439e2bdd8146fe3ba5734920b2096b6c1789 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622853Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61724}
-
Simon Zünd authored
The HandleApiCall uses BUILTIN_EXIT frames now instead of EXIT frames, so API calls show up in stack traces. We no longer need API builtins and this CL removes them and the corresponding C++ macros. Bug: v8:9183 Change-Id: Ifa2e842123ef7e96b2ff296116f46d5d799a63ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617249 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61723}
-
Sigurd Schneider authored
This is mainly a torque change, but as a drive-by we get rid of kStartOfPointerFieldsOffset kEndOfTaggedFieldsOffset which often are used to enclose a section of pointers in an object. Bug: v8:7793 Change-Id: I52d83d09249a3cc6a99e7e7506e154ccfca53a12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615249 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61722}
-
Michael Achenbach authored
TBR=mythria@chromium.org NOTRY=true Bug: v8:9246 Change-Id: I18d6c22da5746d3af34c65ea22fd5ef80e4f13fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622850Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61721}
-
Andrey Lushnikov authored
New revision: fe0467fd105a9ea90fbb091dc2a7b4cdbf539803 Change-Id: I0c53935b719194f16ade131f703d656749ace3d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1623586Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Auto-Submit: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#61720}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/12e7bf6..0742a14 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5655d8f..535dc1d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5716400..c7e440c Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9d4cde4..f71fb4f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5b1310e..2db48c7 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Icfaca034cd7956805b8ba7815c97bc4ba219ca3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1623633Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61719}
-
Andreas Haas authored
At the moment the implementation of LoadElemSegmentImpl is not ready to support the loading of passive element segments into tables with index > 0. I added a check so that we notice when somebody starts to implement it. R=binji@chromium.org Bug: v8:9270 Change-Id: I118da434cc379bbdb7bcef4af847216f5124551f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622105Reviewed-by: Ben Smith <binji@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61718}
-
Andrew Comminos authored
Now that we support a max_samples parameter, it isn't actually necessary to have a record_samples flag (as it can just be modeled by 0). Change-Id: I578ecc9f6ee73ecbe1f93d0d04ee8028a9a2716d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611015 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61717}
-
Clemens Hammacher authored
This reverts commit dac86be2. Reason for revert: Still failing msan: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/26904 Original change's description: > Reland "[heap] Add global memory controller" > > Provide a global memory controller used to compute limits for combined > on-heap and embedder memory. The global controller uses the same > mechanism (gc speed, mutator speed) and growing factors as the regular > on-heap controller. > > Rely on V8's mechanisms for configured state that stops shrinking the > limit. > > This reverts commit 5e043f27. > > Tbr: ulan@chromium.org > Bug: chromium:948807 > Change-Id: Id4f94e7dcb458d1d0d2f872194f8f3ea0959a73f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622968 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61715} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: If30649f158a08fd185f2771a13b8e09cf53fb667 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:948807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622849Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61716}
-
- 21 May, 2019 3 commits
-
-
Michael Lippautz authored
Provide a global memory controller used to compute limits for combined on-heap and embedder memory. The global controller uses the same mechanism (gc speed, mutator speed) and growing factors as the regular on-heap controller. Rely on V8's mechanisms for configured state that stops shrinking the limit. This reverts commit 5e043f27. Tbr: ulan@chromium.org Bug: chromium:948807 Change-Id: Id4f94e7dcb458d1d0d2f872194f8f3ea0959a73f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622968Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61715}
-
Fabrice de Gans-Riberi authored
This is a reland of 748de1e5 Original change's description: > [fuchsia] Replace zx_clock_get() with zx_clock_get_new(). > > zx_clock_get() signature is being replaced to report errors. > As part of a soft transition, zx_clock_get_new() is introduced with > the final function signature. > > Bug: chromium:963956 > Change-Id: Ia6d0f4fc560bd9149683011099b064540b54edd6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1616545 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61591} Bug: chromium:963956 Change-Id: I555df23d448fa246e4edec36b349a3c0aaad66ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617805 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#61714}
-
Michael Lippautz authored
This reverts commit cfe281f3. Reason for revert: Fails on gcc bots Original change's description: > [heap] Add global memory controller > > Provide a global memory controller used to compute limits for combined > on-heap and embedder memory. The global controller uses the same > mechanism (gc speed, mutator speed) and growing factors as the regular > on-heap controller. > > Rely on V8's mechanisms for configured state that stops shrinking the > limit. > > Bug: chromium:948807 > Change-Id: I3283a2c28e6ab889f8d2ad85c9b67b8f234b9900 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619762 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61712} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,bikineev@chromium.org Change-Id: I503d5a1436eb9156556b5bca852d2b2f9da2446f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:948807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622967Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61713}
-