- 21 Sep, 2022 6 commits
-
-
Lu Yahan authored
Port commit 3f998527 Change-Id: Ic82f9d08fbc6c6df524e0361141c9a5d22e8924e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905856 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#83352}
-
Jakob Linke authored
.. and just the option for now, there's no logic behind this yet. --maglev-function-context-specialization enables FCS globally, and the MaglevCompilationInfo stores for each compilation job whether FCS is enabled. Bug: v8:7700 Change-Id: I4c32fe93fca70ae3644588902e282910a9673b74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905382Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#83351}
-
jameslahm authored
... in Runtime_GrowArrayElements. Runtime_GrowArrayElements is only used when the elements kind is fast. And we could check the requested capacity according to the elements kind and throw error early. Bug: v8:13285 Change-Id: I68f59bc68995d622aac23be3e8daf05ac5fd5652 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905062 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#83350}
-
Stephen Roettger authored
The last use was removed in this CLs: https://chromium-review.googlesource.com/c/v8/v8/+/3401585/ Bug: v8:12552, v8:13312 Change-Id: I72c639957ed3b1c2491eb43a54a54b8a96977b6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905188Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Stephen Röttger <sroettger@google.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#83349}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/29d7990..962a856 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9e95466..dea2dd1 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/d128f2b..cec1dd0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fcf15b9..0a4b3b9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/18bdadc..0d126c9 Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220919.1.1..version:9.20220919.2.1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/70967a5..0cb9db1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I34ee778225cc1a732e8bbfb69bbcab5fd08164bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905132 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#83348}
-
Hao Xu authored
Only apply this optimization to the conditions that have multiple branch uses. Bug: v8:12484 Change-Id: Ieb74b8e879e62aa96344f2903f1fea6a1b769549 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3902559Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#83347}
-
- 20 Sep, 2022 34 commits
-
-
Junliang Yan authored
Change-Id: I23b2130798d28c479dfe6394ce6baf9503e74a1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904432 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Paolo Severini authored
Fixing an issue in WasmInstanceObject::GetGlobalBufferAndIndex. Bug: v8:13309 Change-Id: I52e65c109e43ce0300513604e71e587e1949f70a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3907666Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Samuel Groß <saelo@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/main@{#83345}
-
Frank Tang authored
1. Correct the return type of RoundTowardsZero to fix issue with double value > 2^64 2. In TemporalDurationToString: a. Use std::fmod instead of % to get the remainder b. Use extra xx_add variables to hold additional value which may overflow the double during computation. c. Use BigInt for days if the value is too large for double to ensure the precision. 3. Add tests with Number.MAX_SAFE_INTEGER and Number.MAX_VALUE in values for Duration toJSON in mjsunit Bug: v8:11544 Change-Id: Icac4f669ed1c591e947b51c82dd48bdef7a6db6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3900813Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#83344}
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/9215420..465cf4a Bug: v8:7834, v8:13302 Change-Id: Ieb9d6215984b0f7eab201514e5b855f7efcdda65 Fixed: v8:13302 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3906921Reviewed-by:
-
Milad Fa authored
Port 3f998527 R=sroettger@google.com, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I4a92ab1ba942f9303c4f083d9f0b846e924c25f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3907868 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#83342}
-
Leszek Swirski authored
This reverts commit 67106ff4. Reason for revert: Test failure bisected locally to this (failure link: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/40535/overview). Not clear why but reverting to keep the tree green. Original change's description: > [wasm-gc] JS interop: Do not wrap structs/arrays by default > > Bug: v8:7748 > Change-Id: I441fd294bc0f31c0396217bc55c27159abacdbd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905725 > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> > Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83338} Bug: v8:7748 Change-Id: Ifb5e980dedf8e9824d05171c431ad383af180e50 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904416 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#83341}
-
Stephen Roettger authored
Bug: v8:13281 Change-Id: Ie61eb42ad6be565c8be76c9b4aa63282c7856f25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905190Reviewed-by:
-
Manos Koukoutos authored
As part of moving export wrappers to the isolate, it was tried to compile them lazily on the main thread. This resulted in large slowdowns in some cases, therefore we restore the eager parallel compilation. Bug: chromium:1365726 Change-Id: I9cc8d5728f3a5c71099f0e0fdcc605b37d4d6618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905193Reviewed-by:
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: I441fd294bc0f31c0396217bc55c27159abacdbd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905725Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#83338}
-
Matthias Liedtke authored
On x64.release for linux this didn't affect binary size at all but should improve readability of usages. Bug: v8:7748 Change-Id: I46ecc9c2b4814244f6b5114f9ea199cd4d0220cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904602Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: Icde19a554042ce57420a1faa72492c53a07dbc66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905723 Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 0cb75429. Reason for revert: Suspect for waterfall closure - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Maa%20-%20arm64%20-%20no%20pointer%20compression%20debug%20builder/1072/overview Original change's description: > Remove some unused includes > > Bug: v8:13006 > Change-Id: Iee530e965786583330ff5e00ccfe58358a813f76 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3879500 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83332} Bug: v8:13006 Change-Id: I9d9d88a84786cb683042ab2ed665d61656d6de3b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904415 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#83335}
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: Ie68be87805fe85c954209cd3257a0915deec84be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905191Reviewed-by:
-
Milad Fa authored
Change-Id: I154b7d70eb9cbcb2f71db7c88a18b81b3814415d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904424Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:13006 Change-Id: Iee530e965786583330ff5e00ccfe58358a813f76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3879500Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#83332}
-
Andrey Kosyakov authored
Change-Id: Ia8d92151114c674b581ec2fa2b4e3297e9c7cf6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905927 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#83331}
-
Leszek Swirski authored
DCHECK that input registers that are clobbered (e.g. because they are also an output register) are not used as register inputs into eager deopts. This is already the case because we're only allowed to mutate input registers that alias the result register, and eager deopt input allocation happens after result register allocation, but this DCHECK makes this assumption explicit and will break if we ever change the regalloc. Bug: v8:7700 Change-Id: I4e00a8be88e0984044d8fc5b661eaf7bea801b17 Fixed: v8:13278 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905189 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#83330}
-
Matthias Liedtke authored
This change allows to put Wasm structs / arrays into prototype chains. While this isn't particularly useful (as any access lookup on the wasm object will throw a TypeError), there isn't any reason not to allow it. Bug: v8:7748 Change-Id: I81cf709d2e8403b545bbba9ad9c538c1e9748c74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3901979Reviewed-by:
-
Stephen Roettger authored
Change-Id: Ic1950646f880e5b752d2018fa2ad2715e3ad3292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904233 Commit-Queue: Stephen Röttger <sroettger@google.com> Reviewed-by:
-
Marja Hölttä authored
Maglev support is not implemented yet. Also make Maglev conflict with --no-maglev. Bug: v8:13091,v8:13253 Change-Id: Iac5f06a5697405348f681b29ec43044abf50d90a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3907725 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: chromium:1342305, chromium:1354926, chromium:1359709 Change-Id: I5ddedea227669908710b83f808cfb7c4718f0699 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904608Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#83326}
-
Leszek Swirski authored
Use the node aspect mechanism to find and cache tagged equivalents of non-tagged nodes during merging. Bug: v8:7700 Change-Id: If1e6210b34e23a3559bf6251dafa985e827f0d08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904234 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
If a shift right is performed with a negative value <= -32, it may not be reduced to a 32 bit shift. The reduction optimization was introduced by commit 2298b35f. Fixed: v8:13290 Change-Id: Ifb16ed85560ab54d211ebb407690abe2c156e3a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905143 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Array.prototype.group and Array.prototype.groupToMap have an optional thisArg, which is currently not passed. Bug: v8:13301, v8:12499 Change-Id: Ib927638401d39ed0cbcc0595ab41fde328ef43cc Fixed: v8:13301 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905934 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Samuel Groß authored
This is a reland of commit d7fcbba8 The LSan support logic of the ExternalPointerTable has been optimized to avoid timeouts on sanitizer bots Original change's description: > [sandbox] Increase ExternalPointerTable maximum capacity to 512MB > > Bug: v8:10391 > Change-Id: I383e11bdccf6fcaf13f29d25e1404545067d313e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3891249 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83203} Bug: v8:10391 Change-Id: If50156d6fecff7ca8ece5c350e7b08936f50daa6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905141 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: I1d4d951b67546e0403854b96b04b681ce101deaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3902053 Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This CL fixes isolate deserialization such that the first test for concurrent allocation in the shared spaces already succeeds. * Allows dereferences for the shared heap and not just for the shared isolate. * Updates shared_heap_object_cache() for --shared-space. * Sets IN_SHARED_HEAP flag on all shared space pages. Bug: v8:13267 Change-Id: I912630da34f93e15d2ddef77a45a5e875bdceff0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3902523 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#83320}
-
Simon Zünd authored
This CL adds a test that checks the block list for outer functions is also correctly calculated when pausing in inner functions. R=kimanh@chromium.org Bug: chromium:1363561 Change-Id: I2d7c1671475759b977e4e41c7e09856b3b2e7daf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904308Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#83319}
-
Simon Zünd authored
This CL introduces a new root that is conceptually a WeakMap<ScopeInfo, Tuple2<ScopeInfo, StringSet>> Instead of storing the "locals block list" for debug-evaluate on the `ScopeInfo` object directly, we will store it instead in a global WeakMap. This enables us to re-use the "locals block lists" across multiple debug-evaluate invocations without having to modify the `ScopeInfo` of `SharedFunctionInfo`s. R=bmeurer@chromium.org Doc: https://bit.ly/chrome-devtools-debug-evaluate-design Bug: chromium:1363561 Change-Id: Ib52f9abd97cf1c8fa3053ff3c61a6062c4b814be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3902041Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#83318}
-
Leszek Swirski authored
Since we have the NodeInfo map in known_node_aspects now anyway, use it for representation changes instead of the current interpreter frame value swapping mechanism. We originally didn't want a map for representations, but if we have one anyway for node types, it makes sense to merge the two mechanisms. This also allows us to get rid of the "register same as accumulator" hack for binops, which was trying to avoid redundant representation changes, since the redundancy is removed by the node aspects mechanism automatically. It's kept for CheckedInternalizedString, since that isn't a representation change within our framework (maybe it should be?). Bug: v8:7700 Change-Id: I92491307f83d3b63fc7a210f6b8754e45d3531a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905182Reviewed-by:
-
Michael Lippautz authored
This is a reland of commit defa678e Original change's description: > cppgc: Be more conservative in Seeper::FinishIfOutOfWork > > Finalizing sweeping can be beneficial to truly end a GC cylce. We > should only finalize in `FinishIfOutOfWork()` though if that would not > introduce any jank. Limit the amount of executing finalizers in that > scenario. > > Bug: v8:13294 > Change-Id: I0237f6b6017d444c457923d83e85147c58586445 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3902222 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/main@{#83279} Bug: v8:13294 Change-Id: I426a54785d1a0f569c2200156dcf41a5d5c7876f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3902583 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#83316}
-
Simon Zünd authored
We currently use 1 test case per file for tests that check that debug-evaluate correctly blocks the lookup of stack-allocated variables. This CL adapts a similar approach to `debug-scopes.js`, making it easier to add new test cases in the future. R=kimanh@chromium.org Bug: chromium:1363561 Change-Id: I8ff8cfe7d59f0b9808dc02c5579e058f490553eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3904544 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Slots in free memory need to be removed. After a GC the JS application can create additional free memory by either left- or right-trimming of heap objects. The sweeper might discover memory that was freed because of such operations. In case the sweeper discovers free memory, there can't be any recorded slots in it. Otherwise subsequent allocations might store untagged values in those slots and the next deref would most likely crash. Remove OLD_TO_SHARED slots in freed memory when left-trimming, right- trimming and for DeleteObjectPropertyFast. Also full GC was right-trimming objects which now needs to remove slots in OLD_TO_SHARED. Bug: v8:11708 Change-Id: I5761336e103704929fbd455d74bdbb499ae23f61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3905144Reviewed-by:
-
jameslahm authored
Allow non-registered symbols as keys in weakmap and weakset. Allow non-registered symbols as target and unregisterToken in WeakRef and FinalizationRegistry. Bug: v8:12947 Change-Id: Ieb63bda66e3cc378879ac651e23300b71caed627 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865056Reviewed-by:
-
