- 05 Feb, 2022 1 commit
-
-
Shu-yu Guo authored
Currently the Isolate is gotten off of the object that the operation is being performed on. Shared objects return the shared Isolate, which is incorrect as it shouldn't be used to run JS, nor does it have HandleScopes open. Plumb the executing Isolate through. Bug: v8:12547 Change-Id: I4d2c9f5d4d7bc50b3aeb515eb78c08eb1b2a6824 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440902Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78960}
-
- 04 Feb, 2022 26 commits
-
-
Junliang Yan authored
Change-Id: I4646bb0f3f6291c97bb4b397d6248b9bdaa2059a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439641Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78959}
-
Alex Turner authored
This method returns the unique debugger ID for a v8::Context (i.e. the V8DebuggerID), serialized to a pair of int64_ts. Bug: v8:12528 Change-Id: Ib2cdda73447f8233f9afb773fed4a634d4618aef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3369124Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/main@{#78958}
-
Michael Achenbach authored
Using UTF-8 encoding couldn't properly read: test/webkit/parser-high-byte-character.js Fix itertools rename and one usage of map that's now an iterator. Bug: chromium:1292016 Cq-Include-Trybots: luci.v8.try.triggered:v8_linux64_python3_rel_ng_triggered Change-Id: I2b2ab72ce0eb355d1e70f247b5ea38d1d71c7845 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439914Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#78957}
-
Junliang Yan authored
Change-Id: Id233437d92a9af0d7726bcd6207133802ee3d129 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439640Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78956}
-
Junliang Yan authored
Change-Id: I5d9fc560a398328674907962a3730036b72172a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439638Reviewed-by:
-
Milad Fa authored
Change-Id: I709253796b8493cf365f21247c367974ffbb3106 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440435Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78954}
-
Michael Lippautz authored
The size is queried from the background thread to check whether incremental marking should be started. Bug: chromium:1292728 Change-Id: I60e0def5756b62ef2ae2d10cc76ce745f3aef308 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440654 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78953}
-
Seth Brenith authored
The web app owner who notified me about bugs v8:12112 and v8:12126 asked me a reasonable question: "how am I ever supposed to trust the retaining paths in the devtools, if the heap snapshot is generated by a different component than the actual marking code?". This change is my attempt to answer that question. If verification is enabled, the heap snapshot generator will visit each heap object with a realistic marking visitor to find all references from that object. It will then check that those references match the HeapGraphEdges in the snapshot. I also considered the idea that we could collect retaining information during the last GC cycle before taking the heap snapshot, or during an extra GC cycle immediately after. However, running the full GC provides the embedder with the opportunity to run arbitrary code (including JS) both before and after PerformGarbageCollection, so there is no clear guarantee that the heap state during the snapshot actually matches the heap state during marking. Bug: v8:12112, v8:12126 Change-Id: Id29e75ecf9eee19e35daedbdb4a3e1df64785380 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3299590Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#78952}
-
Leszek Swirski authored
Return/Throw/Rethrow all unconditionally exit the bytecode, so the bytecode liveness analysis shouldn't merge their next bytecode's liveness into them. Change-Id: I62f53d16f2763e12a702b8b40b2573c264488968 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439915 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78951}
-
Michael Lippautz authored
Replacement is v8::TracedReference in combination with v8::Global if a callback is really needed. Bug: v8:12603 Change-Id: Iae48fee2e6588a594d430c5f3a71ff0b3e67e5b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439873Reviewed-by:
-
Hannes Payer authored
This is the 3. CL in a series of CollectGarbage refactoring CLs. Bug: v8:12503 Change-Id: Icc578eb9a4dc06083ea3380a00a50dbdbfd22e34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3420908Reviewed-by:
-
Leszek Swirski authored
Distinguish between tagged and machine pointer sizes in grokdump, and dump a tagged memory view in addition to the machine-word dump when they don't match. This tagged view tries to decompress pointers for link targets, by masking the slot they're in to get the cage root. Drive-by: Add a .style.yapf to opt in to python formatting using git cl format. Change-Id: Ic5272cd865f995fc670ab2fb7d5e464f317af1bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439906Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#78948}
-
Michael Lippautz authored
TracedNode is used as backing node for v8::TracedGlobal (with destructor) and v8::TracedReference (no destructor). A future change adds concurrent marking for TracedReference which requires that the node stays around until the atomic pause to avoid synchronization with the concurrent marker. This change prepares TracedNode in prolonging the lifetime until the it is actively cleared ("sweeped") in the atomic pause. This allows for spuriously keeping alive a TracedNode for an additional GC cycle in the case the the node was destroyed while the marker is running. We maintain eager clearing of nodes where possible, i.e., outside of incremental marking. Bug: v8:12600 Change-Id: I9688c83a42b70d352c84613485f37242b1b910a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3436805Reviewed-by: -
Anton Bikineev authored
Bug: chromium:1029379 Change-Id: I3970de943c58aa834bd12afd2d289c2034c65c1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439913 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Milad Fa authored
Change-Id: I2ca9afc488ebe9dcab0fd1d1f1bc4016f9a06c92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440434Reviewed-by:
-
Clemens Backes authored
TimeTicks::HighResolutionNow is identical to TimeTicks::Now since 2018 (https://crrev.com/c/997153), but the declaration still has a wrong comment about a non-existing DCHECK. In order to avoid confusion, remove the redundant method and just use TimeTicks::Now everywhere. Drive-by: Make IsHighResolutionTimer "inline" instead of "V8_INLINE" because it will only be called once anyway. R=mlippautz@chromium.org Bug: v8:12425 Change-Id: I31dc65f8c1ac910862e070e60e928054d4921154 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439909Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Anton Bikineev authored
This is needed to support minor gc tests on the Blink side. Bug: chromium:1029379 Change-Id: Ic7ce1ae8e626b87738d76663ceecf7198e425d18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437050Reviewed-by:
-
Clemens Backes authored
Use the standard TimedHistogramScope instead. R=ahaas@chromium.org Bug: v8:12281 Change-Id: Ib404f8e60999bc5c1871d4dce25f8ba7cc3cadfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437048Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78942}
-
Clemens Backes authored
When updating the dispatch tables, the other instances are often generated from the same wire bytes, or there is only the one original instance in that list of instances. In both cases we can avoid the costly hash table lookup, and just use the signature index from the originating module. For big modules, this saves more than 50% of time for updating the dispatch tables, and ~25% of overall instantiation time. R=manoskouk@chromium.org Bug: v8:12593 Change-Id: I356d5dd10f6c0738330e9a8d1cb27f60ff21215a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3432212Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78941}
-
Anton Bikineev authored
Bug: chromium:1029379 Change-Id: Id496cae4bb59fa247b362d17f3eaf0ecc98e9ae4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437051 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This is a reland of 517ed4ad Original change's description: > Reland "[Torque] Generalize Torque literals to larger size" > > Previously, literals in Torque were stored as double values, which > made it impossible to precisely represent 64 bit integer values. > This CL replaces the old literal expression with an integer and > floating point literal expression that are unbounded in size. We > allow implicit conversion of these literals to arbitary integer > and floating point types respectively and insert a corresponding > bounds check into generated CSA. > > Changes in the reland: Simplified IntegerLiteral to single digit. > > Bug: v8:7793, chromium:1289282 > Change-Id: I31c762c2f31165c7a1d0b07842b764e5851ce189 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406750 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78811} Bug: v8:7793, chromium:1289282 Change-Id: I7aadc4d2c9494f03eae85e94949c8f4cab7a075c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437047Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/79dc3ff..87e6066 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0faae1c..df01c5a R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I0922c8dd2768df0f2b4eca3442f435dbf8d41196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439627 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78938}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I757e67cbcad98b6cacb3ad08b6a364194feead1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3427201Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78937}
-
Michael Achenbach authored
This fixes all Python3 problems in scripts and tests running via v8_presubmit.py. It includes: - Test runner - Release tools - Perf runner - Torque formatter - V8's main presubmit On bots, v8_presubmit is run with vpython, hence we also add the required dependencies. After the Python3 migration, most of the transitional code in this CL can be removed again. Bug: chromium:1293709,chromium:1292016 Change-Id: Ic25e5965948b212c047e9d5194d2a4b6db1fa91b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3432213Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/609143a..2e0f298 Revert "Move back to a single android icu dat file" (Michael Cui) https://chromium.googlesource.com/chromium/deps/icu/+/2e0f298 Suppress C++20 warnings (Mark Schott) https://chromium.googlesource.com/chromium/deps/icu/+/cd7e36d Move back to a single android icu dat file (Mohamed Heikal) https://chromium.googlesource.com/chromium/deps/icu/+/44f2bbf R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I45c34640ec98629a0185141789e969ad4e62b15e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439165 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78935}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5ba6fa4..3a9b7ad Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/f78b4b9..8ccda4f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1e084a5..79dc3ff Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fa5989b..0faae1c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/853a56c..f246ca2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4df24450e536837079fe8cacc12c9208f66c5c23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3438468 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78934}
-
- 03 Feb, 2022 13 commits
-
-
Frank Tang authored
Bug: v8:11544 Change-Id: I59e5a448385b2e67927c18c9609f24f4d66f3756 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380305Reviewed-by:
-
Milad Fa authored
Change-Id: I37ebc9b8470ba0df8c62af7ccc02edf4eb38b6bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437414Reviewed-by:
-
Junliang Yan authored
Change-Id: I9ccd6181437017aea627373b9f323efa6b4a183d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437825Reviewed-by:
-
Junliang Yan authored
Change-Id: I04813fbb55b60d60a829dbb8970637a7cd32c813 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437407Reviewed-by:
-
Clemens Backes authored
Instead of always loading the instance from the frame, try to use the cached instance register instead. This is totally not performance critical since we do a C call afterwards anyway, but it's just as easy to use the cached instance than loading it fresh from the stack. R=thibaudm@chromium.org Change-Id: Ia815e9e6f8ab2efc665b2e3aefcdc7b4aa95739f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3427461Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78929}
-
Junliang Yan authored
Change-Id: I0f42cf86182782b5357d905bfdef1874f6efb909 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437406Reviewed-by:
-
Junliang Yan authored
Change-Id: I0ca1d28774c58bce52f8553a08351d7191ff0f40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3436806Reviewed-by:
-
Camillo Bruni authored
Change-Id: I913e36afd76fe0f212e8c0c9b97e5ac52b2342d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3437045Reviewed-by:
-
Manos Koukoutos authored
The stack guard may update a shared memory's size. Therefore, we need to update the size in the instance cache in Turbofan when StackCheck is invoked for loops. Change-Id: I1b000adad991a6b799ad37ba36c9a33c67559d3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3423780Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
On all platform, the method is implemented identical to {LoadInstanceFromFrame}. So remove {FillInstanceInto} and keep {LoadInstanceFromFrame} which is a better name. R=thibaudm@chromium.org Bug: v8:12425 Change-Id: Ia9e6a3e2478628f8d31ff4faaab8d5250fda7796 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3429203Reviewed-by: -
Leszek Swirski authored
This reverts commit 9ae463bc. Reason for revert: ODROID failure https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Arm%20GC%20Stress/22085/overview Original change's description: > [heap-stats] Fix heap-stats with ptr-cage > > - Heap-stats was trying to load the map without explicitly passing in > the PtrComprBase causing failures with Code objects in external code > space > - Extend the debugPrint.js tests to run with some more debugging and > testing flags to prevent future regressions > > Change-Id: I1f0d03cb31480f316fe533b507ff98fe3befbe8e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3432386 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Auto-Submit: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78919} Change-Id: I4a5e9d8a4ce2f608b7a42dcf5d7e799daf9cc1c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3436285 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78923}
-
Thibaud Michaud authored
This is a reland of f942f656 Changes: Change the order of initialization for wasm continuations to ensure object integrity if a GC happens during allocation. Also add missing handles. Original change's description: > Reland "[wasm] Resume suspender on resolved promise" > > This is a reland of a865d16b > > Changes: > - Make the next ID atomic > - Leave more space for runtime calls in debug mode > > Original change's description: > > [wasm] Resume suspender on resolved promise > > > > Implement the WasmResume builtin, which resumes a wasm suspender > > when the corresponding JS promise resolves. > > > > Drive-by 1: Fix detection of empty stacks in the stack frame iterator. > > Drive-by 2: Add a stack ID for better tracing. > > > > R=ahaas@chromium.org > > CC=fgm@chromium.org > > > > Bug: v8:12191 > > Change-Id: Ifa3f00c4259f802292b04d426c739e9b551f87b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3420827 > > Reviewed-by: Andreas Haas <ahaas@chromium.org> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#78842} > > Bug: v8:12191 > Change-Id: I3c231690b27be79a0c00e13043342bb4a3628886 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3427203 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78890} Bug: v8:12191 Change-Id: I0e1362d3a9da1fd8c0d600ad9776ce2fd26c6a52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3434145Reviewed-by:
-
Clemens Backes authored
Since the equality operator uses the whole encoded bitfield, also the hash value should use that. Otherwise get get unnecessary hash collisions, resulting in bad hash table performance (e.g. in the signature map). R=manoskouk@chromium.org Bug: v8:12593 Change-Id: I6f9b8ed1789ee937c90ece15d78b2bf5a3c357a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3435189Reviewed-by:
-
