1. 20 Apr, 2020 1 commit
  2. 12 Jan, 2018 1 commit
  3. 19 Jun, 2017 1 commit
  4. 14 Feb, 2017 1 commit
    • vabr's avatar
      Fix TypeError message for Reflect.construct · b478e9c1
      vabr authored
      If the Reflect.construct receives an argument expected to be a constructor,
      and the argument is not a constructor, V8 currently declares that
      Reflect.construct is not a function. It should instead say that the offending
      argument is not a constructor.
      
      This is the case for all ports of builtins
      (Builtins::Generate_ReflectConstruct). All of them make an
      attempt to at least pass the right argument to the TypeError parametrised
      message, calling out the offending Reflect.construct argument. However,
      Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
      discarding the precise information.
      
      This CL adds Runtime::kNotConstructor, which reports the arguments passed
      to it, and the CL also modifies the ports of builtins to make use of
      Runtime::kNotConstructor
      
      BUG=v8:5671
      
      Review-Url: https://codereview.chromium.org/2688393003
      Cr-Commit-Position: refs/heads/master@{#43182}
      b478e9c1
  5. 18 Jul, 2016 1 commit
    • jochen's avatar
      Reland^2 "Don't compile functions in a context the caller doesn't have access to" · 02ba2441
      jochen authored
      Original issue's description:
      > Don't compile functions in a context the caller doesn't have access to
      >
      > Instead just return undefined
      >
      > A side effect of this is that it's no longer possible to compile
      > functions in a detached context.
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org,bmeurer@chromium.org
      
      BUG=chromium:541703
      R=verwaest@chromium.org
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
      
      Review-Url: https://codereview.chromium.org/2155503004
      Cr-Commit-Position: refs/heads/master@{#37842}
      02ba2441
  6. 14 Jul, 2016 3 commits
    • jochen's avatar
      Revert of Reland "Don't compile functions in a context the caller doesn't have... · 63449d21
      jochen authored
      Revert of Reland "Don't compile functions in a context the caller doesn't have access to" (patchset #4 id:60001 of https://codereview.chromium.org/2143893005/ )
      
      Reason for revert:
      blink is unhappy about the microtask change
      
      Original issue's description:
      > Reland "Don't compile functions in a context the caller doesn't have access to"
      >
      > Original issue's description:
      > > Don't compile functions in a context the caller doesn't have access to
      > >
      > > Instead just return undefined
      > >
      > > A side effect of this is that it's no longer possible to compile
      > > functions in a detached context.
      > >
      > > BUG=chromium:541703
      > > R=verwaest@chromium.org,bmeurer@chromium.org
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org
      >
      > Committed: https://crrev.com/6bceabac5b705b2ce1f52d34650cea1ae3b8c617
      > Cr-Commit-Position: refs/heads/master@{#37756}
      
      TBR=verwaest@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=chromium:541703
      
      Review-Url: https://codereview.chromium.org/2151843002
      Cr-Commit-Position: refs/heads/master@{#37760}
      63449d21
    • jochen's avatar
      Reland "Don't compile functions in a context the caller doesn't have access to" · 6bceabac
      jochen authored
      Original issue's description:
      > Don't compile functions in a context the caller doesn't have access to
      >
      > Instead just return undefined
      >
      > A side effect of this is that it's no longer possible to compile
      > functions in a detached context.
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org,bmeurer@chromium.org
      
      BUG=chromium:541703
      R=verwaest@chromium.org
      
      Review-Url: https://codereview.chromium.org/2143893005
      Cr-Commit-Position: refs/heads/master@{#37756}
      6bceabac
    • adamk's avatar
      Revert of Don't compile functions in a context the caller doesn't have access... · 68f205b2
      adamk authored
      Revert of Don't compile functions in a context the caller doesn't have access to (patchset #9 id:160001 of https://codereview.chromium.org/2034083002/ )
      
      Reason for revert:
      Causes crashes on Canary
      
      Original issue's description:
      > Don't compile functions in a context the caller doesn't have access to
      >
      > Instead just return undefined
      >
      > A side effect of this is that it's no longer possible to compile
      > functions in a detached context.
      >
      > BUG=chromium:541703
      > R=verwaest@chromium.org,bmeurer@chromium.org
      > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng
      >
      > Committed: https://crrev.com/992e34c21635b179a993b82ac1d81753e7a6a57a
      > Cr-Commit-Position: refs/heads/master@{#37657}
      
      TBR=bmeurer@chromium.org,verwaest@chromium.org,jochen@chromium.org
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=chromium:541703, chromium:628053
      
      Review-Url: https://codereview.chromium.org/2148163002
      Cr-Commit-Position: refs/heads/master@{#37736}
      68f205b2
  7. 11 Jul, 2016 1 commit
  8. 21 Mar, 2016 1 commit
  9. 18 Jan, 2016 1 commit
  10. 10 Dec, 2015 2 commits
    • ishell's avatar
      Fix Function subclassing. · dddcd0ac
      ishell authored
      Function subclasses did not have function properties installed (name, prototype, etc.).
      Now when an instance of a Function subclass is created it gets initial map that corresponds
      to the language mode of the function body. The language mode dependent maps are cached as
      special transitions on initial map of the subclass constructor.
      
      BUG=v8:4597, v8:3101, v8:3330
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1510753005
      
      Cr-Commit-Position: refs/heads/master@{#32764}
      dddcd0ac
    • verwaest's avatar
      Fix Promise intrinsicDefaultProto · 2d13f6ec
      verwaest authored
      BUG=v8:3900, v8:3931, v8:1543, v8:3330
      LOG=n
      
      Review URL: https://codereview.chromium.org/1511893002
      
      Cr-Commit-Position: refs/heads/master@{#32731}
      2d13f6ec
  11. 09 Dec, 2015 1 commit
  12. 07 Dec, 2015 1 commit
  13. 27 Nov, 2015 1 commit
  14. 19 Mar, 2015 1 commit