- 09 Nov, 2021 4 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/329fb06..431abd1 Fix warning with MacOS (#1276) (Bensuperpc) https://chromium.googlesource.com/external/github.com/google/benchmark/+/431abd1 Fixed typo in doc: s/marcro/macro (#1274) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/4b99670 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Ia2b2029241092d1821264f18cc514d14231bb114 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269626Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77783}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I5b908f056222c57e796fb76e86ceea9a77cde77f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3265066Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77782}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I7de616f87dcec7ebaa51af10390c2685650633d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266004Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77781}
-
Ng Zhi An authored
Relaxed f32x4 and f64x2 min and max. These instructions only guarantee results when the inputs are non nans, and when the inputs are not 0s of opposite signs. Drive-by rename of instruction codes to be Minps/Maxps/Minpd/Maxpd since they map down exactly to a single instruction. ia32 port of c3f346b7. Bug: v8:12284 Change-Id: If64da551524ea8c304e1fa8f9cf4acbd54abfe5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251708Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77780}
-
- 08 Nov, 2021 30 commits
-
-
Ng Zhi An authored
4 instructions, i8x16, i16x8, i32x4, i64x2 relaxed lane select. These instructions only guarantee results when the entire lane is set or unset, so vpblendvb will give correct results for all of them. Same instruction selector code as x64. Bug: v8:12284 Change-Id: Icd0bc8c5125cd2780141117830d6cb6e6babbb74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251701Reviewed-by:
-
Junliang Yan authored
Change-Id: Ib13761e9336e67cc2fc218c3a6e9193330fdfd45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268937Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77778}
-
Ng Zhi An authored
vmovups requires AVX, even though we have FMA3 scope, that only enables FMA3 and not AVX. We can't enable AVX when FMA3 is supported (inside of Assembler::Assembler) because we will hit some DCHECKS in SSE instructions that check that AVX is not enabled. Reported in https://chromium-review.googlesource.com/c/v8/v8/+/3131370/5#message-8a19a8c68a205f1efa208917df89a2082bae2276 Bug: v8:11659 Change-Id: Iece17c6550d4a6cbfca0c7f9c0ca042b52600d8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3252249Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I801821448459bf2b74c99b36f6882d59bb24a273 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264645Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I68aeaf1f30a03295ef76bb07037e809ed91f6977 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266009Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77775}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: Ia999105ffd616c07d4e062e0ddf3a35419d645e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264644Reviewed-by:
-
Camillo Bruni authored
Bug: v8:12195 Change-Id: I815594cf7636c1830a6f025159fe0950fe925744 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268196 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77773}
-
Michael Lippautz authored
Explicit write barriers for internal fields are deprecated as they are automatically emitted by V8. Depends on: https://crrev.com/c/3263924 Bug: v8:12356 Change-Id: I171ba5b42a6570ce52e2e2ea1b7c1029d5a8a3a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263888Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77772}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: Ic84020ea7e54c50dc8f773eb655078582bb33fa7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264361Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77771}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: If92311b47a6019cb9f7b96a7dcd313a658d426ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3265067Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77770}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I4bc0378a7d4ad3033485f98e446daa7ff2e83e0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264646Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77769}
-
Michael Lippautz authored
Change-Id: I0b352c8a34f222c904b8cc72db1e315fc7ca48df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268297Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77768}
-
Leszek Swirski authored
This reverts commit ef62cd06. Reason for revert: Fails mjsunit/wasm/grow-memory (https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8831118281610576833/+/u/Check/grow-memory) Original change's description: > [heap] Remove executable_memory_ from release code > > The map is only used to check invariants. > > Bug: v8:12054 > Change-Id: I7d067cca801c9b6104efb22a26cf27f1f62920c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268286 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77766} Bug: v8:12054 Change-Id: I95af58404719855664a128047ed32e8022dd5dd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268300 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77767}
-
Victor Gomes authored
The map is only used to check invariants. Bug: v8:12054 Change-Id: I7d067cca801c9b6104efb22a26cf27f1f62920c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268286Reviewed-by:
-
Victor Gomes authored
This is an unecessary boolean, that makes reason about the code more complicated. Bug: v8:12054 Change-Id: I5bdf2069ead427f53ce774e825fe9656e668480e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268284 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I452cc4b2a25ce2d00825bf8eea7ac4073310583b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260149Reviewed-by:
-
Thibaud Michaud authored
And make the GC visit spilled references in the frame. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: Ida430f12a6de7658972e7890542fb02f7f7ddbb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226784 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77763}
-
Igor Sheludko authored
This CL * adds forwarding accessors to CodeDataContainer for certain widely used Code object's fields and predicates, * adds JSFunction::set_code() overloads accepting CodeT values, * migrates SharedFunctionInfo getters to CodeT, * migrates InterpreterData::interpreter_trampoline to CodeT. Drive-by-fix: replace #if V8_EXTERNAL_CODE_SPACE with #ifdef to be consistent. Bug: v8:11880 Change-Id: I1e114076a0568068038ca6f70a86431a3a9cfb9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3262716 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Change-Id: Ibc3b7d73ce92f3d0f848e94b1266c99a78279392 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259661 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: I53166b226c29a9244b047431e0830de109975306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3262128Reviewed-by:
-
Jakob Gruber authored
V8 flags in general should not change in a process after the first Isolate has been initialized. --jitless and related flags especially sensitive to this, so we introduce a dedicated check just for them. Bug: chromium:1262676, v8:9019, v8:12366 Change-Id: I239726889d236a3785c1fdc076fa21d1b8983c92 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260508 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... which could contain a smi value during CodeDataContainer setup. Bug: v8:11880 Change-Id: Ibc67818411e9b824843bc5a20d249335c88d5f57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264291 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Maya Lekova authored
This CL fixes a null dereference when an attempt is made to access the current arm64 simulator from a background thread. Bug: chromium:1267491 Change-Id: I9232fe134fccbff162eb5076aff20884872e4cc7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264219 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77757}
-
Jakob Gruber authored
`Equals` did not properly account for arrays with odd lengths. Bug: v8:11069 Change-Id: I3264ebef248adcecd59b902bf1521cfddbd5a69d Fixed: chromium:1267674 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264218 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77756}
-
Jakob Gruber authored
This CL adds an Allocator to SmallVector to control how dynamic storage is managed. The default value uses the plain old C++ std::allocator<T>, i.e. acts like malloc/free. For use with zone memory, one can pass a ZoneAllocator as follows: // Allocates in zone memory. base::SmallVector<int, kInitialSize, ZoneAllocator<int>> xs(ZoneAllocator<int>(zone)); Note: this is a follow-up to crrev.com/c/3240823. Drive-by: hide the internal `reset` function. It doesn't free the dynamic backing store; that's a surprise and should not be exposed to external use. Change-Id: I1f92f184924541e2269493fb52c30f2fdec032be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257711 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: -
Manos Koukoutos authored
Since the indirect function table at index 0 in an instance is now represented like the other tables, the IndirectFunctionTableEntry abstraction is no more useful. We replace it with direct access to the tables and a simpler abstraction {FunctionTargetAndRef}. Bug: v8:11510 Change-Id: Iab4a6ca7eda8eb1757dbd321cb3997e98e78267e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247030 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: -
Victor Gomes authored
Introduced by: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 No-Try: true Bug: chromium:1052746 Change-Id: I1dd0028fd05999ec7b4128bb9250f7fa663dfe41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264292 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77753}
-
Manos Koukoutos authored
Design doc: https://bit.ly/3jEVgzz We represent the indirect function table of a WasmInstanceObject at index 0 like the rest of the tables, i.e., as the 0th element of the instance's indirect_function_tables() field. For performance, we maintain direct links from the instance to the contents of table 0 (indirect_function_table_{size, sig_ids, refs, targets} in WasmInstanceObject). Bug: v8:11510 Change-Id: Ice49fd855109051d304ef9033cac7a495b68ab8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3246970 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
The isolate root pointer in a WasmApiFuncionRef cannot be sandboxed, because we would need the isolate root in the first place to decode it. Therefore we do not use Foreign as the parent class of WasmApiFunctionRef. Bug: v8:11510 Change-Id: Idcbe654274c543ee571a335cb8e212ca3492d973 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3262134 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Lu Yahan authored
fix node.js DCHECK failed issue: https://github.com/riscv-collab/v8/issues/514 Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77750}
-
- 06 Nov, 2021 4 commits
-
-
Michael Lippautz authored
Internal fields are used for implementing edges to C++ objects in Oilpan. When setting the fields on a JS API object, we should also emit a write barrier for this edge. This mechanism replaces the explicit write barrier in V8's API which is provided through `JSHeapConsistency::*`. The internal barrier should also be slightly faster as it doesn't require any API calls. Bug: v8:12356 Change-Id: I639d18141acfb910d0ded8d987d8a0916e25431d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257709 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Joyee Cheung authored
Bug: v8:10793 Change-Id: If9e4884ae1817121d9661eedc1e8806ab7f68214 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256998 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9088cd6..f7f53e9 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/9901571..51ffc5e Rolling v8/third_party/aemu-linux-x64: Ce6sqxwYi8DOFfwlCOP0MURltjjH-QIsgAsJ1p7--KIC..JOROMO2u_x7WbmPlWROhQxdCaIY-Q639bZpu8IWRc30C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/429f4e0..e5067b0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1c179b5..6500963 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/7dab69f..a736941 Rolling v8/tools/luci-go: git_revision:68355732afb00a422ae0c70eed95c6a45f9868b1..git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781 Rolling v8/tools/luci-go: git_revision:68355732afb00a422ae0c70eed95c6a45f9868b1..qLMs01I9Ry2iQnzjXEE-TVzz-tLGynUTnCfDp0JgjnAC Rolling v8/tools/luci-go: git_revision:68355732afb00a422ae0c70eed95c6a45f9868b1..git_revision:d17c642c8c3c6d9e37bd9c25535c4c5b66b99781 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4d277c7cb14ecc226a116d4013840c86f1dec456 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264753Reviewed-by:
-
Yolanda Chen authored
Bug: v8:12228 Change-Id: I49b2e1a1c837b96ea2e7cb58f42314109845b7fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263766Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Yolanda Chen <yolanda.chen@intel.com> Cr-Commit-Position: refs/heads/main@{#77746}
-
- 05 Nov, 2021 2 commits
-
-
Milad Fa authored
Currently we are calculating the offset manually. This method uses code patching to re-emit the instruction with correct offset when the value is available. Change-Id: Ie68580398df92ed2ab57c3972f408cfde8e60432 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264746 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77745}
-
Maya Lekova authored
This CL adds support for handling calls to C functions with arbitrary signatures on the arm64 simulator. It adds infrastructure for encoding the signature data from CallDescriptor and FunctionInfo classes into a compact representation, stored in the simulator and called EncodedCSignature. Design doc: https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit This CL is a follow up on the native support added in https://chromium-review.googlesource.com/c/v8/v8/+/3182232 and is partially based on the previous attempt: https://chromium-review.googlesource.com/c/v8/v8/+/2343072 Bug: chromium:1052746 Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
