- 15 Oct, 2018 38 commits
-
-
Hai Dang authored
Array.prototype.map is currently not preserving PACKEDness. Use a for-loop instead. Bug: v8:7980 Change-Id: I08aff1cbcd84b9de260a5a1e2c68b9cfb5c3d888 Reviewed-on: https://chromium-review.googlesource.com/c/1280329 Commit-Queue: Hai Dang <dhai@google.com> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56657}
-
Toon Verwaest authored
Change-Id: Ic8beb18bf37343405e8f4443a9f0991bd365e8df Reviewed-on: https://chromium-review.googlesource.com/c/1280227Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56656}
-
Michael Lippautz authored
Also fully deprecate AbortTracing. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I852d28d8ce0f02b3a048b1061de29c9fce71ce62 Reviewed-on: https://chromium-review.googlesource.com/c/1278811 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56655}
-
Michael Starzinger authored
This switches the encoding of the exceptions (in the exceptions as well as the import section) to use a signature index instead of a flat type vector encoding. Note that only signatures that have a void return type can be used for declaring exceptions. R=clemensh@chromium.org BUG=v8:8153 Change-Id: I481ccbce9ddf29becdf4ed7ceffe80d6145446e1 Reviewed-on: https://chromium-review.googlesource.com/c/1280323 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56654}
-
Ross McIlroy authored
Adds a build-time flag to control enabling of V8 Lite mode. Currently this mode enables optimize-for-size and makes that flag read-only so that it can't be changed at runtime. This mode also replaces the --minimal flag which was previously used to make porting easier. BUG=v8:8293 Change-Id: I8360b4d55dd15a2a7c18429c94329dc5264dea86 Reviewed-on: https://chromium-review.googlesource.com/c/1276467 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#56653}
-
Ulan Degenbaev authored
The race happens when the sweeper is looking up the size of an object that had its map replaced concurrently. The fix is to load the object map using an acquire load so that the sweeper observes the initializing stores of the new map. Bug: v8:8303 Change-Id: Ifaaef06cb815be7d07b6a574085ee61a466bc1d6 Reviewed-on: https://chromium-review.googlesource.com/c/1280310Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56652}
-
Toon Verwaest authored
Change-Id: I8ab8e4f312d315a2f9d7b54ac894af87596fc51f Reviewed-on: https://chromium-review.googlesource.com/c/1280303 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
🎉 Mathias Bynens authoredProposal repository: https://github.com/tc39/proposal-global Intent to ship: https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ Bug: v8:7782 Change-Id: Iaf790f134917796deac0e84cc931828934a6e589 Reviewed-on: https://chromium-review.googlesource.com/c/1260122 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56650}
-
Tobias Tebbi authored
While this is mostly a mechanical change to enable re-visiting macros for inlining, it has a few user-facing effects: - Labels and (variables, parameters, local constants) are handled separately, so they do not shadow each other. - A local variable or constant is not bound in its initializer. This allows code like: const x = 5; { const x = x + 1; } Bug: v8:7793 Change-Id: I968e1f93d92689737362c803342a797d312e95cd Reviewed-on: https://chromium-review.googlesource.com/c/1276628 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#56649}
-
Toon Verwaest authored
Use token ranges for parsing identifiers and literals. Change-Id: Ic6af2c4012033d7f7c69181f90aa6b1b9c2b2a60 Reviewed-on: https://chromium-review.googlesource.com/c/1280224Reviewed-by:
-
Hai Dang authored
Bug: v8:7980 Change-Id: I6e7f1c064830c0055f8708472b62221ab5ca3288 Reviewed-on: https://chromium-review.googlesource.com/c/1280325Reviewed-by:
-
Hai Dang authored
This removes the check for holeyness when using CopyFixedArrayElements, because the function does not use that information. Change-Id: I6033495bf00947ded083ebc24695f6c8bf4569d0 Reviewed-on: https://chromium-review.googlesource.com/c/1280763 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
-
Adam Klein authored
Change-Id: I982f3615136c7a4ba18e4a6d2cc06a3e24e22f54 Reviewed-on: https://chromium-review.googlesource.com/c/1277722Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#56645}
-
Clemens Hammacher authored
For serialization we are using the code table to find the code of all functions. We want to serialize compiled code though, not interpreter entries (we currently fail a DCHECK there). This CL changes the logic to not update the code table with interpreter entries but instead keeps a separate bit set of interpreted functions. R=mstarzinger@chromium.org Bug: v8:8177, chromium:735509 Change-Id: I69c59f92712135ddef667b54114614fad94cc6fc Reviewed-on: https://chromium-review.googlesource.com/c/1278794Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56644}
-
Sigurd Schneider authored
This reverts commit fefd9230. Reason for revert: breaks no-i18n https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noi18n%20-%20debug/23279 Original change's description: > [ia32,root] Disable root indirections in irregexp code > > Irregexp code spills and restores ebx at boundaries, and clobbers it > inbetween. Root-relative loads are disabled in this region. > > Bug: v8:6666 > Change-Id: I9c68bc8ef88d324da609996a8457ac9e30a9b6fc > Reviewed-on: https://chromium-review.googlesource.com/c/1280762 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56639} TBR=sigurds@chromium.org,jgruber@chromium.org Change-Id: I1a349874c28218442ebed4f127d23d69dff094cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1280225Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56643}
-
Maya Lekova authored
Split the runtime function for initializing a promise into AwaitPromisesInit and AwaitPromisesInitOld, the former not firing the INIT hook and being used by the AwaitOptimized builtin. In addition to this the AsyncHooks now caches all the previously inited promises and checks that the init hook is not fired twice for the same promise. Modified test expectations for the new async ids in the async hooks tests. Bug: v8:8300 Change-Id: If4a17e501b2a233578fa70b6442f219473f001d9 Reviewed-on: https://chromium-review.googlesource.com/c/1280442 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56642}
-
Igor Sheludko authored
This reverts commit 6ec90ece. Reason for revert: causes a lot of Canary crashes (chromium:895208). GC relies on an the fact that the transition array stays alive while it's owner map is alive (this is needed in order to properly transfer descriptor array ownership to the parent map when the map owning a shared descriptor array dies). We need to rethink a way of caching the migration target shortcut. Original change's description: > Reland "Create a fast path to get migration target when updating map" > > This is a reland of c285380c > > Original change's description: > > Create a fast path to get migration target when updating map > > > > During map updating, store the pointer to new map in the > > raw_transitions slot of the old map that is deprecated from map > > transition tree. Thus, we can get the migration target directly > > instead of TryReplayPropertyTransitions when updating map. > > > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM > > Chromebook and ~9% on big-core Ubuntu. > > > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db > > Reviewed-on: https://chromium-review.googlesource.com/1233433 > > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#56303} > > Change-Id: Idf0b7716b92a6a15bfe58721c2c34dbd02b31137 > Reviewed-on: https://chromium-review.googlesource.com/c/1270261 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Cr-Commit-Position: refs/heads/master@{#56588} TBR=ishell@chromium.org,shiyu.zhang@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie7e9b98395b041a1095da549d1cd71d7180a4888 Bug: chromium:895208 Reviewed-on: https://chromium-review.googlesource.com/c/1280223 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Predrag Rudic authored
Port commit 23dbb81d. Original CL message: >This CL uses pc-relative jumps and calls (B/BL) for calls from embedded >builtins to embedded builtins. To make this work, the code range size is >limited to 32MB on arm during mksnapshot, which ensures that all builtin >to builtin offsets for jumps/calls fit into the B/BL immediate. At code >generation time, we put a placeholder into the instruction offset which >we resolve to the right code object when the code is copied to the heap. >We use a new relocation mode RELATIVE_CODE_TARGET for these relative jumps. >The relocation mode RELATIVE_CODE_TARGET should never appear after >generating the snapshot. > >We modify the target_address/set_target_address methods of RelocInfo >such that they return the absolute target addresses for pc-relative B/BL >instructions. This ensures that the GC can treat RELATIVE_CODE_TARGET in >the same way as code targets. This, however, only matters during >snapshot creation time, and production code never contains >RELATIVE_CODE_TARGET relocations. > >Bug: v8:6666 >Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng >Change-Id: If7eab83ad588859ca87c654a5ddc3e37caea884c >Reviewed-on: https://chromium-review.googlesource.com/1117181 >Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> >Reviewed-by: Ulan Degenbaev <ulan@chromium.org> >Reviewed-by: Jakob Gruber <jgruber@chromium.org> >Commit-Queue: Sigurd Schneider <sigurds@chromium.org> >Cr-Commit-Position: refs/heads/master@{#54320} This CL is completed Miran's draft without MIPS64 port. (https://chromium-review.googlesource.com/c/v8/v8/+/1136640/3). Change-Id: I979378ac445548641755968d890f7f4a82dc7986 Reviewed-on: https://chromium-review.googlesource.com/c/1221313 Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
-
Jakob Gruber authored
Irregexp code spills and restores ebx at boundaries, and clobbers it inbetween. Root-relative loads are disabled in this region. Bug: v8:6666 Change-Id: I9c68bc8ef88d324da609996a8457ac9e30a9b6fc Reviewed-on: https://chromium-review.googlesource.com/c/1280762Reviewed-by:
-
Michael Lippautz authored
Callers of the ConcurrentMarking API should check the flags, which they were already mostly doing. Change-Id: Ie273bb740fe6d2b36dfb924ce813670ebd47bf3f Reviewed-on: https://chromium-review.googlesource.com/c/1280307Reviewed-by:
-
Ross McIlroy authored
Some jobs might need to be aborted, e.g., if a function is a default parameter in an arrow function it will be re-scoped and won't have a SFI to register. Adds support to abort jobs without having to block if the job is currently running on the background thread. BUG=v8:8041 Change-Id: I9149740401cbaaa31c21be9d79d4e3f5c450bfcf Reviewed-on: https://chromium-review.googlesource.com/c/1278497 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#56637}
-
Sigurd Schneider authored
Change-Id: I5804585565acfabc110b019c5fcecdcabbaf022e Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1276428 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is the first CL in a series that removes the StaticVariable operand. Change-Id: I2acdbf4a7481af43321b8af10dbe38f8f481bea8 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1276365 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ic2c9f22517153dc5bf41f3d6c78fa06dd7cc4f84 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1280306 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Toon Verwaest authored
- use a token-range to quickly identify LHS continuation - queue binding pattern errors only once - outline LHS continuation to reduce memory overhead from aggressive inlining (30kb) Change-Id: Ic0f3cfc3ea0bd6cedb6cea991a69f55f2bada14a Reviewed-on: https://chromium-review.googlesource.com/c/1280207 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
{IsAligned} is defined twice with exactly the same signature and implementation: once in base/macros.h, once in utils.h. This CL removes the definition from utils.h. Note that utils.h includes macros.h, so no further changes are needed. R=mlippautz@chromium.org Bug: v8:8238 Change-Id: I589b00c01619d054ff39c717f728a2351b6c32ea Reviewed-on: https://chromium-review.googlesource.com/c/1280206 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
Since {Address} is just {uintptr_t}, we can just use the standard {IsAligned} function. R=mlippautz@chromium.org Bug: v8:8238 Change-Id: I260591e88b50855cf327096a07b2c18f0c1e4508 Reviewed-on: https://chromium-review.googlesource.com/c/1280204Reviewed-by: -
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:891314 Change-Id: Iaab09ac543b0928f6a81275f529df73949693c83 Reviewed-on: https://chromium-review.googlesource.com/c/1276425Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56630}
-
Andreas Haas authored
In the existing implementation, the structured cloning flag is only set at the startup of the renderer process. In other words, if structured cloning or wasm threads are turned on when the renderer process starts up, then structured cloning is enabled. However, with the origin trial for wasm threads it's possible that wasm threads get turned on only later when the webpages loads. With this CL we now always also check the wasm threads flag in addition to checking the structured cloning flag. R=mstarzinger@chromium.org Bug: v8:8304 Change-Id: I49da6bd76a4cc38abc01fbe0c9707c6b17a8de3f Reviewed-on: https://chromium-review.googlesource.com/c/1280444Reviewed-by:
-
Toon Verwaest authored
Change-Id: I448110b10bb4dafdfb05983db92e06383c2913a3 Reviewed-on: https://chromium-review.googlesource.com/c/1280203Reviewed-by:
-
Jakob Gruber authored
With this CL we finally actually set the root register to the correct value. Verification is still preserved by keeping a magic number in IsolateData. Bug: v8:6666 Change-Id: I89cb7cb36f977ac677ec33a814a2798baab4cec4 Reviewed-on: https://chromium-review.googlesource.com/c/1278277Reviewed-by:
-
Georg Neis authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I37c67adc857ce7dec1a06f580d981a35c474df1c Reviewed-on: https://chromium-review.googlesource.com/c/1280322Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56626}
-
Clemens Hammacher authored
There were a lot of tweaks and optimizations to chromium's {base::Optional} implementation. This CL brings us back in sync with that. Some changes were needed to make this compatible with C++11 and with GCC 4.8: 1) Types like std::decay_t and std::enable_if_t were rewritten to use std::decay and std::enable_if. 2) Some conditional no_except declarations were removed. 3) std::is_trivially_copy_constructible and std::is_trivially_move_constructible are assumed to be false on gcc 4 because it's unimplemented there. R=neis@chromium.org Bug: v8:8238 Change-Id: Ia0542c0d4d2fd43a2454f639ec5201ad8d8201cd Reviewed-on: https://chromium-review.googlesource.com/c/1275824 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Georg Neis authored
With the flag enabled, that phase runs in the background as part of OptimizeGraph. Bug: v8:7790 Change-Id: I313578c113be1fb76dfc315522906178bee1027d Reviewed-on: https://chromium-review.googlesource.com/c/1268156Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Georg Neis authored
There's no ambiguity and the shorter name makes things easier to read. Bug: v8:7790 Change-Id: Ibcf3fd7f38a91e26a83cd335fad0ec80a5fe9be1 Reviewed-on: https://chromium-review.googlesource.com/c/1278392 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Properly handle the case where the CheckFloat64Hole becomes a no-op after RETYPE (because the feedback type is already Number). We always need to pass the Number restriction type here. Bug: chromium:895199 Change-Id: I96a949ba35db1e6d35abedddc4507c101d95b716 Reviewed-on: https://chromium-review.googlesource.com/c/1278804Reviewed-by:
-
Jaroslav Sevcik authored
This fixes the typing for the case when the call is not lowered to the simplified operator. Bug: chromium:880207 Change-Id: Icecf12de77ece0fe9ffec2777874f5f0004a1e97 Reviewed-on: https://chromium-review.googlesource.com/c/1278642 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e270920..9578c43 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I67c5cb1f4f781605098e106289061d4f4e449236 Reviewed-on: https://chromium-review.googlesource.com/c/1279935 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56620}
-
- 14 Oct, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e4c7352..e270920 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/94faf32..dd78844 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7a2eedb4f0271ce281c9722c384add7195e0e38a Reviewed-on: https://chromium-review.googlesource.com/c/1279925 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 13 Oct, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dbb4fad..e4c7352 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c8b97e3..5aac72d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/066e110..94faf32 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I73f0237a1799d01c5dec0df65763300626b19de6 Reviewed-on: https://chromium-review.googlesource.com/c/1279922Reviewed-by:
-
