- 29 Dec, 2017 6 commits
-
-
Sigurd Schneider authored
Change-Id: I56dfa2a0ee6d953002ba9a86f25c142bc2262106 Reviewed-on: https://chromium-review.googlesource.com/846740 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#50321}
-
Mike Stanton authored
Bug: v8:1956 Change-Id: Iee1c6245832b786993ebd71b615cf4257c6bd0bb Reviewed-on: https://chromium-review.googlesource.com/758769 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#50320}
-
Franziska Hinkelmann authored
Cleanup, delete unused struct. Bug: Change-Id: I4ea5e81d6d0711d7cf3fdd279f8b0d136bcd6db3 Reviewed-on: https://chromium-review.googlesource.com/846760 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50319}
-
Sigurd Schneider authored
Update notion of compatibility used in redundancy elimination to determine whether one check subsumes another check to ignore the feedback on the operator. Bug: v8:7127 Change-Id: I77ab8a64adcd2b36ee7eafbe6cc148ddbc430b11 Reviewed-on: https://chromium-review.googlesource.com/839441 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50318}
-
Mike Stanton authored
Bug: v8:1956 Change-Id: Iae150730eb230dd7c90c66941d4d6aa8f0f0a423 Reviewed-on: https://chromium-review.googlesource.com/845685Reviewed-by: Daniel Clifford <danno@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50317}
-
Sigurd Schneider authored
This also fixes benchmark scores for String.prototype.indexOf Bug: v8:7127, v8:7092 Change-Id: Iee0f9689feb5923b300e253c267a6f32ffd4da20 Reviewed-on: https://chromium-review.googlesource.com/846739Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#50316}
-
- 28 Dec, 2017 3 commits
-
-
Eugene Ostroukhov authored
Add an easy way to preview ArrayBuffer as a typed array. This change will always allow previewing ArrayBuffer instances as Uint8Array and Int8Array. ArrayBuffer instances that have even length will allow Int16Array preview and ArrayBuffers that have length divisible by 4 will allow Int32Array previews. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I07440147cc9e83c8a987f9316bd8d1b936db2717 Reviewed-on: https://chromium-review.googlesource.com/842472 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50315}
-
Alexey Kozyatinskiy authored
If user redefines some getter on node then it is too easy to detect our nice tools. Let's make it a little harder. R=dgozman@chromium.org Bug: chromium:795547 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibfee850949124d056a443d869ea67a71abd71d24 Reviewed-on: https://chromium-review.googlesource.com/845299Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#50314}
-
Ilija Pavlovic authored
In tests r6_ldpc and r6_lwupc are accidentally removed instructions which should be actually tested - LDPC and LWUPC. (See 822be9b2 "Normalize casing of hexadecimal digits".) This CL fixes this error in tests. TEST=cctest/test-assembler-mips64/r6_ldpc, cctest/test-assembler-mips64/r6_lwupc BUG= Change-Id: I34b8da2c6b97c0d85bde4f1cd3b3c704a9d05208 Reviewed-on: https://chromium-review.googlesource.com/845623Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#50313}
-
- 27 Dec, 2017 5 commits
-
-
Caitlin Potter authored
Add an early exit if the control op is Dead to prevent failing the DCHECK. BUG=chromium:797596, v8:5940, v8:3018 R=bmeurer@chromium.org, jarin@chromium.org Change-Id: I6090380ea69c3205740b6c7a41d7c066d18d6a9f Reviewed-on: https://chromium-review.googlesource.com/844978 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50312}
-
Karl Schimpf authored
This CL adds the i32.trunc_s:sat/f32 WASM opcode to the turbofan compiler and interpreter (more saturating operators will be added in later CLs). The operatation has been added under an experimental flag. Bug: v8:7226 Change-Id: Ia69e981ffddb2da682e53ba25f489fc9d0cd2db5 Reviewed-on: https://chromium-review.googlesource.com/834670 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50311}
-
Michael Achenbach authored
This tests some high-level scenarios of the V8 test runner, with fake executable, test-suite extension and build configs. The runners are slightly modified to be easier testable. Args are passed from the tests now and the V8 root folder can be faked by the tests. We support coverage if python coverage 4.0 is installed. Otherwise we run without it. Bug: v8:6917 Change-Id: Ib149fd88027cbdc3382bcaea2d82020582f79d2d Reviewed-on: https://chromium-review.googlesource.com/831506 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50310}
-
Ilija Pavlovic authored
Use t9 for the call to C functions instead of t8, since t9 must be used according to MIPS ABI. This saves us one unneccessary move. TEST= BUG= Change-Id: Ic4caf104e043789f0e05930488a48b07c0e134c2 Reviewed-on: https://chromium-review.googlesource.com/844554Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#50309}
-
Michael Achenbach authored
TBR=petermarshall@chromium.org NOTRY=true Bug: v8:7247 Change-Id: Ib59170290ee49bff88595b10bcdda0045325ce36 Reviewed-on: https://chromium-review.googlesource.com/844082Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50308}
-
- 26 Dec, 2017 2 commits
-
-
Yang Guo authored
TBR=ulan@chromium.org R=jgruber@chromium.org Bug: v8:7240 Change-Id: I4273105b496da16a5e00f53a6df3112efddedc91 Reviewed-on: https://chromium-review.googlesource.com/842882 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#50307}
-
Ivica Bogosavljevic authored
Fix 29bb707e Compilation on GYP fails due to missing OnCriticalMemoryPressure overload that accepts size_t parameter. In this case the compiler complains about hiding virtual function. This patch reintroduces the missing functions. Bug: Change-Id: I493891f6908987a6f27c669a16f6c3772339333d Reviewed-on: https://chromium-review.googlesource.com/844077Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#50306}
-
- 22 Dec, 2017 18 commits
-
-
Bill Budge authored
- Moves all allocation retry logic into allocation. Bug: chromium:756050 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I810d01f0a0a002b08bf3f82ea4195d636ab6e03a Reviewed-on: https://chromium-review.googlesource.com/843230Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#50305}
-
Brad Nelson authored
Web platform tests that allocate 600 memories fail due to this. (This seems to also interfere with tests on the same shard). This reverts commit b9abc7f0. Reason for revert: <INSERT REASONING HERE> Original change's description: > [wasm] Enable guards on 64-bit systems. > > R=eholk@chromium.org > > Bug: > Change-Id: Ia099cf085510da50a87b9f999020d6a66d6eab20 > Reviewed-on: https://chromium-review.googlesource.com/838250 > Commit-Queue: Brad Nelson <bradnelson@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Eric Holk <eholk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50300} TBR=bradnelson@chromium.org,eholk@chromium.org,clemensh@chromium.org Change-Id: Ie7fc2a2142bddb03df41a5b705087a2e1f03e163 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/842925Reviewed-by: Brad Nelson <bradnelson@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#50304}
-
Bill Budge authored
- Adds overload to v8::Platform that will make it easier for embedders to maintain a reserve of address space for large, contiguous allocations. - Rewrites retry logic using loops. - Moves retry logic from some VirtualMemory allocation functions to AllocPages. Bug: chromium:756050 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I52e66f9f8b15b6ce2a2f36e74783f178b8cd5cf7 Reviewed-on: https://chromium-review.googlesource.com/840724 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50303}
-
Yang Guo authored
We collect instance type statistics in FatalProcessOutOfMemory into an array, which is allocated to the max instance type value. While we want to leave space to ensure new instance types do not affect constants in the API, we can be more frugal. We currently serialize 350 maps into the startup/context snapshot. Even if we assign a distinct instance type to each of these maps, we would still have more than enough to spare with this change. R=ulan@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3e583c2c8da3342e9132d96046b5d80cd41afd72 Reviewed-on: https://chromium-review.googlesource.com/842542 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50302}
-
Georg Neis authored
- Instantiation errors are no longer recorded. If instantiation fails, the module(s) are reset to "uninstantiated". When instantiation is re-attempted, the thrown exception will be fresh. - Instantiation can succeed even where there are modules in the graph that previously failed evaluation. Bug: v8:1569 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I429f616918afe5f8ab1a956024f0a22f464b8c44 Reviewed-on: https://chromium-review.googlesource.com/763369 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50301}
-
Brad Nelson authored
R=eholk@chromium.org Bug: Change-Id: Ia099cf085510da50a87b9f999020d6a66d6eab20 Reviewed-on: https://chromium-review.googlesource.com/838250 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50300}
-
Andreas Haas authored
This is the implementation of crrev.com/c/766371 for mips64. Original description: Add the ability to return (multiple) return values on the stack: - Extend stack frames with a new buffer region for return slots. This region is located at the end of a caller's frame such that its slots can be indexed as caller frame slots in a callee (located beyond its parameters) and assigned return values. - Adjust stack frame constructon and deconstruction accordingly. - Extend linkage computation to support register plus stack returns. - Reserve return slots in caller frame when respective calls occur. - Introduce and generate architecture instructions ('peek') for reading back results from return slots in the caller. - Aggressive tests. - Some minor clean-up. R=v8-mips-ports@googlegroups.com Change-Id: Ia924f94367320b9062e33d35b58ccd38c8fc3ca3 Reviewed-on: https://chromium-review.googlesource.com/842483Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50299}
-
Daniel Clifford authored
May be causing breakage in browser tests preventing V8 roll TBR=bmeurer@chromium.org Change-Id: Ib1689c38ff250fc9454d2ea991c4808ddc5189de Reviewed-on: https://chromium-review.googlesource.com/842868Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50298}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0cc3a215862430a028e43e0749862729bda8973f Reviewed-on: https://chromium-review.googlesource.com/842869Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50297}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:797083 Change-Id: I6376f1bd652dd20fb44f551e029ce8b71eba7545 Reviewed-on: https://chromium-review.googlesource.com/842866 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50296}
-
Andreas Haas authored
TBR=bradnelson@chromium.org Change-Id: I133a1fd4135ac50182163c3632ba02fd806aa27a Reviewed-on: https://chromium-review.googlesource.com/843024Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50295}
-
Andreas Haas authored
Instead of these two instructions I generalize the kX64Peek instruction. R=bmeurer@chromium.org Change-Id: Ie5f8c7d428b65df3ca8b75594f6a06a75cc8e978 Reviewed-on: https://chromium-review.googlesource.com/839863 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50294}
-
Daniel Ehrenberg authored
This patch implements https://github.com/tc39/proposal-class-fields/pull/65 and https://github.com/tc39/proposal-static-class-features/ by splitting out instance and static field declarations into separate flags for the separate proposals. Instance class fields is currently at Stage 3 whereas static class fields is currently at Stage 2. Bug: v8:5367 Change-Id: I133c945fd0b22dc5718c7bb61b10f22348087acd Reviewed-on: https://chromium-review.googlesource.com/839778 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#50293}
-
Andreas Haas authored
Instead of these two instructions I generalize the kIA32Peek instruction. R=bmeurer@chromium.org Change-Id: I4bc48ac95dffd6e33de47a6aee9a13a1d64f78e0 Reviewed-on: https://chromium-review.googlesource.com/839766Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50292}
-
Andreas Haas authored
On 32-bit platforms, float64 stack returns take 2 stack slots. In the implemention of the kArmPeek instruction we assume that provided slot index points to the first stack slot. However, due to an off-by-1 issue the provided slot index pointed to the second stack slot. This CL fixes the problem and generalizes an existing test which reproduces it. R=v8-arm-ports@googlegroups.com Change-Id: Ibb2fd8275cf912da064e2f863c2d64d2526caaac Reviewed-on: https://chromium-review.googlesource.com/839761Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50291}
-
Yang Guo authored
Bug: chromium:797045 Change-Id: I21171f72c2989819bbc2f22ca9349fd972176095 Reviewed-on: https://chromium-review.googlesource.com/842482Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50290}
-
Sigurd Schneider authored
This also adds speculative checks asserting that all arguments are of the right types; each check disables speculation if it fails. Bug: v8:7127, v8:6270 Change-Id: Ifcb8bc509b86c712f0fab50ef1caee0c3a289e86 Reviewed-on: https://chromium-review.googlesource.com/832449 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50289}
-
Mathias Bynens authored
For numbers, `JSGraph::Constant(Handle<Object> value)` first checks the type of `value`, and then calls `JSGraph::Constant` for its type, which in turn performs some further checks before returning a value. This patch saves a few `if` checks by making the following changes: - JSGraph::Constant(0) → JSGraph::ZeroConstant() - JSGraph::Constant(1) → JSGraph::OneConstant() Change-Id: I6946c280437b7f1fe80d7c45c6fd9b3571907e07 Reviewed-on: https://chromium-review.googlesource.com/840982Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#50288}
-
- 21 Dec, 2017 6 commits
-
-
Michael Achenbach authored
Prepared by: https://crrev.com/c/798412 Bug: v8:7120 Change-Id: I28a00f175673209e6d5f662e30a5448236e7a7c9 Reviewed-on: https://chromium-review.googlesource.com/800612 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#50287}
-
Michael Achenbach authored
https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/19464 https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/19539 NOTRY=true TBR=bbudge@chromium.org Bug: v8:5193 Change-Id: I4d6f73be30dfb1e563aa2f93c11651f739e0741b Reviewed-on: https://chromium-review.googlesource.com/833868Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50286}
-
Ulan Degenbaev authored
We have a heuristics that allows the main thread to skip marking work by the amount marked by the background tasks. Scavenges that happen during incremental marking can reclaim marked objects, which should be accounted in the main thread marking schedule. Bug: chromium:789530 Change-Id: I9b922e05202e3b7665ec191c4fe303dbe7f72a50 Reviewed-on: https://chromium-review.googlesource.com/840843 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50285}
-
Caitlin Potter authored
NodeProperties::InferReceiverMaps now traverses effect chain for Loop-EffectPhi nodes, which makes it possible to inline `iterator.next()` within a loop when the next property is loaded outside of a loop. A new helper, GetInstanceTypeWitness(), performs InferReceiverMaps() and checks that each resulting map has an identical instance type. BUG=chromium:795632, v8:5940, v8:3018 R=bmeurer@chromium.org, jarin@chromium.org Change-Id: Id2690c224668bea62dbcad62ebc2bdf7e37e80d3 Reviewed-on: https://chromium-review.googlesource.com/837484 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50284}
-
Daniel Clifford authored
Bug: v8:1956 Change-Id: I785986ed20e60e21966abe82a1567d239b22b416 Reviewed-on: https://chromium-review.googlesource.com/840026Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#50283}
-
Bill Budge authored
- Adds abstract base class PageAllocator, defined in v8-platform.h. Adds GetPageAllocator method to v8::Platform. - Implements a DefaultPageAllocator, implemented in terms of base::OS page allocation methods. Bug: chromium:756050 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iece0b261a07294a49c30ac25e848dc39cb1a32e2 Reviewed-on: https://chromium-review.googlesource.com/809778 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50282}
-