- 06 Sep, 2018 4 commits
-
-
Sathya Gunasekaran authored
Bug: v8:5751, chromium:881021 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I22514ceb5fb0953b728e67ba5266926e912ce9c1 Reviewed-on: https://chromium-review.googlesource.com/1208516Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55671}
-
Simon Zünd authored
This CL implements a generic baseline version of Array.p.unshift in Torque, enabling us to remove the JS fall-back. The elements-accessor fast-path is still used, but the check whether to use it is also moved to Torque. Support for sparse JSArrays is removed. Drive-by change: Small refactoring in builtins-array that will get extended to other array builtins in a follow-up CL. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7624 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7b23ce15e7b922eb333f61a408050dedec77c95a Reviewed-on: https://chromium-review.googlesource.com/1189902 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55670}
-
Yang Guo authored
This reverts commit f2c943fa. Reason for revert: Non-flaky failures here: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/20374 Original change's description: > [intl] Port collator#resolvedOptions to C++ > > Bug: v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I236dd3a1b5390911a6c668201aec33e7db1cbd53 > Reviewed-on: https://chromium-review.googlesource.com/1208650 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55668} TBR=yangguo@chromium.org,gsathya@chromium.org,usharma1998@gmail.com Change-Id: I018815ec7e3e692cc76a25590c2197a6cf37cc37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1208571Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55669}
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I236dd3a1b5390911a6c668201aec33e7db1cbd53 Reviewed-on: https://chromium-review.googlesource.com/1208650 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55668}
-
- 05 Sep, 2018 36 commits
-
-
Sathya Gunasekaran authored
Bug: v8:7834 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie66f443b86d3cf7bd64cc338d84231045ca5e3c6 Reviewed-on: https://chromium-review.googlesource.com/1208517Reviewed-by:
-
Deepti Gandluri authored
BUG: v8:6532, chromium:874809 Change-Id: I55c00e8563741908cf0daf263152ce927ae18e7c Reviewed-on: https://chromium-review.googlesource.com/1205812 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55666}
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7b126a318480c0d35d6440aa7aea109529ea8ee2 Reviewed-on: https://chromium-review.googlesource.com/1208651 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Previously in the JS implementation, this would throw (on property access) but this new behavior is more in line with how all the other intl objects work. Bug: v8:5751, chromium:880697 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0bd073b2a0a6fc1eacd686083d8f1a72252cea53 Reviewed-on: https://chromium-review.googlesource.com/1207579 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Bug: v8:5751 Change-Id: I978b5b1da41040132204b64dde3f44985b44255d Reviewed-on: https://chromium-review.googlesource.com/1208110 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Change-Id: I4013a966c1f651f5e6cabfbc3f64a08eb01d0dad Bug: v8:5751 Reviewed-on: https://chromium-review.googlesource.com/1207670Reviewed-by:
-
Ujjwal Sharma authored
Rename all BreakIterator builtins from BreakIterator to V8BreakIterator. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I49437096e5a53d85f229421ddae8d61a7164d9a9 Reviewed-on: https://chromium-review.googlesource.com/1207410 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Junliang Yan authored
Use pc relative code on poisoning to allow relocation of bytecode handler. This is allow v8_enable_embedded_bytecode_handlers on ppc. Bug: v8:8068 Change-Id: I6e0a1e961e7e903f0935131cfc190c89c404cf67 Reviewed-on: https://chromium-review.googlesource.com/1205610 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55660}
-
Yannic Bonenberger authored
Change-Id: I2992b0db7f403f682032f9b427c1f8c5238cf61e Reviewed-on: https://chromium-review.googlesource.com/1205290Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55659}
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: I7c65840b62a461de87dc88f8dd2e31eba47e8adf Reviewed-on: https://chromium-review.googlesource.com/1205818Reviewed-by:
-
Benedikt Meurer authored
The Math.expm1() function can actually return -0, for example in the case that -0 is passed to it. Bug: chromium:880207 Change-Id: If3a7a3a1fb6a18075ba0d7816687dfd831ebe293 Reviewed-on: https://chromium-review.googlesource.com/1205072Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55657}
-
Michael Lippautz authored
Allow mocking the limits for ArrayBuffer allocation to simulate operating system OOM. Fixes: - Ensure OS limit > hard limit for external memory. This is necessary as any processing below the hard limit is opportunistic. E.g. a running sweeper may stall the current marking (GC) round. - Immediately process AB allocations when under memory pressure. Otherwise, the allocations may be stuck in a stalled task. Freeing them upon adding them to the collector still enables parallelism if possible. This reverts commit f3ad6cdb. Bug: chromium:845409 Change-Id: Ic3e458f2af231bae3d53afcfd6002a0347d3f12b Reviewed-on: https://chromium-review.googlesource.com/1206872 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I2e461f3f7b3abc666ed5dcc3294a14d27ef0fe60 Reviewed-on: https://chromium-review.googlesource.com/1194583Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55655}
-
jgruber authored
This switches on a restricted register allocation for all CSA-generated builtins on ia32, which treats the kRootRegister (=ebx) as unallocatable. A few builtins are explicitly excluded. These still need to be fixed in follow-up CLs. But I'd like to bake this in now to ensure we don't add more code that cannot handle restricted allocation. All of this is still behind the (disabled-by-default on ia32) v8_embedded_builtins configuration. Bug: v8:6666 Change-Id: If5268aa00439406e1f4e0f7ee18496715a95fdd2 Reviewed-on: https://chromium-review.googlesource.com/1206874Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55654}
-
Mike Stanton authored
An unnecessary call to ToString() on the array index caused trips to the runtime. The fix also includes performance micro-benchmarks so we'll have a harder time regressing this case in future. Bug: v8:8112 Change-Id: Iada5bd2e3c6d2246fb1225e7094f3d9c66ddafbd Reviewed-on: https://chromium-review.googlesource.com/1206355 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55653}
-
jgruber authored
This mostly pushes code around (from the two specialized public ctors to the ConfigureFlags method), but does include one behavioral change in that all builtins/stubs/handlers now disables switch jump tables. Bug: v8:6666 Change-Id: I801d5bdc7a9c4bcc3bc5eb467a7c049404ffaff0 Reviewed-on: https://chromium-review.googlesource.com/1201785Reviewed-by:
Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL adds static assertions (in Liftoff) and DCHECKs (in wasm compiler) to validate that the size of loaded fields from the wasm instance object matches the expected size. This is to avoid future bugs where we change the size of integer fields and forget to update all code that uses these fields. R=titzer@chromium.org Bug: v8:8130, v8:6600 Change-Id: Ib7273800029135b851c0f0b1ca52886783b61fb0 Reviewed-on: https://chromium-review.googlesource.com/1203836 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55651}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: If4086054af6125c252acfbf32074e40ed98b8222 Reviewed-on: https://chromium-review.googlesource.com/1206356 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55650}
-
Michael Achenbach authored
Bug: v8:7964 Change-Id: I540aa0f9b64969f70822f3956d5f9d0a0ea0fde2 Reviewed-on: https://chromium-review.googlesource.com/1206710Reviewed-by:
-
Camillo Bruni authored
The two bool parameters are used for DCHECks in most places. By introducing more specialized enumes kAccessorGetterProperty and kAccessorSetterProperty we can simplify the checks. Bug: v8:7926 Change-Id: I61023f2da0d96ca5a4fba65c6ead309567144786 Reviewed-on: https://chromium-review.googlesource.com/1202822 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55648}
-
Stephan Herhut authored
Change-Id: I34ad8910949e8eb265df53d66f79b315b4a990e6 Reviewed-on: https://chromium-review.googlesource.com/1206630Reviewed-by:
-
Clemens Hammacher authored
The main goal is to untangle Liftoff from the TF-based wasm compiler, but since the AccessBuilder does not simplify anything but rather adds complexity I also removed it from the wasm compiler. Instead, we now bottleneck all offset computations through the new ObjectAccess helper. R=titzer@chromium.org Bug: v8:6600 Change-Id: I362b7b889d68e89da8c30d3fad7b5bab07bee5c8 Reviewed-on: https://chromium-review.googlesource.com/1204090Reviewed-by:
-
Dan Elphick authored
Shrink embedded.cc by writing out octa words instead of bytes. This halves the size of the generated file from 28MB to 14MB in a debug build and reduces compile times for the file from ~2s to ~0.6s. Bug: v8:8129 Change-Id: I90893c7732d83f4eeedee964cd81958201e3b05c Reviewed-on: https://chromium-review.googlesource.com/1204111Reviewed-by:
-
Andreas Haas authored
V8 does not require the embedder to open a HandleScope before executing a v8::Task. However, d8 does open such a HandleScope. Because of that HandleScope we repeatedly found missing HandleScopes only in Chrome tests and not in d8 tests. The same is true for the context, which is not set when Chrome calls a v8::Task. With this CL we create a SealHandleScope around the execution of a v8::Task, and we set the context to nullptr, so that d8 matches Chrome better. Ideally d8 would not open a HandleScope in the first place, and would not set a context. Both make d8 behave different than Chrome and thereby may hide bugs from our testing infrastructure. However, the implementation of the InspectorClient requires them. I think the SealHandleScope and resetting the context is a good workaround at the moment. Yang, do you know if we can get rid of the context there in the long run? R=yangguo@chromium.org Change-Id: I8df0fabde7dfdcdc630d20af4c68f141ac3a454c Reviewed-on: https://chromium-review.googlesource.com/1177742Reviewed-by:
-
Michael Achenbach authored
Path names in import/export statements are relative to the file they are in. This fixes the logic and unblocks using the messages test suite on Android, which has cases importing files from mjsunit, which import more files from there. Bug: chromium:866862 Change-Id: I8d2ff645f69b67fbdaf4a622d06308e55298b0ce Reviewed-on: https://chromium-review.googlesource.com/1206570Reviewed-by:
-
Simon Zünd authored
This CL changes the call-site of SmiLexicographicCompare to a fast c call instead of a runtime call. The runtime function is not deleted as it is still used in InnerArraySort. The test is also moved from mjsunit to cctest, to make removal of the runtime function easier in the future. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7382 Change-Id: Ie961eeb094c13018e9ec28b68f7c444d7f889036 Reviewed-on: https://chromium-review.googlesource.com/1201587 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Hai Dang authored
This CL exposes IteratorBuiltinsAssembler::IterableToList as a builtin to reduce generated code duplication. This follows up on CL 1201882. Change-Id: I848e17bd1b6756de9e898e9d2f8c93d99699df07 Reviewed-on: https://chromium-review.googlesource.com/1206470 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
-
🎉 Mathias Bynens authoredThis reverts commit d3d37157. Reason for revert: waiting for Chromium LKGR to include the updated test expectations. Original change's description: > Reland "Ship globalThis
🎉 " > > This is a reland of 4dac9872 > > Original change's description: > > Ship globalThis🎉 > > > > Proposal repository: > > https://github.com/tc39/proposal-global > > > > Intent to ship: > > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > > > Bug: v8:5537 > > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > > Reviewed-on: https://chromium-review.googlesource.com/1195494 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Commit-Queue: Mathias Bynens <mathias@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55543} > > TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org > > No-Presubmit: true > Bug: v8:5537 > Change-Id: I9776c24952e472c59861ee07f78b6456b19e6f2a > Reviewed-on: https://chromium-review.googlesource.com/1203894 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55635} TBR=adamk@chromium.org,gsathya@chromium.org,mathias@chromium.org Change-Id: Ie1dd22ecc4e13bf1bb6dbec108fbe37ea476bb1a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5537 Reviewed-on: https://chromium-review.googlesource.com/1206471Reviewed-by:Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#55640}
-
Hai Dang authored
This is a reland of 1c48d52b. It turned out that IterableToList doesn't always behave according to the ES operation with the same name. Specifically, it allows holey arrays to take its fast path, which produces an output array with holes where actually "undefined" elements should appear. This CL changes the version of IterableToList that is used for spreads (IterableToListWithSymbolLookup) such that holey arrays take the slow path. It also includes tests for such situations. Original change's description: > [interpreter] Add bytecode for leading array spreads. > > This CL improves the performance of creating [...a, b] or [...a]. > If the array literal has a leading spread, this CL emits the bytecode > [CreateArrayFromIterable] to create the literal. CreateArrayFromIterable > is implemented by [IterableToListDefault] builtin to create the initial > array for the leading spread. IterableToListDefault has a fast path to > clone efficiently if the spread is an actual array. > > The bytecode generated is now shorter. Bytecode generation is refactored > into to BuildCreateArrayLiteral, which allows VisitCallSuper to benefit > from this optimization also. > For now, turbofan also lowers the bytecode to the builtin. > > The idiomatic use of [...a] to clone the array a now performs better > than a simple for-loop, but still does not match the performance of slice. > > Bug: v8:7980 > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ibde659c82d3c7aa1b1777a3d2f6426ac8cc15e35 > Reviewed-on: https://chromium-review.googlesource.com/1181024 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Commit-Queue: Hai Dang <dhai@google.com> > Cr-Commit-Position: refs/heads/master@{#55520} Bug: v8:7980 Change-Id: I0b5603a12d2b588327658bf0a9b214bd0f22e237 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1201882 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
jgruber authored
GCC may be buggy in how it handles visibility in this case. The previous nested implementation resulted in a 'lambda1 declared with greater visibility than the type of its field lambda2' error. Unnesting the inner lambda works around the error. Bug: v8:8126 Change-Id: Id822ca80fec9af27c4adc7ff53be3b6d9478f0d7 Reviewed-on: https://chromium-review.googlesource.com/1206310Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7926 Change-Id: I1c3b831bb19c70e1e7c99f45ae50dbd1351ce2a7 Reviewed-on: https://chromium-review.googlesource.com/1202105 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7926 Change-Id: I62e05240fd2bb165ddf8965b77763ec11a40a609 Reviewed-on: https://chromium-review.googlesource.com/1202543 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
🎉 Mathias Bynens authoredThis is a reland of 4dac9872 Original change's description: > Ship globalThis
🎉 > > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > Bug: v8:5537 > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > Reviewed-on: https://chromium-review.googlesource.com/1195494 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55543} TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org No-Presubmit: true Bug: v8:5537 Change-Id: I9776c24952e472c59861ee07f78b6456b19e6f2a Reviewed-on: https://chromium-review.googlesource.com/1203894 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: -
Clemens Hammacher authored
GCC complained about these. R=mstarzinger@chromium.org Change-Id: I36d69b4191b63ae4373a9b96893cf98650acd7e9 Reviewed-on: https://chromium-review.googlesource.com/1206291Reviewed-by:
-
Daniel Clifford authored
Change-Id: I9dc6a387ce5c9b97e21d20297b59b910daea3c6d Reviewed-on: https://chromium-review.googlesource.com/1199503Reviewed-by:
-
Matheus Marchini authored
As discussed in https://github.com/nodejs/llnode/issues/156, we need postmortem metadata for Symbols to properly print Symbol property names in postmortem debugging tools. Patch suggested by Ben Noordhuis (https://github.com/nodejs/llnode/issues/156#issuecomment-350467852). R=bmeurer@google.com, yangguo@google.com Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118 Reviewed-on: https://chromium-review.googlesource.com/1205052Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
