- 16 Dec, 2014 10 commits
-
-
erik.corry authored
R=jkummerow@chromium.org, yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/799403003 Cr-Commit-Position: refs/heads/master@{#25839}
-
marja authored
The bug would occur when we try to Reset() to a position already at the end. This happens e.g., when the regexp ends with \u. What used to happen in that case: 1) Advance past \ and u (to the end) (which wouldn't increase next_pos_ enough) 2) Try to parse 4 hex digits 3) When that failed, Reset() to the position which should've been at the end but wasn't. To be able to properly Reset() to a position at the end, we need to allow next_pos_ to move beyond the end (since position() is next_pos_ - 1). Minimal repro case: var r = /foo\u/ r.test("foou") // should be true, was false. (Note that \u not followed by 4 hex didits should be interpreted as an identity escape. It already worked unless \u was at the end of the regexp.) BUG=v8:3756 LOG=NO Review URL: https://codereview.chromium.org/802313003 Cr-Commit-Position: refs/heads/master@{#25838}
-
titzer authored
R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/803993002 Cr-Commit-Position: refs/heads/master@{#25837}
-
Benedikt Meurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/811713002 Cr-Commit-Position: refs/heads/master@{#25836}
-
Sven Panne authored
Patch from issue 800293002 authored by ben@strongloop.com TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/806143002 Cr-Commit-Position: refs/heads/master@{#25835}
-
Benedikt Meurer authored
TEST=unittests R=titzer@chromium.org Review URL: https://codereview.chromium.org/810683003 Cr-Commit-Position: refs/heads/master@{#25834}
-
chunyang.dai authored
port d211608a original commit message: [turbofan] Remove the no-context hack for JSToNumber. The ToNumberStub is now able to handle all plain primitives (Numbers, Booleans, Null, Undefined and Strings) without context access. BUG= Review URL: https://codereview.chromium.org/810683002 Cr-Commit-Position: refs/heads/master@{#25833}
-
Benedikt Meurer authored
Relanded with fix for always returning Change for PlainPrimitive even if there was no change. The performance regression on primes.js and corrections.js is due to unlucky loop header alignment; will be addressed separately. TEST=unittests R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/75484e8d16866eba7aa9c3b87841cd6ce2f466b8 Review URL: https://codereview.chromium.org/799413002 Cr-Commit-Position: refs/heads/master@{#25832}
-
bmeurer authored
Revert of [turbofan] Relax effects and context for JSToNumber(x:plain-primitive). (patchset #1 id:1 of https://codereview.chromium.org/799413002/) Reason for revert: Performance regressions on primes and corrections benchmarks. Original issue's description: > [turbofan] Relax effects and context for JSToNumber(x:plain-primitive). > > TEST=unittests > R=svenpanne@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/75484e8d16866eba7aa9c3b87841cd6ce2f466b8 TBR=svenpanne@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/806103002 Cr-Commit-Position: refs/heads/master@{#25831}
-
v8-autoroll authored
Rolling v8/tools/clang to 6538d768c1dd43ad3942574cfc5ba90a8e1e0517 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/803183005 Cr-Commit-Position: refs/heads/master@{#25830}
-
- 15 Dec, 2014 20 commits
-
-
jkummerow authored
There are no users of this infrastructure yet, so it's behind an off-by-default flag. Review URL: https://codereview.chromium.org/768633002 Cr-Commit-Position: refs/heads/master@{#25829}
-
caitpotter88 authored
LOG=N R=dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/799853003 Cr-Commit-Position: refs/heads/master@{#25828}
-
rmcilroy authored
The snapshot and natives blob files should be output in the out directory instead of the gen directory so that they can be picked up by the executable. BUG=421063 LOG=N Review URL: https://codereview.chromium.org/805813004 Cr-Commit-Position: refs/heads/master@{#25827}
-
dslomov authored
R=arv@chromium.org BUG=v8:3330 LOG=Y Review URL: https://codereview.chromium.org/808433002 Cr-Commit-Position: refs/heads/master@{#25826}
-
arv authored
Revert of ES6 computed property names (patchset #9 id:160001 of https://codereview.chromium.org/795573005/) Reason for revert: Crashes on Win32 http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/1357 Test: mjsunit/harmony/computed-property-names Flags: --stress-opt --always-opt Command: build\Release\d8.exe --test --random-seed=-233815021 --stress-opt --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --harmony-computed-property-names test\mjsunit\mjsunit.js test\mjsunit\harmony\computed-property-names.js Run #1 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Run #2 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Run #3 Exit code: -1073741819 Result: CRASH Expected outcomes: PASS Original issue's description: > ES6 computed property names > > This adds support for computed property names, under the flag > --harmony-computed-property-names, for both object literals and > classes. > > BUG=v8:3754 > LOG=Y TBR=dslomov@chromium.org,wingo@igalia.com NOTREECHECKS=true NOTRY=true BUG=v8:3754 Review URL: https://codereview.chromium.org/809433002 Cr-Commit-Position: refs/heads/master@{#25825}
-
balazs.kilvady authored
Port d211608a Original commit message: The ToNumberStub is now able to handle all plain primitives (Numbers, Booleans, Null, Undefined and Strings) without context access. TEST=cctest,mjsunit,unittests BUG= Review URL: https://codereview.chromium.org/803973002 Cr-Commit-Position: refs/heads/master@{#25824}
-
jkummerow authored
Review URL: https://codereview.chromium.org/803833004 Cr-Commit-Position: refs/heads/master@{#25823}
-
jkummerow authored
Review URL: https://codereview.chromium.org/804993002 Cr-Commit-Position: refs/heads/master@{#25822}
-
arv authored
This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. BUG=v8:3754 LOG=Y Review URL: https://codereview.chromium.org/795573005 Cr-Commit-Position: refs/heads/master@{#25821}
-
jochen authored
build is the third number of the V8 version, and very likely to change (in contrast to the patch level which typically is zero on canaries). BUG=chromium:440984 R=mvstanton@chromium.org,yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/802363002 Cr-Commit-Position: refs/heads/master@{#25820}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/806783002 Cr-Commit-Position: refs/heads/master@{#25819}
-
Benedikt Meurer authored
TEST=unittests R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/799413002 Cr-Commit-Position: refs/heads/master@{#25818}
-
fedor.indutny authored
Keyed loads should not unconditionally be compiled to element loads. Update KeyedLoadICs to keep track of the key type, so that Hydrogen can emit ICs for string-keyed loads it doesn't have inline support for. BUG=v8:3167 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/755513003 Cr-Commit-Position: refs/heads/master@{#25817}
-
ishell authored
LayoutDescriptorHelper is now able to calculate the length of contiguous regions of tagged/non-tagged fields. This functionality is now used by both object visitor and store buffer. TEST=cctest/test-unboxed-doubles Review URL: https://codereview.chromium.org/726713003 Cr-Commit-Position: refs/heads/master@{#25816}
-
hpayer authored
Revert of Call DisableInlineAllocation() in heap setup when flag inline_new is off. (patchset #1 id:1 of https://codereview.chromium.org/790353006/) Reason for revert: Fix Windows nosnap. Original issue's description: > Call DisableInlineAllocation() in heap setup when flag inline_new is off. > > BUG= TBR=ulan@chromium.org,mstarzinger@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/794053003 Cr-Commit-Position: refs/heads/master@{#25815}
-
bmeurer authored
The ToNumberStub is now able to handle all plain primitives (Numbers, Booleans, Null, Undefined and Strings) without context access. TEST=cctest,mjsunit,unittests Review URL: https://codereview.chromium.org/801333002 Cr-Commit-Position: refs/heads/master@{#25814}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/790353006 Cr-Commit-Position: refs/heads/master@{#25813}
-
Benedikt Meurer authored
TEST=unittests R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/801263002 Cr-Commit-Position: refs/heads/master@{#25812}
-
Benedikt Meurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/806653003 Cr-Commit-Position: refs/heads/master@{#25811}
-
adamk authored
Review URL: https://codereview.chromium.org/805523002 Cr-Commit-Position: refs/heads/master@{#25810}
-
- 13 Dec, 2014 1 commit
-
-
mathiasb authored
TEST=mjsunit/harmony BUG=v8:3751 LOG=N Review URL: https://codereview.chromium.org/788053003 Cr-Commit-Position: refs/heads/master@{#25809}
-
- 12 Dec, 2014 9 commits
-
-
caitpotter88 authored
Add support for Symbol.isConcatSpreadable in Array.prototype.concat. This enables spreading non-Array objects with the symbol. LOG=N R=dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/771483002 Cr-Commit-Position: refs/heads/master@{#25808}
-
danno authored
Review URL: https://codereview.chromium.org/795353008 Cr-Commit-Position: refs/heads/master@{#25807}
-
adamk authored
Such properties never notified prior to r21558, but the combination of that change and r23163 led to sending notifications when they were set via Object.defineProperty (but not when set via other means). This also allows some cleanup in v8natives.js and objects.cc, both of which were doing unnecessary contortions to produce the right change records. BUG=v8:3745 LOG=n Review URL: https://codereview.chromium.org/791243002 Cr-Commit-Position: refs/heads/master@{#25806}
-
rmcilroy authored
The Mac version of GetCurrentThreadId should be used when building the host build of V8 on Android for Mac. Review URL: https://codereview.chromium.org/799943003 Cr-Commit-Position: refs/heads/master@{#25805}
-
Daniel Vogelheim authored
BUG= Review URL: https://codereview.chromium.org/804543002 Cr-Commit-Position: refs/heads/master@{#25804}
-
ishell authored
FORCE_FIELD -> FORCE_IN_OBJECT, ALLOW_AS_CONSTANT -> ALLOW_IN_DESCRIPTOR. Review URL: https://codereview.chromium.org/799723003 Cr-Commit-Position: refs/heads/master@{#25803}
-
ishell authored
Review URL: https://codereview.chromium.org/801813002 Cr-Commit-Position: refs/heads/master@{#25802}
-
https://codereview.chromium.org/803493002/dcarney authored
Reason for revert: performance bots were unchanged by the original revert Original issue's description: > revert r25736 > > R=bmeurer@chromium.org > > BUG= TBR=bmeurer@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/787183003 Cr-Commit-Position: refs/heads/master@{#25801}
-
Michael Stanton authored
This patch finally allows running and passing tests with vector-based Load and KeyedLoad ICs. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/767743002 Cr-Commit-Position: refs/heads/master@{#25800}
-