1. 08 Mar, 2021 27 commits
  2. 07 Mar, 2021 1 commit
  3. 06 Mar, 2021 4 commits
  4. 05 Mar, 2021 8 commits
    • Bill Budge's avatar
      Reland "[codegen][frames] Generalize argument padding slot code" · d2ab64eb
      Bill Budge authored
      This is a (manual) reland of ba87518e071a75fb951b490d3f75a87ca715cc23
      
      It is unchanged, except to rebase around a merge conflict.
      TBR=neis@chromium.org, jgruber@chromium.org
      
      Bug: v8:9198
      
      > [codegen][frames] Generalize argument padding slot code
      >
      > - Removes kPadArguments boolean.
      > - Changes ShouldPadArguments to ArgumentPaddingSlots to reflect
      >   that on some architectures more than 1 padding slot may be needed.
      > - Adds AddArgumentPaddingSlots and ShouldPadArguments convenience
      >   functions.
      >
      > Bug: v8:9198
      >
      > Change-Id: Iba87518e071a75fb951b490d3f75a87ca715cc23
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679109
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#72605}
      
      Change-Id: I2a9022964d3bafe68c5c1e7de0ae7e837dd5c2e3
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2740457Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73241}
      d2ab64eb
    • Frank Tang's avatar
      Fix DateTimeFormat::formatRange bug · 2590dc5a
      Frank Tang authored
      Using hack mentioned in https://unicode-org.atlassian.net/browse/ICU-20710
      to address the short coming in the ICU IntervalFormat
      
      Bug: v8:11411
      Change-Id: I38e54d3617f24afbd9dc4355f946850d7a506116
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2713573
      Commit-Queue: Frank Tang <ftang@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73240}
      2590dc5a
    • Bill Budge's avatar
      Reland "[compiler][linkage] No allocation of slots after aligning a frame" · 13568594
      Bill Budge authored
      This is a reland of b18bc221
      
      It is unchanged, so:
      TBR=jgruber@chromium.org, georgia.kouveli@arm.com
      
      Original change's description:
      > [compiler][linkage] No allocation of slots after aligning a frame
      >
      > - Adds DCHECKs to make sure no stack slots are allocated after
      >   aligning a frame.
      > - Changes Arm64 CodeGenerator::FinishFrame to align the frame after
      >   allocating callee-saved registers, and relaxes the constraints on
      >   the number of callee-saved registers.
      >
      > Bug: v8:9198
      > Change-Id: Iacb0518b57fa3ea2ff801eda69719f4c32733850
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2694104
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#72781}
      
      Bug: v8:9198
      Change-Id: I0b809fab67586ac188c39ef1569c0b2ceb60d3b9
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2738957Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73239}
      13568594
    • Bill Budge's avatar
      Reland "Reland "Reland "[compiler][wasm] Align Frame slots to value size""" · e639eafe
      Bill Budge authored
      This is a reland of 352b9ecb
      
      The test/fix CL has been merged in, as the fixes to return slot
      accounting are needed to fix Arm64 issues turned up by the fuzzers:
      
      https://chromium-review.googlesource.com/c/v8/v8/+/2644139
      
      The reverted fix for Wasm return slot allocation is added in
      patchset #2, to avoid fuzzer issues that it fixed:
      
      https://chromium-review.googlesource.com/c/v8/v8/+/2683024
      
      TBR=neis@chromium.org
      
      Original change's description:
      > Reland "Reland "[compiler][wasm] Align Frame slots to value size""
      >
      > This is a reland of 1694925c
      >
      > Minor fix to linkage for constexpr.
      >
      > TBR=ahaas@chromium.org,neis@chromium.org
      >
      > Original change's description:
      > > Reland "[compiler][wasm] Align Frame slots to value size"
      > >
      > > This is a reland of cddaf66c
      > >
      > > Original change's description:
      > > > [compiler][wasm] Align Frame slots to value size
      > > >
      > > > - Adds an AlignedSlotAllocator class and tests, to unify slot
      > > >   allocation. This attempts to use alignment holes for smaller
      > > >   values.
      > > > - Reworks Frame to use the new allocator for stack slots.
      > > > - Reworks LinkageAllocator to use the new allocator for stack
      > > >   slots and for ARMv7 FP register aliasing.
      > > > - Fixes the RegisterAllocator to align spill slots.
      > > > - Fixes InstructionSelector to align spill slots.
      > > >
      > > > Bug: v8:9198
      > > >
      > > > Change-Id: Ida148db428be89ef95de748ec5fc0e7b0358f523
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512840
      > > > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > > > Reviewed-by: Georg Neis <neis@chromium.org>
      > > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#71644}
      > >
      > > Bug: v8:9198
      > > Change-Id: Ib91fa6746370c38496706341e12d05c7bf999389
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633390
      > > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > > Reviewed-by: Georg Neis <neis@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#72195}
      >
      > Bug: v8:9198
      > Change-Id: I91e02b823af8ec925dacf075388fb22e3eeb3384
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640890
      > Reviewed-by: Bill Budge <bbudge@chromium.org>
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#72209}
      
      Bug: v8:9198
      Change-Id: Ia5cf63af4e5991bc7cf42da9972ffd044fc829f0
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2733177
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73238}
      e639eafe
    • Ng Zhi An's avatar
      [wasm-simd] Enable SIMD by default · 10587a27
      Ng Zhi An authored
      Bug: v8:11511,v8:6020
      Change-Id: I07b87b2a3a2ea08def9be2d0da808c013dd6fc2a
      Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2728245
      Commit-Queue: Zhi An Ng <zhin@chromium.org>
      Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73237}
      10587a27
    • Clemens Backes's avatar
      [no-wasm] Split off runtime-test-wasm.cc · 15f5679e
      Clemens Backes authored
      This moves all wasm-related runtime functions from runtime-test.cc to
      runtime-test-wasm.cc, which makes it easier to fully exclude them later.
      
      R=ahaas@chromium.org
      
      Bug: v8:11238
      Change-Id: I3bc1c175b8db8837097308ed09aab69725dcf5aa
      Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739648
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73236}
      15f5679e
    • Bill Budge's avatar
      Reland "Reland "[wasm][liftoff] Respect CallDescriptor linkage"" · c2a1d633
      Bill Budge authored
      This is a reland of 36a7cba2
      
      Unchanged, so:
      
      tbr=clemensb@chromium.org
      
      Original change's description:
      > Reland "[wasm][liftoff] Respect CallDescriptor linkage"
      >
      > This is a reland of 94283811
      >
      > Patchset #2 fixes the Arm bug. A vpush is used to push the slot,
      > so subtract kSimd128Size from the stack decrement to get padding.
      >
      > Original change's description:
      > > [wasm][liftoff] Respect CallDescriptor linkage
      > >
      > > - Adds the actual stack slot location to LiftoffStackSlots::Slot.
      > > - Adds SortInPushedOrder method for architectures that push
      > >   parameters.
      > > - Changes the LiftoffStackSlots::Construct signature to take the
      > >   number of parameter slots in total, and changes implementations
      > >   to insert padding when slots aren't contiguous.
      > > - Changes Arm MacroAssembler::AllocateStackSpace to check the
      > >   immediate value, and to be a nop when it's zero.
      > >
      > > Bug: v8:9198
      > > Change-Id: Ibd5775dbed3a40051fa9e345556231a1c07cf4e9
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717120
      > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#73191}
      >
      > Bug: v8:9198
      > Change-Id: Iae4930e28dd7fc634e3709a5726379c6b37e5195
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2735984
      > Reviewed-by: Bill Budge <bbudge@chromium.org>
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#73195}
      
      Bug: v8:9198
      Change-Id: I45c2b6fc8c38ef864a0bd7a7be5b431c7b8855a3
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739737
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73235}
      c2a1d633
    • Clemens Backes's avatar
      [no-wasm] Remove wasm-js · 4e0ac2ed
      Clemens Backes authored
      This CL removes wasm-js.cc from compilation if
      v8_enable_webassembly=false. In order to do so, an alternative
      implementation of {v8::WasmStreaming} has to be provided, because the
      public API should stay unchanged. The only path to obtain a
      {v8::WasmStreaming} object is via {v8::WasmStreaming::Unpack}, which
      will always fail if WebAssembly is not supported. Hence all methods in
      {WasmStreamingImpl} are unreachable.
      
      As a drive-by, this CL removes all includes from src/wasm in src/init
      (bootstrapper.cc would have been done anyway, and v8.cc is just a few
       changes).
      
      R=jkummerow@chromium.org
      
      Bug: v8:11238
      Change-Id: Ic0638eb5cda91ec29c1c07ef400bc670c91630fb
      Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737300Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73234}
      4e0ac2ed