1. 19 May, 2021 1 commit
    • Benedikt Meurer's avatar
      [inspector] Derive breakpoint hint based on resolved location. · ea3ee6da
      Benedikt Meurer authored
      When setting a breakpoint on a line (in the DevTools front-end), the
      front-end sends a columnNumber of 0 and the inspector automatically
      resolves the actual location (in bytecode execution order). In order
      to also support changing source code, the inspector memorizes a text
      hint, and uses that to adjust the location upon reload. This hint was
      however taken based on the original line and column numbers, rather than
      the resolved location, which causes trouble when syntactic order doesn't
      match execution order, as in case of `await o.m()`.
      
      In order to address that we now remember the textual hint based on the
      resolved location.
      
      Fixed: chromium:1081162
      Also-By: kimanh@chromium.org
      Change-Id: I7d08373440693b7abc18c29c1a05929d771d3031
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905606
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74675}
      ea3ee6da