- 28 Oct, 2016 24 commits
-
-
kozyatinskiy authored
When Chromium and V8 use the same version of inspector_protocol, any protocol change takes at least 4 patches and 3 waiting for rolls. To simplify this process we need to have two diffrent versions of inspector_protocol in Chromium and V8. Current state of inspector_protocol was extracted into separate repository [1]. This CL puts last version of inspector_protocol into third_party/inspector_protocol and removes dependency on inspector_protocol in Webkit. [1] https://chromium.googlesource.com/deps/inspector_protocol/ BUG=chromium:637032 R=dgozman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2447323002 Cr-Commit-Position: refs/heads/master@{#40655}
-
eholk authored
BUG= Review-Url: https://codereview.chromium.org/2460773003 Cr-Commit-Position: refs/heads/master@{#40654}
-
lpy authored
Previously we reset runtime counters and dump them when we enter, exit top level trace events respectively. However, there is gap between two top level trace events and runtime counters may be activated, resetting the counters makes the accumulated time inaccurate, and we may end up with negative time due to the nature of how we accumulate time. This patch fixes this problem by only resetting counters when there's no counters active, and before dump counters, we traverse current active counters to calculate their time, and then restart their timer. BUG=chromium:658145 Review-Url: https://codereview.chromium.org/2457523002 Cr-Commit-Position: refs/heads/master@{#40653}
-
titzer authored
This CL implements basic table import functionality. Missing: growing of tables (WebAssembly.Grow) doesn't change dispatch tables Missing: allowing larger table imports than minimum size R=rossberg@chromium.org,bradnelson@chromium.org BUG=v8:5507 Review-Url: https://codereview.chromium.org/2454503005 Cr-Commit-Position: refs/heads/master@{#40652}
-
ulan authored
candidates. BUG=chromium:650314 Review-Url: https://codereview.chromium.org/2459003002 Cr-Commit-Position: refs/heads/master@{#40651}
-
machenbach authored
Revert of [heap] Concurrent store buffer processing. (patchset #13 id:260001 of https://codereview.chromium.org/2453673003/ ) Reason for revert: Seems to block rolling: https://codereview.chromium.org/2447393005/ Original issue's description: > [heap] Concurrent store buffer processing. > > BUG=chromium:648973, chromium:648568 TBR=ulan@chromium.org,mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648973, chromium:648568 Review-Url: https://codereview.chromium.org/2449853010 Cr-Commit-Position: refs/heads/master@{#40650}
-
neis authored
R=gsathya@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2460883002 Cr-Commit-Position: refs/heads/master@{#40649}
-
jochen authored
This is useful for things that don't ever change, but we don't want to eagerly compute the result. Doing this from the embedder is difficult, using DefineOwnProperty would read the property to get the property descriptor, creating an endless recursion. R=verwaest@chromium.org,haraken@chromium.org BUG= Review-Url: https://codereview.chromium.org/2449783006 Cr-Commit-Position: refs/heads/master@{#40648}
-
ulan authored
Cancelable task already guarantees proper waiting. BUG= Review-Url: https://codereview.chromium.org/2462553002 Cr-Commit-Position: refs/heads/master@{#40647}
-
ahaas authored
R=titzer@chromium.org TEST=mjsunit/wasm/start-function Review-Url: https://codereview.chromium.org/2458983002 Cr-Commit-Position: refs/heads/master@{#40646}
-
jochen authored
Otherwise, we don't account for callbacks from optimized code anymore. R=verwaest@chromium.org,cbruni@chromium.org BUG= Review-Url: https://codereview.chromium.org/2459573002 Cr-Commit-Position: refs/heads/master@{#40645}
-
ulan authored
The order is important for DEFINE_IMPLICATION to ensure transitive implication: predictable => single_threaded => !concurrent_sweeping. BUG=5580 Review-Url: https://codereview.chromium.org/2456323002 Cr-Commit-Position: refs/heads/master@{#40644}
-
mstarzinger authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2457763003 Cr-Commit-Position: refs/heads/master@{#40643}
-
hpayer authored
BUG=chromium:648973, chromium:648568 Review-Url: https://codereview.chromium.org/2453673003 Cr-Commit-Position: refs/heads/master@{#40642}
-
leszeks authored
The majority of context slot accesses are to the local context (current context register and depth 0), so this adds bytecodes to optimise for that case. This cuts down bytecode size by roughly 1% (measured on Octane and Top25). Review-Url: https://codereview.chromium.org/2459513002 Cr-Commit-Position: refs/heads/master@{#40641}
-
ishell authored
... because the latter unlike the former records meaningful position. BUG= Review-Url: https://codereview.chromium.org/2456193005 Cr-Commit-Position: refs/heads/master@{#40640}
-
mstarzinger authored
This flag is on by default for now. Whenever heuristics in the compiler pipeline decide to use Ignition+TurboFan, then {BytecodeGraphBuilder} is active. Removing the flag reduces maintenance overhead. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2437103002 Cr-Commit-Position: refs/heads/master@{#40639}
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2446073002 Cr-Commit-Position: refs/heads/master@{#40638}
-
predrag.rudic authored
TEST=ctest/test-scanner-streams/CharacterStreams BUG= Review-Url: https://codereview.chromium.org/2415093002 Cr-Commit-Position: refs/heads/master@{#40637}
-
jgruber authored
This CL adds simple implementation of break and stepping-related functionality as required by the debug-step.js test. This includes * stepOver, stepInto, stepOut * setBreakPoint * clearBreakPoint * evaluate Some of these, e.g. setBreakPoint are not fully implemented for all cases but only for the ones we need right now. One interesting result of this is that using the inspector protocol is roughly 14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to be iteration over all object properties in toProtocolValue, which is used to serialize JS objects before being sent over the wire (e.g. FrameMirrors). This is something that should be fixed at some point. In the meantime, the test now runs 100 instead of 1000 iterations. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2447073007 Cr-Commit-Position: refs/heads/master@{#40636}
-
jgruber authored
This adds a wrapper class around the inspector protocol for use in debugger tests. The interface is intended to stay similar to the currently exposed DebuggerContext. Right now, we support adding a listener, (partial) handling of the AfterCompile event, and enabling/disabling the debugger. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2451153003 Cr-Commit-Position: refs/heads/master@{#40635}
-
jgruber authored
BUG=v8:5339 Review-Url: https://codereview.chromium.org/2452923002 Cr-Commit-Position: refs/heads/master@{#40634}
-
clemensh authored
In the asm.js to wasm pipeline, we generate an entry function with BUILTIN code, but still attached to a TYPE_NORMAL script. This fix avoids trying to set a breakpoint there, resulting in a crash on DCHECK(shared->HasDebugInfo()). Also add two inspector tests to track regressions. BUG=v8:5568 R=titzer@chromium.org,mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2457433002 Cr-Commit-Position: refs/heads/master@{#40633}
-
zhengxing.li authored
port 7d383be9 (r40608) original commit message: For inputs to truncating binary operations like <<, | or >>>, support all Oddballs not just undefined, true and false. This unifies treatment of these truncations in Crankshaft and TurboFan, and is very easy nowadays, since the memory layout of Oddball and HeapNumber is compatible. BUG= Review-Url: https://codereview.chromium.org/2450093007 Cr-Commit-Position: refs/heads/master@{#40632}
-
- 27 Oct, 2016 16 commits
-
-
bjaideep authored
Converting INT_MIN to positive should cause overflow, which was not being captured. Fixed the logic to detect if value is equal to INT_MIN and set the overflow code accordingly. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2446113013 Cr-Commit-Position: refs/heads/master@{#40631}
-
yangguo authored
The first 32 root list items are a conscious choice in order for the serializer to encode root references more efficiently. R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2458603002 Cr-Commit-Position: refs/heads/master@{#40630}
-
ulan authored
BUG=chromium:659165 Review-Url: https://codereview.chromium.org/2455103002 Cr-Commit-Position: refs/heads/master@{#40629}
-
ahaas authored
This change makes the embenchen/copy benchmark a factor of 2 faster and brings back the performance loss through graph trimming. R=titzer@chromium.org CC=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2453343002 Cr-Commit-Position: refs/heads/master@{#40628}
-
ishell authored
The reasons are: 1) Type feedback vectors are not shared between different native contexts and therefore the IC handler created for one native context will not be reused in other native context. 2) Access rights revocation is not supported at all, therefore given (1) once we pass the access check we don't have to check access rights again. BUG=v8:5561 Review-Url: https://codereview.chromium.org/2455953002 Cr-Commit-Position: refs/heads/master@{#40627}
-
ishell authored
BUG=v8:5561 Review-Url: https://codereview.chromium.org/2449463002 Cr-Commit-Position: refs/heads/master@{#40626}
-
bjaideep authored
Port 7d383be9 Original commit message: For inputs to truncating binary operations like <<, | or >>>, support all Oddballs not just undefined, true and false. This unifies treatment of these truncations in Crankshaft and TurboFan, and is very easy nowadays, since the memory layout of Oddball and HeapNumber is compatible. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2455993002 Cr-Commit-Position: refs/heads/master@{#40625}
-
mstarzinger authored
The assumptions that OSR code is installed on {JSFunction} objects no longer holds with TurboFan and hence {assertOptimized} can report a different result dependeing on how OSR code is treated. This is working as intended. R=mythria@chromium.org Review-Url: https://codereview.chromium.org/2453313002 Cr-Commit-Position: refs/heads/master@{#40624}
-
yangguo authored
See https://goo.gl/C9U1dL BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2452333002 Cr-Commit-Position: refs/heads/master@{#40623}
-
gsathya authored
This is no longer used. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2454713003 Cr-Commit-Position: refs/heads/master@{#40622}
-
adamk authored
Unlike other variable allocation logic, MODULE allocation does not depend on resolution. So in order to give hole check elimination (which runs during resolution) access to the information "is this variable an import", simply allocate all modules variables prior to resolution. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2458653002 Cr-Commit-Position: refs/heads/master@{#40621}
-
henrique.ferreiro authored
The latter was left from a previous commit and not updated later to reflect the new name. Review-Url: https://codereview.chromium.org/2447023004 Cr-Commit-Position: refs/heads/master@{#40620}
-
jarin authored
BUG=v8:5573 Review-Url: https://codereview.chromium.org/2458623002 Cr-Commit-Position: refs/heads/master@{#40619}
-
gsathya authored
This patch moves promise specific runtime functions to runtime-promise.cc from runtime-internal.cc BUG=v8:5343 Review-Url: https://codereview.chromium.org/2452833003 Cr-Commit-Position: refs/heads/master@{#40618}
-
mstarzinger authored
This prepares the code-base so that Ignition can be enabled on a certain subset of compilations without setting the {FLAG_ignition} flag (which enables Ignition on all compilations). We should not check the flag in question explicitly anywhere outside of the compiler heuristics. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2443573002 Cr-Commit-Position: refs/heads/master@{#40617}
-
bmeurer authored
R=jarin@chromium.org BUG=chromium:659967 Review-Url: https://codereview.chromium.org/2453633005 Cr-Commit-Position: refs/heads/master@{#40616}
-