Commits · cff61d3bffa1321c7980bc697f46ce14d647dcbb · Linshizhi / V8

23 May, 2014 4 commits

Add a bunch of files in my checkout to .gitignore · cff61d3b

jochen@chromium.org authored May 23, 2014

BUG=none
TBR=machenbach@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/296453020

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21451 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cff61d3b

Remove dummy harmony-promises flag · fe68f988

jochen@chromium.org authored May 23, 2014

BUG=none
LOG=n
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/292723002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fe68f988

Revert "Do away with variable length memcpy to Set/Get registers in simulator" · 83987813

svenpanne@chromium.org authored May 23, 2014

This reverts r21148, it broke tests in debug mode, e.g.
mjsunit/regress/regress-observe-map-cache or mjsunit/debug-stepout-scope-part5.

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/296823014

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

83987813

Do away with variable length memcpy to Set/Get registers in simulator · e61b69f5

svenpanne@chromium.org authored May 23, 2014

About a 32% boost.

Before - 5:31

Richards: 84.5
DeltaBlue: 128
Crypto: 65.3
RayTrace: 203
EarleyBoyer: 149
RegExp: 23.4
Splay: 121
NavierStokes: 98.9
----
Score (version 7): 93.8

After - 4:10

Richards: 107
DeltaBlue: 175
Crypto: 93.9
RayTrace: 258
EarleyBoyer: 186
RegExp: 32.7
Splay: 165
NavierStokes: 124
----
Score (version 7): 124

R=jacob.bramley@arm.com, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/213943002

Patch from Fritz Koenig <frkoenig@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21448 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e61b69f5

22 May, 2014 29 commits

MIPS: Customized support for feedback on calls to Array. · c471c9e8

plind44@gmail.com authored May 22, 2014

Port r21429 (a88ba79)

Original commit message:
Gather transition feedback on array calls, and inline the Array
function call when it makes sense.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/293063012

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21445 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c471c9e8

Revert "Reland r21346 "Inobject slack tracking is done on a per-closure basis... · 9f3183f7

ishell@chromium.org authored May 22, 2014

Revert "Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis.""

This reverts r21442.

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/292433016

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21444 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f3183f7

MIPS: Allow specifying base offset when constructing Keyed hydrogen instructions. · 9fb4abb9

plind44@gmail.com authored May 22, 2014

Port r21426 (17e6338)

This is preparation for pending hydrogen stub work that needs to access memory using KeyedLoad/KeyedStore operations where the base offset used for the accesses are is the the default (e.g. the size of an FixedArray header for FixedArrays or zero for external arrays).

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/296983003

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21443 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9fb4abb9

Reland r21346 "Inobject slack tracking is done on a per-closure basis instead... · 00b8e612

ishell@chromium.org authored May 22, 2014

Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis."
This fixes inobject slack tracking for prototype inheritance pattern that uses closures.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/290993009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21442 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

00b8e612

Consistently say 'own' property · 06f746a5

rossberg@chromium.org authored May 22, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/291153005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

06f746a5

ClearTypeFeedbackInfo() assumed we have a context in the isolate. · d2a32383

mvstanton@chromium.org authored May 22, 2014

Better, is to compare against the context for the JSFunction we are
currently looking at.

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/294903013

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21440 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d2a32383

Harden a few builtins · d6a05b72

jkummerow@chromium.org authored May 22, 2014

Introducing BUILTIN_ASSERT, builtins' equivalent of RUNTIME_ASSERT.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/292173011

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21439 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d6a05b72

If map became unstable, abort compilation and allow re-compilation. · 620f07e3

hpayer@chromium.org authored May 22, 2014

BUG=
R=danno@google.com

Review URL: https://codereview.chromium.org/291653006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21438 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

620f07e3

Revert "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis." · 58932c6c

ishell@chromium.org authored May 22, 2014

This reverts r21436.

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/295933012

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

58932c6c

Inobject slack tracking is done on a per-closure basis instead of per-shared info basis. · 4a47cc5f

ishell@chromium.org authored May 22, 2014

This fixes inobject slack tracking for prototype inheritance pattern that uses closures.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/283383006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4a47cc5f

GCMole evaluation order issue in CallIC::DoCustomHandler(). · 894df708

mvstanton@chromium.org authored May 22, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/296693011

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21435 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

894df708

ClearTypeFeedbackInfo(): context may not be initialized. · 5392e94e

mvstanton@chromium.org authored May 22, 2014

SharedFunctionInfo::ClearTypeFeedbackInfo() wants to compare feedback
to the array JSFunction, but it's called at times when the context
isn't fully initialized. Be cautious about this check.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/298983002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21434 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5392e94e

Add support for ES6 Symbol in heap profiler · 87513237

yurys@chromium.org authored May 22, 2014

Heap profiler will create a node with name Symbol and type kSymbol.

BUG=chromium:376194
LOG=Y
R=loislo@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/290013004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21433 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

87513237

Revert "Make v8::TryCatch able to consume natively thrown exceptions" · acec7363

mstarzinger@chromium.org authored May 22, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/293123003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21432 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

acec7363

Attempt no. 3 to fix Heap::IsHeapIterable and HeapIterator. · 3d0bf69c

jarin@chromium.org authored May 22, 2014

Now we remember new space's top pointer after the last GC to find out if there was a new space allocation since the last GC.

Unfortunately, this not completely safe - the debugger has a callback hook (that can call to JS) at the end of the GC epilogue that can in theory allocate and possibly make the heap non-iterable. We can only hope this does not happen.

BUG=373283
R=hpayer@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/291193005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21431 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3d0bf69c

Make serializer non-static. · d0398c08

yangguo@chromium.org authored May 22, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/296853007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21430 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d0398c08

Customized support for feedback on calls to Array. · e443c892

mvstanton@chromium.org authored May 22, 2014

Gather transition feedback on array calls, and inline the Array
function call when it makes sense.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/279423005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e443c892

Revert "Rename target-specific binaries built for host." · 0829572e

jkummerow@chromium.org authored May 22, 2014

The Android build system support for gyp has been fixed to handle
target-dependent host binaries correctly without requiring them to
include the target architecture in the name. Remove the suffixes to make
referring to these targets simpler again.

This reverts r14209.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/236833004

Patch from Richard Coles <torne@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21428 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0829572e

Make v8::TryCatch able to consume natively thrown exceptions. · 38d30d78

mstarzinger@chromium.org authored May 22, 2014

R=yangguo@chromium.org, haraken@chromium.org
BUG=chromium:362388
TEST=cctest/test-api/TryCatchNative
LOG=N

Review URL: https://codereview.chromium.org/287133005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21427 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

38d30d78

Allow specifying base offset when constructing Keyed hydrogen instructions · def6cff3

danno@chromium.org authored May 22, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/295913009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21426 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

def6cff3

Increase external allocation limit. · 628636fb

hpayer@chromium.org authored May 22, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/291653005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21425 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

628636fb

Remove usage of Locker/Unlocker where possible. · 8b785bd3

yangguo@chromium.org authored May 22, 2014

This is possible because we removed DebuggerAgent.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/286903004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21424 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b785bd3

Fix Array.prototype.push and Array.prototype.unshift for read-only length. · e56594f1

ulan@chromium.org authored May 22, 2014

BUG=
R=mstarzinger@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/279773002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21423 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e56594f1

Remove check for SAHF support in ia32. · f01f0e6c

yangguo@chromium.org authored May 22, 2014

On ia32, SAHF is guaranteed. It's only necessary to probe for it on x64.

R=svenpanne@chromium.org
BUG=376087
LOG=N

Review URL: https://codereview.chromium.org/296133006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21422 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f01f0e6c

Remove special debug ExternalReferences. · 6fd69c24

yangguo@chromium.org authored May 22, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/296043002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21421 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6fd69c24

Don't replace initializing smi stores during store elimination. · 7c30bba1

bmeurer@chromium.org authored May 22, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/286903019

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c30bba1

Reland "Prevent liveedit on or under generators with open activations" · ab3afc57

yangguo@chromium.org authored May 22, 2014

The change relative to the previous CL is a logic change in
DropActivationsInActiveThreadImpl.  The previous CL skipped the matcher
unless the frame was a JS frame; this was correct for
MultipleFunctionTarget but not for SingleFrameTarget.

I have not been able to reproduce the original failures on either
architecture (ia32 or x64; stack frame dropping is unsupported on other
architectures).

R=yangguo@chromium.org
LOG=N
TEST=mjsunit/harmony/generators-debug-liveedit.js
BUG=

Review URL: https://codereview.chromium.org/270283002

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ab3afc57

Introduce a separate event for CodeDeopt · a7e816db

alph@chromium.org authored May 22, 2014

The reuse of CodeCreateEvent for deopt events caused a CodeCreateEvent
fired twice for a code object. When the event was processed for the first
time it seized the no-fp-ranges from code object, so the second event
had no ranges info leaving code entry without them.
As a result when a cpu profile sample falls into the region it missed the
2nd stack frame.

LOG=N
BUG=
R=bmeurer@chromium.org, loislo@chromium.org

Review URL: https://codereview.chromium.org/290093005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21418 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a7e816db

Transitioning stores change maps. · 6683b4b9

bmeurer@chromium.org authored May 22, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/296953003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21417 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6683b4b9

21 May, 2014 7 commits

Implement Mirror object for Symbols. · d9736047

yangguo@chromium.org authored May 21, 2014

R=rossberg@chromium.org, yurys@chromium.org
BUG=v8:3290
LOG=Y

Review URL: https://codereview.chromium.org/297513006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21414 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d9736047

Move promises recorded for debugging to thread local data. · c1eff30f

yangguo@chromium.org authored May 21, 2014

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/296693005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21413 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c1eff30f

Revert "Increase external allocation limit." · b06ad596

hpayer@chromium.org authored May 21, 2014

BUG=

Review URL: https://codereview.chromium.org/292983010

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21412 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b06ad596

Increase external allocation limit. · 95077490

hpayer@chromium.org authored May 21, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/297663008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21411 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

95077490

Reorder checks in Runtime_TypedArrayInitialize* · 38cfd30b

jkummerow@chromium.org authored May 21, 2014

All checks must be performed before any side effects, so we get atomic transactions

BUG=chromium:374443
LOG=n
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/298843003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21410 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

38cfd30b

Fix OrderedHashSet::Remove caller in debug-only code after r21408 · ccf8b204

adamk@chromium.org authored May 21, 2014

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/294473011

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ccf8b204

Teach OrderedHashSet::Remove to report whether it actually removed anything · 9f86a91e

adamk@chromium.org authored May 21, 2014

This avoids an unnecessary runtime call from Set.prototype.delete().

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/290733008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21408 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f86a91e