- 30 Mar, 2016 3 commits
-
-
jarin authored
This CL introduces static variables and global lock for writing to the dump files, so that multiple web workers do not run into trouble. Review URL: https://codereview.chromium.org/1839133002 Cr-Commit-Position: refs/heads/master@{#35123}
-
bmeurer authored
Remove the duplicate if_join label (thanks C++ for not even emitting a warning about this). R=mtrofin@chromium.org Review URL: https://codereview.chromium.org/1837393003 Cr-Commit-Position: refs/heads/master@{#35122}
-
joransiu authored
The CodeGenerator sequence for Mod64/ModU64 is incorrectly using 32-bit operations. Fix Mod64/ModU64 to use 64-bit divides to calculate the remainder. Fix disassembly for DLR, which was reading the wrong bits for the two register operands. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1839813006 Cr-Commit-Position: refs/heads/master@{#35121}
-
- 29 Mar, 2016 33 commits
-
-
adamk authored
R=littledan@chromium.org BUG=v8:4602 LOG=y Review URL: https://codereview.chromium.org/1838393002 Cr-Commit-Position: refs/heads/master@{#35120}
-
joransiu authored
Fix bug in simulator which incorrectly interpreted the operands for SQEBR (Float32 sqrt) as 64-bit doubles. Add missing disassembler case for SQEBR as well. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1837263003 Cr-Commit-Position: refs/heads/master@{#35119}
-
adamk authored
This patch adds fast paths for @@replace and @@split that call into the old, side-effect free (and faster) versions of those builtin operations when possible (roughly, when the receiver is a RegExp and the 'exec' method is untampered). Also add some micro-optimizations that further improve performance. Taken altogether, this takes us from a ~70% regression on the Octane RegExp benchmark to a ~9% regression. The test262.status lines for RegExps has been reorganized to make it clearer the status of individual tests. More work will likely be required to increase spec compliance before the --harmony-regexp-exec flag is shipped; some of that work is happening on the spec side. BUG=v8:4602 LOG=y Review URL: https://codereview.chromium.org/1836123002 Cr-Commit-Position: refs/heads/master@{#35118}
-
kozyatinskiy authored
This method returns contextDebugId for function. We can't use context_data from FunctionMirror.prototype.script because it can be incorrect when compilation cache is used and one script object was used for JSFunctions in different contexts. BUG=chromium:595206 LOG=Y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1840713002 Cr-Commit-Position: refs/heads/master@{#35117}
-
jfb authored
We'll require the abstract code (as well as the offset) when we do full backtraces. R=bradnelson@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1838933002 Cr-Commit-Position: refs/heads/master@{#35116}
-
jfb authored
wasm_to_js and js_to_wasm both derive from wasm, which was confusing because is_wasm wasn't true for them and that made WasmFrame::cast awkward. Make them derive from StubFrame instead. R=bradnelson@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1839843002 Cr-Commit-Position: refs/heads/master@{#35115}
-
jacob.bramley authored
AArch64 kernels older than 3.18 presented a different cpuinfo format than what V8 expects. Most of V8's logic still works, but it misreads the "CPU architecture" field. BUG= Review URL: https://codereview.chromium.org/1841733002 Cr-Commit-Position: refs/heads/master@{#35114}
-
ulan authored
This avoids redundant casts, loss of precision, and potential overflows. BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1841043002 Cr-Commit-Position: refs/heads/master@{#35113}
-
jyan authored
Updates the prologue_offset value in LCodeGen::GeneratePrologue after generating ahi/aghi. prologue_offset is used in FindCodeAgeSequence. Failing to update prologue_offset will result in failing to correctly identify the code aging sequence (young). R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1843673002 Cr-Commit-Position: refs/heads/master@{#35112}
-
ulan authored
This fixes available_in_free_list counter. BUG= Review URL: https://codereview.chromium.org/1840083002 Cr-Commit-Position: refs/heads/master@{#35111}
-
joransiu authored
The CodeGenerator sequence for kS390_Div64 was incorrectly defaulting to the 32-bit divide sequence. That case has been fixed to use the proper 64-bit divide (DSGR). Fix bug in DLGR simulation where the register number was being used as operands instead of the values in those registers. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1844563002 Cr-Commit-Position: refs/heads/master@{#35110}
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1841713002 Cr-Commit-Position: refs/heads/master@{#35109}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1839003003 Cr-Commit-Position: refs/heads/master@{#35108}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1836013004 Cr-Commit-Position: refs/heads/master@{#35107}
-
joransiu authored
Fix bug in simulator which incorrectly interpreted the operands for CEBR (Float32 compare) as 64-bit doubles. Add missing disassembler case for CEBR as well. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1844473002 Cr-Commit-Position: refs/heads/master@{#35106}
-
machenbach authored
Uploading chromium CLs requires hooks to be run now, what the auto-roller doesn't do. TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1843593002 Cr-Commit-Position: refs/heads/master@{#35105}
-
ulan authored
Now instead of saving all event details in the ring buffer, we save only the bytes and duration. This reduces the GCTracer size from 20K to 3K and simplifies code. BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1830723004 Cr-Commit-Position: refs/heads/master@{#35104}
-
titzer authored
Loop analysis results in smaller graphs (fewer phis), thus faster compilation time and better code. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1836223002 Cr-Commit-Position: refs/heads/master@{#35103}
-
yangguo authored
I can't express my disbelief when I saw it getting a raw context object from the runtime. Luckily this is not used anywhere. R=neis@chromium.org Review URL: https://codereview.chromium.org/1844543002 Cr-Commit-Position: refs/heads/master@{#35102}
-
neis authored
This fixes another bug in Array.prototype.sort (when the array is not a JSArray and there is a proxy on the prototype chain). R=cbruni@chromium.org BUG=chromium:596866 LOG=n Review URL: https://codereview.chromium.org/1842563004 Cr-Commit-Position: refs/heads/master@{#35101}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1839993002 Cr-Commit-Position: refs/heads/master@{#35100}
-
yangguo authored
R=jochen@chromium.org BUG=v8:4361 LOG=N Review URL: https://codereview.chromium.org/1819313002 Cr-Commit-Position: refs/heads/master@{#35099}
-
ishell authored
[es6] Add a flag to the Isolate that defines whether ES2015 tail call elimination is enabled or not. Thus DevTools will be able to disable tail call elimination dynamically upon user's choice. BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1837513002 Cr-Commit-Position: refs/heads/master@{#35098}
-
mlippautz authored
If we don't write fillers, we crash during PagedSpace verification when we try to iterate over dead memory (unused folded allocation slots). BUG=v8:4871,chromium:580959 LOG=N Review URL: https://codereview.chromium.org/1837163002 Cr-Commit-Position: refs/heads/master@{#35097}
-
titzer authored
In JavaScript code and stubs, JSSP mirrors the CSP but may be unaligned. But in WASM code only CSP is used, like native code, and it must be aligned. Calls into WASM from JS need to carefully align the C stack pointer (csp) and restore the previous JSSP, while calls from WASM to JS need to compute a new JSSP and restore their CSP after the call. R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1811283003 Cr-Commit-Position: refs/heads/master@{#35096}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1836213002 Cr-Commit-Position: refs/heads/master@{#35095}
-
bmeurer authored
Fix and re-enable the flexible representation for Math.floor (which is used to implement Math.ceil) and Math.round, which allows Math.floor and Math.round to return double results instead of int32, and therefore allows values outside the int32 range, especially -0 is now a valid result, which doesn't deopt. Also port this feature to x64 and ia32 when the CPU supports the SSE4.1 extension. This addresses all the known deoptimization loops related to Math.round in the Kraken benchmark suite, and seems to also address most of the deoptimization loops related to Math.floor in the Oort Online benchmark. Drive-by-fix: Import the regression tests for the broken HMathFloorOfDiv optimization that caused the initial revert of the feature (for arm64 only back then). BUG=chromium:476477,v8:2890,v8:4059 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1841513003 Cr-Commit-Position: refs/heads/master@{#35094}
-
hpayer authored
BUG= NOTRY=true Review URL: https://codereview.chromium.org/1842523004 Cr-Commit-Position: refs/heads/master@{#35093}
-
jarin authored
This fixes support for debug info in perf. Thanks to Stephane Eranian for identifying the problem - debug info event has to be emitted before the code load event. It also seems that perf does not yet support the shorthand for repeated source files in the debug info entry ("\xff\0"), so I changed it to always write the script name. Review URL: https://codereview.chromium.org/1843563002 Cr-Commit-Position: refs/heads/master@{#35092}
-
jarin authored
Difference from --perf-basic-prof: - correctly attributes samples when code space gets reused (when unused code object dies and a new code objects is allocated at the same place). - outputs compiled machine code for instruction-level profile. Just like --perf-basic-prof, the file writer is not synchronized (even worse, there is a per-isolate file handle), so we will run into trouble with multiple isolates. However, this patch is still an improvement on --perf-basic-prof, and it should be fine to replace ll-prof. The patch also introduces experimental support for debug info, but it does not seem to be picked by the perf tool. Usage: You need the perf tool from Linux kernel >4.5. Then run: $ perf record -k mono d8 --perf-prof <your JS file> $ perf inject -j -i perf.data -o perf.data.jitted $ perf report -i perf.data.jitted Some explanations: The "-k mono" switch from "perf record" tells the perf tool to use the monotonic clock for perf sample timestamping. The "perf inject -j" command injects the collected code events into the perf data file, writing the output into perf.data.jitted. The perf report command then creates the report. Review URL: https://codereview.chromium.org/1809203007 Cr-Commit-Position: refs/heads/master@{#35091}
-
bmeurer authored
The NumberFloor operator matches exactly the semantics of the Math.floor builtin on Numbers. It uses hardware rounding instructions if available, but provides a full fallback solution that is compatible with Math.floor. The lowering is optimizable based on types if needed later, i.e. we already optimize it for the case that the input is already an Integer (in the EcmaScript sense, including NaN and -0), but we could add more optimizations, like combining NumberFloor and NumberDivide in the future, if necessary. R=jarin@chromium.org BUG=v8:2890,v8:4059 LOG=n Review URL: https://codereview.chromium.org/1843533003 Cr-Commit-Position: refs/heads/master@{#35090}
-
bmeurer authored
The timezone part of the Date string representation might contain non-ASCII characters depending on the exact platform configuration, so we cannot safely assume that the whole date string is ASCII encoded. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=yangguo@chromium.org BUG=chromium:581925 LOG=n Review URL: https://codereview.chromium.org/1838063002 Cr-Commit-Position: refs/heads/master@{#35089}
-
v8-autoroll authored
Rolling v8/tools/clang to 51bba1037858028f42141689ed1b3b63a20f0b52 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1838013003 Cr-Commit-Position: refs/heads/master@{#35088}
-
- 28 Mar, 2016 4 commits
-
-
jyan authored
Implement Left/Right Logical/Arithmetic Shift Pair operations for s390 R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1835973003 Cr-Commit-Position: refs/heads/master@{#35087}
-
littledan authored
The getter RegExp.prototype.source is specified in ES2015 to throw when called on a non-RegExp instance, such as RegExp.prototype. We had previously put in a compatibility workaround for all RegExp getters to make them throw on access specifically with RegExp.prototype as the receiver; however, we only have evidence that this is needed for properties other than source. This patch removes the compatibility workaround for get RegExp.prototype.source and gives it semantics precisely as per the ES2015 specification. R=adamk BUG=chromium:581577,v8:4827 LOG=Y Review URL: https://codereview.chromium.org/1837843002 Cr-Commit-Position: refs/heads/master@{#35086}
-
adamk authored
Previously, they would check for Symbol.match/Symbol.search, and then do another check for Symbol.match in the RegExp constructor. This patch avoids the second one by skipping the RegExp constructor, as the spec does. Review URL: https://codereview.chromium.org/1840723002 Cr-Commit-Position: refs/heads/master@{#35085}
-
jyan authored
when needs_return_buffer == true and result_size() > 2, the 3rd return value is placed in r4 register. But when debug code is emited, it uses r4 register for checking exceptions, which corrupts the 3rd return value. R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1839663002 Cr-Commit-Position: refs/heads/master@{#35084}
-