- 22 Jun, 2020 14 commits
-
-
Jakob Kummerow authored
No-Try: true Bug: v8:10619 Change-Id: I5c428bf47f2f6923aa88a8407d62d9480aa954fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257222 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68460}
-
Thibaud Michaud authored
Intent to Ship thread on blink-dev: https://groups.google.com/a/chromium.org/g/blink-dev/c/K4-P5rq7FbY Spec repository: https://github.com/WebAssembly/multi-value/ WebAssembly multi-value is ready to ship. The proposal is now merged into the core WebAssembly spec, and is implemented in both TurboFan and Liftoff. R=ecmziegler@chromium.org Bug: chromium:1097717 Change-Id: Id53ee318cacae1bc9dd9d9611f9223de594a99b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257225Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68459}
-
Jakob Gruber authored
... when jitless is enabled to fix fuzzers that pass random flag combinations. Bug: chromium:1096168,v8:7777 Change-Id: Ia78c4d9e1256e44c10df2200ecc32067a617d777 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257220 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68458}
-
Anton Bikineev authored
This allows the implementation of different stack scanning mechanisms in V8 (e.g. conservative scanning) while re-using the stack walking API. Change-Id: I9b9c3b8ffe5d527ca3f7105776821776b509b187 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238194 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#68457}
-
Clemens Backes authored
We already have specialized logic for unops and binops, and the generic {BuildSimpleOperator} implementation (based on a signature) was reimplementing these two cases. This CL avoids the switch since we only need to handle exactly two cases, and redirects to the existing methods for implementing them. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I8eb5c768f0fa59e48503c108498b334a0ae9037a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249859Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68456}
-
Michael Lippautz authored
Mutable references are allowed by the style guide and the linter has been adjusted. Bug: v8:10624, chromium:1056170 Change-Id: I8a7dc06da5758f5c714a5e61d75378c2a13ffb9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252192 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68455}
-
Dan Elphick authored
Add nullptr guard for the return value of AllocateBasicChunk. Bug: chromium:1097502 Change-Id: Ia4642151a119ccabe58d7084077808aac93e5d1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257221Reviewed-by:
-
Andreas Haas authored
R=adamk@chromium.org Bug: v8:7741 Change-Id: Icf7247825bd10048cd198b910b8bd976a0a0b3d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241516 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68453}
-
Nico Hartmann authored
Change-Id: I23a0a4811d8c42f09bbbc5460902ee7138f9b1ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255469 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Clemens Backes authored
This is a follow-up to https://crrev.com/c/2249928. The arguments for {SubVector} are {from, to}, not {from, size}. R=jkummerow@chromium.org Bug: chromium:1097442 Change-Id: I3c5571ff7f0c6b8e235ecf4164591630dbd05739 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255465Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68451}
-
Maya Lekova authored
Bug: v8:9993 Change-Id: I06428edd7f01805d08927718e4711298c731d2e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253844 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Lippautz authored
As of May 2020 the Google C++ Style Guide suggests using references for out paramters. Adjust V8's presubmit checks to allow mutable reference parameters. Bug: v8:10624 Change-Id: Idcd027892916a14f91ca3bfcb5eba48757cab523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252185Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68449}
-
Jakob Gruber authored
In native context independent code we cannot embed the (native context dependent) feedback vector as a constant. Instead, we will load it from the JSFunction once and pass it to all users. This CL makes this change for all unary operators. All other {binary,compare} operators will need similar work in the future. Bug: v8:8888 Change-Id: I4d49a6e0effc84dcdf3599814e5c2708b16bcc44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246576Reviewed-by:Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68448}
-
Kim-Anh Tran authored
This check skips inserting a breakpoint into the BreakPointInfo if it has already been inserted before. Change-Id: Ic773fe1d6b2351bf6069fa0ff002737bd0b03293 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253851Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#68447}
-
- 21 Jun, 2020 1 commit
-
-
Milad Farazmand authored
Change-Id: I70fa23a2491186d2bf94b26a292163efa1c23d61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255503Reviewed-by:
-
- 20 Jun, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3591130..2dc7c7a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4ac015d..95c1f42 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2410c84..35c6274 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/eaf99a4..02daed1 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2219c9b1aeaff06fb06c29e2d08089d22c63ed4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2255501Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68445}
-
- 19 Jun, 2020 24 commits
-
-
Ng Zhi An authored
This implements I32x4DotI16x8S for ia32. Also fixes instruction-selector for SIMD ops, they should all set operand1 to be a register, since we do not have memory alignment yet. Bug: v8:10583 Change-Id: Id273816efd5eea128580f3f7bde533a8e1b2435d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231031 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68444}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I9af885e4c33541a8e065082ae7f07804bd11807a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252190 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Refer to "Advanced SIMD two registers misc", ARM DDI 0487F.b F4-4228. Also moved the method down to the section with all the NEON instructions, matching where the declaration in assembler-arm.h is. Bug: v8:10553 Change-Id: I450edbfc3eafead4aad419299c93e43bd9d83133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252764Reviewed-by:
-
Almothana Athamneh authored
Bug: v8:10445 Change-Id: I45b142bd1f4330dc07d06f89dc9daf7db127aaaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253958Reviewed-by:
-
Clemens Backes authored
Replace by "consistency check", or "validity check", or more specific wording as appropriate. R=ecmziegler@chromium.org Bug: v8:10619 Change-Id: Ifd7852d8f703d5b784d53671b82d65db15722ede Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253855Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:1091698 Change-Id: Ida82d262f409c54e59640bcaa026879d18ff178d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252184 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port c6642b51 Original Commit Message: We rely on Liftoff for debugging, hence enable it everywhere by default. This follows a chromium finch experiment and a CL to enable it everywhere in chrome: https://crrev.com/c/2252100 R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I1a8e7a4acb9a5ce5a6d0ba96b105ba32e53f1b69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253464Reviewed-by:
-
Mike Stanton authored
Formerly, we zapped a transition array when we replaced it with a larger one, but this is no longer necessary. Leaving those arrays in peace makes life easier for concurrent (racy) access from a background compilation thread. Design doc with more info about racy access to transition arrays between the main JavaScript thread and a background compilation thread here: https://docs.google.com/document/d/1ax2qyENdr50Qu9yur1qNu6_zRK0m6K2l7BLM_QDBFJM/edit?usp=sharing Change-Id: I4c2757945266d43d82ec157e0ff2b9208a8e4c63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253840Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Maya Lekova authored
Avoid possible use-after-free. Fixed: v8:10210 Change-Id: Id8bdf70804448b5b793d9d593374f4b588fe3e87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253841 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68436}
-
Peter Marshall authored
Change-Id: I37e241d9c62f1a7fed438ee8717f02f5b4f51bea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253846 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#68435}
-
Almothana Athamneh authored
This CL migrates the bots v8_mac64_gc_stress_dbg and v8_mac64_asan_rel to the new format. Bug: v8:10445 Change-Id: I7520985499c91c6571ba93e1515223f57f0d38ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253839Reviewed-by:
-
Kim-Anh Tran authored
Until now the breakpointIdToDebuggerBreakpointIds was cleared on page reload. It keeps a map from breakpointIds to debuggerBreakpointIds, with the latter being necessary for removing breakpoints. If a breakpoint is set and we trigger a page reload, the information about that breakpoint will be removed from the map, even if it still exists. If we later want to remove the breakpoint we look into the map, but the meta data is no longer existing. Thus, reloading the page again will lead to hitting the breakpoint, even if we removed it in the front-end. This change keeps the map alive on page reset, so that we still keep track of set breakpoints after a page reload. Bug: chromium:1073071 Change-Id: I82192777bac7afc406245a5a1cff0620e8174499 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253842Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#68433}
-
Peter Marshall authored
evaluate() bypassed CSP for unsafe-eval by default. This is a useful option for debugging clients, but is not always what we want. e.g. in the devtools console we want to match the page's CSP settings to make debugging CSP issues on the page easier. Add a toggle that keeps the current behavior by default. Bug: chromium:1084558 Change-Id: Ia01142d5be00f8ef5f65e5eeba17549efc6f9120 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2250245 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Backes authored
We rely on Liftoff for debugging, hence enable it everywhere by default. This follows a chromium finch experiment and a CL to enable it everywhere in chrome: https://crrev.com/c/2252100 R=ecmziegler@chromium.org Bug: chromium:1040030 Change-Id: I3abbf915515883e6eb1f37501466290def57862d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252196Reviewed-by:
-
Maya Lekova authored
Bug: v8:10009 Change-Id: Iccc42a9b5f9f7340851542185473ac49683c838c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253843Reviewed-by:
-
Clemens Backes authored
Make sure that the workers do not start running before the main thread told them so by setting the memory to the first element in the sequence. Otherwise it can happen that the main thread resets the memory after the workers already started doing their updates, which results in a hang (see linked bug). R=marja@chromium.org Bug: v8:10625 Change-Id: I959018279e0049900d44457b72146bc37a12bcb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252191 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#68429}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I58e8216e3d51aa9da3e6a819cdf2614b4509e1a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2250249 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Dan Elphick authored
Bug: v8:10473 Change-Id: Ic53130ca5103ba219329f7b204b218bc021f07f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252178Reviewed-by:
-
Michael Lippautz authored
This is a reland of e0c1a349 The issue was passing SentinelPointer (== +1) through T*. The fix is disabling cfi unrelated cast diagnostic for the bottlenecks (Get()). This means that nullptr is treated the same as kSentinelPointer. The alternative would be a DCHECK that Get() does not return kSentinelPointer and adjusting all Member and Persistent logic that uses Get() to work on void*. This is quite intrusive as it involves Swap(), heterogeneous assignments, comparisons, etc. Original change's description: > cppgc: Properly clear (Weak)Peristent and WeakMember pointers > > The CL addresses two issues with (Weak)Persistent and WeakMember: > 1. (Weak)Persistent pointers are cleared on heap teardown. Before this > CL the pointers would contain stale values which could lead to UAF. > 2. WeakPersistent and WeakMember are cleared using a combination of > internal clearing methods and mutable fields which avoids the use > of const_cast<>. > > Bug: chromium:1056170 > Change-Id: Ibf2b0f0856771b4f6906608cde13a6d43ebf81f3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2248190 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68394} Bug: chromium:1056170 Change-Id: I3d74b43464c2973df1956f51b1419d755dd9f519 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2250240Reviewed-by:
-
Manos Koukoutos authored
This CL introduces one-letter shorthands to HeapTypes, and fixes signatures to be in sync with the ValueType and HeapType shorthands. Bug: v8:7748 Change-Id: I4cc8e26d6523074bc36bf2d29289e63a23e80ddc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249672 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
Increase TypedArray.kMaxLength by 1. Bug: chromium:1095721 Change-Id: Ic3668ff4e71cfd1289eda495333c4aae62c44795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249668Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I6087c02aab93ba44b8029f3d1a0c99fd6a4da6f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2250248 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:10599 Change-Id: I1248d365576c0bc8c01d8ce07f0c49654fabfc52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2251173 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/78f36d4..3591130 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/3200e0f..1ed9957 Rolling v8/buildtools/linux64: git_revision:fbe7aec770944d17c9f3006f6cbb5c19e8cd43ea..git_revision:7d7e8deea36d126397bda2cf924682504271f0e1 Rolling v8/third_party/aemu-linux-x64: T98d0T9VlsHV98PPahwzBa8kF94z5dghLKOTUDCTmwYC..UoYLOT0X6577j70eB9nPqYQs9Z3Nh5lA4I-pRtTchO0C Rolling v8/third_party/android_sdk/public: CR25ixsRhwuRnhdgDpGFyl9S0C_0HO9SUgFrwX46zq8C..uM0XtAW9BHh8phcbhBDA9GfzP3bku2SP7AiMahhimnoC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fbbd9ca..4ac015d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3eb899a..2410c84 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/9e7dae8..79326ef Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0d67b22..42b285f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3024219a33b862fef5e7393a3e18c88f46e29dc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253105Reviewed-by:
-
