- 22 Sep, 2021 20 commits
-
-
Victor Gomes authored
Sparkplug code does not contain deoptimization data. Bug: v8:12258 Change-Id: Ieb9f7f1469e00677d9533c6f05b17c80ef06b9d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3175820 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#76997}
-
Peter Kasting authored
Long term, ideally, these would be fixed and this flag can be removed. For now, this is an expedient way to allow enabling -Wshadow in Chromium. Bug: chromium:794619 Change-Id: I038e5fc758fbb8284bb28cb4f7f8a4c44da0db66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173891 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76996}
-
Andreas Haas authored
See https://github.com/WebAssembly/js-types/blob/main/document/js-api/index.bs#L866 R=manoskouk@chromium.org Bug: v8:12227 Change-Id: I384483a7568d37c40d077487165ff9b1761da342 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172768Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76995}
-
Junliang Yan authored
Change-Id: I91ed4bf22231c6080b2c5e445ea407d076baeadc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3175374Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76994}
-
Patrick Thier authored
When kDontAdaptArgumentsSentinel is 0 (the receiver is included in the argument count), we don't need a dedicated check against the sentinel before comparing the formal parameter count to the actual argument count when calling a JS function. Bug: v8:11112 Change-Id: I8c9f64a538984cb3de9e35f16bc6adbd3c92d24f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173671Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#76993}
-
Junliang Yan authored
Change-Id: I01c4a68377a70cfed425b3cd1ed56b120c9b5056 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3174627Reviewed-by:
-
Junliang Yan authored
Change-Id: I83611a53426efff35960b2d90de909f2a6b07264 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3175369Reviewed-by:
-
Junliang Yan authored
Change-Id: I74873db343b3103f12d47ca1a9617369d516424d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3174411Reviewed-by:
-
Dominik Inführ authored
We should cancel tasks before we destroy objects like the string table from the isolate. So far our concurrent tasks didn't interact with the isolate much, but we now have tasks that can e.g. access the heap concurrently. While this is not strictly necessary at the moment, I want to see whether there might be problems with that approach. In the future this order will be required e.g. for baseline batch compilation tasks. Bug: v8:11708 Change-Id: I80d8a9447bb51e9ae84ed9b6c0da6183290dc70b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3164338 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76989}
-
Camillo Bruni authored
Bug: v8:11165 Change-Id: Ic2c8c6e6b97f279941e8634bc6178511103edbca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173676Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#76988}
-
Clemens Backes authored
Liftoff is fully supported on all officially supported platforms, thus remove a TODO to implement it on more platforms. R=thibaudm@chromium.org Bug: v8:11879 Change-Id: I00a559286d67e7e377a36b68803ee30e8fa2f34e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168341 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76987}
-
Michalis Spyrou authored
Add support for heap sandbox on arm64 when building with v8_enable_heap_sandbox=true Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Bug: v8:10391 Change-Id: I3080f5970d2a604ca67827c732cd77761f7611a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3165057 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76986}
-
Clemens Backes authored
As the comment notes, we want to ensure that code space is *not* writable by the current thread. R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Change-Id: I5c3cad32b8edc56013f298405c8e20d8bc9da05f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173675Reviewed-by:
-
Clemens Backes authored
On Mac we handle SIGBUS, not SIGSEGV, so the test should access a valid but inaccessible pointer to trigger the right signal. R=jkummerow@chromium.org Bug: v8:11955, v8:12249 Change-Id: I25b93ce40bccc24ef5e84694a7c03c465eb4c51e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168344 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Liu Yu authored
Port 06af754c Bug: v8:12203,v8:8661 Change-Id: Ib0379acc1db7dcebf7252e44d252e45bfa787e1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3174377 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#76983}
-
Lu Yahan authored
Port 3162142:[isolate-data] Split builtin tables into tiers Change-Id: I0f506d75eb75bed9afc7e1971e61f2bdf9bf5740 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3174613 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76982}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Iddf021d292f44ab2a7d719792f14cdc57e40223b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172759 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#76981}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I6a86dd1313a7bfb72024e9857a0c18dd6c83fe3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160518 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1037128..66bad00 Rolling v8/third_party/aemu-linux-x64: bOp0PE8R9VUQxsHclvuA10P4iOaWjRRpsK8ZQKtAZCAC..UnrNXrNKJtnUOqrH_BbjXgZ_Ns1v0PZ9WNtFgoHrQZwC Rolling v8/third_party/android_sdk/public: yODElY4RdHopNEfpOnqjRcrpa6JMzbhYYqGD53-DjJwC..AuYa11pULKT8AI14_owabJrkZoRGuovL-nvwmiONlYEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8ec776f..25814bb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c1fd44b..eff810e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/7ea32d7..948efd2 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9bc3a48c310c9364a3cd2e24e1fdc6fcd5e6d934 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172719Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76979}
-
Hao Xu authored
Bug: v8:12018, v8:12163 Change-Id: I87f779b4a355fa0638885db88fd0ebff0f930443 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141034 Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76978}
-
- 21 Sep, 2021 20 commits
-
-
Ng Zhi An authored
DISALLOW_COPY_AND_ASSIGN is no longer in our codebase, and the compilers mentioned in the comments are (probably) no longer supported. Bug: v8:12244 Change-Id: I432bd56ca3ddd870be140032f11d94ddb60ce1a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3171974Reviewed-by:
-
Michael Lippautz authored
This reverts commit f2e25f8a. Reason for revert: Breaks GCC 8.4.0 compilation, see bug. Original change's description: > [base] Replace base::Optional with Abseil > > Change base::Optional to an alias of absl::optional. Eventually we > should remove it entirely. > > Bug: v8:11006 > Change-Id: I687d44cc7e7cd0a49a84bcc207231eb6808eef2d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476318 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76913} Bug: v8:11006, v8:12252 Change-Id: I8048dee676a36551d15f25a31d1e171dae00d975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173672 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76976}
-
Clemens Backes authored
Add another "#if V8_ENABLE_WEBASSEMBLY" block to fix compilation if wasm is disabled. TBR=jkummerow@chromium.org Bug: v8:11974 Change-Id: If889814e16dfb51d5b78122e6957bb2c41cefe5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172758Reviewed-by:
-
Junliang Yan authored
Change-Id: I65c60a17c0f8fe19b49f0661b9d57b5a504abe07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168283Reviewed-by:
-
Ng Zhi An authored
Drive-by edit to use ASM_CODE_COMMENT for better code comments for all the more complicated macro-assembler functions. Also undef macros (AVX_OP et al) since they are not longer used outside of shared-macro-assembler. Bug: v8:11589 Change-Id: I424f27b5b742a8efb26ccef87dbffb01eae60335 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173892Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76973}
-
Ng Zhi An authored
Previously it generates a mvoq+pinsrq, now it generates a single punpcklqdq. punpcklqdq is smaller in code size, and also faster on most arch (latency 1, rthroughput of 1, 1 uop, uses 1 port) than pinsrq (latency 2, 2 uop, uses 2 port) (from https://uops.info/table.html) punpcklqdq is mean to work on int domain, and although we can't be certain what v128.const will be used for, the movq is considered an integer domain instruction, so we can avoid unnecessary transitions by using punpcklqdq (instead of movddup, which is similar in perf and code size). Bug: v8:11033 Change-Id: Iab81168ffad84488b90ff307d440bed15c9f90a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3169322Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76972}
-
Omer Katz authored
This is a reland of adb6276f Causes for previous revert was addressed by crbug.com/3140387 and crbug.com/3163579. Original change's description: > Reland "cppgc: Enable checks for assignments in prefinalizers" > > This is a reland of edcc8ff5 > > Cause for previous revert was addressed by crbug.com/1241773. > > Original change's description: > > cppgc: Enable checks for assignments in prefinalizers > > > > Bug: v8:11749 > > Change-Id: Ic027f732030fb6a2befeffeca9db2eacfd0830a5 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099953 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#76370} > > Bug: v8:11749 > Change-Id: I57fc138ace002d41e54f7f70250e4d19bc9262b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122153 > Auto-Submit: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76553} Bug: v8:11749 Change-Id: I138ca374314108f0f23e234a8fd90d15d912120d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168280Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#76971}
-
Ng Zhi An authored
We move some instructions from the test that just disassembles them, to the test that checks for expected output. Bug: v8:12207 Change-Id: Ide8954e36c6ad016150bfe45abc1717bed55eb19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3171972Reviewed-by:
-
Samuel Groß authored
This CL exposes the size of the virtual memory cage to the embedder through V8::GetVirtualMemoryCageSizeInBytes(). This will for example be useful to collect metrics about the cage reservation, such as how frequently it fails, in the future. While collecting these metrics directly in V8 would also be possible, it would require access to an Isolate, which is not yet available when the cage is initialized. As such, it is easier to enable the embedder to collect these metrics. Bug: chromium:1218005 Change-Id: Ie9c9ca7d1cd158ec024be6ab2418f50083b06d6e Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172762Reviewed-by:
-
Georg Neis authored
The NowIs operator doesn't exist anymore. R=mslekova@chromium.org Change-Id: Id081c7e0cf5b122a77598fc0b886a2d1c09c881f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172767Reviewed-by:
-
Junliang Yan authored
Port 06af754c Original Message: .. for more efficient access to builtins from generated code. Root-relative accesses tend to be faster and produce more compact code when the root-relative offset is small. IsolateData contains a few large tables (roots, external references, builtins), resulting in very large offsets in general. This CL starts by splitting the builtin table into tiers: tier 0 is a minimal set of perf-critical builtins that should be cheap to access. The offset to tier 0 builtins is guaranteed to be small. The full builtin table also remains in IsolateData for occasions in which we need to lookup builtins by index. In future work, we can also split external references and roots into tiers. On x64, this reduces deopt exit sizes from 7 to 4 bytes and from 12 to 9 bytes (dynamic map checks / EagerWithResume deopts). Change-Id: I021d60b20b783da170987ffcf0327b93206f7e5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172917Reviewed-by:
-
Andreas Haas authored
The shipping version was incorrect in the original CL. R=ecmziegler@chromium.org Bug: v8:7581 Change-Id: Ib382cdacb8f6aa80718e6917b535c026b83d88cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172766Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76966}
-
Andreas Haas authored
The function index encoded into the serialized module is already offset by num_imported_functions. For lazy compilation, however, we added the number of imported functions another time, which was incorrect. R=clemensb@chromium.org Change-Id: I56380e21e74b4d1935ebdbab6ef8cc388de49f2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172761 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Backes authored
Conditions are usually used in binary comparisons, and are named for that purpose. When used in a unary comparison, {kEqual} means "equal to zero" and {kUnequal} means "not equal to zero". This is noted in several comments in {LiftoffCompiler}. This CL introduces the alternative names {kEqualZero} and {kNotEqualZero} to avoid the repeated comments and increase readability. R=thibaudm@chromium.org Bug: v8:12244 Change-Id: I720a3d91ea95a26a38a48c68161f1b0552937cd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172763Reviewed-by: -
Sathya Gunasekaran authored
Change-Id: Ibb8de6e2df6eaee5413d9d6b197a9490dfa8ff07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172756Reviewed-by:
-
Sathya Gunasekaran authored
Change-Id: Ibcfdfa7c6f8e5c13f6f2a5098fc7fde4fa15f3c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172757 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Useful for debugging errors Change-Id: Ibab5acec4a8e927262dbc12d5d4cc4cd27ebf0ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172754 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Andreas Haas authored
Spec tests were fixed in the meantime. R=ecmziegler@chromium.org Bug: v8:7581 Change-Id: If8e192ea94f9908ec469ebd5ccd876f51e4ea6f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3167492 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Victor Gomes authored
No-Try: true Bug: v8:11880 Change-Id: If16fe503a7fda39ccbec745d6c75959e7d2f5433 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172755 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
Most call signatures are small enough to keep them on the stack. This CL adds a little optimization to avoid two Zone allocations for such small signatures (and one in the general case). R=thibaudm@chromium.org Change-Id: I20ea7b77bfe8f1c86f8aa66450baa3561d564de1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168279 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
