- 17 Oct, 2017 34 commits
-
-
Michael Achenbach authored
This reverts commit 526c31d0. Reason for revert: cfi still unhappy: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/11905 Original change's description: > Reland "[snapshot] Add BuiltinDeserializerAllocator" > > This is a reland of 2b9a6d89 > Original change's description: > > [snapshot] Add BuiltinDeserializerAllocator > > > > Encapsulates special reservation / allocation behavior for builtin > > deserialization. > > > > Bug: v8:6624 > > Change-Id: Ic784ed43b607c881b356c6e535c9dbe185e1d4cd > > Reviewed-on: https://chromium-review.googlesource.com/716229 > > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48638} > > TBR=yangguo@chromium.org > > Bug: v8:6624 > Change-Id: I07c49263b4ef128dfe9b97d364e9a279b343aa24 > Reviewed-on: https://chromium-review.googlesource.com/723520 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48647} TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: I2a0534505d646a3ba90523f06f726b5059b90e35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6624 Reviewed-on: https://chromium-review.googlesource.com/723521Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48650}
-
Ross McIlroy authored
Ensure we only lower SpeculativeNumberBinops to a pure operator for non-string plain primitives. Previously we could lower if a value might be the-hole, however this would fail a CHECK in ConvertInputsToNumber which expects a plain primitive. BUG=chromium:772420 Change-Id: I0c755d10db7afd9cabfb638eca5662d70dfc8d51 Reviewed-on: https://chromium-review.googlesource.com/715717 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48649}
-
Clemens Hammacher authored
This prepares fixes in the implementations of vabs and vneg (potentially more). In order to implement them correctly, we need to preserve the exact bit pattern. R=ahaas@chromium.org, rodolph.perfetta@arm.com Bug: v8:6947 Change-Id: I7194a60371a6e3c9ffba32981c90090ffafaa610 Reviewed-on: https://chromium-review.googlesource.com/722941Reviewed-by:
Rodolph Perfetta <rodolph.perfetta@arm.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48648}
-
Jakob Gruber authored
This is a reland of 2b9a6d89 Original change's description: > [snapshot] Add BuiltinDeserializerAllocator > > Encapsulates special reservation / allocation behavior for builtin > deserialization. > > Bug: v8:6624 > Change-Id: Ic784ed43b607c881b356c6e535c9dbe185e1d4cd > Reviewed-on: https://chromium-review.googlesource.com/716229 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48638} TBR=yangguo@chromium.org Bug: v8:6624 Change-Id: I07c49263b4ef128dfe9b97d364e9a279b343aa24 Reviewed-on: https://chromium-review.googlesource.com/723520Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48647}
-
Ben L. Titzer authored
This feature is turned off in flag-definitions but reenabled in a non-standard way in d8. Given that the situations in which the trap handler are disabled are more limited now due to integration problems, disabling this feature for now, since we lack enough coverage to have confidence to turn it on by default. We should probably introduce a proper test variant for this feature so that it can be handled in a more standard way. R=eholk@chromium.org CC=mlippautz@chromium.org,hablich@chromium.org,mstarzinger@chromium.org Bug: Change-Id: Ic2e13181036ace8802736be847ae16ff889e3cea Reviewed-on: https://chromium-review.googlesource.com/723221 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48646}
-
Michael Achenbach authored
Bug: chromium:726584 Change-Id: I1d413b5568e533e4f517c0687716689dd15da70d Reviewed-on: https://chromium-review.googlesource.com/723459 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: v8:6923 Change-Id: Ic8c8829d39d482463309507719379cd17346b52a Reviewed-on: https://chromium-review.googlesource.com/723179Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48644}
-
Franziska Hinkelmann authored
Instead of re-iterating over the heap all the time, use the list of feedback vectors on the isolate. This also avoids GC of vectors. Bug: v8:5935 Change-Id: I0bb96fcf2b0feb9856e9806f812188de1fc7b37e Reviewed-on: https://chromium-review.googlesource.com/668396Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48643}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Bug: chromium:774805 Change-Id: Iaf744749acf006558e02300c05627c8f25457e0d Reviewed-on: https://chromium-review.googlesource.com/723383Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2b9a6d89. Reason for revert: Fails ubsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20UBSanVptr/builds/770 Original change's description: > [snapshot] Add BuiltinDeserializerAllocator > > Encapsulates special reservation / allocation behavior for builtin > deserialization. > > Bug: v8:6624 > Change-Id: Ic784ed43b607c881b356c6e535c9dbe185e1d4cd > Reviewed-on: https://chromium-review.googlesource.com/716229 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48638} TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: I0c6eceb88efe65526499e124acc4a45ee2904c1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6624 Reviewed-on: https://chromium-review.googlesource.com/723141Reviewed-by:
-
Michael Lippautz authored
Mechanical move simplifying a follow up that removes the recursive locking strategy by properly partitioning pages. Bug: v8:6923 Change-Id: I688e61131731e2b9dc9c311b0b43f0902c149359 Reviewed-on: https://chromium-review.googlesource.com/723020Reviewed-by:
-
Benedikt Meurer authored
So far the inlining of Function#bind into TurboFan optimized code was limited to cases where TurboFan could infer the constant JSFunction that was bound. However we can easily extend that to cover JSBoundFunction as well, and obviously also take the LOAD_IC feedback if we don't have a known JSFunction or JSBoundFunction. This adds a new operator JSCreateBoundFunction that contains the logic for the creation of the bound function object and the arguments. On the micro-benchmarks we go from functionBindParameter0: 1239 ms. functionBindConstant0: 478 ms. functionBindBoundConstant0: 1256 ms. functionBindParameter1: 1278 ms. functionBindConstant1: 475 ms. functionBindBoundConstant1: 1253 ms. functionBindParameter2: 1431 ms. functionBindConstant2: 616 ms. functionBindBoundConstant2: 1437 ms. to functionBindParameter0: 462 ms. functionBindConstant0: 485 ms. functionBindBoundConstant0: 474 ms. functionBindParameter1: 478 ms. functionBindConstant1: 474 ms. functionBindBoundConstant1: 474 ms. functionBindParameter2: 617 ms. functionBindConstant2: 614 ms. functionBindBoundConstant2: 616 ms. which is a ~2.5x improvement. On the jshint benchmark in the web-tooling-benchmark we observe a 2-3% improvement, which corresponds to the time we had seen it running in the generic version. Bug: v8:6936, v8:6946 Change-Id: I940d13220ff35ae602dbaa33349ba4bbe0c9a9d3 Reviewed-on: https://chromium-review.googlesource.com/723080Reviewed-by:
-
jgruber authored
Encapsulates special reservation / allocation behavior for builtin deserialization. Bug: v8:6624 Change-Id: Ic784ed43b607c881b356c6e535c9dbe185e1d4cd Reviewed-on: https://chromium-review.googlesource.com/716229 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: Change-Id: I28d6905a0c527a171deae89374ef54c2b4b97d3d Reviewed-on: https://chromium-review.googlesource.com/722960Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48637}
-
jgruber authored
This removes the builtins area from the startup snapshot. It's now completely contained in the separate builtins blob area. Bug: v8:6624 Change-Id: Id3c43a177c7e1ed418eec59cf620fa461eb6df81 Reviewed-on: https://chromium-review.googlesource.com/715759 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
R=clemensh@chromium.org Bug: chromium:766003,chromium:772332,chromium:771243 Change-Id: I1e2df014f31a87fd94154277d1a415ec359d42df Reviewed-on: https://chromium-review.googlesource.com/721666Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48635}
-
jgruber authored
A continuation of the work in 59e4b751, this extracts logic around memory reservation and allocations out of the Deserializer class. Follow-up work is planned to create a specialized allocator for builtin deserialization. Bug: v8:6624 Change-Id: I7081cdc557ab8fb2571aadb816399e136ea2cdbb Reviewed-on: https://chromium-review.googlesource.com/716036 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=bmeurer@chromium.org BUG=v8:6792 Change-Id: I8ed3e6ec06bfba117781efc63d79bc7641b7ec24 Reviewed-on: https://chromium-review.googlesource.com/722641Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48633}
-
Ben L. Titzer authored
R=rossberg@chromium.org Bug: Change-Id: Icac33dc87dd660173e5a45d02b31be46f7d1cb2d Reviewed-on: https://chromium-review.googlesource.com/721550 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Andreas Rossberg <rossberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#48632}
-
Marja Hölttä authored
OSR for functions which use arguments no longer needs to be disabled, since TurboFan handles the case. Bug: Change-Id: I121f1190a142c18f113bd5f875e258812645c43f Reviewed-on: https://chromium-review.googlesource.com/721661Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48631}
-
Igor Sheludko authored
Bug: chromium:774860 Change-Id: I180ca7e9e8d8603e0d61deb0eb71d758895d0f74 Reviewed-on: https://chromium-review.googlesource.com/721551Reviewed-by:
-
Marja Hölttä authored
BUG=v8:5402,v8:6921 Change-Id: Iab2509554718a6beca73217f80cafedf650bd066 Reviewed-on: https://chromium-review.googlesource.com/718741Reviewed-by:
-
Andreas Haas authored
This reverts commit 972d460f. Reason for revert: This CL is not the right solution, and it makes back-merging the right solution more difficult. Original change's description: > [wasm] Use 64-bit comparison for bounds checks on 64-bit platforms > > By using 64-bit comparison we make sure that there will be no out of > memory accesses even if there are stale values in the high word of a > register. > > R=titzer@chromium.org > > Change-Id: I2627b15e1598f35cc480d7028031e8de405164ea > Reviewed-on: https://chromium-review.googlesource.com/721323 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48604} TBR=titzer@chromium.org,ahaas@chromium.org Change-Id: I0c15e9d8ac72def2e22543a17366126d90a17918 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/721702Reviewed-by:
-
Clemens Hammacher authored
The simulator currently does not handle signalling NaNs correctly on the vabs and vneg instructions. Temporarily disable the tests until we have a fix. R=ahaas@chromium.org Bug: v8:6947 Change-Id: I281cb8213cdcc73c91768a82c44f90f009f7c8eb Reviewed-on: https://chromium-review.googlesource.com/721663Reviewed-by:
-
Ulan Degenbaev authored
Disabling only for stress mode did not help, the test uses 10GB in other modes too. Bug: v8:6924 Change-Id: I0e1348f8a43e41612d3a94e75396f0a26a82ece2 Reviewed-on: https://chromium-review.googlesource.com/721662Reviewed-by:
-
jgruber authored
Remove unused macros, and move macro definitions used only in a single file into the file itself. Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: If62107816ad1e6addf58705a075d3eba4f23bf08 Reviewed-on: https://chromium-review.googlesource.com/721381Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#48625}
-
Daniel Clifford authored
This adds a single bottleneck that properly handles the copying of empty, COW and FixedDoubleArray arrays under the control of flags. This is in preparation of adding new CSA-based array builtins on Array.prototype. Drive by: Fix SmiConstant handling when ENABLE_VERIFY_CSA is not active and make the use of constant detection/folding consistent in the CSA depending on ParameterMode. Change-Id: If1889ab8cbff1805286b7b4344c29ffbe7191b39 Reviewed-on: https://chromium-review.googlesource.com/715798 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#48624}
-
Peter Marshall authored
This code is never used, and we don't right trim TypedArrays. Bug: Change-Id: Ic3e32b194fb10ecd067449c755b1982c87c98257 Reviewed-on: https://chromium-review.googlesource.com/721541Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2857e783. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/20965 Original change's description: > [ia32][wasm] Add I32x4AddHoriz and I16x8AddHoriz > > Add phaddd, phaddw and AVX version > Add vmovdqu and Movdqu macro > > Bug: > Change-Id: I4f5c0cf96ab481fc18f0a0d554101a996a16c954 > Reviewed-on: https://chromium-review.googlesource.com/715677 > Commit-Queue: Jing Bao <jing.bao@intel.com> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48621} TBR=bbudge@chromium.org,mtrofin@chromium.org,bmeurer@chromium.org,jing.bao@intel.com Change-Id: Icaf36b46134e77e46180fc1671d0c6569b729a89 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/722679Reviewed-by:
-
jing.bao authored
Add phaddd, phaddw and AVX version Add vmovdqu and Movdqu macro Bug: Change-Id: I4f5c0cf96ab481fc18f0a0d554101a996a16c954 Reviewed-on: https://chromium-review.googlesource.com/715677 Commit-Queue: Jing Bao <jing.bao@intel.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0db5732..b6fbb0d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/f6d165d..e043d81 Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/ca9dc72..110e5f6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c0f385b..733ecb1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d1283a8..af65d54 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: Iac5e37f0f49ddf33182e1742e97e81ad1c5e1b52 Reviewed-on: https://chromium-review.googlesource.com/721505Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48620}
-
Adam Klein authored
Inner functions which called eval, and were the kind of functions that can use `super`, were erroneously not marked as "uses_super_property", leading to downstream crashes when the runtime tried to load the [[HomeObject]] from them. This patch eliminates the public Scope::uses_super_property() API and ensures that callers always call Scope::NeedsHomeObject() instead. This is a minimal fix designed for easy merging; it's likely that in the long run we should remove most mentions of "uses super property" and replace them with "needs home object" for clarity. Bug: v8:5516, chromium:774994 Change-Id: Id269dd33e35bd40f6b59a3d3e19330687afa64f8 Reviewed-on: https://chromium-review.googlesource.com/721879Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48619}
-
Alexey Kozyatinskiy authored
The method returns names for all available top-level scope variables in giving context. R=dgozman@chromium.org,jgruber@chromium.org Bug: chromium:681333 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d0b600e1afbfef9087f53ea9c26abe1e112047c Reviewed-on: https://chromium-review.googlesource.com/719409 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#48618}
-
Alexey Kozyatinskiy authored
R=dgozman@chromium.org Bug: chromium:696798 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ida60ee5fb3e3e42d15bf6d4bad84dfcfb521b74f Reviewed-on: https://chromium-review.googlesource.com/722073Reviewed-by:
-
- 16 Oct, 2017 6 commits
-
-
Ben Smith authored
Change-Id: I77b6eb5e949f8b37fa76d2a161d1ec2c1117ab04 Reviewed-on: https://chromium-review.googlesource.com/722078Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#48616}
-
Alexey Kozyatinskiy authored
This is a reland of 61292f0b Original change's description: > [inspector] breakpoint after last break position should not jump to first line > > R=jgruber@chromium.org > > Bug: chromium:730177 > Change-Id: I0f3666a333604cb80bb51410c5edf2aceb0c6ef5 > Reviewed-on: https://chromium-review.googlesource.com/717717 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48556} TBR=jgruber@chromium.org Bug: chromium:730177 Change-Id: I564cc5d7778f9d79780eae9dbe2d9aafaad4f466 Reviewed-on: https://chromium-review.googlesource.com/721468 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48615}
-
Michael Achenbach authored
This reverts commit d0e3fb4f. Reason for revert: Failures on all GPU bots: https://build.chromium.org/p/client.v8.fyi/builders/Win%20Release%20%28NVIDIA%29/builds/3171 https://build.chromium.org/p/client.v8.fyi/builders/Linux%20Release%20%28NVIDIA%29/builds/3730 Original change's description: > Reland: [heap] Add missing steps for Add/Remove observers > > This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/715118. > The UI doesn't allow me to reland this automatically due to merge conflicts > so I ended up doing this manually. > > Change-Id: Ic013b61f459cb1e91e24203fb31ae7c14f3754f8 > Reviewed-on: https://chromium-review.googlesource.com/720136 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Cr-Commit-Position: refs/heads/master@{#48606} TBR=ulan@chromium.org,mlippautz@chromium.org,ofrobots@google.com Change-Id: I80f63ac0cc54471b3ecaa7b6d85b1805ea599dd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/721440Reviewed-by:
-
Mike Stanton authored
Because the typeof operator may lower to a builtin call (which is effectful in turbofan parlance after effect control linearization), it really should be encoded as a simplified operator, which can be optimized with respect for the effect chain in linearization. No new functionality here, rather a furniture rearrangement in the TurboFan node structure. BUG=v8:6929 Change-Id: I38593e10956ebd57cecdd606c35f3f73efb1327e Reviewed-on: https://chromium-review.googlesource.com/718745Reviewed-by:
-
Jakob Kummerow authored
This supports {valueOf() { return BigInt(...) }} objects as operands in binary and unary operations. Bug: v8:6791 Change-Id: I30ec9983ff611477742f9ea0bc6d04972fe21d3c Reviewed-on: https://chromium-review.googlesource.com/716863 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#48612}
-
Adam Klein authored
We can use member initializers instead of the OTHER_CONSTANTS macro to handle the declaration of oddball AstValue members in AstValueFactory. Bug: v8:6921 Change-Id: I701e2fd36f854cfc0d835981d060622070b5bfba Reviewed-on: https://chromium-review.googlesource.com/719395Reviewed-by:
-
