1. 01 Aug, 2018 1 commit
    • Andreas Haas's avatar
      [mjsunit] Move the implementation of testAsync into a separate file · 8c3c1b6c
      Andreas Haas authored
      The original implementation of 'testAsync' in mjsunit.js required to
      put the call to '%AbortJS' into an 'eval' statement. The reason is that
      this call requires the flag --allow-natives-syntax to be set, but the
      flag is not set in all mjsunit tests. With the use of 'eval'
      compilation errors can be avoided.
      
      The problem with this approach was that the fuzzer started to produce
      test cases which include the line 'eval("%AbortJS(message)");', and
      this line crashes intentionally. Different to the line
      '%Abort(message)', however, the 'eval' statement cannot be filtered
      so easily in the fuzzer. Therefore I pulled the implementation of
      'testAsync' into a separate file to avoid the 'eval'.
      
      Additional changes: I use '===' now instead of 'deepEquals' in
      AsyncAssertion.equals because 'deepEquals' is not available outside
      mjsunit.js. Using '===' seems more appropriate anyways because for
      all tests but one it is sufficient, and it is more precise than
      deepEquals.
      
      R=gsathya@chromium.org
      
      Bug: chromium:774841
      Change-Id: I47270aa63ff5a1d6aa76a771f9276eaaf579c5ac
      Reviewed-on: https://chromium-review.googlesource.com/1156598Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54833}
      8c3c1b6c
  2. 22 Feb, 2018 1 commit