- 12 Feb, 2015 15 commits
-
-
loislo authored
1) create beefy RelocInfo table when cpu profiler is active, so if a function was optimized when profiler was active RelocInfo would get separate DeoptInfo for the each deopt case. 2) push DeoptInfo from CodeEntry to ProfileNode. When deopt happens we put the info collected on #1 into CodeEntry and record stack sample. On the sampling thread we grab the deopt data and append it to the corresponding ProfileNode deopts list. Sample profile dump. [Top down]: 0 (root) 0 #1 1 29 #2 5 test 29 #3 3 opt_function 29 #4 deopted at 52 with reason 'not a heap number' deopted at 71 with reason 'division by zero' BUG=452067 LOG=n Review URL: https://codereview.chromium.org/919953002 Cr-Commit-Position: refs/heads/master@{#26615}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/871253005 Cr-Commit-Position: refs/heads/master@{#26614}
-
mstarzinger authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/918143002 Cr-Commit-Position: refs/heads/master@{#26613}
-
marja authored
Parser must be able to operate independent of Isolate and the V8 heap during parsing. After the heap-independent phase, there is a heap dependent phase, during which we internalize strings, handle errors, etc. This makes Isolate (also via CompilationInfo) unaccessible during parsing, and thus decreases the probability of accidental code changes which would add heap-dependent operations into the heap-independent phase. Since Isolate is also accessible via CompilationInfo, now CompilationInfo is only passed to the entry points of parsing, and not stored in Parser. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/908173003 Cr-Commit-Position: refs/heads/master@{#26612}
-
bmeurer authored
Google style guide forbids -inl.h headers. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/922633002 Cr-Commit-Position: refs/heads/master@{#26611}
-
svenpanne authored
Use a fake code stub instead, basically following the null object pattern. Review URL: https://codereview.chromium.org/918973002 Cr-Commit-Position: refs/heads/master@{#26610}
-
bmeurer authored
Review URL: https://codereview.chromium.org/924453002 Cr-Commit-Position: refs/heads/master@{#26609}
-
danno authored
Previously, emitting two more more unique source positions at the same pc would generate two or more RelocInfo entries. Now, only the last emitted source position for any pc is added to the RelocInfo. Review URL: https://codereview.chromium.org/908443002 Cr-Commit-Position: refs/heads/master@{#26608}
-
hpayer authored
NOTREECHECKS=true TBR=ulan@chromium.org Review URL: https://codereview.chromium.org/918113002 Cr-Commit-Position: refs/heads/master@{#26607}
-
Ben L. Titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/913183005 Cr-Commit-Position: refs/heads/master@{#26606}
-
hpayer authored
Just visit young array buffers during scavenge. Additionally keep the views in new space in a separate global list and move them to the corresponding array buffers when they get promoted. This reduces young generation garbage collections when many array buffers are allocated. BUG= Review URL: https://codereview.chromium.org/904633003 Cr-Commit-Position: refs/heads/master@{#26605}
-
mstarzinger authored
R=danno@chromium.org TEST=cctest/test-run-intrinsics/CallFunction Review URL: https://codereview.chromium.org/916873002 Cr-Commit-Position: refs/heads/master@{#26604}
-
cdai2 authored
port fdcf3e59 (r26599) original commit message: new classes: implement correct check for uninitialized this in 'super()' BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/913383002 Cr-Commit-Position: refs/heads/master@{#26603}
-
bmeurer authored
Rename tools/vim/v8.ycm_extra_conf.py to .ycm_extra_conf.py, so every YCM plugin (no matter if it's VIM or Emacs) should pick it up automatically. Also move the common tools/vim/ninja_output.py to tools/ninja/ as it's also not related to VIM. Review URL: https://codereview.chromium.org/904143003 Cr-Commit-Position: refs/heads/master@{#26602}
-
cdai2 authored
port 9b158fa7 (r26594) original commit message: new classes: implement default constructors BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/914403004 Cr-Commit-Position: refs/heads/master@{#26601}
-
- 11 Feb, 2015 25 commits
-
-
dcarney authored
TBR=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/915113004 Cr-Commit-Position: refs/heads/master@{#26600}
-
dslomov authored
R=arv@chromium.org BUG=v8:3834 LOG=N Review URL: https://codereview.chromium.org/918603004 Cr-Commit-Position: refs/heads/master@{#26599}
-
akos.palfi authored
Port 9b158fa7 BUG= Review URL: https://codereview.chromium.org/914303003 Cr-Commit-Position: refs/heads/master@{#26598}
-
akos.palfi authored
Port bf49be39 BUG= Review URL: https://codereview.chromium.org/906813003 Cr-Commit-Position: refs/heads/master@{#26597}
-
chunyang.dai authored
port bf49be39 (r26572) original commit message: new classes: implement new.target passing to superclass constructor BUG= Review URL: https://codereview.chromium.org/912233003 Cr-Commit-Position: refs/heads/master@{#26596}
-
chunyang.dai authored
This error is exposed by this CL: https://codereview.chromium.org/817293005. This CL set all Buildin JS function to optimization_disabled. And set the bailout reason to "kBuiltinFunctionCannotBeOptimized". But in Runtime_SetCode() function. It copied the the compiler_hints which include the "bool optimization_disabled" value, But the corresponding Bailout reason is not copied. This leads to the check error in "CompilationInfo::AbortOptimization(...)" function. This issue is exposed on turbofan unsupported X87 platform. Crankshaft is invoked to compile the typed array function Uint8Array. BUG= Review URL: https://codereview.chromium.org/917643002 Cr-Commit-Position: refs/heads/master@{#26595}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:3834 LOG=N Review URL: https://codereview.chromium.org/917753002 Cr-Commit-Position: refs/heads/master@{#26594}
-
loislo authored
The offensive cl is https://codereview.chromium.org/874323003/ Test: ./out/arm64.debug/d8 --test --random-seed=-235865360 --turbo-deoptimization --turbo-filter=* --always-opt --debug-code --verify-heap --gc-interval=500 --stress-compaction test/mjsunit/mjsunit.js test/mjsunit/regress/regress-builtinbust-7.js --trace-deopt BUG=452067 TBR=dcarney, svenpanne LOG=n Review URL: https://codereview.chromium.org/917823002 Cr-Commit-Position: refs/heads/master@{#26593}
-
rodolph.perfetta authored
BUG= Review URL: https://codereview.chromium.org/905383003 Cr-Commit-Position: refs/heads/master@{#26592}
-
mstarzinger authored
R=jarin@chromium.org TEST=unittests/ControlEquivalenceTest Review URL: https://codereview.chromium.org/916823002 Cr-Commit-Position: refs/heads/master@{#26591}
-
cdai2 authored
port 5d68529b (r26546) original commit message: Parsing: Make Scope not know about Isolate. Scope, like Parser, must be able to operate independent of Isolate and the V8 heap (for background parsing). After the heap-independent phase, there is a heap dependent phase, during which we do operations such as scope anaylysis. This CL makes the phases explicit by not telling Scope about the Isolate too early (during the heap-independent phase, Scope should know nothing about Isolate). This decreases the probability of accidental code changes which would add heap-dependent operations into the heap-independent phase. BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/913163003 Cr-Commit-Position: refs/heads/master@{#26590}
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/917583004 Cr-Commit-Position: refs/heads/master@{#26589}
-
cdai2 authored
port 86cae163 (r26545) original commit message: 1) Deoptimizer::Reason was replaced with Deoptimizer::DeoptInfo because it also has raw position. Also the old name clashes with DeoptReason enum. 2) c_entry_fp assignment call was added to EntryGenerator::Generate So we can calculate sp and have a chance to record the stack for the deopting function. btw it makes the test stable. 3) new kind of CodeEvents was added to cpu-profiler 4) GetDeoptInfo method was extracted from PrintDeoptLocation. So it could be reused in cpu profiler. BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/912403003 Cr-Commit-Position: refs/heads/master@{#26588}
-
adamk authored
This comment used to have a (commented-out) ASSERT attached to it. But that ASSERT was removed years ago, so the comment is now a non-sequitar. Review URL: https://codereview.chromium.org/918453002 Cr-Commit-Position: refs/heads/master@{#26587}
-
arv authored
We did not set up the [[HomeObject]] for properties created for computed property names. BUG=v8:3879 LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/914773002 Cr-Commit-Position: refs/heads/master@{#26586}
-
arv authored
Support for `new super` has been removed so this code in the full code gen is now unreachable. BUG=None LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/911223002 Cr-Commit-Position: refs/heads/master@{#26585}
-
mstarzinger authored
R=bmeurer@chromium.org TEST=unittests/CommonOperatorTest Review URL: https://codereview.chromium.org/912393002 Cr-Commit-Position: refs/heads/master@{#26584}
-
titzer authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/917433007 Cr-Commit-Position: refs/heads/master@{#26583}
-
dcarney authored
LOG=N BUG=v8:3884 Review URL: https://codereview.chromium.org/916803002 Cr-Commit-Position: refs/heads/master@{#26582}
-
Yang Guo authored
TBR=vogelheim@chromium.org Review URL: https://codereview.chromium.org/913173002 Cr-Commit-Position: refs/heads/master@{#26581}
-
svenpanne authored
A CompilationInfo constructed from just an Isolate* and a Zone* is in weird an inconsistent state (calling e.g. flags() on it will crash), so we need to avoid them. This CL removes almost all of them, the remaining 2 call sites in (for testing only) will be handled in a separate CL. Things which have been changed: * Linkage is basically a decorator for CallDescriptor now. * ChangeLowering doesn't need Linkage at all. * JSGenericLowering doesn't need a full CompilationInfo*, just a single flag. * JSContextSpecializer doesn't need the full CompilationInfo, just a Context. * Removed unused CompilationInfo from SimplifiedLoweringTester. This nicely decouples things already a bit more, but there's still work to do... Review URL: https://codereview.chromium.org/899803003 Cr-Commit-Position: refs/heads/master@{#26580}
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/917653002 Cr-Commit-Position: refs/heads/master@{#26579}
-
yangguo authored
R=jochen@chromium.org BUG=chromium:457459 LOG=N Review URL: https://codereview.chromium.org/919613002 Cr-Commit-Position: refs/heads/master@{#26578}
-
hpayer authored
BUG=454725 LOG=n Review URL: https://codereview.chromium.org/919473008 Cr-Commit-Position: refs/heads/master@{#26577}
-
titzer authored
BUG= Review URL: https://codereview.chromium.org/898353002 Cr-Commit-Position: refs/heads/master@{#26576}
-